Files
accounted/tests/pg/dashboard-nav-flags-rpc.pg.test.ts
MattssonandClaude Fable 5.1 6ea92f3152 feat(zettle): sync paid purchases into webshop_orders (#2445)
Community PR #2416 by @olofpinzke, adopted and finished by maintainers (rebased so every commit is signed).

Why the problem occurred: no Zettle integration; POS sales only reached the books as bank descriptors while Woo/Shopify already had order underlag via webshop_orders. The contributor's version also failed at the database (platform CHECKs listed only woocommerce/shopify), which the mocked unit tests never saw.
What was simplified: reused the Orders/book/invoice path instead of a new inbox; Finance API payouts/fees deferred. Sales the one-account, revenue-per-rate model cannot book (split tender, gift cards, tips) import unbookable with a "bokför manuellt" title instead of guessing accounts. Reset parity uses the rename-and-wrap pattern instead of re-issuing the reset body.
Why this solution: per-purchase rows give the radunderlag BFL verifikat need and the bulk-book path exists; daily kassarapport aggregation and Finance API fees/payouts are the follow-up (DECISIONS.md). Skeptic-refuted paths fixed before merge: concurrent refresh-token rotation (sync claim), cron offset paging (candidate snapshot), platform CHECKs, writer-role gate, migration-reset parity, white-label return origin re-validated at callback, VAT net from product rows.

Not live until ZETTLE_CLIENT_ID / ZETTLE_CLIENT_SECRET / ZETTLE_CREDENTIALS_ENCRYPTION_KEY are set on Vercel and a Zettle developer app is registered with the callback redirect URI.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WtYqzKPoTSRHskYYdf7MwB
2026-09-09 11:19:39 +02:00

112 lines
5.2 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import { getPool, withUserContext } from './setup'
import { insertAuthUser, insertCompany, insertCompanyMember, seedCompany } from './fixtures'
// Validates migration 20260826120000_get_dashboard_nav_flags (plus zettle):
// 1. has_webshop flips on an ACTIVE WooCommerce, Shopify, or Zettle connection
// (a pending/revoked one does not count) and has_mileage_trips on any
// mileage_trips row.
// 2. SECURITY INVOKER: a member of ANOTHER company sees (false, false)
// for this company, RLS applies inside the function.
// 3. EXECUTE is granted to authenticated only, not anon.
//
// webshop_orders is the third has_webshop source; its row shape carries many
// NOT NULL platform columns and the existing connection paths already prove
// the OR, so it is covered by the EXISTS shape, not a fixture here.
const FLAGS = `SELECT has_webshop, has_mileage_trips FROM public.get_dashboard_nav_flags($1::uuid)`
type Row = { has_webshop: boolean; has_mileage_trips: boolean }
async function flagsAs(userId: string, companyId: string): Promise<Row> {
return withUserContext(userId, async (client) => {
const res = await client.query<Row>(FLAGS, [companyId])
expect(res.rows).toHaveLength(1)
return res.rows[0]
})
}
describe('get_dashboard_nav_flags()', () => {
it('is (false, false) for a fresh company', async () => {
const { userId, companyId } = await seedCompany()
expect(await flagsAs(userId, companyId)).toEqual({ has_webshop: false, has_mileage_trips: false })
})
it('flips has_webshop on an active WooCommerce connection, not on a pending one', async () => {
const { userId, companyId } = await seedCompany()
await getPool().query(
`INSERT INTO public.woocommerce_connections (company_id, user_id, store_url, status)
VALUES ($1, $2, $3, 'pending')`,
// Unique per run: the active-connection unique index is on the store URL.
[companyId, userId, `https://nav-flags-${companyId.slice(0, 8)}.example.se`],
)
expect((await flagsAs(userId, companyId)).has_webshop).toBe(false)
await getPool().query(
// Active requires stored keys + browser confirmation (CHECK, 20260907143000).
`UPDATE public.woocommerce_connections
SET status = 'active',
consumer_key_encrypted = 'enc:k', consumer_secret_encrypted = 'enc:s',
browser_confirmed_at = now()
WHERE company_id = $1`,
[companyId],
)
expect((await flagsAs(userId, companyId)).has_webshop).toBe(true)
})
it('flips has_webshop on an active Shopify connection', async () => {
const { userId, companyId } = await seedCompany()
await getPool().query(
`INSERT INTO public.shopify_connections (company_id, user_id, shop_domain, status)
VALUES ($1, $2, $3, 'active')`,
// Unique per run: shopify_connections_shop_active_uniq is on the domain.
[companyId, userId, `nav-flags-${companyId.slice(0, 8)}.myshopify.com`],
)
expect((await flagsAs(userId, companyId)).has_webshop).toBe(true)
})
it('flips has_webshop on an active Zettle connection', async () => {
const { userId, companyId } = await seedCompany()
await getPool().query(
`INSERT INTO public.zettle_connections (company_id, user_id, organization_uuid, status)
VALUES ($1, $2, $3, 'active')`,
[companyId, userId, `nav-flags-zettle-${companyId}`],
)
expect((await flagsAs(userId, companyId)).has_webshop).toBe(true)
})
it('flips has_mileage_trips on any mileage trip', async () => {
const { userId, companyId } = await seedCompany()
await getPool().query(
`INSERT INTO public.mileage_trips (company_id, user_id, trip_date, distance_km, from_location, to_location, purpose)
VALUES ($1, $2, '2026-08-01', 12.5, 'Kontoret', 'Kund AB', 'Kundbesök')`,
[companyId, userId],
)
expect(await flagsAs(userId, companyId)).toEqual({ has_webshop: false, has_mileage_trips: true })
})
it('applies RLS: a member of another company sees (false, false) for this one', async () => {
const { userId, companyId } = await seedCompany()
await getPool().query(
`INSERT INTO public.mileage_trips (company_id, user_id, trip_date, distance_km, from_location, to_location, purpose)
VALUES ($1, $2, '2026-08-01', 3, 'A', 'B', 'Test')`,
[companyId, userId],
)
const outsider = await insertAuthUser()
const otherCompany = await insertCompany({ createdBy: outsider })
await insertCompanyMember({ companyId: otherCompany, userId: outsider })
expect(await flagsAs(userId, companyId)).toEqual({ has_webshop: false, has_mileage_trips: true })
expect(await flagsAs(outsider, companyId)).toEqual({ has_webshop: false, has_mileage_trips: false })
})
it('grants EXECUTE to authenticated but not anon', async () => {
const res = await getPool().query<{ anon_can: boolean; authenticated_can: boolean }>(
`SELECT
has_function_privilege('anon', 'public.get_dashboard_nav_flags(uuid)', 'EXECUTE') AS anon_can,
has_function_privilege('authenticated', 'public.get_dashboard_nav_flags(uuid)', 'EXECUTE') AS authenticated_can`,
)
expect(res.rows[0].anon_can).toBe(false)
expect(res.rows[0].authenticated_can).toBe(true)
})
})