Files
MattssonandClaude Fable 5.1 26e29f47bc feat(company): ideell förening as a third legal form, behind a flag (#2072 step 1) (#2423)
* feat(company): ideell förening as a third legal form, behind a flag (#2072 step 1)

Why the problem occurred: the legal form was modelled as a binary flag in
~300 files. `EntityType` was a two-member union, but nothing dispatched on it
exhaustively: 28 sites defaulted `?? 'enskild_firma'` (invoice, categorize,
match, stripe, invoice-inbox) or `?? 'aktiebolag'` (year-end, bokslut,
MCP), and every form-dependent choice was an `=== 'aktiebolag' ? A : B`
ternary. Widening the union compiled everywhere and changed nothing, so a
förening would have booked as an enskild firma in the app and as an
aktiebolag in bokslut and MCP, with no error anywhere. The lookup refused
föreningar at the door (mapEntityType returned null), which is what the
tester hit.

What was removed or simplified: the silent defaults. One module,
lib/company/entity-type.ts, now holds the list (ENTITY_TYPES), the parser
(never defaults), the resolver (settings hint, then companies.entity_type,
then throw) and `byEntityType`, whose Record arms make the compiler refuse
the next widening until each site has an answer. The form-dependent facts
(closing account, owner settlement account, calendar-year lock, default
method, K1/K2 label, personnummer vs 16-prefix) live there once instead of
in the ternaries. On the SQL side supported_entity_types() replaces four
copies of the literal list in the create RPCs.

Why this shape and not the proposed one: the tracker asked for the enum
widening plus a chart; that alone was the dangerous version (compiles, books
wrong). Bundling stiftelse was considered and dropped: identical plumbing but
no chart block. Creation sits behind NEXT_PUBLIC_IDEELL_FORENING_ENABLED so
the CHECK, RPCs and seed can ship now and the first partner is switched on
without a migration; the flag goes when Phase 2 (packs, INK3, årsbokslut,
Swish) lands on the tracker.

Domain choices (DECISIONS.md 2026-09-08, verify with an accountant before
Phase 2): result closes to 2069 with 2068 as prior-year carry; no owner
accounts, member settlement on 2890; accrual default; brutet räkenskapsår
allowed; K1 label for the 5 000 kr accrual threshold (BFNAR 2010:1); org
number gets the 16 prefix.

Migration 20260908110835 widens the three CHECK constraints, adds
supported_entity_types(), re-creates the three create RPCs with the widened
guard and adds the förening block to seed_chart_of_accounts. Applied to
staging and covered by ideell-forening-entity-type.pg.test.ts.

Part of #2072

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

* fix(company): close the förening paths the skeptic refuted (#2072)

Five refutations from the /skeptic pass on 7a05c54d2, each fixed at the
shared definition rather than the reported site:

1. Privately paid supplier invoices and the utlägg dialog resolved the owner
   account in lib/expenses/payer.ts with its own AB/EF ternary, so a förening
   member's invoice was built on 2893 and then refused by the expense-claim
   service (which already said 2890), burning an ankomstnummer. The helper now
   uses ownerSettlementAccount.
2. Booking templates substitute their `_ab` accounts only for an aktiebolag;
   the `private_expense` template kept its base 2013 for a förening. Template
   accounts now resolve through templateAccountForForm: EF base, AB override,
   förening base with owner accounts translated to 2890 (booking-templates.ts
   and proposal-lines.ts share it).
3. A VAT-registered förening with helårsmoms got no momsdeklaration deadline:
   the annual VAT rule bailed on anything but AB/EF. A förening is a juridisk
   person and follows the räkenskapsår schedule (SFL 26 kap 33 §), so the rule
   now keys on fiscalYearLockedToCalendar instead of the two literals; same in
   the MCP VAT report.
4. 2069 would have accumulated across years: the year-open omföring was
   AB-only with 2099/2098 hard-coded. planResultAppropriation now takes the
   pair from resultClosingAccounts (AB 2099 -> 2098, förening 2069 -> 2068)
   and skips forms with no carry (EF).
5. With the flag off, a registry lookup that returned "Ideell förening" was
   prefilled into the onboarding journey, the form picker was skipped and the
   create step answered "Ogiltig företagsform" with no way back. The
   journey, the BankID picker, the onboarding page and the MCP lookup now use
   mapSetupEntityType, which maps only creatable forms, so a flagged-off form
   falls through to the picker as before.

Also: form picker keeps its AB-first order; tests for each fix.

Part of #2072

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

* chore(migrations): move ideell förening migration after main's latest version (20260908143051)

Two migrations landed on main after the branch forked; a lower version
would be skipped by the merge-time apply. Staging history row renamed to
match.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

* chore(skills): regenerate accounted-api reference for the widened entity_type enum

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-08 14:47:50 +02:00

207 lines
8.3 KiB
TypeScript

import type { SupabaseClient } from '@supabase/supabase-js'
import type { EntityType } from '@/types'
import { flagEnabled } from '@/lib/env/public-flags'
/**
* The one place that knows which legal forms Accounted books for and what
* follows from each of them.
*
* Before this module the form was a binary flag spread over ~300 files:
* `=== 'aktiebolag' ? A : B` ternaries and `?? 'enskild_firma'` /
* `?? 'aktiebolag'` defaults. Widening the `EntityType` union compiled
* everywhere and changed nothing, so a third form silently booked as an
* enskild firma in the app and as an aktiebolag in bokslut and MCP. Every
* form-dependent fact now goes through `byEntityType`, whose `Record` arms
* make the compiler refuse the next widening until each site has an answer.
*
* Domain facts (issue #2072, DECISIONS.md 2026-09-08):
* - Ideell förening closes its result to 2069 "Årets resultat" and carries
* it to 2068 at the next year start, mirroring the AB 2099/2098 pair on the
* BAS 2060-2069 group for föreningar.
* - A förening has no owner: there are no egna uttag/insättningar (EF
* 2013/2018) and no delägarskuld (AB 2893). Money settled with a member is
* a plain short-term liability, 2890.
* - A förening is a juridisk person, so BFL 3 kap does not force the
* calendar year on it (the EF rule) and its default method is accrual.
*/
export const ENTITY_TYPES = [
'enskild_firma',
'aktiebolag',
'ideell_forening',
] as const satisfies readonly EntityType[]
// Compile-time proof that ENTITY_TYPES lists every member of the union.
type MissingFromList = Exclude<EntityType, (typeof ENTITY_TYPES)[number]>
const entityTypesAreExhaustive: MissingFromList extends never ? true : never = true
void entityTypesAreExhaustive
/** Statutory Swedish names, kept in Swedish in both locales. */
export const ENTITY_TYPE_LABELS_SV: Record<EntityType, string> = {
enskild_firma: 'Enskild firma',
aktiebolag: 'Aktiebolag',
ideell_forening: 'Ideell förening',
}
export class UnknownEntityTypeError extends Error {
readonly code = 'COMPANY_ENTITY_TYPE_UNKNOWN'
constructor(value: unknown) {
super(
`Unknown company entity_type ${JSON.stringify(value)}: expected one of ${ENTITY_TYPES.join(', ')}`,
)
this.name = 'UnknownEntityTypeError'
}
}
export function isEntityType(value: unknown): value is EntityType {
return typeof value === 'string' && (ENTITY_TYPES as readonly string[]).includes(value)
}
/** Narrow a raw DB/JSON value; throws instead of defaulting. */
export function parseEntityType(value: unknown): EntityType {
if (isEntityType(value)) return value
throw new UnknownEntityTypeError(value)
}
/**
* Exhaustive dispatch on the legal form. `Record<EntityType, T>` makes every
* arm mandatory at compile time; the runtime check catches a corrupt string
* that slipped past the DB CHECK.
*/
export function byEntityType<T>(entityType: EntityType, arms: Record<EntityType, T>): T {
if (!Object.prototype.hasOwnProperty.call(arms, entityType)) {
throw new UnknownEntityTypeError(entityType)
}
return arms[entityType]
}
/**
* Resolve a company's legal form for a booking path. `hint` is whatever the
* caller already loaded (usually `company_settings.entity_type`); when it is
* missing or invalid the canonical `companies.entity_type` (NOT NULL, CHECKed)
* is read. Never defaults: a wrong form books to the wrong equity account.
*/
export async function resolveCompanyEntityType(
supabase: SupabaseClient,
companyId: string,
hint?: unknown,
): Promise<EntityType> {
if (isEntityType(hint)) return hint
const { data, error } = await supabase
.from('companies')
.select('entity_type')
.eq('id', companyId)
.maybeSingle()
if (error) throw new Error(`Failed to load company entity type: ${error.message}`)
return parseEntityType(data?.entity_type)
}
/**
* Creation gate for forms still in beta. `NEXT_PUBLIC_` so the onboarding
* picker and the server-side create paths read the same switch; the DB CHECK
* accepts the value regardless, so flipping the flag never needs a migration.
* The literal `process.env.NEXT_PUBLIC_...` spelling is what Next.js inlines
* into client bundles; a computed key would read undefined in the browser.
*/
export const IDEELL_FORENING_FLAG = 'NEXT_PUBLIC_IDEELL_FORENING_ENABLED'
export function isEntityTypeCreatable(entityType: EntityType): boolean {
return byEntityType(entityType, {
enskild_firma: true,
aktiebolag: true,
ideell_forening: flagEnabled(process.env.NEXT_PUBLIC_IDEELL_FORENING_ENABLED),
})
}
/** Forms a user may pick right now (feature flags applied). */
export function creatableEntityTypes(): EntityType[] {
return ENTITY_TYPES.filter(isEntityTypeCreatable)
}
// ── Domain facts ─────────────────────────────────────────────────────
export interface ResultClosingAccounts {
/** Account the year's net result is closed to. */
closing: string
closingName: string
/**
* Account the previous year's result is moved to at the next year start
* (null when the form closes straight into an equity account, EF 2010).
*/
priorYearCarry: string | null
}
export function resultClosingAccounts(entityType: EntityType): ResultClosingAccounts {
return byEntityType<ResultClosingAccounts>(entityType, {
enskild_firma: { closing: '2010', closingName: 'Eget kapital', priorYearCarry: null },
aktiebolag: { closing: '2099', closingName: 'Årets resultat', priorYearCarry: '2098' },
ideell_forening: { closing: '2069', closingName: 'Årets resultat', priorYearCarry: '2068' },
})
}
/**
* Account for money settled with the owner (EF: egna uttag/insättningar, AB:
* skuld till aktieägare). A förening has no owner; a member who pays or is
* paid is a plain short-term counterparty on 2890.
*/
export function ownerSettlementAccount(
entityType: EntityType,
direction: 'withdrawal' | 'contribution',
): string {
return byEntityType(entityType, {
enskild_firma: direction === 'withdrawal' ? '2013' : '2018',
aktiebolag: '2893',
ideell_forening: '2890',
})
}
/** Owner-side accounts a booking template may name in its base/AB columns. */
const OWNER_SETTLEMENT_ACCOUNTS = new Set(['2013', '2018', '2893'])
/**
* Resolve a booking template's account for the form. Templates carry a base
* (enskild firma) account and an optional `_ab` override; an ideell förening
* takes the base account (6991 for a course, 3100 for exempt revenue) except
* that any owner account becomes the member settlement account, since a
* förening has no egna uttag/insättningar and no delägarskuld.
*/
export function templateAccountForForm(
entityType: EntityType,
base: string | undefined,
abOverride: string | undefined,
): string | undefined {
return byEntityType(entityType, {
enskild_firma: base,
aktiebolag: abOverride ?? base,
ideell_forening:
base && OWNER_SETTLEMENT_ACCOUNTS.has(base) ? ownerSettlementAccount('ideell_forening', 'withdrawal') : base,
})
}
/** Only an aktiebolag prepares an årsredovisning in Accounted today. */
export function preparesArsredovisning(entityType: EntityType): boolean {
return byEntityType(entityType, { enskild_firma: false, aktiebolag: true, ideell_forening: false })
}
/** BFL 3 kap 1 §: a fysisk person (enskild firma) is bound to the calendar year. */
export function fiscalYearLockedToCalendar(entityType: EntityType): boolean {
return byEntityType(entityType, { enskild_firma: true, aktiebolag: false, ideell_forening: false })
}
/** The org number is the owner's personnummer only for an enskild firma. */
export function usesPersonnummerAsOrgNumber(entityType: EntityType): boolean {
return byEntityType(entityType, { enskild_firma: true, aktiebolag: false, ideell_forening: false })
}
export function defaultAccountingMethod(entityType: EntityType): 'accrual' | 'cash' {
return byEntityType(entityType, { enskild_firma: 'cash', aktiebolag: 'accrual', ideell_forening: 'accrual' })
}
/**
* Simplified year-end regelverk label used by the accrual threshold logic
* (K1: 5 000 kr per post may stay unperiodised). EF: BFNAR 2006:1; ideell
* förening: BFNAR 2010:1; AB prepares under K2.
*/
export function simplifiedYearEndRegelverk(entityType: EntityType): 'K1' | 'K2' {
return byEntityType(entityType, { enskild_firma: 'K1', aktiebolag: 'K2', ideell_forening: 'K1' })
}