* fix(bookkeeping): send each missing-underlag lookup chunk once per URL The "verifikat utan underlag" filter (/bookkeeping?missingUnderlag=true) failed with "Verifikaten kunde inte hamtas" on a self-hosted instance as soon as the candidate set passed one chunk of 150 ids. Why it occurred: resolveMissingUnderlagEntries issues four lookups per chunk. Three carry the id list once; the supplier_invoices lookup interpolated the same chunk twice into a single .or() over registration_journal_entry_id and payment_journal_entry_id. That URL alone crossed the 8 KB header buffer nginx/Kong ship with, so the gateway answered 414 before PostgREST saw the request. Hosted sits at roughly half of Cloudflare's 16 KB ceiling on the same query. The LOOKUP_CHUNK docblock acknowledged the doubling without sizing for it. What was removed: the runtime-built .or() string, the chunkInList helper and its uuid guard (the .in() array filter is injection-safe on its own). The supplier-invoice lookup is now two .in() queries, one per FK column, merged into the same set, so every request carries the chunk exactly once and the proxy limit stops being a dependency rather than moving. LOOKUP_CHUNK stays 150 and its comment is now true. The literal filter also leaves the phantom-column scanner's unresolvable budget. Two secondary defects from the same report: MissingUnderlagQueryError now carries the raw driver error as `cause` and the journal-entries route logs it, while the response keeps the Swedish text (the log used to say only "Nagot gick fel", hiding the 414). The "Visa saknade underlag" badge renders the total of the last successful filtered fetch and hides on failure, instead of borrowing the list count (0 on a failed first load, the whole ledger after a toggle). Alternatives: halving LOOKUP_CHUNK moves the wall instead of removing it. Pushing the list filters into the verifikat_without_documents RPC and deleting the TS mirror leaves one predicate instead of two, but moves search, series, date and sort into SQL; recorded in DECISIONS.md as the intended next step for the surface owner. Fixes #2395 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q4kpVfYooLp8CWeUguRVpQ * fix(bookkeeping): hide the underlag badge on network failure, log the bulk route's cause Skeptic findings on aacb17634. The badge contract is "no honest source, no badge": the non-OK branch cleared missingCount but the network-level catch (offline, aborted body, JSON parse rejection) did not, so a period or series change that failed at that level kept the previous filtered total next to the toggle. The bulk "Inget underlag kravs" route had the same log gap as the list route: it returned the mapped text without logging the driver error, so a gateway 414 on that path stayed invisible. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q4kpVfYooLp8CWeUguRVpQ --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
138 lines
5.8 KiB
TypeScript
138 lines
5.8 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { createQueuedMockSupabase } from '@/tests/helpers'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import { getErrorMessage } from '@/lib/errors/get-error-message'
|
|
import {
|
|
MissingUnderlagQueryError,
|
|
resolveMissingUnderlagEntries,
|
|
} from '@/lib/bookkeeping/missing-underlag'
|
|
|
|
const { supabase, enqueue, reset, findCalls } = createQueuedMockSupabase()
|
|
const client = supabase as unknown as SupabaseClient
|
|
|
|
const E1 = '11111111-1111-4111-8111-111111111111'
|
|
const E2 = '22222222-2222-4222-8222-222222222222'
|
|
const E3 = '33333333-3333-4333-8333-333333333333'
|
|
const candidate = (id: string) => ({ id })
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
})
|
|
|
|
describe('resolveMissingUnderlagEntries: supplier-invoice reference lookup (#2395)', () => {
|
|
it('sends the candidate chunk once per URL: two .in() lookups, never one .or() over both FKs', async () => {
|
|
enqueue({ data: [candidate(E1), candidate(E2), candidate(E3)], error: null }) // candidates
|
|
enqueue({ data: [], error: null }) // no direct documents
|
|
enqueue({ data: [], error: null }) // SI by registration FK
|
|
enqueue({ data: [], error: null }) // SI by payment FK
|
|
enqueue({ data: [], error: null }) // no SI payment rows
|
|
enqueue({ data: [], error: null }) // no exemptions
|
|
enqueue({ data: [], error: null }) // no customer invoices pointing at the entries
|
|
enqueue({ data: [], error: null }) // no invoice payment rows
|
|
|
|
const missing = await resolveMissingUnderlagEntries(client, 'company-1', {}, { idOnly: true })
|
|
|
|
expect(missing.map((e) => e.id)).toEqual([E1, E2, E3])
|
|
// The doubled .or() is what pushed one lookup over an 8 KB proxy header
|
|
// buffer (414 on self-hosted Kong) while the single-list lookups passed.
|
|
expect(findCalls('supplier_invoices', 'or')).toHaveLength(0)
|
|
expect(findCalls('supplier_invoices', 'in')).toEqual([
|
|
['registration_journal_entry_id', [E1, E2, E3]],
|
|
['payment_journal_entry_id', [E1, E2, E3]],
|
|
])
|
|
// Both lookups stay scoped to the company and to invoices with a document.
|
|
expect(findCalls('supplier_invoices', 'eq')).toEqual([
|
|
['company_id', 'company-1'],
|
|
['company_id', 'company-1'],
|
|
])
|
|
expect(findCalls('supplier_invoices', 'not')).toEqual([
|
|
['document_id', 'is', null],
|
|
['document_id', 'is', null],
|
|
])
|
|
})
|
|
|
|
it('treats an anchored reference from either lookup as underlag, unanchored from neither', async () => {
|
|
enqueue({ data: [candidate(E1), candidate(E2), candidate(E3)], error: null })
|
|
enqueue({ data: [], error: null }) // no direct documents
|
|
enqueue({
|
|
data: [
|
|
{
|
|
registration_journal_entry_id: E1,
|
|
payment_journal_entry_id: null,
|
|
document: { journal_entry_id: E1 }, // anchored
|
|
},
|
|
],
|
|
error: null,
|
|
})
|
|
enqueue({
|
|
data: [
|
|
{
|
|
registration_journal_entry_id: null,
|
|
payment_journal_entry_id: E2,
|
|
document: { journal_entry_id: E2 }, // anchored
|
|
},
|
|
{
|
|
registration_journal_entry_id: null,
|
|
payment_journal_entry_id: E3,
|
|
document: { journal_entry_id: null }, // unanchored: deletable, not underlag
|
|
},
|
|
],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // no SI payment rows
|
|
enqueue({ data: [], error: null }) // no exemptions
|
|
enqueue({ data: [], error: null }) // no customer invoices pointing at the entries
|
|
enqueue({ data: [], error: null }) // no invoice payment rows
|
|
|
|
const missing = await resolveMissingUnderlagEntries(client, 'company-1', {}, { idOnly: true })
|
|
|
|
expect(missing.map((e) => e.id)).toEqual([E3])
|
|
})
|
|
|
|
it('chunks the candidate list at 150 ids and issues both supplier-invoice lookups per chunk', async () => {
|
|
const ids = Array.from(
|
|
{ length: 151 },
|
|
(_, i) => `${String(i).padStart(8, '0')}-0000-4000-8000-000000000000`,
|
|
)
|
|
enqueue({ data: ids.map(candidate), error: null })
|
|
for (let chunk = 0; chunk < 2; chunk++) {
|
|
enqueue({ data: [], error: null }) // documents
|
|
enqueue({ data: [], error: null }) // SI by registration FK
|
|
enqueue({ data: [], error: null }) // SI by payment FK
|
|
enqueue({ data: [], error: null }) // SI payment rows
|
|
enqueue({ data: [], error: null }) // exemptions
|
|
enqueue({ data: [], error: null }) // customer invoices
|
|
enqueue({ data: [], error: null }) // invoice payment rows
|
|
}
|
|
|
|
const missing = await resolveMissingUnderlagEntries(client, 'company-1', {}, { idOnly: true })
|
|
|
|
expect(missing).toHaveLength(151)
|
|
const inCalls = findCalls('supplier_invoices', 'in')
|
|
expect(inCalls.map(([column, list]) => [column, (list as string[]).length])).toEqual([
|
|
['registration_journal_entry_id', 150],
|
|
['payment_journal_entry_id', 150],
|
|
['registration_journal_entry_id', 1],
|
|
['payment_journal_entry_id', 1],
|
|
])
|
|
expect(findCalls('supplier_invoices', 'or')).toHaveLength(0)
|
|
})
|
|
|
|
it('carries the driver error as cause alongside the user-facing Swedish text', async () => {
|
|
enqueue({ data: [candidate(E1)], error: null })
|
|
enqueue({ data: [], error: null }) // documents
|
|
const driverError = { message: 'Request-URI Too Large', code: '414', details: null, hint: null }
|
|
enqueue({ data: null, error: driverError }) // SI by registration FK fails
|
|
|
|
const thrown = await resolveMissingUnderlagEntries(client, 'company-1').catch((e) => e)
|
|
|
|
expect(thrown).toBeInstanceOf(MissingUnderlagQueryError)
|
|
// The raw driver error survives for the server log, unmapped.
|
|
expect(thrown.cause).toBe(driverError)
|
|
// What the user sees went through the shared mapper, same as before.
|
|
expect(thrown.userMessage).toBe(getErrorMessage(driverError))
|
|
expect(thrown.message).toBe(thrown.userMessage)
|
|
})
|
|
})
|