Files
MattssonandClaude Fable 5.1 51f05ffeba
CodeQL / Analyze (javascript-typescript) (push) Failing after 10m53s
CodeQL / Analyze (actions) (push) Failing after 10m43s
Build and Push Docker Image / Build linux/arm64 (push) Has been cancelled
Build and Push Docker Image / Merge, sign and scan (push) Has been cancelled
Build and Push Docker Image / Build linux/amd64 (push) Failing after 3m4s
Workflow audit (zizmor) / Audit workflows (push) Failing after 5m54s
feat(dashboard): dismissible system notice banner for every signed-in user (#2464)
* feat(dashboard): dismissible system notice banner for every signed-in user

Operator-set banner ("high load right now, some pages may respond slowly
or fail") rendered under the dashboard chrome for every signed-in user
while NEXT_PUBLIC_SYSTEM_NOTICE_UNTIL (ISO timestamp with offset) is in
the future. Closing it stores the deadline in localStorage, so each
browser sees it once; the banner hides itself at the deadline in open
tabs and is not rendered at all after it.

Why the problem occurred: there was no way to tell every user something
about the system itself. The existing banners are all per-company state
(sandbox, seat grace), so an operator notice had no home.

What was removed or simplified instead: no notices table, no migration,
no admin UI. One public env var carries both the on/off switch and the
expiry, and the same value is the dismiss key, so a later notice re-shows
once without any code change. No DB read, which matters because the
first use is a DB restart window.

Why this over the proposed shape: the request was a banner "until 23:00
tonight". Hardcoding that in code would need a second PR to switch off
or reuse; a DB-backed notice would read the database that is about to
go down. The env var expires on its own, and unset means gone.

Fixes #2463

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF

* fix(dashboard): system notice survives long deadlines, blocked storage, and every layout shell

Skeptic findings on 839a255f3:
- setTimeout clamps delays above 2^31-1 ms to ~1 ms, so a deadline more
  than 24.8 days out hid the banner instantly. Wait in bounded steps and
  re-check the clock.
- window.localStorage is a throwing property access when a browser blocks
  site data; read it behind a try so the dashboard never crashes over a
  notice.
- The close button was a hand-rolled 22px icon button; design.md requires
  the shadcn icon Button (40px target).
- The byrå-consultant shell and the stale-cookie shell rendered no banner,
  so "every signed-in user" was not true. The banner is now computed once,
  before the shell branches, and mounted in all three.

Refs #2463

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF

* fix(dashboard): system notice deadline requires a UTC offset

A date-time without Z or a numeric offset parses as local time, which is
UTC on Vercel and the operator's zone locally, so the same value would
mean different instants. Reject it instead (CodeRabbit on #2464).

Declined: scoping the dismissal key by user id. The notice is about the
system, not the account; per-browser dismissal is the sandbox banner's
semantics and keeps identity out of layout chrome.

Refs #2463

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 13:15:27 +02:00

59 lines
2.1 KiB
TypeScript

/**
* System notice window: a one-off, operator-set banner ("high load right
* now") shown to every signed-in user until a fixed point in time.
*
* The switch is NEXT_PUBLIC_SYSTEM_NOTICE_UNTIL, an ISO timestamp with an
* explicit offset (e.g. 2026-09-10T23:00:00+02:00). The value doubles as the
* dismiss key: closing the banner stores the timestamp in localStorage, so a
* later notice with a new timestamp shows once again while the old dismissal
* stays inert. No DB read: the notice must survive the DB being unavailable.
*/
export const SYSTEM_NOTICE_STORAGE_KEY = 'Accounted:system-notice-dismissed'
/**
* A date-time without Z or a numeric offset is parsed as the runtime's local
* time, which is UTC on Vercel and whatever the operator's laptop is locally.
* Require the offset so the deadline means the same instant everywhere.
*/
const HAS_UTC_OFFSET = /(?:Z|[+-]\d{2}:?\d{2})$/i
/**
* Parse the raw env value into an epoch ms deadline. Returns null when the
* value is missing, has no UTC offset, is unparseable, or is already in the
* past, so callers render nothing without a second check.
*/
export function parseSystemNoticeUntil(
raw: string | undefined | null,
now: number = Date.now(),
): number | null {
const trimmed = raw?.trim()
if (!trimmed) return null
if (!HAS_UTC_OFFSET.test(trimmed)) return null
const until = new Date(trimmed).getTime()
if (!Number.isFinite(until)) return null
return until > now ? until : null
}
type StorageLike = Pick<Storage, 'getItem' | 'setItem'>
export function isSystemNoticeDismissed(
storage: StorageLike | null | undefined,
until: number,
): boolean {
try {
return storage?.getItem(SYSTEM_NOTICE_STORAGE_KEY) === String(until)
} catch {
return false
}
}
export function dismissSystemNotice(storage: StorageLike | null | undefined, until: number): void {
try {
storage?.setItem(SYSTEM_NOTICE_STORAGE_KEY, String(until))
} catch {
// Private mode or blocked storage: the banner closes for this page
// load and may show again next time, which is the acceptable fallback.
}
}