CodeQL / Analyze (javascript-typescript) (push) Failing after 10m53s
CodeQL / Analyze (actions) (push) Failing after 10m43s
Build and Push Docker Image / Build linux/arm64 (push) Has been cancelled
Build and Push Docker Image / Merge, sign and scan (push) Has been cancelled
Build and Push Docker Image / Build linux/amd64 (push) Failing after 3m4s
Workflow audit (zizmor) / Audit workflows (push) Failing after 5m54s
* feat(dashboard): dismissible system notice banner for every signed-in user
Operator-set banner ("high load right now, some pages may respond slowly
or fail") rendered under the dashboard chrome for every signed-in user
while NEXT_PUBLIC_SYSTEM_NOTICE_UNTIL (ISO timestamp with offset) is in
the future. Closing it stores the deadline in localStorage, so each
browser sees it once; the banner hides itself at the deadline in open
tabs and is not rendered at all after it.
Why the problem occurred: there was no way to tell every user something
about the system itself. The existing banners are all per-company state
(sandbox, seat grace), so an operator notice had no home.
What was removed or simplified instead: no notices table, no migration,
no admin UI. One public env var carries both the on/off switch and the
expiry, and the same value is the dismiss key, so a later notice re-shows
once without any code change. No DB read, which matters because the
first use is a DB restart window.
Why this over the proposed shape: the request was a banner "until 23:00
tonight". Hardcoding that in code would need a second PR to switch off
or reuse; a DB-backed notice would read the database that is about to
go down. The env var expires on its own, and unset means gone.
Fixes #2463
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF
* fix(dashboard): system notice survives long deadlines, blocked storage, and every layout shell
Skeptic findings on 839a255f3:
- setTimeout clamps delays above 2^31-1 ms to ~1 ms, so a deadline more
than 24.8 days out hid the banner instantly. Wait in bounded steps and
re-check the clock.
- window.localStorage is a throwing property access when a browser blocks
site data; read it behind a try so the dashboard never crashes over a
notice.
- The close button was a hand-rolled 22px icon button; design.md requires
the shadcn icon Button (40px target).
- The byrå-consultant shell and the stale-cookie shell rendered no banner,
so "every signed-in user" was not true. The banner is now computed once,
before the shell branches, and mounted in all three.
Refs #2463
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF
* fix(dashboard): system notice deadline requires a UTC offset
A date-time without Z or a numeric offset parses as local time, which is
UTC on Vercel and the operator's zone locally, so the same value would
mean different instants. Reject it instead (CodeRabbit on #2464).
Declined: scoping the dismissal key by user id. The notice is about the
system, not the account; per-browser dismissal is the sandbox banner's
semantics and keeps identity out of layout chrome.
Refs #2463
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
92 lines
2.6 KiB
TypeScript
92 lines
2.6 KiB
TypeScript
'use client'
|
|
|
|
import { useEffect, useState } from 'react'
|
|
import { X } from 'lucide-react'
|
|
import { useTranslations } from 'next-intl'
|
|
import { Button } from '@/components/ui/button'
|
|
import {
|
|
dismissSystemNotice,
|
|
isSystemNoticeDismissed,
|
|
} from '@/components/dashboard/system-notice'
|
|
|
|
/**
|
|
* setTimeout clamps anything above 2^31-1 ms to ~1 ms, so a deadline more
|
|
* than 24.8 days out would hide the banner instantly. Wait in bounded steps
|
|
* and re-check the clock at each step instead.
|
|
*/
|
|
const MAX_TIMER_MS = 2_147_483_647
|
|
|
|
/**
|
|
* localStorage is a throwing property access when a browser blocks site
|
|
* data, not just a null; read it behind a try so the dashboard never
|
|
* crashes over a notice.
|
|
*/
|
|
function safeStorage(): Storage | null {
|
|
try {
|
|
return window.localStorage
|
|
} catch {
|
|
return null
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Operator-set system notice, shown once per browser until the deadline.
|
|
* Same chrome treatment as SandboxBanner: environment notice on secondary,
|
|
* never a warning fill (status colors are data, not chrome).
|
|
*
|
|
* Visibility is computed in an effect so server and client markup agree at
|
|
* hydration, and a timer hides the banner at the deadline in tabs that stay
|
|
* open past it.
|
|
*/
|
|
export function SystemNoticeBanner({ until }: { until: number }) {
|
|
const t = useTranslations('system_notice')
|
|
const [visible, setVisible] = useState(false)
|
|
|
|
useEffect(() => {
|
|
let timer: ReturnType<typeof setTimeout> | undefined
|
|
const tick = () => {
|
|
if (isSystemNoticeDismissed(safeStorage(), until)) {
|
|
setVisible(false)
|
|
return
|
|
}
|
|
const msLeft = until - Date.now()
|
|
if (msLeft <= 0) {
|
|
setVisible(false)
|
|
return
|
|
}
|
|
setVisible(true)
|
|
timer = setTimeout(tick, Math.min(msLeft, MAX_TIMER_MS))
|
|
}
|
|
tick()
|
|
return () => {
|
|
if (timer !== undefined) clearTimeout(timer)
|
|
}
|
|
}, [until])
|
|
|
|
if (!visible) return null
|
|
|
|
function handleDismiss() {
|
|
dismissSystemNotice(safeStorage(), until)
|
|
setVisible(false)
|
|
}
|
|
|
|
return (
|
|
<div
|
|
role="status"
|
|
className="relative z-50 flex flex-wrap items-center justify-center gap-x-3 gap-y-1 border-b border-border bg-secondary py-2 pl-4 pr-12 text-sm text-secondary-foreground"
|
|
>
|
|
<span className="text-center text-xs font-medium sm:text-sm">{t('high_load')}</span>
|
|
<Button
|
|
type="button"
|
|
variant="ghost"
|
|
size="icon"
|
|
onClick={handleDismiss}
|
|
className="absolute right-1 top-1/2 -translate-y-1/2"
|
|
aria-label={t('dismiss')}
|
|
>
|
|
<X className="h-4 w-4" />
|
|
</Button>
|
|
</div>
|
|
)
|
|
}
|