* fix(woocommerce): require both verified keys and browser confirmation to activate a connection The wc-auth callback alone used to flip a connection to active. Until the initiator's browser reached the return route the row was syncable, so an approver who never came back (closed tab, skipped sign-in, or lured into approving a connect someone else started) left their store's keys active inside another company's books, reachable by manual sync within seconds. Now the callback only stages the verified keys on the pending row, the return leg records browser_confirmed_at after the initiator check, and one conditional update flips the row to active exactly once when both signals are present, in either arrival order. A DB CHECK (20260907100000) makes an active row without both signals impossible; every consumer selects status = 'active', so staged keys can never sync. Also: 15-minute handshake TTL on both legs, duplicate callback refused, stale pending rows swept (keys wiped) at the start of the nightly orders cron, manual key entry records the confirmation itself, every path that closes a pending row wipes staged keys, expired/conflict toasts in sv + en. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCnbsjSYtD5uwo7ZqJAMQz * fix(woocommerce): drop the callback-leg TTL and state the gate's real scope Skeptic pass on the activation gate: - WooCommerce answers any non-200 callback response by deleting the key it just minted and showing a store-side error page, never redirecting back. A 410 for a slow approval therefore stranded the merchant. The callback now stages regardless of age; the session-bound return leg and the nightly sweep enforce expiry, and a stale pending row cannot sync either way. - The second activation signal comes from the initiating user, so the gate does not stop a store admin from approving a link someone else generated (wc-auth delivers keys server-to-server and identifies no approver). The migration header, route comments, decision log and PR body now say so instead of claiming otherwise. Proof of store control is a follow-up. - Every path that parks a pending row also wipes the store metadata the probe staged, so a refused handshake leaves nothing of the store behind. - A duplicate callback POST is a 200 no-op instead of a 409, so the status code no longer tells the state holder whether the merchant has approved. - The expiry message tells the user to remove the unused key in the store. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCnbsjSYtD5uwo7ZqJAMQz * fix(woocommerce): carry the handshake TTL in the activation flip, wipe metadata on denial Re-verification of the skeptic fixes found two gaps: - The initiator can open the return URL early, so a row confirmed at minute one still flipped when the keys landed hours later; the callback no longer refuses stale rows, so nothing bounded that. The conditional activation update now also requires created_at within the TTL. The callback still answers 200 (no store-side wp_die); the flip matches zero rows and the sweep parks the row. Covered by a pg-real case with both signals present on a 20-minute-old row. - The store-denied path parked the row without clearing the staged store metadata. It now wipes the same five columns as every other parking path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCnbsjSYtD5uwo7ZqJAMQz * chore(migrations): move the WooCommerce activation gate to 20260907143000 after main took 20260907100000 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCnbsjSYtD5uwo7ZqJAMQz * fix(woocommerce): make browser_confirmed_at server-only, finish replayed callbacks, budget the cron sweep Review round on PR #2375: - Superagent P1: browser_confirmed_at was member-writable through the row-scoped RLS policy, so any writer of the company could supply the initiator's signal on a colleague's pending row. New migration 20260907150000 adds a trigger keyed on the JWT role claim (same pattern as enforce_company_writer_role): end-user sessions cannot insert or update the column, service role and migrations pass. Manual key entry now inserts on the service client with company_id/user_id from the verified context. pg-real covers refusal on insert and update plus the server path. - CodeRabbit: a replayed callback for an already-keyed row now runs the activation flip instead of returning early, so a callback cut off between staging and activating is completed by its retry. - CodeRabbit: the cron deadline is fixed before the stale-handshake sweep, so the sweep counts against the route's maxDuration budget. - CodeRabbit: the activation CHECK is added NOT VALID (rows were already conformed by the backfill) and validated in 20260907150000 under the weaker lock. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCnbsjSYtD5uwo7ZqJAMQz * fix(woocommerce): make activation itself server-only, install the trigger before validating the gate Second review round on PR #2375: - CodeRabbit: an authenticated company member could still UPDATE ... SET status = 'active' on a fully staged row through PostgREST; the CHECK only proves both signals exist, and the 15-minute TTL lives in the server's conditional activation update. The server-only trigger now also refuses any end-user transition into 'active' (insert or update). Leaving 'active' (disconnect, supersede, revoked-key marking) stays member-writable. pg-real covers an expired, fully staged row: 42501 from a user session, then a member disconnect after the server activates. - Superagent P2: the VALIDATE CONSTRAINT now runs after the trigger is installed, so the gate is never enforced while its signal is still member-writable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LCnbsjSYtD5uwo7ZqJAMQz --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
303 lines
12 KiB
TypeScript
303 lines
12 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
|
|
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createServiceClient: vi.fn(),
|
|
}))
|
|
vi.mock('@/lib/init', () => ({ ensureInitialized: vi.fn() }))
|
|
vi.mock('@/lib/events/bus', () => ({ eventBus: { emit: vi.fn() } }))
|
|
vi.mock('@/lib/extensions/loader', () => ({ loadExtensions: vi.fn() }))
|
|
vi.mock('@/lib/extensions/registry', () => ({ extensionRegistry: { get: vi.fn() } }))
|
|
vi.mock('@/extensions/general/woocommerce/lib/api-client', async (importOriginal) => {
|
|
const actual =
|
|
await importOriginal<typeof import('@/extensions/general/woocommerce/lib/api-client')>()
|
|
return { ...actual, testConnectionAndFetchStoreInfo: vi.fn() }
|
|
})
|
|
|
|
import { POST } from '../callback/route'
|
|
import { createServiceClient } from '@/lib/supabase/server'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
import { extensionRegistry } from '@/lib/extensions/registry'
|
|
import { testConnectionAndFetchStoreInfo } from '@/extensions/general/woocommerce/lib/api-client'
|
|
import { decryptCredential } from '@/extensions/general/woocommerce/lib/credentials'
|
|
import { createQueuedMockSupabase } from '@/tests/helpers'
|
|
|
|
const STATE = '123e4567-e89b-12d3-a456-426614174000'
|
|
|
|
function makeCallbackRequest(body: unknown): Request {
|
|
return new Request('https://test.local/api/extensions/woocommerce/callback', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: typeof body === 'string' ? body : JSON.stringify(body),
|
|
})
|
|
}
|
|
|
|
const PENDING_ROW = {
|
|
id: 'conn-1',
|
|
company_id: 'company-1',
|
|
user_id: 'user-1',
|
|
store_url: 'https://shop.example.se',
|
|
created_at: new Date().toISOString(),
|
|
consumer_key_encrypted: null as string | null,
|
|
}
|
|
|
|
const STORE_INFO = {
|
|
name: 'Testbutiken',
|
|
currency: 'SEK',
|
|
prices_include_tax: true,
|
|
wc_version: '9.9.5',
|
|
}
|
|
|
|
function mockServiceClient() {
|
|
const queued = createQueuedMockSupabase()
|
|
vi.mocked(createServiceClient).mockResolvedValue(
|
|
queued.supabase as unknown as Awaited<ReturnType<typeof createServiceClient>>,
|
|
)
|
|
return queued
|
|
}
|
|
|
|
const VALID_BODY = {
|
|
key_id: 1,
|
|
user_id: STATE,
|
|
consumer_key: 'ck_new',
|
|
consumer_secret: 'cs_new',
|
|
key_permissions: 'read',
|
|
}
|
|
|
|
describe('POST /api/extensions/woocommerce/callback', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.stubEnv('WOOCOMMERCE_CREDENTIALS_ENCRYPTION_KEY', 'test-key')
|
|
vi.mocked(extensionRegistry.get).mockReturnValue(
|
|
{ id: 'woocommerce' } as ReturnType<typeof extensionRegistry.get>,
|
|
)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs()
|
|
})
|
|
|
|
it('refuses with 503 when the extension is disabled', async () => {
|
|
vi.mocked(extensionRegistry.get).mockReturnValue(undefined)
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(503)
|
|
const body = await res.json()
|
|
expect(body.code).toBe('EXTENSION_DISABLED')
|
|
})
|
|
|
|
it('rejects a non-JSON body with 400', async () => {
|
|
const res = await POST(makeCallbackRequest('not json'))
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('rejects a missing or non-UUID state with 400', async () => {
|
|
const res = await POST(
|
|
makeCallbackRequest({ ...VALID_BODY, user_id: 'not-a-uuid' }),
|
|
)
|
|
expect(res.status).toBe(400)
|
|
|
|
const res2 = await POST(makeCallbackRequest({ user_id: STATE }))
|
|
expect(res2.status).toBe(400)
|
|
})
|
|
|
|
it('returns 404 for an unknown or already-consumed state', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
vi.mocked(createServiceClient).mockResolvedValue(
|
|
supabase as unknown as Awaited<ReturnType<typeof createServiceClient>>,
|
|
)
|
|
enqueue({ data: null, error: { message: 'no rows', code: 'PGRST116' } })
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(404)
|
|
})
|
|
|
|
it('marks the row error and returns 502 when the credential probe fails', async () => {
|
|
const { enqueue, findCall } = mockServiceClient()
|
|
enqueue({ data: PENDING_ROW })
|
|
enqueue({ data: null }) // markError update
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockRejectedValue(new Error('403'))
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(502)
|
|
const errorUpdate = findCall('woocommerce_connections', 'update')?.[0] as Record<
|
|
string,
|
|
unknown
|
|
>
|
|
expect(errorUpdate).toMatchObject({
|
|
status: 'error',
|
|
oauth_state: null,
|
|
consumer_key_encrypted: null,
|
|
consumer_secret_encrypted: null,
|
|
})
|
|
// The probe ran against the STORED store_url, not anything the caller sent.
|
|
expect(vi.mocked(testConnectionAndFetchStoreInfo).mock.calls[0][0]).toMatchObject({
|
|
storeUrl: 'https://shop.example.se',
|
|
consumerKey: 'ck_new',
|
|
})
|
|
})
|
|
|
|
it('stages the verified keys but leaves the row pending until the browser confirms', async () => {
|
|
const { enqueue, findCalls, calls } = mockServiceClient()
|
|
enqueue({ data: PENDING_ROW })
|
|
enqueue({ data: { id: 'conn-1' } }) // stage update
|
|
enqueue({ data: null }) // activateIfComplete: browser signal missing, zero rows
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockResolvedValue(STORE_INFO)
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(200)
|
|
expect(await res.json()).toEqual({ success: true, activated: false })
|
|
|
|
const updates = findCalls('woocommerce_connections', 'update')
|
|
expect(updates).toHaveLength(2)
|
|
const staged = updates[0][0] as Record<string, string | boolean | null>
|
|
// Keys and store info are staged; nothing here says 'active' or turns
|
|
// the feed on, and the state stays so the return leg can find the row.
|
|
expect(staged).not.toHaveProperty('status')
|
|
expect(staged).not.toHaveProperty('transaction_sync_enabled')
|
|
expect(staged).not.toHaveProperty('oauth_state')
|
|
expect(staged.store_name).toBe('Testbutiken')
|
|
// Secrets never stored in plaintext, and they decrypt back.
|
|
expect(String(staged.consumer_key_encrypted)).not.toContain('ck_new')
|
|
expect(decryptCredential(String(staged.consumer_key_encrypted))).toBe('ck_new')
|
|
expect(decryptCredential(String(staged.consumer_secret_encrypted))).toBe('cs_new')
|
|
|
|
// The activation attempt is the conditional one: pending + both signals.
|
|
const activation = updates[1][0] as Record<string, unknown>
|
|
expect(activation.status).toBe('active')
|
|
const notCalls = calls.filter((c) => c.method === 'not').map((c) => c.args)
|
|
expect(notCalls).toContainEqual(['consumer_key_encrypted', 'is', null])
|
|
expect(notCalls).toContainEqual(['consumer_secret_encrypted', 'is', null])
|
|
expect(notCalls).toContainEqual(['browser_confirmed_at', 'is', null])
|
|
|
|
expect(eventBus.emit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('activates and emits when the browser confirmed before the keys arrived', async () => {
|
|
const { enqueue, findCalls } = mockServiceClient()
|
|
enqueue({ data: PENDING_ROW })
|
|
enqueue({ data: { id: 'conn-1' } }) // stage update
|
|
enqueue({
|
|
data: {
|
|
id: 'conn-1',
|
|
company_id: 'company-1',
|
|
user_id: 'user-1',
|
|
store_url: 'https://shop.example.se',
|
|
},
|
|
}) // activateIfComplete: both signals present
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockResolvedValue(STORE_INFO)
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(200)
|
|
expect(await res.json()).toEqual({ success: true, activated: true })
|
|
|
|
const updates = findCalls('woocommerce_connections', 'update')
|
|
const activation = updates[1][0] as Record<string, unknown>
|
|
expect(activation).toMatchObject({
|
|
status: 'active',
|
|
transaction_sync_enabled: true,
|
|
oauth_state: null,
|
|
})
|
|
expect(eventBus.emit).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
type: 'woocommerce.connected',
|
|
payload: expect.objectContaining({ connectionId: 'conn-1', companyId: 'company-1' }),
|
|
}),
|
|
)
|
|
})
|
|
|
|
it('answers a duplicate POST for a state that already holds keys with 200, never re-probes, but still runs the flip', async () => {
|
|
const { enqueue, findCalls } = mockServiceClient()
|
|
enqueue({ data: { ...PENDING_ROW, consumer_key_encrypted: 'enc:already' } })
|
|
enqueue({ data: null }) // activateIfComplete: browser not confirmed yet
|
|
|
|
const res = await POST(makeCallbackRequest({ ...VALID_BODY, consumer_key: 'ck_forged' }))
|
|
// 200, not 4xx: WooCommerce deletes its key and shows a store-side error
|
|
// on any non-200, and a distinct status would tell whoever holds the
|
|
// state whether the merchant has approved yet.
|
|
expect(res.status).toBe(200)
|
|
expect(await res.json()).toEqual({ success: true, activated: false })
|
|
expect(testConnectionAndFetchStoreInfo).not.toHaveBeenCalled()
|
|
// The only write is the conditional activation: the forged keys in the
|
|
// body never reach the row.
|
|
const updates = findCalls('woocommerce_connections', 'update')
|
|
expect(updates).toHaveLength(1)
|
|
expect(updates[0][0]).toMatchObject({ status: 'active' })
|
|
expect(updates[0][0]).not.toHaveProperty('consumer_key_encrypted')
|
|
})
|
|
|
|
it('completes a callback that was cut off between staging and activating when WooCommerce replays it', async () => {
|
|
const { enqueue } = mockServiceClient()
|
|
enqueue({ data: { ...PENDING_ROW, consumer_key_encrypted: 'enc:already' } })
|
|
enqueue({
|
|
data: {
|
|
id: 'conn-1',
|
|
company_id: 'company-1',
|
|
user_id: 'user-1',
|
|
store_url: 'https://shop.example.se',
|
|
},
|
|
}) // activateIfComplete: browser had confirmed in the meantime
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(200)
|
|
expect(await res.json()).toEqual({ success: true, activated: true })
|
|
expect(testConnectionAndFetchStoreInfo).not.toHaveBeenCalled()
|
|
expect(eventBus.emit).toHaveBeenCalledWith(
|
|
expect.objectContaining({ type: 'woocommerce.connected' }),
|
|
)
|
|
})
|
|
|
|
it('stages keys for a slow approval past the handshake TTL instead of refusing (WooCommerce wp_dies on non-200)', async () => {
|
|
const { enqueue, findCalls, calls } = mockServiceClient()
|
|
enqueue({
|
|
data: { ...PENDING_ROW, created_at: new Date(Date.now() - 45 * 60_000).toISOString() },
|
|
})
|
|
enqueue({ data: { id: 'conn-1' } }) // stage update
|
|
enqueue({ data: null }) // activateIfComplete: browser not confirmed
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockResolvedValue(STORE_INFO)
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(200)
|
|
expect(await res.json()).toEqual({ success: true, activated: false })
|
|
const updates = findCalls('woocommerce_connections', 'update')
|
|
expect(updates).toHaveLength(2)
|
|
expect(updates[0][0]).not.toHaveProperty('status')
|
|
// Even if the initiator confirmed early, the flip carries the TTL, so a
|
|
// stale row cannot become active from this leg.
|
|
const gte = calls.filter((c) => c.method === 'gte').map((c) => c.args)
|
|
expect(gte).toHaveLength(1)
|
|
expect(gte[0][0]).toBe('created_at')
|
|
})
|
|
|
|
it('parks the row and returns 409 when activation hits the one-active-per-store index', async () => {
|
|
const { enqueue, findCalls } = mockServiceClient()
|
|
enqueue({ data: PENDING_ROW })
|
|
enqueue({ data: { id: 'conn-1' } }) // stage update
|
|
enqueue({ data: null, error: { code: '23505', message: 'duplicate key' } })
|
|
enqueue({ data: null }) // markError update
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockResolvedValue(STORE_INFO)
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(409)
|
|
const updates = findCalls('woocommerce_connections', 'update')
|
|
expect(updates).toHaveLength(3)
|
|
// Parking wipes the staged secrets AND the store metadata the probe read.
|
|
expect(updates[2][0]).toMatchObject({
|
|
status: 'error',
|
|
consumer_key_encrypted: null,
|
|
consumer_secret_encrypted: null,
|
|
store_name: null,
|
|
currency: null,
|
|
})
|
|
expect(eventBus.emit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns 404 when the row left pending between lookup and staging', async () => {
|
|
const { enqueue } = mockServiceClient()
|
|
enqueue({ data: PENDING_ROW })
|
|
enqueue({ data: null }) // stage update matched zero rows
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockResolvedValue(STORE_INFO)
|
|
|
|
const res = await POST(makeCallbackRequest(VALID_BODY))
|
|
expect(res.status).toBe(404)
|
|
expect(eventBus.emit).not.toHaveBeenCalled()
|
|
})
|
|
})
|