-- PR #607 review round-1 fixes for match_batch_allocate. -- -- Five tightenings, all motivated by review findings on the prior patch -- (20260531120000_match_batch_allocate_cross_currency.sql): -- -- 1. Strict undershoot rejection. Previously the RPC accepted any -- v_total_allocated <= v_tx_abs, which meant the journal entry's -- bank line could come up short of the actual bank receipt and -- silently break reconciliation. We now require -- ABS(v_total_allocated - v_tx_abs) <= 0.005. -- The UI already enforces "fully allocated" — this matches it so -- the server can't be coaxed into the same broken state by a -- direct API caller. Returns new code BATCH_AMOUNT_BELOW_TX. -- -- 2. Bank line uses v_tx_abs (not v_total_allocated). With strict sum -- check (#1) the two values are equal within rounding, but using -- v_tx_abs makes the intent legible — the bank line IS the bank -- receipt, full stop. Per-row FX diff lines absorb the rounding. -- -- 3. Defense-in-depth company_id filter on re-queries in the line- -- build and payment passes. The validation pass already locked -- the rows with the filter, so this is paranoia, not correctness -- — but it costs nothing and closes the door on a future hand- -- crafted attack that swaps allocation.invoice_id between passes. -- (Greptile V8.2.1.) -- -- 4. Drop the v_booked_sek temp-aliasing in the line-build pass. -- The previous code reused v_booked_sek as a scratch var for -- invoice.total, which was a documented foot-gun and made the -- cross-currency branch hard to read. Adds a dedicated v_inv_total. -- (Greptile PI1.3.) -- -- 5. Truncate invoice_number in line_description to 32 chars. An -- adversarial 200-char invoice_number would push the description -- past the column's text length and break verification on SIE -- export readers that assume sensible field widths. Truncation -- mirrors what `padEnd(40)` would do downstream. -- (Greptile V1.2.5.) -- -- Everything else stays byte-identical: caller membership check, dedupe, -- deadlock-stable ORDER BY locking, period resolution, payment-row -- inserts, direction-mismatch guards, FX deviation guard. CREATE OR REPLACE FUNCTION public.match_batch_allocate( p_tx_id uuid, p_allocations jsonb, p_user_id uuid, p_company_id uuid ) RETURNS jsonb LANGUAGE plpgsql SECURITY DEFINER SET search_path TO 'public' AS $$ DECLARE v_tx RECORD; v_tx_abs numeric; v_allocation jsonb; v_alloc_index int := 0; v_kind text; v_invoice_id uuid; v_supplier_invoice_id uuid; v_alloc_amount numeric; v_total_allocated numeric := 0; v_has_customer boolean := false; v_has_supplier boolean := false; v_seen_ids text[] := ARRAY[]::text[]; v_target_id text; v_invoice RECORD; v_si_invoice RECORD; v_supplier_name text; v_supplier_invoice_number text; v_invoice_number text; v_fiscal_period_id uuid; v_period_is_closed boolean; v_period_locked_at timestamptz; v_journal_entry_id uuid := gen_random_uuid(); v_voucher_series text := 'A'; v_voucher_number int; v_entry_description text; v_source_type text; v_line_sort_order int := 0; v_new_paid numeric; v_new_remaining numeric; v_new_status text; v_now timestamptz := now(); v_payment_id uuid; v_results jsonb := '[]'::jsonb; v_inv_remaining numeric; v_inv_currency text; v_inv_fx_rate numeric; v_inv_total numeric; -- invoice.total (was aliased to v_booked_sek before — review fix #4) v_booked_sek numeric; -- SEK on 1510/2440 at booking time = inv_remaining × rate v_fx_diff numeric; -- bookedSek - allocation.amount (signed) v_paid_in_inv_currency numeric; v_inv_number_short text; -- truncated invoice_number for description (review fix #5) BEGIN IF NOT EXISTS ( SELECT 1 FROM public.company_members WHERE user_id = auth.uid() AND company_id = p_company_id ) THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_UNAUTHORIZED'); END IF; SELECT * INTO v_tx FROM public.transactions WHERE id = p_tx_id AND company_id = p_company_id FOR UPDATE; IF NOT FOUND THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_TX_NOT_FOUND'); END IF; IF v_tx.journal_entry_id IS NOT NULL THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_TX_ALREADY_BOOKED', 'details', jsonb_build_object('journal_entry_id', v_tx.journal_entry_id)); END IF; IF v_tx.amount = 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_TX_ZERO_AMOUNT'); END IF; v_tx_abs := ABS(v_tx.amount); IF jsonb_typeof(p_allocations) IS DISTINCT FROM 'array' OR jsonb_array_length(p_allocations) = 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_NO_ALLOCATIONS'); END IF; FOR v_allocation IN SELECT value FROM jsonb_array_elements(p_allocations) AS t(value) ORDER BY COALESCE(value->>'invoice_id', value->>'supplier_invoice_id', '') LOOP v_kind := v_allocation->>'kind'; v_alloc_amount := (v_allocation->>'amount')::numeric; v_target_id := COALESCE(v_allocation->>'invoice_id', v_allocation->>'supplier_invoice_id'); IF v_alloc_amount IS NULL OR v_alloc_amount <= 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_INVALID_AMOUNT', 'details', jsonb_build_object('index', v_alloc_index, 'amount', v_alloc_amount)); END IF; IF v_target_id IS NOT NULL AND v_target_id = ANY(v_seen_ids) THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_DUPLICATE_ALLOCATION', 'details', jsonb_build_object('id', v_target_id, 'index', v_alloc_index)); END IF; IF v_target_id IS NOT NULL THEN v_seen_ids := array_append(v_seen_ids, v_target_id); END IF; v_total_allocated := v_total_allocated + v_alloc_amount; IF v_kind = 'customer_invoice' THEN v_has_customer := true; v_invoice_id := (v_allocation->>'invoice_id')::uuid; SELECT * INTO v_invoice FROM public.invoices WHERE id = v_invoice_id AND company_id = p_company_id FOR UPDATE; IF NOT FOUND THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_INVOICE_NOT_FOUND', 'details', jsonb_build_object('index', v_alloc_index, 'invoice_id', v_invoice_id)); END IF; IF v_invoice.status NOT IN ('sent', 'overdue', 'partially_paid') THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_INVOICE_NOT_OPEN', 'details', jsonb_build_object('index', v_alloc_index, 'invoice_id', v_invoice_id, 'status', v_invoice.status)); END IF; v_inv_remaining := COALESCE(v_invoice.remaining_amount, v_invoice.total); v_inv_currency := v_invoice.currency; v_inv_fx_rate := v_invoice.exchange_rate; IF v_inv_currency = v_tx.currency THEN IF v_alloc_amount > v_inv_remaining + 0.005 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_OVERSHOOT', 'details', jsonb_build_object('index', v_alloc_index, 'invoice_id', v_invoice_id, 'requested', v_alloc_amount, 'remaining', v_inv_remaining)); END IF; ELSE IF v_inv_fx_rate IS NULL OR v_inv_fx_rate <= 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_FX_RATE_MISSING', 'details', jsonb_build_object('index', v_alloc_index, 'invoice_id', v_invoice_id, 'invoice_currency', v_inv_currency)); END IF; v_booked_sek := ROUND(v_inv_remaining * v_inv_fx_rate * 100) / 100; IF ABS(v_alloc_amount - v_booked_sek) > v_booked_sek * 0.10 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_FX_DEVIATION_TOO_LARGE', 'details', jsonb_build_object('index', v_alloc_index, 'invoice_id', v_invoice_id, 'allocation_amount', v_alloc_amount, 'expected_sek', v_booked_sek)); END IF; END IF; ELSIF v_kind = 'supplier_invoice' THEN v_has_supplier := true; v_supplier_invoice_id := (v_allocation->>'supplier_invoice_id')::uuid; SELECT * INTO v_si_invoice FROM public.supplier_invoices WHERE id = v_supplier_invoice_id AND company_id = p_company_id FOR UPDATE; IF NOT FOUND THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_SUPPLIER_INVOICE_NOT_FOUND', 'details', jsonb_build_object('index', v_alloc_index, 'supplier_invoice_id', v_supplier_invoice_id)); END IF; IF v_si_invoice.status NOT IN ('registered', 'approved', 'overdue', 'partially_paid') THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_SUPPLIER_INVOICE_NOT_OPEN', 'details', jsonb_build_object('index', v_alloc_index, 'supplier_invoice_id', v_supplier_invoice_id, 'status', v_si_invoice.status)); END IF; v_inv_remaining := COALESCE(v_si_invoice.remaining_amount, v_si_invoice.total); v_inv_currency := v_si_invoice.currency; v_inv_fx_rate := v_si_invoice.exchange_rate; IF v_inv_currency = v_tx.currency THEN IF v_alloc_amount > v_inv_remaining + 0.005 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_OVERSHOOT', 'details', jsonb_build_object('index', v_alloc_index, 'supplier_invoice_id', v_supplier_invoice_id, 'requested', v_alloc_amount, 'remaining', v_inv_remaining)); END IF; ELSE IF v_inv_fx_rate IS NULL OR v_inv_fx_rate <= 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_FX_RATE_MISSING', 'details', jsonb_build_object('index', v_alloc_index, 'supplier_invoice_id', v_supplier_invoice_id, 'invoice_currency', v_inv_currency)); END IF; v_booked_sek := ROUND(v_inv_remaining * v_inv_fx_rate * 100) / 100; IF ABS(v_alloc_amount - v_booked_sek) > v_booked_sek * 0.10 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_FX_DEVIATION_TOO_LARGE', 'details', jsonb_build_object('index', v_alloc_index, 'supplier_invoice_id', v_supplier_invoice_id, 'allocation_amount', v_alloc_amount, 'expected_sek', v_booked_sek)); END IF; END IF; ELSE RETURN jsonb_build_object('ok', false, 'code', 'BATCH_INVALID_KIND', 'details', jsonb_build_object('index', v_alloc_index, 'kind', v_kind)); END IF; v_alloc_index := v_alloc_index + 1; END LOOP; IF v_has_customer AND v_has_supplier THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_MIXED_KINDS_UNSUPPORTED'); END IF; -- Review fix #1: strict sum check on BOTH sides. Was previously only -- overshoot. Undershoot is now a server-side reject so a direct API -- caller can't sneak past the UI's balanced-only confirm. IF v_total_allocated > v_tx_abs + 0.005 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_AMOUNT_EXCEEDS_TX', 'details', jsonb_build_object('allocated', v_total_allocated, 'tx_amount_abs', v_tx_abs)); END IF; IF v_total_allocated < v_tx_abs - 0.005 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_AMOUNT_BELOW_TX', 'details', jsonb_build_object('allocated', v_total_allocated, 'tx_amount_abs', v_tx_abs)); END IF; IF v_has_customer AND v_tx.amount <= 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_DIRECTION_MISMATCH', 'details', jsonb_build_object('expected', 'income', 'tx_amount', v_tx.amount)); END IF; IF v_has_supplier AND v_tx.amount >= 0 THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_DIRECTION_MISMATCH', 'details', jsonb_build_object('expected', 'expense', 'tx_amount', v_tx.amount)); END IF; SELECT id, is_closed, locked_at INTO v_fiscal_period_id, v_period_is_closed, v_period_locked_at FROM public.fiscal_periods WHERE company_id = p_company_id AND v_tx.date BETWEEN period_start AND period_end ORDER BY period_start DESC LIMIT 1; IF v_fiscal_period_id IS NULL THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_NO_FISCAL_PERIOD', 'details', jsonb_build_object('tx_date', v_tx.date)); END IF; IF v_period_is_closed OR v_period_locked_at IS NOT NULL THEN RETURN jsonb_build_object('ok', false, 'code', 'BATCH_PERIOD_LOCKED', 'details', jsonb_build_object('fiscal_period_id', v_fiscal_period_id, 'is_closed', v_period_is_closed, 'locked_at', v_period_locked_at)); END IF; v_entry_description := CASE WHEN v_has_customer THEN 'Samlingsinbetalning ' || v_tx.date ELSE 'Samlingsbetalning ' || v_tx.date END; v_source_type := CASE WHEN v_has_customer THEN 'invoice_paid' ELSE 'supplier_invoice_paid' END; INSERT INTO public.journal_entries (id, user_id, company_id, fiscal_period_id, voucher_number, voucher_series, entry_date, description, source_type, status) VALUES (v_journal_entry_id, p_user_id, p_company_id, v_fiscal_period_id, 0, v_voucher_series, v_tx.date, v_entry_description, v_source_type, 'draft'); -- Line-build pass. Re-queries the locked invoice row WITH the company_id -- filter (review fix #3) and uses a dedicated v_inv_total var instead of -- aliasing v_booked_sek (review fix #4). v_alloc_index := 0; FOR v_allocation IN SELECT value FROM jsonb_array_elements(p_allocations) AS t(value) ORDER BY COALESCE(value->>'invoice_id', value->>'supplier_invoice_id', '') LOOP v_alloc_amount := (v_allocation->>'amount')::numeric; IF v_has_customer THEN v_invoice_id := (v_allocation->>'invoice_id')::uuid; SELECT invoice_number, currency, exchange_rate, remaining_amount, total INTO v_invoice_number, v_inv_currency, v_inv_fx_rate, v_inv_remaining, v_inv_total FROM public.invoices WHERE id = v_invoice_id AND company_id = p_company_id; v_inv_remaining := COALESCE(v_inv_remaining, v_inv_total); -- Review fix #5: truncate invoice_number to 32 chars in description. v_inv_number_short := LEFT(COALESCE(v_invoice_number, ''), 32); IF v_inv_currency = v_tx.currency THEN INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '1510', 0, v_alloc_amount, v_tx.currency, v_line_sort_order, 'Faktura ' || v_inv_number_short); v_line_sort_order := v_line_sort_order + 1; ELSE v_booked_sek := ROUND(v_inv_remaining * v_inv_fx_rate * 100) / 100; v_fx_diff := ROUND((v_booked_sek - v_alloc_amount) * 100) / 100; INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '1510', 0, v_booked_sek, v_tx.currency, v_line_sort_order, 'Faktura ' || v_inv_number_short || ' (' || v_inv_currency || ')'); v_line_sort_order := v_line_sort_order + 1; IF ABS(v_fx_diff) > 0.005 THEN IF v_fx_diff > 0 THEN INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '7960', v_fx_diff, 0, v_tx.currency, v_line_sort_order, 'Valutakursförlust ' || v_inv_number_short); ELSE INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '3960', 0, ABS(v_fx_diff), v_tx.currency, v_line_sort_order, 'Valutakursvinst ' || v_inv_number_short); END IF; v_line_sort_order := v_line_sort_order + 1; END IF; END IF; ELSE v_supplier_invoice_id := (v_allocation->>'supplier_invoice_id')::uuid; SELECT si.supplier_invoice_number, s.name, si.currency, si.exchange_rate, si.remaining_amount, si.total INTO v_supplier_invoice_number, v_supplier_name, v_inv_currency, v_inv_fx_rate, v_inv_remaining, v_inv_total FROM public.supplier_invoices si LEFT JOIN public.suppliers s ON s.id = si.supplier_id WHERE si.id = v_supplier_invoice_id AND si.company_id = p_company_id; v_inv_remaining := COALESCE(v_inv_remaining, v_inv_total); v_inv_number_short := LEFT(COALESCE(v_supplier_invoice_number, ''), 32); IF v_inv_currency = v_tx.currency THEN INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '2440', v_alloc_amount, 0, v_tx.currency, v_line_sort_order, TRIM(BOTH ' - ' FROM COALESCE(v_supplier_name, '') || ' - ' || v_inv_number_short)); v_line_sort_order := v_line_sort_order + 1; ELSE v_booked_sek := ROUND(v_inv_remaining * v_inv_fx_rate * 100) / 100; v_fx_diff := ROUND((v_booked_sek - v_alloc_amount) * 100) / 100; INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '2440', v_booked_sek, 0, v_tx.currency, v_line_sort_order, TRIM(BOTH ' - ' FROM COALESCE(v_supplier_name, '') || ' - ' || v_inv_number_short || ' (' || v_inv_currency || ')')); v_line_sort_order := v_line_sort_order + 1; IF ABS(v_fx_diff) > 0.005 THEN IF v_fx_diff > 0 THEN INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '3960', 0, v_fx_diff, v_tx.currency, v_line_sort_order, 'Valutakursvinst ' || v_inv_number_short); ELSE INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '7960', ABS(v_fx_diff), 0, v_tx.currency, v_line_sort_order, 'Valutakursförlust ' || v_inv_number_short); END IF; v_line_sort_order := v_line_sort_order + 1; END IF; END IF; END IF; v_alloc_index := v_alloc_index + 1; END LOOP; -- Review fix #2: bank line uses v_tx_abs (the actual bank receipt). -- The journal balances because per-row FX diff lines absorbed the -- rounding between booked_sek and alloc_amount on cross-currency -- rows, and the strict sum check guarantees same-currency rows -- already total to v_tx_abs. IF v_has_customer THEN INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '1930', v_tx_abs, 0, v_tx.currency, v_line_sort_order, 'Inbetalning ' || v_tx.date); ELSE INSERT INTO public.journal_entry_lines (journal_entry_id, account_number, debit_amount, credit_amount, currency, sort_order, line_description) VALUES (v_journal_entry_id, '1930', 0, v_tx_abs, v_tx.currency, v_line_sort_order, 'Utbetalning ' || v_tx.date); END IF; SELECT voucher_number INTO v_voucher_number FROM public.commit_journal_entry(p_company_id, v_journal_entry_id); v_alloc_index := 0; FOR v_allocation IN SELECT value FROM jsonb_array_elements(p_allocations) AS t(value) ORDER BY COALESCE(value->>'invoice_id', value->>'supplier_invoice_id', '') LOOP v_alloc_amount := (v_allocation->>'amount')::numeric; IF v_has_customer THEN v_invoice_id := (v_allocation->>'invoice_id')::uuid; -- Review fix #3: re-query with company_id filter. SELECT * INTO v_invoice FROM public.invoices WHERE id = v_invoice_id AND company_id = p_company_id; IF v_invoice.currency = v_tx.currency THEN v_paid_in_inv_currency := v_alloc_amount; ELSE v_paid_in_inv_currency := COALESCE(v_invoice.remaining_amount, v_invoice.total); END IF; v_new_paid := ROUND((COALESCE(v_invoice.paid_amount, 0) + v_paid_in_inv_currency) * 100) / 100; v_new_remaining := GREATEST(0, ROUND((COALESCE(v_invoice.remaining_amount, v_invoice.total) - v_paid_in_inv_currency) * 100) / 100); v_new_status := CASE WHEN v_new_remaining <= 0.005 THEN 'paid' ELSE 'partially_paid' END; UPDATE public.invoices SET status = v_new_status, paid_at = CASE WHEN v_new_status = 'paid' THEN v_now ELSE paid_at END, paid_amount = v_new_paid, remaining_amount = v_new_remaining, updated_at = v_now WHERE id = v_invoice_id AND company_id = p_company_id; INSERT INTO public.invoice_payments (user_id, company_id, invoice_id, payment_date, amount, currency, exchange_rate, journal_entry_id, transaction_id) VALUES (p_user_id, p_company_id, v_invoice_id, v_tx.date, v_paid_in_inv_currency, v_invoice.currency, v_invoice.exchange_rate, v_journal_entry_id, p_tx_id) RETURNING id INTO v_payment_id; v_results := v_results || jsonb_build_array(jsonb_build_object( 'kind', 'customer_invoice', 'invoice_id', v_invoice_id, 'payment_id', v_payment_id, 'status', v_new_status, 'paid_amount', v_new_paid, 'remaining_amount', v_new_remaining, 'amount', v_alloc_amount, 'cross_currency', v_invoice.currency <> v_tx.currency)); ELSE v_supplier_invoice_id := (v_allocation->>'supplier_invoice_id')::uuid; SELECT * INTO v_si_invoice FROM public.supplier_invoices WHERE id = v_supplier_invoice_id AND company_id = p_company_id; IF v_si_invoice.currency = v_tx.currency THEN v_paid_in_inv_currency := v_alloc_amount; ELSE v_paid_in_inv_currency := COALESCE(v_si_invoice.remaining_amount, v_si_invoice.total); END IF; v_new_paid := ROUND((COALESCE(v_si_invoice.paid_amount, 0) + v_paid_in_inv_currency) * 100) / 100; v_new_remaining := GREATEST(0, ROUND((COALESCE(v_si_invoice.remaining_amount, v_si_invoice.total) - v_paid_in_inv_currency) * 100) / 100); v_new_status := CASE WHEN v_new_remaining <= 0.005 THEN 'paid' ELSE 'partially_paid' END; UPDATE public.supplier_invoices SET status = v_new_status, paid_at = CASE WHEN v_new_status = 'paid' THEN v_now ELSE paid_at END, paid_amount = v_new_paid, remaining_amount = v_new_remaining, payment_journal_entry_id = v_journal_entry_id, updated_at = v_now WHERE id = v_supplier_invoice_id AND company_id = p_company_id; INSERT INTO public.supplier_invoice_payments (user_id, company_id, supplier_invoice_id, payment_date, amount, currency, journal_entry_id, transaction_id) VALUES (p_user_id, p_company_id, v_supplier_invoice_id, v_tx.date, v_paid_in_inv_currency, v_si_invoice.currency, v_journal_entry_id, p_tx_id) RETURNING id INTO v_payment_id; v_results := v_results || jsonb_build_array(jsonb_build_object( 'kind', 'supplier_invoice', 'supplier_invoice_id', v_supplier_invoice_id, 'payment_id', v_payment_id, 'status', v_new_status, 'paid_amount', v_new_paid, 'remaining_amount', v_new_remaining, 'amount', v_alloc_amount, 'cross_currency', v_si_invoice.currency <> v_tx.currency)); END IF; v_alloc_index := v_alloc_index + 1; END LOOP; UPDATE public.transactions SET journal_entry_id = v_journal_entry_id, is_business = TRUE, invoice_id = CASE WHEN jsonb_array_length(p_allocations) = 1 AND v_has_customer AND ABS(v_total_allocated - v_tx_abs) < 0.005 THEN (p_allocations->0->>'invoice_id')::uuid ELSE NULL END, supplier_invoice_id = CASE WHEN jsonb_array_length(p_allocations) = 1 AND v_has_supplier AND ABS(v_total_allocated - v_tx_abs) < 0.005 THEN (p_allocations->0->>'supplier_invoice_id')::uuid ELSE NULL END, potential_invoice_id = NULL, potential_supplier_invoice_id = NULL, updated_at = v_now WHERE id = p_tx_id AND company_id = p_company_id; RETURN jsonb_build_object('ok', true, 'journal_entry_id', v_journal_entry_id, 'voucher_series', v_voucher_series, 'voucher_number', v_voucher_number, 'tx_id', p_tx_id, 'allocations', v_results, 'total_allocated', v_total_allocated, 'leftover', 0); END; $$; NOTIFY pgrst, 'reload schema';