Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.
Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.
Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.
Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* fix(reconciliation): secondary-account scoping, dialog clipping, and N:1 matching
Three follow-ups to per-account bank reconciliation (PR #623):
- Secondary same-currency accounts (e.g. a 1931 savings account) double-counted
the company's unassigned (NULL cash_account_id) transactions, inflating their
bank total and showing a large bogus difference while 1930 still reconciled.
Only the primary cash account now claims NULL rows; every other account scopes
strictly to its own id. `includeUnassigned` is threaded through all
status/run/list call sites from cash_accounts.is_primary.
- The "Matcha mot befintlig verifikation" picker's dropdown was absolutely
positioned inside the dialog's overflow-y-auto container and got clipped. Add
an `inline` mode that renders the candidate list in normal flow; the dialog
uses it, the reconciliation view keeps the compact overlay.
- N:1 matching: several bank transactions can now settle one verifikat (a salary
run paid in multiple transfers, an invoice paid in instalments). New
get_account_gl_lines_for_matching RPC surfaces already-matched vouchers with a
linked_transaction_count behind a "Visa även matchade verifikationer" toggle;
manualLink's 1:1 guard is relaxed (the aggregate difference still catches
mis-links).
Tests: extended bank-reconciliation unit tests (strict scope + N:1), rewrote the
cash_account_id isolation pg test to prove NULL rows land on the primary account
only, and added a pg test for the new RPC.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(reconciliation): address PR review — accurate "att matcha mot" count
- BankReconciliationView: the "N verifikationer att matcha mot" hint counted
glLines (which includes already-matched vouchers when "Visa matchade" is on),
overcounting the vouchers that still need a transaction. Use unmatchedGlLines
so the label is correct regardless of the toggle (matches the table below).
- MatchVerifikationPicker: document that `open` is overlay-only; the setOpen()
writes are intentional no-ops in inline mode.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
