Bug/open banking flow (#854)

* fix(enable-banking): pin Mobile BankID (decoupled) auth_method so Handelsbanken corporate connects

We never sent auth_method to Enable Banking, so it fell back to the ASPSP's
visible default — REDIRECT for Handelsbanken. For Handelsbanken *corporate*
PSUs the redirect flow does not support Mobile BankID, so authorization failed
right after the user approved in the BankID app. Mobile BankID at Handelsbanken
is a DECOUPLED method flagged hidden_method=true, which Enable Banking only uses
when requested explicitly.

Resolve the bank's preferred auth method before /auth: query the ASPSP's
auth_methods and pick the DECOUPLED (Mobile BankID) method when present,
otherwise leave auth_method unset so banks that already work are untouched.
The method name is read dynamically per psu_type, so it is robust across
sandbox/production naming.

- api-client: add approach/hidden_method to AuthMethod, fix ASPSP.auth_methods
  field name (was available_auth_methods, never populated), add
  getPreferredAuthMethod(), thread optional authMethod through startAuthorization
- index: resolve authMethod in /connect and pass it on both fresh + reconnect
- tests: cover method selection and request-body shaping

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(invoice-inbox): clean up bulk-selection toolbar UI

Redesign the selection toolbar shown when inbox items are checked:
one solid primary "Bokför valda" button with outlined secondary
actions ("Fråga assistenten", "Ta bort") and a plain selection
count. Removes the redundant "Avmarkera" button (users uncheck the
still-visible box), fixes label clipping, and gives the toolbar more
breathing room.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(entitlements): bypass paywall in local development

Add isPaywallBypassed() so all gated capabilities are testable locally
without a subscription. Fires only on NODE_ENV=development (npm run dev)
or an explicit DISABLE_PAYWALL=true escape hatch — production builds run
under NODE_ENV=production and the entitlement suite runs under 'test',
so both keep exercising the real gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(tic): resolve enskild firma bolagsuppgifter via 12-digit personnummer

TIC's Lens search is fuzzy and only resolves an enskild firma from the 12-digit (century-prefixed) personnummer; a 10-digit form fuzzy-matched an unrelated entity. Expand personnummer to 12 digits before querying and reject hits whose registration number is unrelated to the request. Add a "Hämta" action to the settings Bolagsuppgifter panel to (re)fetch on demand.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(transactions): implement categorize core for bank transaction categorization

- Added `categorize-core.ts` to handle categorization of bank transactions, supporting single and bulk operations.
- Introduced `categorizeMatchedTransaction` and `bulkBookMatchedInboxItems` functions for transaction processing.
- Implemented fiscal period validation and duplicate booking detection.
- Enhanced logging and error handling for transaction categorization.

feat(scripts): add diagnostic script for Handelsbanken ASPSP metadata

- Created `check-handelsbanken-aspsp.mjs` to fetch and display available authentication methods for Handelsbanken.
- Outputs metadata for business and personal PSU types, including default authentication methods.

fix(migrations): increase statement timeout for SIE bulk delete operations

- Updated `20260629160000_sie_bulk_delete_statement_timeout.sql` to set a longer statement timeout for bulk delete RPCs to prevent cancellations during large imports.

feat(migrations): add bulk book inbox items to pending operations

- Expanded `pending_operations` table to include `bulk_book_inbox_items` operation type in `20260630120000_pending_operations_add_bulk_book_inbox_items.sql`.
- Supports bulk booking of matched inbox items against bank transactions.

test(pg): add tests for replace_period_opening_balance_link RPC

- Implemented tests in `replace-period-opening-balance-link.pg.test.ts` to validate the functionality of the opening-balance correction flow.
- Ensured immutability of opening balance links and proper handling of posted vs. non-posted entries.

* fix(sie-export): update journal entries and lines handling in SIE export tests

* fix(migrations): resolve version collision on 20260629160000

The SIE bulk-delete statement_timeout migration shared version
20260629160000 with journal_entries_list_series_filter (merged from
main via #798/#823), causing a schema_migrations_pkey duplicate key
error on apply. Rename the branch's migration to 20260629160100.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(compliance): resolve compliance-swarm + review findings

- opening-balance/correct: compensating rollback for the non-atomic
  storno+rebook so a mid-sequence failure never leaves two posted OB
  entries (ASVS V2.3); durable audit event on every failure path
  (V16); reference the original verifikationsnummer in the corrected
  entry per BFL 5 kap 5§; document that requireWrite already enforces
  write-role + membership (V8.2.1 was a false positive)
- reports sources routes: validate the cursor date component as ISO
  (/^\d{4}-\d{2}-\d{2}$/) before use, 400 on malformed (ASVS V1.2),
  applied to both the VAT-declaration and trial-balance routes
- AgentSessionList: await the rename PATCH, revert the optimistic
  title and toast on failure (ASVS V4.5)
- bank booking: exclude same-batch siblings from the booking-time
  duplicate guard so bulk-booking distinct same-(date,amount)
  transactions no longer false-positives; pre-existing duplicate
  detection is preserved
- BulkBookInboxDialog: drop the unsafe currency-based reverse_charge
  default, add an omvänd skattskyldighet advisory, and type VAT
  options to the backend VatTreatment union
- OpeningBalanceRowEditor: hold onChange in a ref (synced in effect,
  not during render) so an unstable callback can't cause a render loop

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mattsson
2026-07-01 18:13:00 +02:00
committed by GitHub
co-authored by Claude Opus 4.8
parent 2da9c71eb3
commit f63d3e3100
83 changed files with 6769 additions and 1360 deletions
+21 -1
View File
@@ -1139,8 +1139,17 @@
"fy_status_open": "Open",
"fy_status_locked": "Locked",
"fy_status_closed": "Closed",
"fy_action_lock": "Lock",
"fy_action_unlock": "Unlock",
"fy_confirm_cancel": "Cancel",
"fy_lock_confirm_title": "Lock fiscal year?",
"fy_lock_confirm_body": "{name} will be locked. No new entries can be posted in this period until you unlock it again.",
"fy_unlock_confirm_title": "Unlock fiscal year?",
"fy_unlock_confirm_body": "{name} will be unlocked so entries can be posted in this period again. This action is recorded in the audit log.",
"fy_lock_success": "Fiscal year locked",
"fy_unlock_success": "Fiscal year unlocked",
"fy_action_error": "The action could not be completed",
"related_heading": "Related",
"related_fiscal_year": "Fiscal years and opening balances",
"related_chart_of_accounts": "Chart of accounts (BAS)"
},
"settings_tax": {},
@@ -1778,10 +1787,17 @@
"doc_attached_count": "{count} attached",
"doc_pick_existing": "Choose existing document",
"doc_picked_remove": "Remove document",
"doc_clear": "Remove document",
"doc_link_failed_title": "Receipt could not be attached",
"doc_link_failed_description": "{count} file(s) could not be linked to the journal entry. Try again from the bookkeeping page.",
"bank_line_description": "Business account"
},
"document_viewer": {
"empty": "No document attached",
"header_label": "Document",
"open_in_new_tab": "Open in new tab",
"not_previewable": "Can't preview"
},
"tx_attach_dialog": {
"title": "Match to document",
"description": "Attach a receipt or invoice to the transaction — pick from the inbox or upload a new file.",
@@ -3203,6 +3219,7 @@
"correct_menu": "Correct",
"correct_lines": "Correct lines",
"correct_date": "Correct date",
"correct_opening_balances": "Correct opening balances",
"reverse_action": "Reverse (storno)",
"reverse_confirm_title": "Reverse journal entry",
"reverse_confirm_label": "Create storno",
@@ -3263,6 +3280,7 @@
"delete_dialog_entry_body": "The journal entry and its lines are removed. Linked transactions and invoices keep their data but are marked as unposted. Documents (receipts, files) are kept but unlinked."
},
"journal_form": {
"account_not_activated": "Activated when you post",
"save_edit": "Save changes",
"toast_updated_title": "Draft updated",
"toast_updated_description": "Your changes to the draft were saved.",
@@ -3664,6 +3682,8 @@
"tab_new_entry": "New journal entry",
"tab_accounts": "Chart of accounts",
"new_entry_dialog_title": "New journal entry",
"create_with_assistant": "Create with assistant",
"ask_assistant_handoff": "Let the assistant fill it in?",
"loading_source_voucher": "Loading source voucher...",
"copy_failed_title": "Could not copy journal entry",
"copy_source_missing": "Source voucher not found.",
+21 -1
View File
@@ -1139,8 +1139,17 @@
"fy_status_open": "Öppet",
"fy_status_locked": "Låst",
"fy_status_closed": "Stängt",
"fy_action_lock": "Lås",
"fy_action_unlock": "Lås upp",
"fy_confirm_cancel": "Avbryt",
"fy_lock_confirm_title": "Lås räkenskapsår?",
"fy_lock_confirm_body": "{name} låses. Inga nya verifikationer kan bokföras i perioden förrän du låser upp den igen.",
"fy_unlock_confirm_title": "Lås upp räkenskapsår?",
"fy_unlock_confirm_body": "{name} låses upp så att verifikationer åter kan bokföras i perioden. Åtgärden loggas i behandlingshistoriken.",
"fy_lock_success": "Räkenskapsåret är låst",
"fy_unlock_success": "Räkenskapsåret är upplåst",
"fy_action_error": "Åtgärden kunde inte slutföras",
"related_heading": "Relaterat",
"related_fiscal_year": "Räkenskapsår och ingående balanser",
"related_chart_of_accounts": "Kontoplan (BAS)"
},
"settings_tax": {},
@@ -1778,10 +1787,17 @@
"doc_attached_count": "{count} bifogade",
"doc_pick_existing": "Välj befintligt underlag",
"doc_picked_remove": "Ta bort underlag",
"doc_clear": "Ta bort underlag",
"doc_link_failed_title": "Underlag kunde inte bifogas",
"doc_link_failed_description": "{count} fil(er) kunde inte länkas till verifikationen. Försök igen via bokföringssidan.",
"bank_line_description": "Företagskonto"
},
"document_viewer": {
"empty": "Inget underlag bifogat",
"header_label": "Underlag",
"open_in_new_tab": "Öppna i ny flik",
"not_previewable": "Kan inte förhandsvisas"
},
"tx_attach_dialog": {
"title": "Matcha mot underlag",
"description": "Koppla ett kvitto eller en faktura till transaktionen — välj från inkorgen eller ladda upp en ny fil.",
@@ -3203,6 +3219,7 @@
"correct_menu": "Rätta",
"correct_lines": "Rätta rader",
"correct_date": "Rätta datum",
"correct_opening_balances": "Korrigera ingående balanser",
"reverse_action": "Återför (storno)",
"reverse_confirm_title": "Återför verifikat",
"reverse_confirm_label": "Skapa storno",
@@ -3263,6 +3280,7 @@
"delete_dialog_entry_body": "Verifikatet och dess kontorader tas bort. Kopplade transaktioner och fakturor behåller sina uppgifter men markeras som ej bokförda. Underlag (kvitton, dokument) behålls men avlänkas."
},
"journal_form": {
"account_not_activated": "Aktiveras vid bokföring",
"save_edit": "Spara ändringar",
"toast_updated_title": "Utkast uppdaterat",
"toast_updated_description": "Ändringarna i utkastet har sparats.",
@@ -3664,6 +3682,8 @@
"tab_new_entry": "Ny verifikation",
"tab_accounts": "Kontoplan",
"new_entry_dialog_title": "Ny verifikation",
"create_with_assistant": "Skapa med assistent",
"ask_assistant_handoff": "Hellre låta assistenten fylla i?",
"loading_source_voucher": "Laddar källverifikat...",
"copy_failed_title": "Kunde inte kopiera verifikat",
"copy_source_missing": "Källverifikatet hittades inte.",