admin/accounted
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: hide API-archived customers and suppliers from lists and pickers (#1927)

Browse Source 
* fix: hide API-archived customers and suppliers from lists and pickers

The v1 API soft-archives customers and suppliers (archived_at, plus
is_active=false on suppliers) and its own list routes hide those rows
behind ?include_archived=true. No other surface filtered archived_at, so
an archived counterparty stayed a normal row in the dashboard rosters,
the internal /api/customers and /api/suppliers list routes, the MCP list
tools and every customer/supplier picker.

Apply the same canonical `archived_at IS NULL` filter on every non-v1
list and picker path:

- /api/customers GET, /api/suppliers GET (feeds the customers page and
  the supplier-invoice form)
- suppliers dashboard page (reads suppliers via browser Supabase)
- InvoiceEditor and NewRecurringScheduleDialog customer pickers; an
  invoice or schedule being edited keeps its current customer visible
  (archiving does not refuse on drafts, so a draft can point at one)
- deadlines page and CalendarWorkspace customer pickers
- InvoicePreviewCard sample customer
- gnubok_list_customers and gnubok_list_suppliers: hidden by default,
  optional include_archived boolean mirroring the v1 flag; rows now
  carry archived_at so an agent can tell them apart when opted in

Detail routes and by-id lookups are untouched: an archived row still
opens. The delete-vs-archive semantics are unchanged.

The tools/list payload guard moves 60.7K to 60.8K: main had ~6 tokens
of headroom, so even the bare boolean contract crossed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(schema): raise the unresolvable-expression ceiling by 2 for the archived-customer picker filters

The two .or('archived_at.is.null,id.eq.<uuid>') filters keep an edited
draft's archived customer selectable. The uuid is a runtime value, so the
scanner cannot resolve the expression; both columns exist and the filter is
covered by the archived-counterparty tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-08-26 13:35:27 +02:00
committed by GitHub
co-authored by Claude Fable 5 Jakob Wennberg
parent 1185ab4294
commit f338850bd0
14 changed files with 273 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/general/mcp-server/server.ts
+30 -14
View File
@@ -5295,8 +5295,12 @@ export const tools: McpTool[] = [
{
name: 'gnubok_list_customers',
title: 'List Customers',
description: 'List all customers for the active company. Use to look up customer_id for invoice creation.',
inputSchema: { type: 'object', additionalProperties: false, properties: {} },
description: 'List active customers. Use to look up customer_id for invoice creation. include_archived=true adds archived rows.',
inputSchema: {
type: 'object',
additionalProperties: false,
properties: { include_archived: { type: 'boolean' } },
},
outputSchema: {
type: 'object',
additionalProperties: false,
@@ -5312,7 +5316,10 @@ export const tools: McpTool[] = [
idempotentHint: true,
openWorldHint: false,
},
async execute(_args, companyId, userId, supabase) {
async execute(args, companyId, userId, supabase) {
// Archived rows (v1 API soft-delete) are hidden by default: same
// `archived_at IS NULL` convention and opt-in flag as the v1 list.
const includeArchived = args.include_archived === true
// Paginated (fetchAllRows): PostgREST silently caps un-ranged selects at
// 1000 rows. Page on the unique id, then re-sort by name for display.
type ListedCustomer = {
@@ -5324,14 +5331,15 @@ export const tools: McpTool[] = [
}
let rows: ListedCustomer[]
try {
rows = await fetchAllRows<ListedCustomer>(({ from, to }) =>
supabase
rows = await fetchAllRows<ListedCustomer>(({ from, to }) => {
const query = supabase
.from('customers')
.select('id, name, customer_type, email, org_number, vat_number, personal_number, default_payment_terms, city, country')
.select('id, name, customer_type, email, org_number, vat_number, personal_number, default_payment_terms, city, country, archived_at')
.eq('company_id', companyId)
return (includeArchived ? query : query.is('archived_at', null))
.order('id', { ascending: true })
.range(from, to)
)
})
} catch (error) {
throw new Error(`Database error: ${error instanceof Error ? error.message : 'unknown error'}`)
}
@@ -6971,8 +6979,12 @@ export const tools: McpTool[] = [
{
name: 'gnubok_list_suppliers',
title: 'List Suppliers (Leverantörer)',
description: 'List all suppliers (leverantörer) with contact and payment details, sorted by name.',
inputSchema: { type: 'object', additionalProperties: false, properties: {} },
description: 'List active suppliers (leverantörer) with contact and payment details, sorted by name. include_archived=true adds archived rows.',
inputSchema: {
type: 'object',
additionalProperties: false,
properties: { include_archived: { type: 'boolean' } },
},
outputSchema: {
type: 'object',
additionalProperties: false,
@@ -6988,19 +7000,23 @@ export const tools: McpTool[] = [
idempotentHint: true,
openWorldHint: false,
},
async execute(_args, companyId, userId, supabase) {
async execute(args, companyId, userId, supabase) {
// Archived rows (v1 API soft-delete) are hidden by default: same
// `archived_at IS NULL` convention and opt-in flag as the v1 list.
const includeArchived = args.include_archived === true
// Paginated (fetchAllRows): PostgREST silently caps un-ranged selects at
// 1000 rows. Page on the unique id, then re-sort by name for display.
let suppliers: { id: string; name: string }[]
try {
suppliers = await fetchAllRows<{ id: string; name: string }>(({ from, to }) =>
supabase
suppliers = await fetchAllRows<{ id: string; name: string }>(({ from, to }) => {
const query = supabase
.from('suppliers')
.select('id, name, supplier_type, email, phone, org_number, vat_number, default_expense_account, default_payment_terms, default_currency, city, country')
.select('id, name, supplier_type, email, phone, org_number, vat_number, default_expense_account, default_payment_terms, default_currency, city, country, archived_at')
.eq('company_id', companyId)
return (includeArchived ? query : query.is('archived_at', null))
.order('id', { ascending: true })
.range(from, to)
)
})
} catch (error) {
throw new Error(`Database error: ${error instanceof Error ? error.message : 'unknown error'}`)
}