chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers (#2150)

* chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers

Remove 33 dead files, ~270 unreferenced exports/types, 13 dead i18n
namespaces and 4 unused dependencies; fold byte-identical helper copies
into one canonical home each (lib/utils chunk/sleep/utcDateStamp,
lib/dates/iso, lib/invariants/uuid, lib/xml/escape, lib/reports/sru/format,
lib/pdf/number-text, lib/browser/panel-request, lib/api/v1/body +
v1ValidationError rolled out to ~55 v1 routes, booking-template schemas).

No behaviour change: v1 bodies and status codes, MCP tool schemas, DB
writes and money math are untouched. Naive ore rounding was deliberately
not swapped for roundOre; see DECISIONS.md 2026-09-02 for the full list
of things left alone on purpose.

tsc, lint, 19588 unit tests and check:guards green; antipattern baseline
ratcheted (naive-ore-round 622 -> 620, hand-rolled-invariant 115 -> 113).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(transactions): import RawTransaction from @/types after the ingest re-export removal

CI's type ratchet (check:types, full tsconfig) caught the one test file
that still imported the type through lib/transactions/ingest.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-09-02 11:51:16 +02:00
committed by GitHub
co-authored by Claude Fable 5.1 Jakob Wennberg
parent 18cbc4c30a
commit f266c386f3
359 changed files with 1796 additions and 11199 deletions
-246
View File
@@ -1,246 +0,0 @@
'use client'
import { useState } from 'react'
import Link from 'next/link'
import { useTranslations } from 'next-intl'
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'
import { Badge } from '@/components/ui/badge'
import { Button } from '@/components/ui/button'
import { useToast } from '@/components/ui/use-toast'
import { Deadline, DeadlineStatus, TAX_DEADLINE_TYPE_LABELS, DEADLINE_STATUS_LABELS } from '@/types'
import { getReportUrl } from '@/lib/tax/deadline-config'
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
// Use the labels from types
const STATUS_LABELS = DEADLINE_STATUS_LABELS
import {
FileText,
ChevronRight,
AlertTriangle,
Clock,
Send,
Check,
Loader2,
ExternalLink,
} from 'lucide-react'
interface TaxTodoWidgetProps {
deadlines: Deadline[]
onStatusChange?: (deadlineId: string, newStatus: DeadlineStatus) => void
}
export function TaxTodoWidget({ deadlines, onStatusChange }: TaxTodoWidgetProps) {
const { toast } = useToast()
const t = useTranslations('tax_todo')
const [updatingId, setUpdatingId] = useState<string | null>(null)
// Filter to only tax deadlines needing attention
const taxDeadlines = deadlines.filter(
(d) =>
d.deadline_type === 'tax' &&
!d.is_completed &&
['action_needed', 'overdue', 'in_progress'].includes(d.status)
)
// Sort by urgency: overdue first, then by date
const sortedDeadlines = taxDeadlines.sort((a, b) => {
if (a.status === 'overdue' && b.status !== 'overdue') return -1
if (b.status === 'overdue' && a.status !== 'overdue') return 1
return a.due_date.localeCompare(b.due_date)
})
const overdueCount = taxDeadlines.filter((d) => d.status === 'overdue').length
const actionNeededCount = taxDeadlines.filter((d) => d.status === 'action_needed').length
if (sortedDeadlines.length === 0) {
return null
}
const formatDate = (dateStr: string) => {
const date = new Date(dateStr)
const today = new Date()
today.setHours(0, 0, 0, 0)
const diffDays = Math.ceil(
(date.getTime() - today.getTime()) / (1000 * 60 * 60 * 24)
)
if (diffDays === 0) return t('today')
if (diffDays === 1) return t('tomorrow')
if (diffDays < 0) return t('days_ago', { count: Math.abs(diffDays) })
if (diffDays <= 7) return t('in_days', { count: diffDays })
return date.toLocaleDateString('sv-SE', { day: 'numeric', month: 'short' })
}
const handleStatusChange = async (deadlineId: string, newStatus: DeadlineStatus) => {
setUpdatingId(deadlineId)
try {
const response = await fetch(`/api/deadlines/${deadlineId}/status`, {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ status: newStatus }),
})
if (!response.ok) {
// Map the parsed body plus the status, never `new Error(data.error)`:
// the route answers thrown errors with the canonical envelope
// `{ error: { code, message } }`, and the Error constructor would
// stringify that object to "[object Object]", discarding the route's
// own Swedish reason.
const body = await response.json().catch(() => null)
toast({
title: getUserErrorMessage(body, { statusCode: response.status }),
variant: 'destructive',
})
return
}
toast({
title: t('toast_status_updated'),
description: t('toast_status_updated_description', { status: STATUS_LABELS[newStatus].toLowerCase() }),
})
onStatusChange?.(deadlineId, newStatus)
} catch (error) {
toast({
title: error instanceof Error ? getUserErrorMessage(error) : t('toast_status_update_failed'),
variant: 'destructive',
})
} finally {
setUpdatingId(null)
}
}
const getReportLink = (deadline: Deadline): string | null => {
if (!deadline.linked_report_type || !deadline.linked_report_period) {
return null
}
return getReportUrl(deadline.linked_report_type, deadline.linked_report_period)
}
return (
<Card>
<CardHeader className="pb-2">
<div className="flex items-center justify-between">
<CardTitle className="text-lg flex items-center gap-2">
<FileText className="h-5 w-5 text-attn" />
{t('title')}
</CardTitle>
<div className="flex gap-2">
{overdueCount > 0 && (
<Badge variant="destructive">{t('overdue_badge', { count: overdueCount })}</Badge>
)}
{actionNeededCount > 0 && (
<Badge variant="warning">{t('action_needed_badge', { count: actionNeededCount })}</Badge>
)}
</div>
</div>
</CardHeader>
<CardContent className="space-y-3">
{sortedDeadlines.slice(0, 5).map((deadline) => {
const isUpdating = updatingId === deadline.id
const reportLink = getReportLink(deadline)
const isOverdue = deadline.status === 'overdue'
return (
<div
key={deadline.id}
className={`p-3 rounded-lg ${isOverdue ? 'bg-destructive/5' : ''}`}
>
<div className="flex items-start justify-between gap-2">
<div className="flex items-start gap-2 min-w-0 flex-1">
{isOverdue ? (
<AlertTriangle className="h-4 w-4 text-destructive flex-shrink-0 mt-0.5" />
) : (
<Clock className="h-4 w-4 text-attn flex-shrink-0 mt-0.5" />
)}
<div className="min-w-0 flex-1">
<p className="text-sm font-medium">{deadline.title}</p>
<div className="flex items-center gap-2 mt-1">
<span
className={`text-xs ${
isOverdue ? 'text-destructive font-medium' : 'text-muted-foreground'
}`}
>
{formatDate(deadline.due_date)}
</span>
{deadline.tax_deadline_type && (
<span className="text-xs text-muted-foreground">
· {TAX_DEADLINE_TYPE_LABELS[deadline.tax_deadline_type]}
</span>
)}
</div>
</div>
</div>
<div className="flex items-center gap-1 flex-shrink-0">
{/* Link to report if available */}
{reportLink && (
<Link href={reportLink}>
<Button variant="ghost" size="sm" className="h-9 px-2.5">
<ExternalLink className="h-3.5 w-3.5" />
</Button>
</Link>
)}
{/* Mark as in progress */}
{['action_needed', 'overdue'].includes(deadline.status) && (
<Button
variant="outline"
size="sm"
className="h-9 px-3 text-xs"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'in_progress')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
t('start')
)}
</Button>
)}
{/* Mark as submitted */}
{deadline.status === 'in_progress' && (
<Button
variant="default"
size="sm"
className="h-9 px-3 text-xs gap-1"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'submitted')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<>
<Send className="h-3.5 w-3.5" />
{t('submitted')}
</>
)}
</Button>
)}
</div>
</div>
</div>
)
})}
{sortedDeadlines.length > 5 && (
<p className="text-xs text-muted-foreground text-center">
{t('more_tasks', { count: sortedDeadlines.length - 5 })}
</p>
)}
<Link href="/deadlines" className="block">
<Button variant="ghost" className="w-full justify-between">
{t('view_all')}
<ChevronRight className="h-4 w-4" />
</Button>
</Link>
</CardContent>
</Card>
)
}
@@ -1,222 +0,0 @@
'use client'
import { useState } from 'react'
import Link from 'next/link'
import { useTranslations } from 'next-intl'
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'
import { Badge } from '@/components/ui/badge'
import { Button } from '@/components/ui/button'
import { useToast } from '@/components/ui/use-toast'
import { Deadline, DeadlineStatus } from '@/types'
import {
getUpcomingDeadlines,
STATUS_LABELS,
} from '@/lib/calendar/utils'
import { Calendar, ChevronRight, AlertTriangle, Clock, Check, Send, Loader2 } from 'lucide-react'
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
interface UpcomingDeadlinesWidgetProps {
deadlines: Deadline[]
maxItems?: number
onStatusChange?: (deadlineId: string, newStatus: DeadlineStatus) => void
}
export function UpcomingDeadlinesWidget({ deadlines, maxItems = 5, onStatusChange }: UpcomingDeadlinesWidgetProps) {
const { toast } = useToast()
const t = useTranslations('upcoming_deadlines')
const [updatingId, setUpdatingId] = useState<string | null>(null)
// Get upcoming deadlines (next 7 days) + any needing attention
const upcomingDeadlines = getUpcomingDeadlines(deadlines, 7)
const actionNeededDeadlines = deadlines.filter(
(d) => !d.is_completed && d.status === 'action_needed'
)
const overdueDeadlines = deadlines.filter(
(d) => !d.is_completed && d.status === 'overdue'
)
// Combine and sort (overdue first, then action_needed, then upcoming)
const displayDeadlines = [...overdueDeadlines, ...actionNeededDeadlines, ...upcomingDeadlines]
.filter((d, i, arr) => arr.findIndex((x) => x.id === d.id) === i) // Remove duplicates
.slice(0, maxItems)
const overdueCount = overdueDeadlines.length
const actionNeededCount = actionNeededDeadlines.length
if (displayDeadlines.length === 0) {
return null
}
const formatDate = (dateStr: string) => {
const date = new Date(dateStr)
const today = new Date()
const tomorrow = new Date(today)
tomorrow.setDate(tomorrow.getDate() + 1)
if (date.toDateString() === today.toDateString()) {
return t('today')
}
if (date.toDateString() === tomorrow.toDateString()) {
return t('tomorrow')
}
return date.toLocaleDateString('sv-SE', { day: 'numeric', month: 'short' })
}
const handleStatusChange = async (deadlineId: string, newStatus: DeadlineStatus) => {
setUpdatingId(deadlineId)
try {
const response = await fetch(`/api/deadlines/${deadlineId}/status`, {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ status: newStatus }),
})
if (!response.ok) {
// Map the parsed body plus the status, never `new Error(data.error)`:
// the route answers thrown errors with the canonical envelope
// `{ error: { code, message } }`, and the Error constructor would
// stringify that object to "[object Object]", discarding the route's
// own Swedish reason.
const body = await response.json().catch(() => null)
toast({
title: getUserErrorMessage(body, { statusCode: response.status }),
variant: 'destructive',
})
return
}
toast({
title: t('toast_status_updated'),
description: t('toast_status_updated_description', { status: STATUS_LABELS[newStatus].toLowerCase() }),
})
// Notify parent component
onStatusChange?.(deadlineId, newStatus)
} catch (error) {
toast({
title: error instanceof Error ? getUserErrorMessage(error) : t('toast_status_update_failed'),
variant: 'destructive',
})
} finally {
setUpdatingId(null)
}
}
const getStatusBadgeVariant = (status: DeadlineStatus): 'default' | 'secondary' | 'destructive' | 'warning' => {
switch (status) {
case 'overdue': return 'destructive'
case 'action_needed': return 'warning'
case 'submitted':
case 'confirmed': return 'default'
default: return 'secondary'
}
}
return (
<Card>
<CardHeader className="pb-2">
<div className="flex items-center justify-between">
<CardTitle className="text-lg flex items-center gap-2">
<Calendar className="h-5 w-5" />
{t('title')}
</CardTitle>
<div className="flex gap-2">
{overdueCount > 0 && (
<Badge variant="destructive">{t('overdue_badge', { count: overdueCount })}</Badge>
)}
{actionNeededCount > 0 && (
<Badge variant="warning">{t('action_needed_badge', { count: actionNeededCount })}</Badge>
)}
</div>
</div>
</CardHeader>
<CardContent className="space-y-2">
{displayDeadlines.map((deadline) => {
const isUpdating = updatingId === deadline.id
return (
<div
key={deadline.id}
className={`flex items-center justify-between p-2 rounded-lg ${
deadline.status === 'overdue' ? 'bg-destructive/5' : ''
}`}
>
<div className="flex items-center gap-2 min-w-0 flex-1">
{deadline.status === 'overdue' ? (
<AlertTriangle className="h-4 w-4 text-destructive flex-shrink-0" />
) : deadline.status === 'action_needed' ? (
<Clock className="h-4 w-4 text-attn flex-shrink-0" />
) : (
<Clock className="h-4 w-4 text-muted-foreground flex-shrink-0" />
)}
<div className="min-w-0 flex-1">
<p className="text-sm font-medium truncate">{deadline.title}</p>
<p className="text-xs text-muted-foreground">
{formatDate(deadline.due_date)}
{deadline.due_time && ` ${t('time_prefix')} ${deadline.due_time.slice(0, 5)}`}
{deadline.tax_deadline_type && (
<>
{' '}
<span className="text-muted-foreground/30">·</span> {t('tax_badge')}
</>
)}
</p>
</div>
</div>
<div className="flex items-center gap-2 flex-shrink-0">
{/* Status badge */}
<Badge variant={getStatusBadgeVariant(deadline.status)} className="text-xs">
{STATUS_LABELS[deadline.status]}
</Badge>
{/* Quick action buttons for tax deadlines */}
{deadline.tax_deadline_type && !['submitted', 'confirmed'].includes(deadline.status) && (
<Button
variant="ghost"
size="sm"
className="h-9 px-2.5"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'submitted')}
title={t('mark_as_submitted')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<Send className="h-3.5 w-3.5" />
)}
</Button>
)}
{deadline.status === 'submitted' && (
<Button
variant="ghost"
size="sm"
className="h-9 px-2.5"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'confirmed')}
title={t('mark_as_confirmed')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<Check className="h-3.5 w-3.5" />
)}
</Button>
)}
</div>
</div>
)
})}
<Link href="/deadlines" className="block">
<Button variant="ghost" className="w-full justify-between mt-2">
{t('view_all')}
<ChevronRight className="h-4 w-4" />
</Button>
</Link>
</CardContent>
</Card>
)
}
-5
View File
@@ -1,5 +0,0 @@
export { DeadlineRow } from './DeadlineRow'
export { DeadlineForm } from './DeadlineForm'
export { DeadlineList } from './DeadlineList'
export { UpcomingDeadlinesWidget } from './UpcomingDeadlinesWidget'
export { TaxTodoWidget } from './TaxTodoWidget'