chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers (#2150)
* chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers Remove 33 dead files, ~270 unreferenced exports/types, 13 dead i18n namespaces and 4 unused dependencies; fold byte-identical helper copies into one canonical home each (lib/utils chunk/sleep/utcDateStamp, lib/dates/iso, lib/invariants/uuid, lib/xml/escape, lib/reports/sru/format, lib/pdf/number-text, lib/browser/panel-request, lib/api/v1/body + v1ValidationError rolled out to ~55 v1 routes, booking-template schemas). No behaviour change: v1 bodies and status codes, MCP tool schemas, DB writes and money math are untouched. Naive ore rounding was deliberately not swapped for roundOre; see DECISIONS.md 2026-09-02 for the full list of things left alone on purpose. tsc, lint, 19588 unit tests and check:guards green; antipattern baseline ratcheted (naive-ore-round 622 -> 620, hand-rolled-invariant 115 -> 113). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(transactions): import RawTransaction from @/types after the ingest re-export removal CI's type ratchet (check:types, full tsconfig) caught the one test file that still imported the type through lib/transactions/ingest. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Fable 5.1
Jakob Wennberg
Claude Fable 5.1
Jakob Wennberg
parent
18cbc4c30a
commit
f266c386f3
@@ -1,3 +1,4 @@
|
||||
import { BookingTemplateLineSchema, BookingTemplateCategorySchema, BookingTemplateEntityTypeSchema } from '@/lib/bookkeeping/booking-template-schemas'
|
||||
import { NextResponse } from 'next/server'
|
||||
import { withRouteContext } from '@/lib/api/with-route-context'
|
||||
import { z } from 'zod'
|
||||
@@ -5,24 +6,11 @@ import { validateBody } from '@/lib/api/validate'
|
||||
import { sparsePatchBody } from '@/lib/api/sparse-patch'
|
||||
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
||||
|
||||
const BookingTemplateLineSchema = z.object({
|
||||
account: z.string().regex(/^\d{4}$/),
|
||||
label: z.string().min(1),
|
||||
side: z.enum(['debit', 'credit']),
|
||||
type: z.enum(['business', 'vat', 'settlement']),
|
||||
ratio: z.number().min(0).max(10).optional(),
|
||||
vat_rate: z.number().min(0).max(1).optional(),
|
||||
})
|
||||
|
||||
const UpdateBookingTemplateSchema = z.object({
|
||||
name: z.string().min(1).max(200).optional(),
|
||||
description: z.string().max(2000).optional(),
|
||||
category: z.enum([
|
||||
'eu_trade', 'tax_account', 'private_transfer',
|
||||
'salary', 'representation', 'year_end',
|
||||
'vat', 'financial', 'other',
|
||||
]).optional(),
|
||||
entity_type: z.enum(['all', 'enskild_firma', 'aktiebolag']).optional(),
|
||||
category: BookingTemplateCategorySchema.optional(),
|
||||
entity_type: BookingTemplateEntityTypeSchema.optional(),
|
||||
lines: z.array(BookingTemplateLineSchema).min(2).optional(),
|
||||
})
|
||||
|
||||
|
||||
@@ -1,27 +1,15 @@
|
||||
import { BookingTemplateLineSchema, BookingTemplateCategorySchema, BookingTemplateEntityTypeSchema } from '@/lib/bookkeeping/booking-template-schemas'
|
||||
import { NextResponse } from 'next/server'
|
||||
import { withRouteContext } from '@/lib/api/with-route-context'
|
||||
import { z } from 'zod'
|
||||
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
||||
|
||||
const ImportLineSchema = z.object({
|
||||
account: z.string().regex(/^\d{4}$/),
|
||||
label: z.string().min(1),
|
||||
side: z.enum(['debit', 'credit']),
|
||||
type: z.enum(['business', 'vat', 'settlement']),
|
||||
ratio: z.number().min(0).max(10).optional(),
|
||||
vat_rate: z.number().min(0).max(1).optional(),
|
||||
})
|
||||
|
||||
const ImportTemplateSchema = z.object({
|
||||
name: z.string().min(1).max(200),
|
||||
description: z.string().max(2000).default(''),
|
||||
category: z.enum([
|
||||
'eu_trade', 'tax_account', 'private_transfer',
|
||||
'salary', 'representation', 'year_end',
|
||||
'vat', 'financial', 'other',
|
||||
]).default('other'),
|
||||
entity_type: z.enum(['all', 'enskild_firma', 'aktiebolag']).default('all'),
|
||||
lines: z.array(ImportLineSchema).min(2),
|
||||
category: BookingTemplateCategorySchema.default('other'),
|
||||
entity_type: BookingTemplateEntityTypeSchema.default('all'),
|
||||
lines: z.array(BookingTemplateLineSchema).min(2),
|
||||
})
|
||||
|
||||
const ImportPayloadSchema = z.object({
|
||||
|
||||
@@ -3,31 +3,24 @@ import { withRouteContext } from '@/lib/api/with-route-context'
|
||||
import { z } from 'zod'
|
||||
import { validateBody } from '@/lib/api/validate'
|
||||
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
||||
import { UUID_RE } from '@/lib/invariants/uuid'
|
||||
import {
|
||||
BookingTemplateCategorySchema,
|
||||
BookingTemplateEntityTypeSchema,
|
||||
BookingTemplateLineSchema,
|
||||
} from '@/lib/bookkeeping/booking-template-schemas'
|
||||
|
||||
// The GET scope below builds a PostgREST .or() filter by string interpolation.
|
||||
// Guard every interpolated id against a strict UUID shape so a tainted value
|
||||
// can never inject filter syntax. Both ids are server-derived (companyId from
|
||||
// membership, teamId from a DB column), so this is defense-in-depth.
|
||||
const UUID_RE = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
|
||||
|
||||
const BookingTemplateLineSchema = z.object({
|
||||
account: z.string().regex(/^\d{4}$/),
|
||||
label: z.string().min(1),
|
||||
side: z.enum(['debit', 'credit']),
|
||||
type: z.enum(['business', 'vat', 'settlement']),
|
||||
ratio: z.number().min(0).max(10).optional(),
|
||||
vat_rate: z.number().min(0).max(1).optional(),
|
||||
})
|
||||
// Guard every interpolated id against a strict UUID shape (UUID_RE) so a
|
||||
// tainted value can never inject filter syntax. Both ids are server-derived
|
||||
// (companyId from membership, teamId from a DB column), so this is
|
||||
// defense-in-depth.
|
||||
|
||||
const CreateBookingTemplateSchema = z.object({
|
||||
name: z.string().min(1).max(200),
|
||||
description: z.string().max(2000).default(''),
|
||||
category: z.enum([
|
||||
'eu_trade', 'tax_account', 'private_transfer',
|
||||
'salary', 'representation', 'year_end',
|
||||
'vat', 'financial', 'other',
|
||||
]).default('other'),
|
||||
entity_type: z.enum(['all', 'enskild_firma', 'aktiebolag']).default('all'),
|
||||
category: BookingTemplateCategorySchema.default('other'),
|
||||
entity_type: BookingTemplateEntityTypeSchema.default('all'),
|
||||
lines: z.array(BookingTemplateLineSchema).min(2),
|
||||
team_id: z.string().uuid().optional(),
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user