feat: make extension system packageable via enriched ExtensionContext

Enrich ExtensionContext with supabase, emit(), settings, storage, log, and services so extensions can receive everything through dependency injection instead of importing core modules directly. - Add context factory and inject context into event handlers via registry - Move supplier invoice journal entry creation to core event handler - Add services.ingestTransactions to ExtensionContext for enable-banking - Create catch-all API route for extension-declared apiRoutes - Migrate 5 extensions to accept context with dynamic import fallbacks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 09:24:21 +01:00
parent 59d935f2cc
commit ef5a84a5d5
24 changed files with 1058 additions and 185 deletions
@@ -0,0 +1,200 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest'
+import {
+  createQueuedMockSupabase,
+  createMockRequest,
+  parseJsonResponse,
+} from '@/tests/helpers'
+import { NextResponse } from 'next/server'
+
+// Mock dependencies
+vi.mock('@/lib/supabase/server', () => ({
+  createClient: vi.fn(),
+}))
+
+vi.mock('@/lib/init', () => ({
+  ensureInitialized: vi.fn(),
+}))
+
+vi.mock('@/lib/extensions/toggle-check', () => ({
+  isExtensionEnabled: vi.fn(),
+}))
+
+vi.mock('@/lib/extensions/context-factory', () => ({
+  createExtensionContext: vi.fn().mockReturnValue({
+    userId: 'user-1',
+    extensionId: 'test-ext',
+  }),
+}))
+
+import { createClient } from '@/lib/supabase/server'
+import { extensionRegistry } from '@/lib/extensions/registry'
+import { isExtensionEnabled } from '@/lib/extensions/toggle-check'
+import { GET, POST } from '../route'
+
+const mockCreateClient = vi.mocked(createClient)
+const mockIsEnabled = vi.mocked(isExtensionEnabled)
+
+function createPathParams(path: string[]) {
+  return { params: Promise.resolve({ path }) }
+}
+
+describe('Extension Catch-All Route', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    extensionRegistry.clear()
+  })
+
+  it('returns 400 for empty path', async () => {
+    const request = createMockRequest('/api/extensions/ext/')
+    const response = await GET(request, createPathParams([]))
+    const { status } = await parseJsonResponse(response)
+
+    expect(status).toBe(400)
+  })
+
+  it('returns 404 for unknown extension', async () => {
+    const { supabase } = createQueuedMockSupabase()
+    supabase.auth.getUser.mockResolvedValue({
+      data: { user: { id: 'user-1' } },
+      error: null,
+    })
+    mockCreateClient.mockResolvedValue(supabase as never)
+
+    const request = createMockRequest('/api/extensions/ext/nonexistent/foo')
+    const response = await GET(request, createPathParams(['nonexistent', 'foo']))
+    const { status } = await parseJsonResponse(response)
+
+    expect(status).toBe(404)
+  })
+
+  it('returns 401 when not authenticated', async () => {
+    extensionRegistry.register({
+      id: 'test-ext',
+      name: 'Test',
+      version: '1.0.0',
+      apiRoutes: [{ method: 'GET', path: '/data', handler: vi.fn() }],
+    })
+
+    const { supabase } = createQueuedMockSupabase()
+    supabase.auth.getUser.mockResolvedValue({
+      data: { user: null },
+      error: { message: 'Not authenticated' },
+    })
+    mockCreateClient.mockResolvedValue(supabase as never)
+
+    const request = createMockRequest('/api/extensions/ext/test-ext/data')
+    const response = await GET(request, createPathParams(['test-ext', 'data']))
+    const { status } = await parseJsonResponse(response)
+
+    expect(status).toBe(401)
+  })
+
+  it('returns 403 when extension is disabled', async () => {
+    extensionRegistry.register({
+      id: 'test-ext',
+      name: 'Test',
+      version: '1.0.0',
+      apiRoutes: [{ method: 'GET', path: '/data', handler: vi.fn() }],
+    })
+
+    const { supabase } = createQueuedMockSupabase()
+    supabase.auth.getUser.mockResolvedValue({
+      data: { user: { id: 'user-1' } },
+      error: null,
+    })
+    mockCreateClient.mockResolvedValue(supabase as never)
+    mockIsEnabled.mockResolvedValue(false)
+
+    const request = createMockRequest('/api/extensions/ext/test-ext/data')
+    const response = await GET(request, createPathParams(['test-ext', 'data']))
+    const { status } = await parseJsonResponse(response)
+
+    expect(status).toBe(403)
+  })
+
+  it('returns 404 for unmatched method/path', async () => {
+    extensionRegistry.register({
+      id: 'test-ext',
+      name: 'Test',
+      version: '1.0.0',
+      apiRoutes: [{ method: 'POST', path: '/data', handler: vi.fn() }],
+    })
+
+    const { supabase } = createQueuedMockSupabase()
+    supabase.auth.getUser.mockResolvedValue({
+      data: { user: { id: 'user-1' } },
+      error: null,
+    })
+    mockCreateClient.mockResolvedValue(supabase as never)
+    mockIsEnabled.mockResolvedValue(true)
+
+    // GET doesn't match POST /data
+    const request = createMockRequest('/api/extensions/ext/test-ext/data')
+    const response = await GET(request, createPathParams(['test-ext', 'data']))
+    const { status } = await parseJsonResponse(response)
+
+    expect(status).toBe(404)
+  })
+
+  it('dispatches to matching handler with context', async () => {
+    const handler = vi.fn().mockResolvedValue(
+      NextResponse.json({ banks: [] })
+    )
+
+    extensionRegistry.register({
+      id: 'enable-banking',
+      name: 'Enable Banking',
+      version: '1.0.0',
+      apiRoutes: [{ method: 'GET', path: '/banks', handler }],
+    })
+
+    const { supabase } = createQueuedMockSupabase()
+    supabase.auth.getUser.mockResolvedValue({
+      data: { user: { id: 'user-1' } },
+      error: null,
+    })
+    mockCreateClient.mockResolvedValue(supabase as never)
+    mockIsEnabled.mockResolvedValue(true)
+
+    const request = createMockRequest('/api/extensions/ext/enable-banking/banks')
+    const response = await GET(request, createPathParams(['enable-banking', 'banks']))
+    const { status, body } = await parseJsonResponse<{ banks: unknown[] }>(response)
+
+    expect(status).toBe(200)
+    expect(body.banks).toEqual([])
+    expect(handler).toHaveBeenCalledWith(request, expect.objectContaining({
+      extensionId: 'test-ext',
+    }))
+  })
+
+  it('dispatches POST requests correctly', async () => {
+    const handler = vi.fn().mockResolvedValue(
+      NextResponse.json({ ok: true })
+    )
+
+    extensionRegistry.register({
+      id: 'test-ext',
+      name: 'Test',
+      version: '1.0.0',
+      apiRoutes: [{ method: 'POST', path: '/connect', handler }],
+    })
+
+    const { supabase } = createQueuedMockSupabase()
+    supabase.auth.getUser.mockResolvedValue({
+      data: { user: { id: 'user-1' } },
+      error: null,
+    })
+    mockCreateClient.mockResolvedValue(supabase as never)
+    mockIsEnabled.mockResolvedValue(true)
+
+    const request = createMockRequest('/api/extensions/ext/test-ext/connect', {
+      method: 'POST',
+      body: { foo: 'bar' },
+    })
+    const response = await POST(request, createPathParams(['test-ext', 'connect']))
+    const { status } = await parseJsonResponse(response)
+
+    expect(status).toBe(200)
+    expect(handler).toHaveBeenCalled()
+  })
+})