admin/accounted
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)

Browse Source 
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-07-04 15:58:06 +02:00
committed by GitHub
co-authored by Claude Sonnet 5
parent a5154ee884
commit ec27228a8e
1588 changed files with 28388 additions and 10890 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/import/BankFileColumnMappingStep.tsx
+5 -5
View File
@@ -89,7 +89,7 @@ export default function BankFileColumnMappingStep({
// contain known column-name keywords (bokföringsdag, beskrivning, belopp, …).
// A row needs ≥ 2 keyword hits to qualify, which excludes metadata rows where
// only the label cell happens to match (e.g. "Saldo,251495,41,SEK").
// Falls back to row 0 if nothing qualifies — preserves prior behavior for
// Falls back to row 0 if nothing qualifies: preserves prior behavior for
// simple files where the header truly is the first row.
const DATE_PATTERNS = [/^\d{4}-\d{2}-\d{2}$/, /^\d{2}[./]\d{2}[./]\d{4}$/, /^\d{8}$/]
const detectedHeaderRow = useMemo(() => {
@@ -126,7 +126,7 @@ export default function BankFileColumnMappingStep({
// skip_rows = number of rows to skip before transaction data starts.
// When hasHeader: skip past the header row (detectedHeaderRow + 1).
// When no header: skip nothing — data starts at row 0.
// When no header: skip nothing: data starts at row 0.
const skipRows = hasHeader ? detectedHeaderRow + 1 : 0
const columnHeaders = useMemo(() => {
@@ -139,7 +139,7 @@ export default function BankFileColumnMappingStep({
// Auto-guess date/description/amount/balance columns. Matches header labels
// first (so the trailing Saldo column is never picked as the amount), then
// falls back to value heuristics. Initial defaults only — user can override.
// falls back to value heuristics. Initial defaults only: user can override.
useEffect(() => {
if (dateCol !== -1 || descCol !== -1 || amountCol !== -1) return
if (dataRows.length === 0) return
@@ -401,8 +401,8 @@ export default function BankFileColumnMappingStep({
return (
<TableRow key={i}>
<TableCell className="font-mono text-sm">{row[dateCol] || '–'}</TableCell>
<TableCell className="text-sm">{row[descCol] || '–'}</TableCell>
<TableCell className="font-mono text-sm">{row[dateCol] || '-'}</TableCell>
<TableCell className="text-sm">{row[descCol] || '-'}</TableCell>
<TableCell
className={`text-right font-mono text-sm ${
!isNaN(amount) && amount >= 0 ? 'text-success' : 'text-destructive'