feat(reconciliation): manual adapter for the whole balance sheet (Reko bilagor, PR 1) (#1854)
* feat(reconciliation): manual adapter so the whole balance sheet is reconcilable and signable (Reko bilagor, PR 1) Every class 1-2 account the bank and skattekonto adapters do not own now appears on the Avstämning page under "Övriga balanskonton" with IB, movement and UB through the balansdag, a system specification where one exists (1510 kundreskontra, 2440 leverantörsreskontra, 2920/2940 semesterlöneskuld) and, for every other account, the balance the signer states from their underlag at sign-off. Same three doors as before: dashboard routes, v1 API and the MCP tools take manual:<BAS> keys and an external_balance. The ledger side is computed per fiscal period via generateTrialBalance, never as an all-history sum: year-end re-books every balance account in an opening_balance verifikat, so an all-history sum counts a closed year twice. A stated external_balance is refused (EXTERNAL_BALANCE_NOT_ALLOWED) wherever the system already has an outside truth, so it can never hide a difference. No migration: account_reconciliations already accepts manual:NNNN keys. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RvFveUpbdPBXdm7f5FEYoz * chore(api-skill): regenerate banking reference for the sign-off external_balance field Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RvFveUpbdPBXdm7f5FEYoz --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Fable 5
Jakob Wennberg
Claude Fable 5
Jakob Wennberg
parent
1e6e19afe9
commit
ebbdf96b74
@@ -16,13 +16,24 @@ import {
|
||||
DialogTitle,
|
||||
} from '@/components/ui/dialog'
|
||||
import { formatCurrency } from '@/lib/utils'
|
||||
import { roundOre } from '@/lib/money'
|
||||
|
||||
/**
|
||||
* "Markera som avstämd": date, optional note, and (only when the engine
|
||||
* reports an unexplained difference) the explicit "sign anyway" choice that
|
||||
* makes the note mandatory. The policy lives in lib/reconciliation/signoff.ts;
|
||||
* this dialog only collects the input and shows the server's refusal verbatim.
|
||||
* makes the note mandatory. A manual account without a system specification
|
||||
* also asks for the balance per the signer's underlag; the difference against
|
||||
* the booked balance is then what needs explaining. The policy lives in
|
||||
* lib/reconciliation/signoff.ts; this dialog only collects the input and
|
||||
* shows the server's refusal verbatim.
|
||||
*/
|
||||
export interface SignoffSubmitInput {
|
||||
through_date: string
|
||||
note: string | null
|
||||
force: boolean
|
||||
external_balance?: number | null
|
||||
}
|
||||
|
||||
interface SignoffDialogProps {
|
||||
open: boolean
|
||||
onOpenChange: (open: boolean) => void
|
||||
@@ -33,8 +44,19 @@ interface SignoffDialogProps {
|
||||
maxDate: string
|
||||
unexplained: number | null
|
||||
currency: string
|
||||
/** Ask for the balance per underlag (manual accounts without a system specification). */
|
||||
askExternalBalance?: boolean
|
||||
/** The booked balance the stated one is compared with. */
|
||||
ledgerBalance?: number | null
|
||||
/** Returns an error message to show inline, or null on success. */
|
||||
onSubmit: (input: { through_date: string; note: string | null; force: boolean }) => Promise<string | null>
|
||||
onSubmit: (input: SignoffSubmitInput) => Promise<string | null>
|
||||
}
|
||||
|
||||
function parseAmount(raw: string): number | null {
|
||||
const normalized = raw.replace(/\s/g, '').replace(',', '.')
|
||||
if (normalized === '' || normalized === '-') return null
|
||||
const n = Number(normalized)
|
||||
return Number.isFinite(n) ? roundOre(n) : null
|
||||
}
|
||||
|
||||
export function SignoffDialog({
|
||||
@@ -45,16 +67,24 @@ export function SignoffDialog({
|
||||
maxDate,
|
||||
unexplained,
|
||||
currency,
|
||||
askExternalBalance = false,
|
||||
ledgerBalance = null,
|
||||
onSubmit,
|
||||
}: SignoffDialogProps) {
|
||||
const t = useTranslations('reconciliation')
|
||||
const [date, setDate] = useState(defaultDate)
|
||||
const [note, setNote] = useState('')
|
||||
const [force, setForce] = useState(false)
|
||||
const [external, setExternal] = useState('')
|
||||
const [error, setError] = useState<string | null>(null)
|
||||
const [busy, setBusy] = useState(false)
|
||||
|
||||
const needsForce = unexplained == null || Math.abs(unexplained) >= 0.005
|
||||
// With a stated balance the difference is against the booked balance;
|
||||
// without one the engine's number (or "unknown") decides.
|
||||
const stated = askExternalBalance ? parseAmount(external) : null
|
||||
const effectiveUnexplained =
|
||||
stated != null && ledgerBalance != null ? roundOre(ledgerBalance - stated) : unexplained
|
||||
const needsForce = effectiveUnexplained == null || Math.abs(effectiveUnexplained) >= 0.005
|
||||
|
||||
// Reset per opening so a second sign-off does not inherit the last one's
|
||||
// note or override choice.
|
||||
@@ -63,6 +93,7 @@ export function SignoffDialog({
|
||||
setDate(defaultDate)
|
||||
setNote('')
|
||||
setForce(false)
|
||||
setExternal('')
|
||||
setError(null)
|
||||
}
|
||||
}, [open, defaultDate])
|
||||
@@ -73,7 +104,12 @@ export function SignoffDialog({
|
||||
setBusy(true)
|
||||
setError(null)
|
||||
try {
|
||||
const message = await onSubmit({ through_date: date, note: note.trim() || null, force: needsForce && force })
|
||||
const message = await onSubmit({
|
||||
through_date: date,
|
||||
note: note.trim() || null,
|
||||
force: needsForce && force,
|
||||
...(askExternalBalance ? { external_balance: stated } : {}),
|
||||
})
|
||||
if (message) setError(message)
|
||||
} finally {
|
||||
setBusy(false)
|
||||
@@ -99,12 +135,32 @@ export function SignoffDialog({
|
||||
className="tabular-nums"
|
||||
/>
|
||||
</div>
|
||||
{askExternalBalance && (
|
||||
<div className="space-y-1.5">
|
||||
<Label htmlFor="signoff-external">{t('signoff_external_balance')}</Label>
|
||||
<Input
|
||||
id="signoff-external"
|
||||
inputMode="decimal"
|
||||
value={external}
|
||||
onChange={(e) => setExternal(e.target.value)}
|
||||
placeholder="0,00"
|
||||
className="tabular-nums"
|
||||
/>
|
||||
<p className="text-[12px] text-muted-foreground">
|
||||
{ledgerBalance != null
|
||||
? t('signoff_external_balance_help', { amount: formatCurrency(ledgerBalance, currency) })
|
||||
: t('signoff_external_balance_optional')}
|
||||
</p>
|
||||
</div>
|
||||
)}
|
||||
{needsForce && (
|
||||
<div className="space-y-2 rounded-lg bg-warning/10 px-3 py-2.5 text-[13px] text-foreground">
|
||||
<p>
|
||||
{unexplained == null
|
||||
? t('tile_unknown')
|
||||
: t('signoff_unexplained_warning', { amount: formatCurrency(unexplained, currency) })}
|
||||
{effectiveUnexplained == null
|
||||
? askExternalBalance
|
||||
? t('signoff_external_balance_optional')
|
||||
: t('tile_unknown')
|
||||
: t('signoff_unexplained_warning', { amount: formatCurrency(effectiveUnexplained, currency) })}
|
||||
</p>
|
||||
<label className="flex items-center gap-2 text-[13px]">
|
||||
<Checkbox checked={force} onCheckedChange={(v) => setForce(v === true)} />
|
||||
|
||||
Reference in New Issue
Block a user