feat(mcp): add create_voucher + correct_entry MCP tools (#448)
* feat(mcp): add create_voucher + correct_entry MCP tools The MCP toolset had no way to post a journal entry outside the preset workflows (categorize_transaction, create_invoice, …). That blocks legitimate flows the engine already supports — K3 capitalization to BAS 1010, period-end accruals, FX adjustments, prepayments, and rättelseposter for foreign reverse-charge VAT that landed on 2641 instead of 2614/2645. create_voucher exposes the existing createJournalEntry() primitive: arbitrary balanced lines, optional fiscal-period auto-resolution, staged for human approval. correct_entry exposes correctEntry() (storno + new corrected entry per BFL 5 kap 5§) so part of a posted verifikation can be fixed without losing the legs that were right. Both are HIGH risk in OPERATION_RISK_TIERS — the arbitrary account/amount/ period inputs make them compliance-critical despite being structurally similar to uncategorize_transaction (medium). Approval flow unchanged; no auto-commit, regardless of trust level. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(mcp): address PR #448 review — voucher tools hardening Greptile P1 + compliance bot findings, all in one pass. commitCreateVoucher (commit.ts): - Hardcode source_type to 'manual' instead of reading from params. A future direct-staging path or hand-inserted pending_operations row could otherwise inject 'bank_transaction'/'invoice_created'/etc. and corrupt the audit-trail origin. - Re-validate balance defensively before reaching the engine, so a tampered params row surfaces a clean Swedish 400 instead of an opaque engine error. gnubok_create_voucher (server.ts): - Validate the explicit fiscal_period_id when supplied: confirm it exists, is open (is_closed = false), and that entry_date falls within its span. Without this, a closed/locked period was only caught at commit-time with a generic DB-trigger error. - Throw at staging when any line targets an account that's missing from chart_of_accounts or marked inactive, rather than relying on the approver to spot the advisory flag. - Remove source_type from the staged params blob entirely — the executor ignores it anyway, no point letting it travel through. - Add a comment that the staging-time period-lock check is advisory and the executor is the authoritative guard, so future cleanup doesn't remove either as 'redundant'. Descriptions: - gnubok_correct_entry now explicitly notes that the storno + corrected entries land in the original period (defends against compliance bot's speculative "different period" concern recurring on future reviews). - Both tools' tax_code field gets a note that the BAS account number drives momsdeklaration ruta mapping, not tax_code — guards against an LLM treating tax_code as the VAT-routing dial. commitCorrectEntry (commit.ts): - Add a comment pointing at storno-service.ts:99,102,195,198 to make the "uses original period and date" invariant explicit in this file. Tests: - +2 voucher-executors cases: source_type tampering is ignored, unbalanced params return 400. - +10 new voucher-tools tests (MCP layer): unbalanced, closed explicit period, missing explicit period, entry_date outside period, unknown account, inactive account, happy path + correct_entry registration + unbalanced replacement. 720 tests pass in the impacted suites; full suite 2998/2998. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Opus 4.7
Claude Opus 4.7
parent
ec06a2d04d
commit
eb77ad50b5
@@ -121,6 +121,9 @@ export const TOOL_SCOPE_MAP: Record<string, ApiKeyScope> = {
|
||||
// Invoice conversion + crediting
|
||||
gnubok_convert_invoice: 'invoices:write',
|
||||
gnubok_credit_invoice: 'invoices:write',
|
||||
// Phase 4: arbitrary-line bookkeeping primitives (high-risk, always staged)
|
||||
gnubok_create_voucher: 'bookkeeping:write',
|
||||
gnubok_correct_entry: 'bookkeeping:write',
|
||||
}
|
||||
|
||||
export function validateScopes(scopes: unknown): ApiKeyScope[] | null {
|
||||
|
||||
@@ -66,6 +66,8 @@ describe('pending_operations: actor model + risk columns', () => {
|
||||
'run_currency_revaluation', 'explain_voucher_gap', 'uncategorize_transaction',
|
||||
'approve_supplier_invoice', 'credit_supplier_invoice',
|
||||
'credit_invoice', 'convert_invoice', 'import_sie',
|
||||
// Phase 4: arbitrary-line bookkeeping primitives
|
||||
'create_voucher', 'correct_entry',
|
||||
]
|
||||
|
||||
for (const op of expandedTypes) {
|
||||
|
||||
@@ -53,4 +53,14 @@ describe('risk-tiers', () => {
|
||||
expect(isHighRisk('create_customer')).toBe(false)
|
||||
expect(isHighRisk('categorize_transaction')).toBe(false)
|
||||
})
|
||||
|
||||
// Phase 4: arbitrary-line bookkeeping primitives. These accept any account
|
||||
// and any amount from the caller, so they're HIGH despite being structurally
|
||||
// similar to uncategorize_transaction (which is medium).
|
||||
it('treats arbitrary-line voucher primitives as high risk', () => {
|
||||
expect(getRiskLevel('create_voucher')).toBe('high')
|
||||
expect(getRiskLevel('correct_entry')).toBe('high')
|
||||
expect(isHighRisk('create_voucher')).toBe(true)
|
||||
expect(isHighRisk('correct_entry')).toBe(true)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -0,0 +1,425 @@
|
||||
/**
|
||||
* Unit tests for commitCreateVoucher and commitCorrectEntry executors.
|
||||
* The executors aren't exported individually, so we drive them through the
|
||||
* public `commitPendingOperation` dispatcher.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { eventBus } from '@/lib/events/bus'
|
||||
import { createQueuedMockSupabase, makeJournalEntry } from '@/tests/helpers'
|
||||
import type { PendingOperation } from '@/types'
|
||||
|
||||
vi.mock('@/lib/bookkeeping/engine', async () => {
|
||||
const actual = await vi.importActual<typeof import('@/lib/bookkeeping/engine')>(
|
||||
'@/lib/bookkeeping/engine'
|
||||
)
|
||||
return {
|
||||
...actual,
|
||||
createJournalEntry: vi.fn(),
|
||||
findFiscalPeriod: vi.fn(),
|
||||
}
|
||||
})
|
||||
|
||||
vi.mock('@/lib/core/bookkeeping/storno-service', async () => {
|
||||
const actual = await vi.importActual<typeof import('@/lib/core/bookkeeping/storno-service')>(
|
||||
'@/lib/core/bookkeeping/storno-service'
|
||||
)
|
||||
return {
|
||||
...actual,
|
||||
correctEntry: vi.fn(),
|
||||
}
|
||||
})
|
||||
|
||||
import { commitPendingOperation } from '../commit'
|
||||
import { createJournalEntry, findFiscalPeriod } from '@/lib/bookkeeping/engine'
|
||||
import { correctEntry } from '@/lib/core/bookkeeping/storno-service'
|
||||
|
||||
function makePendingOp(overrides: Partial<PendingOperation>): PendingOperation {
|
||||
return {
|
||||
id: 'op-1',
|
||||
user_id: 'user-1',
|
||||
company_id: 'company-1',
|
||||
operation_type: 'create_voucher',
|
||||
status: 'pending',
|
||||
title: 'test',
|
||||
params: {},
|
||||
preview_data: {},
|
||||
result_data: null,
|
||||
actor_type: 'user',
|
||||
actor_id: null,
|
||||
actor_label: null,
|
||||
risk_level: 'high',
|
||||
created_at: '2026-05-12T00:00:00Z',
|
||||
resolved_at: null,
|
||||
updated_at: '2026-05-12T00:00:00Z',
|
||||
...overrides,
|
||||
} as PendingOperation
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
eventBus.clear()
|
||||
})
|
||||
|
||||
// ─── create_voucher ─────────────────────────────────────────────────
|
||||
|
||||
describe('commitPendingOperation: create_voucher', () => {
|
||||
it('happy path: posts a balanced entry with the provided fiscal_period_id', async () => {
|
||||
vi.mocked(createJournalEntry).mockResolvedValueOnce(
|
||||
makeJournalEntry({ id: 'je-100', voucher_number: 42, voucher_series: 'A' })
|
||||
)
|
||||
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's commit update
|
||||
|
||||
const op = makePendingOp({
|
||||
params: {
|
||||
entry_date: '2026-05-12',
|
||||
description: 'Capitalize Cursor subscription to 1010',
|
||||
fiscal_period_id: 'fp-1',
|
||||
lines: [
|
||||
{ account_number: '1010', debit_amount: 250, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 250 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('committed')
|
||||
expect(result.data).toMatchObject({
|
||||
journal_entry_id: 'je-100',
|
||||
voucher_number: 42,
|
||||
voucher_series: 'A',
|
||||
fiscal_period_id: 'fp-1',
|
||||
})
|
||||
expect(createJournalEntry).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
'company-1',
|
||||
'user-1',
|
||||
expect.objectContaining({
|
||||
fiscal_period_id: 'fp-1',
|
||||
entry_date: '2026-05-12',
|
||||
description: 'Capitalize Cursor subscription to 1010',
|
||||
source_type: 'manual',
|
||||
}),
|
||||
'mcp_create_voucher'
|
||||
)
|
||||
// findFiscalPeriod must NOT be called when fiscal_period_id is supplied —
|
||||
// it's the caller's explicit choice.
|
||||
expect(findFiscalPeriod).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('resolves fiscal_period from entry_date when omitted', async () => {
|
||||
vi.mocked(findFiscalPeriod).mockResolvedValueOnce('fp-resolved')
|
||||
vi.mocked(createJournalEntry).mockResolvedValueOnce(
|
||||
makeJournalEntry({ id: 'je-101', voucher_number: 7 })
|
||||
)
|
||||
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's commit update
|
||||
|
||||
const op = makePendingOp({
|
||||
params: {
|
||||
entry_date: '2026-05-12',
|
||||
description: 'no fiscal_period_id',
|
||||
lines: [
|
||||
{ account_number: '5410', debit_amount: 100, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 100 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('committed')
|
||||
expect(result.data).toMatchObject({ fiscal_period_id: 'fp-resolved' })
|
||||
expect(findFiscalPeriod).toHaveBeenCalledWith(expect.anything(), 'company-1', '2026-05-12')
|
||||
})
|
||||
|
||||
it('returns 400 in Swedish when no fiscal period covers the date', async () => {
|
||||
vi.mocked(findFiscalPeriod).mockResolvedValueOnce(null)
|
||||
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
params: {
|
||||
entry_date: '2027-12-31',
|
||||
description: 'far-future date',
|
||||
lines: [
|
||||
{ account_number: '5410', debit_amount: 100, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 100 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('failed')
|
||||
expect(result.http_status).toBe(400)
|
||||
expect(result.error).toMatch(/räkenskapsperiod/i)
|
||||
expect(createJournalEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('returns 400 when required fields are missing', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
params: {
|
||||
entry_date: '2026-05-12',
|
||||
// missing description and lines
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('failed')
|
||||
expect(result.http_status).toBe(400)
|
||||
expect(createJournalEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('hardcodes source_type to manual even if params.source_type is tampered', async () => {
|
||||
vi.mocked(createJournalEntry).mockResolvedValueOnce(
|
||||
makeJournalEntry({ id: 'je-tamper', voucher_number: 8 })
|
||||
)
|
||||
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's commit update
|
||||
|
||||
const op = makePendingOp({
|
||||
params: {
|
||||
entry_date: '2026-05-12',
|
||||
description: 'attempt to spoof source_type',
|
||||
fiscal_period_id: 'fp-1',
|
||||
// Direct DB insert or future stager could put anything here.
|
||||
source_type: 'bank_transaction',
|
||||
lines: [
|
||||
{ account_number: '1010', debit_amount: 100, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 100 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('committed')
|
||||
// Critical assertion: source_type is ALWAYS 'manual', never the
|
||||
// caller-supplied value. Bypassing this lets a tampered operation
|
||||
// misrepresent the audit trail as a bank-feed or invoice entry.
|
||||
expect(createJournalEntry).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
'company-1',
|
||||
'user-1',
|
||||
expect.objectContaining({ source_type: 'manual' }),
|
||||
'mcp_create_voucher'
|
||||
)
|
||||
expect(createJournalEntry).not.toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.anything(),
|
||||
expect.anything(),
|
||||
expect.objectContaining({ source_type: 'bank_transaction' }),
|
||||
expect.anything()
|
||||
)
|
||||
})
|
||||
|
||||
it('returns 400 with Swedish error when params are unbalanced (tamper defense)', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
params: {
|
||||
entry_date: '2026-05-12',
|
||||
description: 'tampered: debit ≠ credit',
|
||||
fiscal_period_id: 'fp-1',
|
||||
// The MCP tool validates balance before staging, but a hand-inserted
|
||||
// pending_operations row could bypass that. The executor's own
|
||||
// validateBalance() gate catches it before reaching the engine.
|
||||
lines: [
|
||||
{ account_number: '1010', debit_amount: 1000, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 800 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('failed')
|
||||
expect(result.http_status).toBe(400)
|
||||
expect(result.error).toMatch(/balanserar inte/i)
|
||||
expect(createJournalEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
|
||||
// ─── correct_entry ──────────────────────────────────────────────────
|
||||
|
||||
describe('commitPendingOperation: correct_entry', () => {
|
||||
it('happy path: posts storno + corrected for a posted entry in an open period', async () => {
|
||||
vi.mocked(correctEntry).mockResolvedValueOnce({
|
||||
reversal: makeJournalEntry({ id: 'je-storno', voucher_number: 50 }),
|
||||
corrected: makeJournalEntry({ id: 'je-corrected', voucher_number: 51 }),
|
||||
})
|
||||
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({
|
||||
data: {
|
||||
id: 'je-original',
|
||||
status: 'posted',
|
||||
fiscal_period_id: 'fp-1',
|
||||
fiscal_periods: { is_closed: false },
|
||||
},
|
||||
error: null,
|
||||
}) // executor's pre-flight fetch
|
||||
enqueue({ data: null, error: null }) // dispatcher's commit update
|
||||
|
||||
const op = makePendingOp({
|
||||
operation_type: 'correct_entry',
|
||||
params: {
|
||||
entry_id: 'je-original',
|
||||
lines: [
|
||||
{ account_number: '2645', debit_amount: 250, credit_amount: 0 },
|
||||
{ account_number: '2614', debit_amount: 0, credit_amount: 250 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('committed')
|
||||
expect(result.data).toMatchObject({
|
||||
original_entry_id: 'je-original',
|
||||
storno_entry_id: 'je-storno',
|
||||
corrected_entry_id: 'je-corrected',
|
||||
storno_voucher_number: 50,
|
||||
corrected_voucher_number: 51,
|
||||
})
|
||||
expect(correctEntry).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
'company-1',
|
||||
'user-1',
|
||||
'je-original',
|
||||
expect.arrayContaining([
|
||||
expect.objectContaining({ account_number: '2645' }),
|
||||
expect.objectContaining({ account_number: '2614' }),
|
||||
])
|
||||
)
|
||||
})
|
||||
|
||||
it('returns 404 when the original entry does not exist', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // executor's pre-flight fetch (no row)
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
operation_type: 'correct_entry',
|
||||
params: {
|
||||
entry_id: 'je-missing',
|
||||
lines: [
|
||||
{ account_number: '5410', debit_amount: 100, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 100 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('rejected')
|
||||
expect(result.auto_rejected).toBe(true)
|
||||
expect(result.http_status).toBe(404)
|
||||
expect(correctEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('returns 409 when the original entry is not posted', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({
|
||||
data: {
|
||||
id: 'je-draft',
|
||||
status: 'draft',
|
||||
fiscal_period_id: 'fp-1',
|
||||
fiscal_periods: { is_closed: false },
|
||||
},
|
||||
error: null,
|
||||
}) // executor's pre-flight fetch
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
operation_type: 'correct_entry',
|
||||
params: {
|
||||
entry_id: 'je-draft',
|
||||
lines: [
|
||||
{ account_number: '5410', debit_amount: 100, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 100 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('rejected')
|
||||
expect(result.http_status).toBe(409)
|
||||
expect(result.error).toMatch(/bokförda verifikationer/)
|
||||
expect(correctEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('returns 409 with omprövning hint when the period is closed', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({
|
||||
data: {
|
||||
id: 'je-original',
|
||||
status: 'posted',
|
||||
fiscal_period_id: 'fp-1',
|
||||
fiscal_periods: { is_closed: true },
|
||||
},
|
||||
error: null,
|
||||
}) // executor's pre-flight fetch
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
operation_type: 'correct_entry',
|
||||
params: {
|
||||
entry_id: 'je-original',
|
||||
lines: [
|
||||
{ account_number: '5410', debit_amount: 100, credit_amount: 0 },
|
||||
{ account_number: '1930', debit_amount: 0, credit_amount: 100 },
|
||||
],
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('rejected')
|
||||
expect(result.http_status).toBe(409)
|
||||
expect(result.error).toMatch(/omprövning/i)
|
||||
expect(correctEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('returns 400 when required fields are missing', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // CAS claim
|
||||
enqueue({ data: null, error: null }) // dispatcher's reject update
|
||||
|
||||
const op = makePendingOp({
|
||||
operation_type: 'correct_entry',
|
||||
params: {
|
||||
entry_id: 'je-1',
|
||||
// missing lines
|
||||
},
|
||||
})
|
||||
|
||||
const result = await commitPendingOperation(supabase as never, 'user-1', 'company-1', op)
|
||||
|
||||
expect(result.status).toBe('failed')
|
||||
expect(result.http_status).toBe(400)
|
||||
expect(correctEntry).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
@@ -27,7 +27,8 @@ import {
|
||||
createInvoiceJournalEntry,
|
||||
createCreditNoteJournalEntry,
|
||||
} from '@/lib/bookkeeping/invoice-entries'
|
||||
import { reverseEntry } from '@/lib/bookkeeping/engine'
|
||||
import { createJournalEntry, findFiscalPeriod, reverseEntry, validateBalance } from '@/lib/bookkeeping/engine'
|
||||
import { correctEntry } from '@/lib/core/bookkeeping/storno-service'
|
||||
import { closePeriod, lockPeriod, unlockPeriod } from '@/lib/core/bookkeeping/period-service'
|
||||
import {
|
||||
executeYearEndClosing,
|
||||
@@ -64,6 +65,8 @@ import type {
|
||||
InvoiceItem,
|
||||
AccountingMethod,
|
||||
CreditNote,
|
||||
CreateJournalEntryLineInput,
|
||||
JournalEntrySourceType,
|
||||
} from '@/types'
|
||||
|
||||
const log = createLogger('pending-operations/commit')
|
||||
@@ -1592,6 +1595,171 @@ async function commitImportSie(
|
||||
}
|
||||
}
|
||||
|
||||
// ── Phase 4: arbitrary-line bookkeeping primitives ───────────────
|
||||
|
||||
/**
|
||||
* Normalize raw JSON line input from pending_operations.params into the
|
||||
* engine's typed line shape. Trusts shape because the MCP tool already
|
||||
* validates via Zod before staging — defensive coercion only.
|
||||
*/
|
||||
function normalizeVoucherLines(raw: unknown): CreateJournalEntryLineInput[] {
|
||||
if (!Array.isArray(raw)) return []
|
||||
return raw.map((l) => {
|
||||
const line = l as Record<string, unknown>
|
||||
return {
|
||||
account_number: String(line.account_number),
|
||||
debit_amount: Number(line.debit_amount) || 0,
|
||||
credit_amount: Number(line.credit_amount) || 0,
|
||||
line_description: line.line_description ? String(line.line_description) : undefined,
|
||||
currency: line.currency ? String(line.currency) : undefined,
|
||||
amount_in_currency: line.amount_in_currency !== undefined ? Number(line.amount_in_currency) : undefined,
|
||||
exchange_rate: line.exchange_rate !== undefined ? Number(line.exchange_rate) : undefined,
|
||||
tax_code: line.tax_code ? String(line.tax_code) : undefined,
|
||||
cost_center: line.cost_center ? String(line.cost_center) : undefined,
|
||||
project: line.project ? String(line.project) : undefined,
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
async function commitCreateVoucher(
|
||||
supabase: SupabaseClient,
|
||||
userId: string,
|
||||
companyId: string,
|
||||
params: Record<string, unknown>
|
||||
): Promise<ExecutorResult> {
|
||||
const entryDate = params.entry_date as string
|
||||
const description = params.description as string
|
||||
const lines = normalizeVoucherLines(params.lines)
|
||||
|
||||
if (!entryDate || !description || lines.length < 2) {
|
||||
return { error: 'entry_date, description, and at least two lines are required', status: 400 }
|
||||
}
|
||||
|
||||
// Re-validate balance defensively. The MCP tool already checks before
|
||||
// staging, but a tampered or hand-inserted pending_operations row would
|
||||
// bypass that gate. createDraftEntry runs the same check internally — this
|
||||
// is for a cleaner 400 + Swedish error before reaching the engine.
|
||||
const balance = validateBalance(lines)
|
||||
if (!balance.valid) {
|
||||
return {
|
||||
error: `Verifikationen balanserar inte: debet ${balance.totalDebit} SEK, kredit ${balance.totalCredit} SEK.`,
|
||||
status: 400,
|
||||
}
|
||||
}
|
||||
|
||||
// Resolve fiscal period: prefer explicit, fall back to date lookup so the
|
||||
// caller can post a voucher without first calling list_fiscal_periods.
|
||||
let fiscalPeriodId = params.fiscal_period_id as string | undefined
|
||||
if (!fiscalPeriodId) {
|
||||
const resolved = await findFiscalPeriod(supabase, companyId, entryDate)
|
||||
if (!resolved) {
|
||||
return {
|
||||
error: `Ingen öppen räkenskapsperiod täcker datumet ${entryDate}. Öppna en period eller välj ett annat datum.`,
|
||||
status: 400,
|
||||
}
|
||||
}
|
||||
fiscalPeriodId = resolved
|
||||
}
|
||||
|
||||
try {
|
||||
const entry = await createJournalEntry(
|
||||
supabase,
|
||||
companyId,
|
||||
userId,
|
||||
{
|
||||
fiscal_period_id: fiscalPeriodId,
|
||||
entry_date: entryDate,
|
||||
description,
|
||||
// source_type is hardcoded — never trust params.source_type. The MCP
|
||||
// tool stages 'manual', but a future direct-staging path could
|
||||
// otherwise inject 'bank'/'invoice'/etc. and corrupt audit attribution.
|
||||
source_type: 'manual' as JournalEntrySourceType,
|
||||
voucher_series: (params.voucher_series as string) || undefined,
|
||||
notes: (params.notes as string) || undefined,
|
||||
lines,
|
||||
},
|
||||
'mcp_create_voucher'
|
||||
)
|
||||
|
||||
return {
|
||||
data: {
|
||||
journal_entry_id: entry.id,
|
||||
voucher_number: entry.voucher_number,
|
||||
voucher_series: entry.voucher_series,
|
||||
fiscal_period_id: fiscalPeriodId,
|
||||
},
|
||||
}
|
||||
} catch (err) {
|
||||
if (isBookkeepingError(err)) throw err
|
||||
return { error: err instanceof Error ? err.message : 'Failed to create voucher', status: 500 }
|
||||
}
|
||||
}
|
||||
|
||||
async function commitCorrectEntry(
|
||||
supabase: SupabaseClient,
|
||||
userId: string,
|
||||
companyId: string,
|
||||
params: Record<string, unknown>
|
||||
): Promise<ExecutorResult> {
|
||||
const entryId = params.entry_id as string
|
||||
const lines = normalizeVoucherLines(params.lines)
|
||||
|
||||
if (!entryId || lines.length < 2) {
|
||||
return { error: 'entry_id and at least two lines are required', status: 400 }
|
||||
}
|
||||
|
||||
// Pre-flight: verify the original is posted and its period is not locked.
|
||||
// Falling into correctEntry without this returns a less helpful DB error and
|
||||
// half-creates the storno before rolling back; surfacing the Swedish message
|
||||
// here matches the period_locked UX everywhere else in the app.
|
||||
const { data: original, error: origErr } = await supabase
|
||||
.from('journal_entries')
|
||||
.select('id, status, fiscal_period_id, fiscal_periods!inner(is_closed)')
|
||||
.eq('id', entryId)
|
||||
.eq('company_id', companyId)
|
||||
.maybeSingle()
|
||||
|
||||
if (origErr || !original) {
|
||||
return { error: 'Verifikationen hittades inte.', status: 404 }
|
||||
}
|
||||
if (original.status !== 'posted') {
|
||||
return {
|
||||
error: `Endast bokförda verifikationer kan rättas. Aktuell status: ${original.status}. Drafts redigeras direkt.`,
|
||||
status: 409,
|
||||
}
|
||||
}
|
||||
const period = original.fiscal_periods as { is_closed?: boolean } | { is_closed?: boolean }[] | null
|
||||
const periodClosed = Array.isArray(period) ? period[0]?.is_closed : period?.is_closed
|
||||
if (periodClosed) {
|
||||
return {
|
||||
error: 'Räkenskapsperioden är låst. Öppna perioden eller använd omprövning för redan inlämnade momsdeklarationer.',
|
||||
status: 409,
|
||||
}
|
||||
}
|
||||
|
||||
try {
|
||||
// correctEntry() posts both the storno and the corrected entry into the
|
||||
// SAME fiscal_period_id and entry_date as the original (see
|
||||
// lib/core/bookkeeping/storno-service.ts:99,102,195,198). So a rättelse
|
||||
// made in May 2026 for a December 2025 voucher correctly lands in 2025,
|
||||
// keeping that period's balances consistent. The is_closed pre-flight
|
||||
// above is what blocks corrections to already-locked periods.
|
||||
const result = await correctEntry(supabase, companyId, userId, entryId, lines)
|
||||
return {
|
||||
data: {
|
||||
original_entry_id: entryId,
|
||||
storno_entry_id: result.reversal.id,
|
||||
corrected_entry_id: result.corrected.id,
|
||||
storno_voucher_number: result.reversal.voucher_number,
|
||||
corrected_voucher_number: result.corrected.voucher_number,
|
||||
},
|
||||
}
|
||||
} catch (err) {
|
||||
if (isBookkeepingError(err)) throw err
|
||||
return { error: err instanceof Error ? err.message : 'Failed to correct entry', status: 500 }
|
||||
}
|
||||
}
|
||||
|
||||
// ── Public dispatcher ────────────────────────────────────────────
|
||||
|
||||
/**
|
||||
@@ -1703,6 +1871,12 @@ export async function commitPendingOperation(
|
||||
case 'import_sie':
|
||||
result = await commitImportSie(supabase, userId, companyId, pendingOp.params)
|
||||
break
|
||||
case 'create_voucher':
|
||||
result = await commitCreateVoucher(supabase, userId, companyId, pendingOp.params)
|
||||
break
|
||||
case 'correct_entry':
|
||||
result = await commitCorrectEntry(supabase, userId, companyId, pendingOp.params)
|
||||
break
|
||||
default:
|
||||
return {
|
||||
status: 'failed',
|
||||
|
||||
@@ -57,6 +57,13 @@ export const OPERATION_RISK_TIERS: Record<string, RiskLevel> = {
|
||||
create_supplier_invoice_from_inbox: 'medium',
|
||||
credit_invoice: 'high',
|
||||
convert_invoice: 'medium',
|
||||
|
||||
// ── Phase 4: arbitrary-line bookkeeping primitives ─────────────────
|
||||
// Both accept caller-supplied account/amount/period — unlike
|
||||
// uncategorize_transaction (medium), which mirrors an existing entry.
|
||||
// The arbitrary-line capability is what makes these compliance-critical.
|
||||
create_voucher: 'high',
|
||||
correct_entry: 'high',
|
||||
}
|
||||
|
||||
export function getRiskLevel(operationType: string): RiskLevel {
|
||||
|
||||
Reference in New Issue
Block a user