admin/accounted
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: complete multi-tenant refactor + settings validation + fiscal period API (#156)

Browse Source 
* feat: complete multi-tenant refactor for reconciliation, arcim, settings validation

- Migrate bank-reconciliation to company_id (all functions + tests)
- Migrate arcim-migration entity mappers and orchestrator to company_id
- Fix enable-banking reconciliation calls to use companyId
- Add Swedish law validation to settings schema:
  - VAT number required when VAT-registered (ML 11 kap. 8§)
  - Moms period required when VAT-registered (SFL 26 kap.)
  - Aktiebolag must use accrual accounting (BFNAR 2006:1)
- Fix fiscal year period creation: always 12 months after first year (BFL 3 kap.)
- Add plusgiro, website, pays_salaries fields to CompanySettings
- Add plusgiro to invoice PDF template
- Add fiscal period CRUD and opening balances API routes
- Add frame-src CSP directive for future iframe embedding
- Fix unlinked_1930_lines RPC to use company_id parameter
- Update CLAUDE.md documentation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address PR review findings (P1 + P2)

- Fix reconciliation events emitting companyId as userId — thread
  actual userId through runReconciliation and manualLink
- Move VAT cross-field validation (vat_number, moms_period) from
  schema refinements to route handler where effective stored state
  is available, preventing false rejection on partial updates
- Add plusgiro format validation regex (N-N pattern)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-04-01 14:46:41 +02:00
committed by GitHub
co-authored by Claude Opus 4.6
parent fad4899cb4
commit e89f2c402d
20 changed files with 427 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/reconciliation/__tests__/bank-reconciliation.test.ts
+11 -11
View File
@@ -278,7 +278,7 @@ describe('runReconciliation', () => {
// from('transactions').select — unmatched
enqueue({ data: [] })
const result = await runReconciliation(supabase as never, 'user-1')
const result = await runReconciliation(supabase as never, 'company-1')
expect(result.matches).toEqual([])
expect(result.applied).toBe(0)
@@ -300,7 +300,7 @@ describe('runReconciliation', () => {
// from('transactions') returns unmatched transactions
enqueue({ data: [tx] })
const result = await runReconciliation(supabase as never, 'user-1', { dryRun: true })
const result = await runReconciliation(supabase as never, 'company-1', { dryRun: true })
expect(result.matches).toHaveLength(1)
expect(result.matches[0].method).toBe('auto_exact')
@@ -325,7 +325,7 @@ describe('runReconciliation', () => {
// Update transaction with link
enqueue({ data: null, error: null })
const result = await runReconciliation(supabase as never, 'user-1', { dryRun: false })
const result = await runReconciliation(supabase as never, 'company-1', { dryRun: false })
expect(result.matches).toHaveLength(1)
expect(result.applied).toBe(1)
@@ -379,7 +379,7 @@ describe('manualLink', () => {
// Transaction query returns null
enqueue({ data: null, error: { message: 'Not found' } })
const result = await manualLink(supabase as never, 'user-1', 'tx-1', 'je-1')
const result = await manualLink(supabase as never, 'company-1', 'tx-1', 'je-1')
expect(result.success).toBe(false)
expect(result.error).toBe('Transaction not found')
@@ -392,7 +392,7 @@ describe('manualLink', () => {
// Transaction found but already linked
enqueue({ data: tx })
const result = await manualLink(supabase as never, 'user-1', 'tx-1', 'je-1')
const result = await manualLink(supabase as never, 'company-1', 'tx-1', 'je-1')
expect(result.success).toBe(false)
expect(result.error).toBe('Transaction is already linked to a journal entry')
@@ -405,11 +405,11 @@ describe('manualLink', () => {
// Transaction found
enqueue({ data: tx })
// Journal entry found
enqueue({ data: { id: 'je-1', user_id: 'user-1', status: 'posted' } })
enqueue({ data: { id: 'je-1', user_id: 'company-1', status: 'posted' } })
// No 1930 lines
enqueue({ data: [] })
const result = await manualLink(supabase as never, 'user-1', 'tx-1', 'je-1')
const result = await manualLink(supabase as never, 'company-1', 'tx-1', 'je-1')
expect(result.success).toBe(false)
expect(result.error).toBe('Journal entry has no line on account 1930')
@@ -422,7 +422,7 @@ describe('manualLink', () => {
// Transaction found
enqueue({ data: tx })
// Journal entry found
enqueue({ data: { id: 'je-1', user_id: 'user-1', status: 'posted' } })
enqueue({ data: { id: 'je-1', user_id: 'company-1', status: 'posted' } })
// 1930 line exists
enqueue({ data: [{ debit_amount: 1000, credit_amount: 0 }] })
// No existing link
@@ -430,7 +430,7 @@ describe('manualLink', () => {
// Update succeeds
enqueue({ data: null, error: null })
const result = await manualLink(supabase as never, 'user-1', 'tx-1', 'je-1')
const result = await manualLink(supabase as never, 'company-1', 'tx-1', 'je-1')
expect(result.success).toBe(true)
})
@@ -488,7 +488,7 @@ describe('unlinkReconciliation', () => {
},
})
const result = await unlinkReconciliation(supabase as never, 'user-1', 'tx-1')
const result = await unlinkReconciliation(supabase as never, 'company-1', 'tx-1')
expect(result.success).toBe(false)
expect(result.error).toContain('Cannot unlink')
@@ -508,7 +508,7 @@ describe('unlinkReconciliation', () => {
// Update succeeds
enqueue({ data: null, error: null })
const result = await unlinkReconciliation(supabase as never, 'user-1', 'tx-1')
const result = await unlinkReconciliation(supabase as never, 'company-1', 'tx-1')
expect(result.success).toBe(true)
})
lib/reconciliation/bank-reconciliation.ts
+27 -26
View File
@@ -126,19 +126,19 @@ export function tryReconcileTransaction(
*/
export async function runReconciliation(
supabase: SupabaseClient,
userId: string,
options: ReconciliationOptions = {}
companyId: string,
options: ReconciliationOptions & { userId?: string } = {}
): Promise<ReconciliationRunResult> {
const { dateFrom, dateTo, dryRun = false } = options
// Fetch unlinked GL lines via RPC
const glLines = await fetchUnlinkedGLLines(supabase, userId, dateFrom, dateTo)
const glLines = await fetchUnlinkedGLLines(supabase, companyId, dateFrom, dateTo)
// Fetch unmatched transactions
let query = supabase
.from('transactions')
.select('*')
.eq('company_id', userId)
.eq('company_id', companyId)
.is('journal_entry_id', null)
.eq('currency', 'SEK')
@@ -172,7 +172,7 @@ export async function runReconciliation(
is_business: true,
})
.eq('id', match.transaction.id)
.eq('company_id', userId)
.eq('company_id', companyId)
if (error) {
errors++
@@ -185,8 +185,8 @@ export async function runReconciliation(
transaction: match.transaction,
journalEntryId: match.glLine.journal_entry_id,
method: match.method,
userId,
companyId: userId,
userId: options.userId ?? companyId,
companyId,
},
})
} catch {
@@ -210,7 +210,7 @@ export async function runReconciliation(
*/
export async function getReconciliationStatus(
supabase: SupabaseClient,
userId: string,
companyId: string,
dateFrom?: string,
dateTo?: string
): Promise<ReconciliationStatus> {
@@ -218,7 +218,7 @@ export async function getReconciliationStatus(
let txQuery = supabase
.from('transactions')
.select('amount, journal_entry_id, reconciliation_method')
.eq('company_id', userId)
.eq('company_id', companyId)
.eq('currency', 'SEK')
if (dateFrom) txQuery = txQuery.gte('date', dateFrom)
@@ -229,9 +229,9 @@ export async function getReconciliationStatus(
// Get GL 1930 lines (all, not just unlinked)
let glQuery = supabase
.from('journal_entry_lines')
.select('debit_amount, credit_amount, journal_entries!inner(user_id, entry_date, status)')
.select('debit_amount, credit_amount, journal_entries!inner(company_id, entry_date, status)')
.eq('account_number', '1930')
.eq('journal_entries.company_id', userId)
.eq('journal_entries.company_id', companyId)
.eq('journal_entries.status', 'posted')
if (dateFrom) glQuery = glQuery.gte('journal_entries.entry_date', dateFrom)
@@ -259,7 +259,7 @@ export async function getReconciliationStatus(
).length
// Unlinked GL lines count
const unlinkedLines = await fetchUnlinkedGLLines(supabase, userId, dateFrom, dateTo)
const unlinkedLines = await fetchUnlinkedGLLines(supabase, companyId, dateFrom, dateTo)
const difference = Math.round((bankTotal - glBalance) * 100) / 100
@@ -284,16 +284,17 @@ export async function getReconciliationStatus(
*/
export async function manualLink(
supabase: SupabaseClient,
userId: string,
companyId: string,
transactionId: string,
journalEntryId: string
journalEntryId: string,
userId?: string
): Promise<{ success: boolean; error?: string }> {
// Fetch transaction
const { data: tx, error: txError } = await supabase
.from('transactions')
.select('*')
.eq('id', transactionId)
.eq('company_id', userId)
.eq('company_id', companyId)
.single()
if (txError || !tx) {
@@ -307,9 +308,9 @@ export async function manualLink(
// Fetch journal entry + verify it has a 1930 line
const { data: entry, error: entryError } = await supabase
.from('journal_entries')
.select('id, user_id, status')
.select('id, company_id, status')
.eq('id', journalEntryId)
.eq('company_id', userId)
.eq('company_id', companyId)
.single()
if (entryError || !entry) {
@@ -336,7 +337,7 @@ export async function manualLink(
.from('transactions')
.select('id')
.eq('journal_entry_id', journalEntryId)
.eq('company_id', userId)
.eq('company_id', companyId)
.single()
if (existingLink) {
@@ -352,7 +353,7 @@ export async function manualLink(
is_business: true,
})
.eq('id', transactionId)
.eq('company_id', userId)
.eq('company_id', companyId)
if (updateError) {
return { success: false, error: 'Failed to link transaction' }
@@ -365,8 +366,8 @@ export async function manualLink(
transaction: tx as Transaction,
journalEntryId,
method: 'manual' as ReconciliationMethod,
userId,
companyId: userId,
userId: userId ?? companyId,
companyId,
},
})
} catch {
@@ -382,7 +383,7 @@ export async function manualLink(
*/
export async function unlinkReconciliation(
supabase: SupabaseClient,
userId: string,
companyId: string,
transactionId: string
): Promise<{ success: boolean; error?: string }> {
// Fetch transaction
@@ -390,7 +391,7 @@ export async function unlinkReconciliation(
.from('transactions')
.select('id, journal_entry_id, reconciliation_method')
.eq('id', transactionId)
.eq('company_id', userId)
.eq('company_id', companyId)
.single()
if (txError || !tx) {
@@ -413,13 +414,13 @@ export async function unlinkReconciliation(
is_business: null,
})
.eq('id', transactionId)
.eq('company_id', userId)
.eq('company_id', companyId)
if (updateError) {
return { success: false, error: 'Failed to unlink transaction' }
}
logMatchEvent(supabase, userId, transactionId, 'unmatched', {
logMatchEvent(supabase, companyId, transactionId, 'unmatched', {
previousState: {
journal_entry_id: tx.journal_entry_id,
reconciliation_method: tx.reconciliation_method,
@@ -441,7 +442,7 @@ export async function fetchUnlinkedGLLines(
dateTo?: string
): Promise<UnlinkedGLLine[]> {
const { data, error } = await supabase.rpc('get_unlinked_1930_lines', {
p_user_id: companyId,
p_company_id: companyId,
p_date_from: dateFrom || null,
p_date_to: dateTo || null,
})