refactor(design): no amber boxes, attention is one ochre sentence (#1562)
The founder wants the yellow boxes gone everywhere. The design system already agreed: status colors are data, not chrome (convention 12) and attention is a single ochre sentence, never a banner (convention 6). This enforces it: - ConfirmationDialog: the amber warning panel is now an AttnLine, and the hardcoded Swedish default warningText is gone: it injected an immutability warning into dialogs whose authors never asked for one (every current caller passes the prop explicitly, so no behavior change at any call site). - Badge warning variant: amber fill replaced with a hairline chip and ochre text. - DestructiveConfirmDialog warning variant: neutral icon disc, default primary confirm button (only --destructive survives as chrome). - BankSyncStatusChip stale state: same neutral shape as the healthy chip, ochre text carries the signal. - SandboxBanner: solid amber bar becomes secondary-on-border chrome. - BankIdAuth, BankIdCompanyPicker, SessionTimeoutModal: the last three raw-amber (bg-amber-*) holdouts moved onto tokens, the company-picker banner becoming a plain AttnLine. - Mechanical sweep of the ~58 hand-rolled bg-warning/border-warning boxes across 45 files: fills to bg-muted/30 (icon discs bg-muted), borders to border-border, text-warning-foreground to text-attn. The account-class dots in account-number.tsx keep bg-warning: they are data indicators, not chrome. Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Jakob Wennberg
Claude Fable 5
parent
abff8d90f6
commit
e51a2c8102
@@ -404,11 +404,11 @@ export default function InvoiceMatchDialog({
|
||||
<div className="space-y-4">
|
||||
{/* Duplicate-payment warning: customer-side only, only when a candidate exists */}
|
||||
{!targetBlocked && candidate && isCustomerInvoice && (
|
||||
<div className="rounded-lg border border-warning/40 bg-warning/10 p-4 space-y-3">
|
||||
<div className="rounded-lg border border-border bg-muted/30 p-4 space-y-3">
|
||||
<div className="flex items-start gap-2">
|
||||
<AlertTriangle className="h-4 w-4 flex-shrink-0 mt-0.5 text-warning-foreground" />
|
||||
<AlertTriangle className="h-4 w-4 flex-shrink-0 mt-0.5 text-attn" />
|
||||
<div className="text-sm space-y-1">
|
||||
<p className="font-medium text-warning-foreground">{t('duplicate_title')}</p>
|
||||
<p className="font-medium text-attn">{t('duplicate_title')}</p>
|
||||
{/* candidate.amount is the voucher leg's SEK debit
|
||||
(duplicate-payment-detection.ts), so it is formatted as
|
||||
SEK regardless of the transaction's currency: an
|
||||
@@ -553,7 +553,7 @@ export default function InvoiceMatchDialog({
|
||||
if (targetBlocked) {
|
||||
const isSettled = targetMatchState === 'settled'
|
||||
return (
|
||||
<div className="flex items-start gap-2 p-3 rounded-lg bg-warning/10 text-warning-foreground">
|
||||
<div className="flex items-start gap-2 p-3 rounded-lg bg-muted/30 text-attn">
|
||||
<AlertTriangle className="h-4 w-4 flex-shrink-0 mt-0.5" />
|
||||
<div className="text-sm">
|
||||
<p className="font-medium">
|
||||
@@ -617,7 +617,7 @@ export default function InvoiceMatchDialog({
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="flex items-start gap-2 p-3 rounded-lg bg-warning/10 text-warning-foreground">
|
||||
<div className="flex items-start gap-2 p-3 rounded-lg bg-muted/30 text-attn">
|
||||
<AlertTriangle className="h-4 w-4 flex-shrink-0 mt-0.5" />
|
||||
<div className="text-sm">
|
||||
<p className="font-medium">{t('amounts_differ')}</p>
|
||||
@@ -652,9 +652,9 @@ export default function InvoiceMatchDialog({
|
||||
rather than inside the Valutaomräkning card below, because in
|
||||
this state the preview 400s and that card never renders. */}
|
||||
{!targetBlocked && invoiceRateMissing && (
|
||||
<div className="rounded-lg border border-warning/40 bg-warning/5 p-4">
|
||||
<div className="rounded-lg border border-border bg-muted/30 p-4">
|
||||
<div className="flex items-start gap-2">
|
||||
<AlertTriangle className="h-4 w-4 mt-0.5 text-warning-foreground flex-shrink-0" />
|
||||
<AlertTriangle className="h-4 w-4 mt-0.5 text-attn flex-shrink-0" />
|
||||
<div className="flex-1 text-sm">
|
||||
{/* Untinted title, matching the sibling
|
||||
fx_rate_unavailable panel below: the ochre lives in the
|
||||
@@ -691,9 +691,9 @@ export default function InvoiceMatchDialog({
|
||||
if ('error' in fx) {
|
||||
// Riksbanken unavailable: show manual rate input.
|
||||
return (
|
||||
<div className="rounded-lg border border-warning/40 bg-warning/5 p-4 space-y-3">
|
||||
<div className="rounded-lg border border-border bg-muted/30 p-4 space-y-3">
|
||||
<div className="flex items-start gap-2">
|
||||
<AlertTriangle className="h-4 w-4 mt-0.5 text-warning-foreground flex-shrink-0" />
|
||||
<AlertTriangle className="h-4 w-4 mt-0.5 text-attn flex-shrink-0" />
|
||||
<div className="flex-1 text-sm">
|
||||
<p className="font-medium">{t('fx_rate_unavailable_title')}</p>
|
||||
<p className="text-muted-foreground mt-1">
|
||||
|
||||
Reference in New Issue
Block a user