feat(bank): expose bank-reported balance (booked + available) in UI, reconciliation, MCP and v1 API (#2118)

* feat(bank): expose bank-reported balance (booked + available) in UI, reconciliation, MCP and v1 API The PSD2 sync has fetched the bank's reported balance for years but the data was stranded (F7): the Bank-page source picker read a cash_accounts column no sync ever updated (frozen at connect time), reconciliation hard-coded external_balance to null for bank accounts, and neither MCP nor the v1 API exposed any balance at all, so the only path to a current bank balance was logging into the bank. - getAccountBalance now returns booked + available from the same quota-limited BALANCES response (previously all but one type discarded) - every sync (manual + cron) mirrors balance, available_balance and balance_updated_at into cash_accounts, fixing the stale picker - new cash_accounts.available_balance column (additive migration) - reconciliation bank kind: external_balance = bank-reported balance, plus bank_reported_* fields and fetch timestamp in the bank block; difference math stays movement-based and untouched - reconciliation view shows "Saldo enligt banken ... hamtat {date}" - MCP gnubok_list_cash_accounts returns the three balance fields; the cash_today prompt now reports the bank's figure instead of teaching agents to answer with the bookkept 19xx balance - new GET /api/v1/companies/{companyId}/cash-accounts endpoint Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ewu46quXgh9LSr9UwYusxm * fix(bank): keep external_balance null for bank sign-offs; never fabricate a zero balance; guard the mirror against stale writers Post-review fixes from the skeptic pass + CodeRabbit on PR #2118: - external_balance stays null for the bank reconciliation kind: sign-off persists it into account_reconciliations and bokslutsbilagor computes closing - external from that row, so a today-balance stored on a balansdag sign-off printed a phantom warning-red differens in the year-end appendix. The bank-reported figure lives only in the timestamped bank_reported_* pair in the bank block, and only when its fetch timestamp exists (a balance of unknown age is suppressed). - AccountOverview no longer falls back to today's date when the balance timestamp is missing; the line is omitted instead. - getAccountBalance returns null on an empty BALANCES response instead of fabricating amount 0 with a fresh timestamp; sync keeps the previous stored value. - updateBalancesFromSync only writes over an older-or-missing balance_updated_at, so an older sync run finishing later cannot move the mirrored balance backwards. - The inline initial backfill (picker save) now mirrors fetched balances into cash_accounts too (accounts_data is deliberately not re-written there). - cash_today MCP prompt mentions the gnubok_call_tool bridge for hosts that only see the default catalog. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ewu46quXgh9LSr9UwYusxm * fix(bank): express the stale-writer guard as two literal predicates for the schema guard The .or() with a template literal pushed the no-phantom-columns unresolvable-expression count over its ceiling. Same semantics, two updates: one for rows with an older timestamp, one for rows with none. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ewu46quXgh9LSr9UwYusxm * fix(bank): rank interimBooked (ITBD) as a booked balance type before the generic fallback Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ewu46quXgh9LSr9UwYusxm --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-01 16:16:29 +02:00
parent a57a8d968b
commit cd40127f0e
30 changed files with 985 additions and 28 deletions
@@ -608,7 +608,7 @@ describe('syncAccountTransactions', () => {

  it('refreshes the balance when the stored balance is older than 12 hours', async () => {
    mockGetAllTransactionsWithRaw.mockResolvedValue({ transactions: [], rawPages: [] })
-    mockGetAccountBalance.mockResolvedValue({ amount: 1234.56, date: '2026-06-01' })
+    mockGetAccountBalance.mockResolvedValue({ amount: 1234.56, date: '2026-06-01', available: 1100.5 })

    const staleAt = new Date(Date.now() - 13 * 60 * 60 * 1000).toISOString()
    const account = makeAccount({ balance: 500, balance_updated_at: staleAt })
@@ -620,9 +620,48 @@ describe('syncAccountTransactions', () => {

    expect(mockGetAccountBalance).toHaveBeenCalledWith('acc-uid-1')
    expect(account.balance).toBe(1234.56)
+    expect(account.available_balance).toBe(1100.5)
    expect(account.balance_updated_at).not.toBe(staleAt)
  })

+  it('keeps the previous balance and timestamp when the bank reports no balances (null result)', async () => {
+    // A 200 with zero balances used to fabricate amount 0; with balances now
+    // user-facing that would pin "banken rapporterar 0 kr" for 12h.
+    mockGetAllTransactionsWithRaw.mockResolvedValue({ transactions: [], rawPages: [] })
+    mockGetAccountBalance.mockResolvedValue(null)
+
+    const staleAt = new Date(Date.now() - 13 * 60 * 60 * 1000).toISOString()
+    const account = makeAccount({ balance: 500, available_balance: 480, balance_updated_at: staleAt })
+
+    await syncAccountTransactions(
+      {} as never, COMPANY_ID, USER_ID, CONNECTION_ID, account,
+      '2026-01-01', '2026-06-01', mockIngest
+    )
+
+    expect(mockGetAccountBalance).toHaveBeenCalledTimes(1)
+    expect(account.balance).toBe(500)
+    expect(account.available_balance).toBe(480)
+    expect(account.balance_updated_at).toBe(staleAt)
+  })
+
+  it('clears a stored available balance when the refresh reports none', async () => {
+    // A stale available figure next to a fresh booked figure would misstate
+    // what can be spent: null from the bank overwrites, never keeps.
+    mockGetAllTransactionsWithRaw.mockResolvedValue({ transactions: [], rawPages: [] })
+    mockGetAccountBalance.mockResolvedValue({ amount: 1234.56, date: '2026-06-01', available: null })
+
+    const staleAt = new Date(Date.now() - 13 * 60 * 60 * 1000).toISOString()
+    const account = makeAccount({ balance: 500, available_balance: 480, balance_updated_at: staleAt })
+
+    await syncAccountTransactions(
+      {} as never, COMPANY_ID, USER_ID, CONNECTION_ID, account,
+      '2026-01-01', '2026-06-01', mockIngest
+    )
+
+    expect(account.balance).toBe(1234.56)
+    expect(account.available_balance).toBeUndefined()
+  })
+
  it('treats a future balance_updated_at as stale and refreshes', async () => {
    // Clock skew or bad data can store a future timestamp; its negative age
    // must not count as fresh, or refreshes would be suppressed indefinitely.