feat(mcp): already-explained voucher guard at stage and commit for match_batch_allocate (#2294) (#2346)
* feat(mcp): already-explained voucher guard at stage and commit for match_batch_allocate The dashboard match-batch route refused BATCH_TX_POSSIBLE_DUPLICATE when posted, unlinked vouchers already summed to the bank row (PR #2300), but the MCP door (gnubok_match_batch_allocate staging + commitMatchBatchAllocate) called the RPC with no guard, so an agent could book a Bankgirot aggregate a second time. The detector existed once; the guard lived in one door. One shared decision helper, lib/invoices/already-explained-guard.ts, now sits on top of the existing detectors (no fork) and is called by the dashboard route, the MCP staging tools and the commit executors: - gnubok_match_batch_allocate refuses to stage, coded BATCH_TX_POSSIBLE_DUPLICATE, naming the vouchers, the reconcile_match / link_transaction_to_journal_entry call that resolves the row, and the exact force + expected_journal_entry_ids binding. - commitMatchBatchAllocate runs the same guard before the RPC and re-validates a staged force binding against the set detected at commit, so a stale approval cannot book a duplicate; 409 auto-rejects with the vouchers in result_data. - force + expected_journal_entry_ids on the tool mirror MatchBatchSchema; an honoured override stages with a compliance_warning and, after the booking succeeds, writes BankTransactionDuplicateDismissed to behandlingshistorik (dashboard route included; it only logged before). - gnubok_match_transaction_to_invoice and commitMatchTransactionInvoice get the dashboard's 1:1 soft-duplicate guard (MATCH_INVOICE_POSSIBLE_DUPLICATE / MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH) with force + expected_journal_entry_id; at commit it runs before the storno. - Registry: both duplicate codes gain retryable: false and a remediation. Catalog payload held under the 60K ceiling by trimming the two tools' own descriptions (59 988 measured, ledger entry in payload-size.bench.test.ts). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6 * docs(decisions): record the 2026-09-06 ten-issue batch's first-principles choices Carries the DECISIONS.md lines for PRs #2337 #2339 #2340 #2341 #2342 #2343 #2344 #2345 #2346 #2347 in one place so the ten branches do not conflict on this file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6 * fix(mcp): refuse an unverifiable forced override, surface a failed duplicate check, validate the binding (#2294 review) Review round on PR #2346 (CodeRabbit + compliance): - guardAlreadyExplained returned 'clear' when the detector threw even with force=true, so a forced 1:N override could book without re-validating expected_journal_entry_ids and left no behandlingshistorik record. It now returns a distinct 'unverifiable' outcome under force (mirrors guardDuplicatePaymentVoucher); the dashboard route, the MCP staging tool and the commit executor all refuse it with the new registry code BATCH_TX_EXPLAINED_CHECK_FAILED (409, retryable, remediation). Regression tests on every caller. - A detector failure without force still fails open at stage time, but no longer silently: the tools track onDetectError and stage a complianceNote, so preview_data.compliance_warning is set on both match_batch_allocate (GenericPreview renders it) and match_transaction_invoice (MatchTransactionInvoicePreview now renders data.compliance_warning through AttnLine). - expected_journal_entry_ids / expected_journal_entry_id are validated at the MCP boundary (array of 1 to 10 non-empty strings / non-empty string) and refused with VALIDATION_ERROR instead of being silently filtered. No schema description text added: catalog payload unchanged. - RoPA: .compliance/ropa.yaml gains bookkeeping.duplicate_dismissal_history for the BankTransactionDuplicateDismissed record (Art. 6(1)(c), BFNAR 2013:2 p. 9.16, retention per BFL 7 kap, stored in processing_history). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Fable 5.1
Jakob Wennberg
Claude Fable 5.1
Jakob Wennberg
parent
39d409d257
commit
cce0de5704
@@ -0,0 +1,217 @@
|
||||
/**
|
||||
* gnubok_match_batch_allocate: the already-explained guard at stage time
|
||||
* (issue #2294).
|
||||
*
|
||||
* The dashboard door refuses a batch allocation with
|
||||
* BATCH_TX_POSSIBLE_DUPLICATE when posted, unlinked vouchers on the row's
|
||||
* settlement account sum exactly to the row (gecko's Bankgirot aggregate, PR
|
||||
* #2300). The MCP door used to stage straight past that, so an agent could
|
||||
* book the aggregate a second time. Now the same detector runs before
|
||||
* staging: the refusal names the vouchers and the link call that resolves
|
||||
* the row, and force is bound to exactly those ids.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createQueuedMockSupabase } from '@/tests/helpers'
|
||||
|
||||
const { mockDetectSet } = vi.hoisted(() => ({ mockDetectSet: vi.fn() }))
|
||||
vi.mock('@/lib/invoices/duplicate-payment-detection', () => ({
|
||||
detectExplainingVoucherSetForTransaction: mockDetectSet,
|
||||
detectDuplicatePaymentVoucher: vi.fn(async () => null),
|
||||
}))
|
||||
|
||||
import { tools } from '../server'
|
||||
|
||||
const allocate = tools.find((t) => t.name === 'gnubok_match_batch_allocate')!
|
||||
|
||||
const TX_ID = '11111111-1111-4111-8111-111111111111'
|
||||
const INV_ID = '22222222-2222-4222-8222-222222222222'
|
||||
const JE_A = '55555555-5555-4555-8555-555555555555'
|
||||
const JE_B = '66666666-6666-4666-8666-666666666666'
|
||||
|
||||
const txRow = {
|
||||
id: TX_ID,
|
||||
description: 'BGGIRERING',
|
||||
merchant_name: null,
|
||||
amount: 88250,
|
||||
currency: 'SEK',
|
||||
amount_sek: null,
|
||||
exchange_rate: null,
|
||||
cash_account_id: 'ca-1',
|
||||
date: '2026-07-31',
|
||||
journal_entry_id: null,
|
||||
}
|
||||
|
||||
const explainingSet = {
|
||||
vouchers: [
|
||||
{ journal_entry_id: JE_A, voucher_label: 'A57', entry_date: '2026-07-31', description: 'Inbetalning kundfaktura 063', source_type: 'invoice_paid', amount: 62500, bank_account_number: '1930' },
|
||||
{ journal_entry_id: JE_B, voucher_label: 'A58', entry_date: '2026-07-31', description: 'Inbetalning kundfaktura 064', source_type: 'invoice_paid', amount: 25750, bank_account_number: '1930' },
|
||||
],
|
||||
total: 88250,
|
||||
bank_account_number: '1930',
|
||||
same_date: true,
|
||||
}
|
||||
|
||||
const args = (extra: Record<string, unknown> = {}) => ({
|
||||
transaction_id: TX_ID,
|
||||
allocations: [{ kind: 'customer_invoice', invoice_id: INV_ID, amount: 88250 }],
|
||||
...extra,
|
||||
})
|
||||
|
||||
function run(supabase: unknown, extra: Record<string, unknown> = {}) {
|
||||
return allocate.execute(args(extra), 'company-1', 'user-1', supabase as never, { type: 'api_key' } as never)
|
||||
}
|
||||
|
||||
/** tx fetch + invoice tenant pre-check: everything the tool reads before the guard. */
|
||||
function enqueuePreGuard(enqueue: (r: { data?: unknown; error?: unknown }) => void) {
|
||||
enqueue({ data: txRow, error: null })
|
||||
enqueue({ data: [{ id: INV_ID, document_type: 'invoice' }], error: null })
|
||||
}
|
||||
|
||||
/** period_status lookups + the pending_operations insert. */
|
||||
function enqueueStage(enqueue: (r: { data?: unknown; error?: unknown }) => void) {
|
||||
enqueue({ data: { bookkeeping_locked_through: null }, error: null }) // company_settings
|
||||
enqueue({ data: { id: 'fp-1', is_closed: false, locked_at: null }, error: null }) // fiscal_periods
|
||||
enqueue({ data: { id: 'op-batch-1' }, error: null }) // pending_operations insert
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockDetectSet.mockResolvedValue(null)
|
||||
})
|
||||
|
||||
describe('gnubok_match_batch_allocate: already-explained guard at stage time', () => {
|
||||
it('refuses to stage, coded BATCH_TX_POSSIBLE_DUPLICATE, naming the vouchers, the link call and the force binding', async () => {
|
||||
mockDetectSet.mockResolvedValue(explainingSet)
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
const err = await run(supabase).then(() => null, (e: Error & { code?: string }) => e)
|
||||
expect(err).toBeInstanceOf(Error)
|
||||
expect(err!.code).toBe('BATCH_TX_POSSIBLE_DUPLICATE')
|
||||
expect(err!.message).toContain('A57 + A58')
|
||||
expect(err!.message).toContain('gnubok_reconcile_match')
|
||||
expect(err!.message).toContain('bank:ca-1')
|
||||
expect(err!.message).toContain(`expected_journal_entry_ids=${JSON.stringify([JE_A, JE_B])}`)
|
||||
// The row the tool already holds goes to the detector: no second fetch.
|
||||
expect(mockDetectSet).toHaveBeenCalledWith(supabase, 'company-1', expect.objectContaining({ id: TX_ID, cash_account_id: 'ca-1' }))
|
||||
// Nothing was staged.
|
||||
const tables = (supabase.from as ReturnType<typeof vi.fn>).mock.calls.map((c) => c[0])
|
||||
expect(tables).not.toContain('pending_operations')
|
||||
})
|
||||
|
||||
it('points a single explaining voucher at the 1:1 link tool too', async () => {
|
||||
mockDetectSet.mockResolvedValue({ ...explainingSet, vouchers: [explainingSet.vouchers[0]] })
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
await expect(run(supabase)).rejects.toThrow(/gnubok_link_transaction_to_journal_entry/)
|
||||
})
|
||||
|
||||
it('stages with a compliance warning when force names exactly the detected set, and persists the binding', async () => {
|
||||
mockDetectSet.mockResolvedValue(explainingSet)
|
||||
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
enqueueStage(enqueue)
|
||||
|
||||
const result = (await run(supabase, { force: true, expected_journal_entry_ids: [JE_B, JE_A] })) as {
|
||||
staged: boolean
|
||||
operation_id?: string
|
||||
message: string
|
||||
preview: Record<string, unknown>
|
||||
}
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.operation_id).toBe('op-batch-1')
|
||||
expect(result.preview.compliance_warning).toContain('A57 + A58')
|
||||
expect(result.message).toContain('WARNING')
|
||||
// The commit executor re-validates against the set detected at commit,
|
||||
// so the binding must travel with the op.
|
||||
const inserted = findCall('pending_operations', 'insert')?.[0] as { params: Record<string, unknown> }
|
||||
expect(inserted.params).toMatchObject({
|
||||
transaction_id: TX_ID,
|
||||
force: true,
|
||||
expected_journal_entry_ids: [JE_B, JE_A],
|
||||
})
|
||||
})
|
||||
|
||||
it('refuses force whose ids are not exactly the set detected now', async () => {
|
||||
mockDetectSet.mockResolvedValue(explainingSet)
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
const err = await run(supabase, { force: true, expected_journal_entry_ids: [JE_A] }).then(
|
||||
() => null,
|
||||
(e: Error & { code?: string }) => e,
|
||||
)
|
||||
expect(err!.code).toBe('BATCH_TX_POSSIBLE_DUPLICATE')
|
||||
expect(err!.message).toMatch(/^force=true avvisad/)
|
||||
const tables = (supabase.from as ReturnType<typeof vi.fn>).mock.calls.map((c) => c[0])
|
||||
expect(tables).not.toContain('pending_operations')
|
||||
})
|
||||
|
||||
it('rejects force without expected_journal_entry_ids before any query runs', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
const err = await run(supabase, { force: true }).then(() => null, (e: Error & { code?: string }) => e)
|
||||
expect(err!.code).toBe('VALIDATION_ERROR')
|
||||
expect(err!.message).toContain('expected_journal_entry_ids is required when force=true')
|
||||
expect(supabase.from).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('rejects a malformed expected_journal_entry_ids at the boundary instead of silently filtering it', async () => {
|
||||
// No host validates inputSchema at runtime: a string, an empty array, a
|
||||
// non-string element and more than 10 ids are each a validation error,
|
||||
// never a filtered list that then reads as a force mismatch.
|
||||
for (const bad of [JE_A, [], [JE_A, 42], [JE_A, ''], Array.from({ length: 11 }, () => JE_A)]) {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
const err = await run(supabase, { force: true, expected_journal_entry_ids: bad }).then(
|
||||
() => null,
|
||||
(e: Error & { code?: string }) => e,
|
||||
)
|
||||
expect(err?.code, JSON.stringify(bad)).toBe('VALIDATION_ERROR')
|
||||
expect(err!.message).toContain('array of 1 to 10 journal_entry_id strings')
|
||||
expect(supabase.from).not.toHaveBeenCalled()
|
||||
}
|
||||
})
|
||||
|
||||
it('does not persist a binding on a plain stage', async () => {
|
||||
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
enqueueStage(enqueue)
|
||||
|
||||
const result = (await run(supabase)) as { staged: boolean; preview: Record<string, unknown> }
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.preview.compliance_warning).toBeUndefined()
|
||||
const inserted = findCall('pending_operations', 'insert')?.[0] as { params: Record<string, unknown> }
|
||||
expect(inserted.params).not.toHaveProperty('force')
|
||||
expect(inserted.params).not.toHaveProperty('expected_journal_entry_ids')
|
||||
})
|
||||
|
||||
it('fails open when the detector throws without force, but the approval card says the check did not run', async () => {
|
||||
mockDetectSet.mockRejectedValue(new Error('ledger scan timed out'))
|
||||
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
enqueueStage(enqueue)
|
||||
|
||||
const result = (await run(supabase)) as { staged: boolean; message: string; preview: Record<string, unknown> }
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.preview.compliance_warning).toContain('Dubblettkontrollen kunde inte köras')
|
||||
expect(result.message).toContain('WARNING')
|
||||
// Persisted with the op, so /pending (GenericPreview) renders the same warning.
|
||||
const inserted = findCall('pending_operations', 'insert')?.[0] as { preview_data: Record<string, unknown> }
|
||||
expect(inserted.preview_data.compliance_warning).toContain('Dubblettkontrollen kunde inte köras')
|
||||
})
|
||||
|
||||
it('refuses force=true when the detector throws: an override that cannot be re-verified is never staged', async () => {
|
||||
mockDetectSet.mockRejectedValue(new Error('ledger scan timed out'))
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
const err = await run(supabase, { force: true, expected_journal_entry_ids: [JE_A, JE_B] }).then(
|
||||
() => null,
|
||||
(e: Error & { code?: string }) => e,
|
||||
)
|
||||
expect(err!.code).toBe('BATCH_TX_EXPLAINED_CHECK_FAILED')
|
||||
const tables = (supabase.from as ReturnType<typeof vi.fn>).mock.calls.map((c) => c[0])
|
||||
expect(tables).not.toContain('pending_operations')
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,207 @@
|
||||
/**
|
||||
* gnubok_match_transaction_to_invoice: the soft-duplicate guard at stage time
|
||||
* (issue #2294, parity with the dashboard match-invoice route's
|
||||
* MATCH_INVOICE_POSSIBLE_DUPLICATE / MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH).
|
||||
*
|
||||
* A manual verifikation that already books the receipt is surfaced before
|
||||
* anything is staged, with the voucher named and the link call that resolves
|
||||
* it; force is bound to that exact candidate and travels with the op so the
|
||||
* commit executor can re-validate it.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createQueuedMockSupabase } from '@/tests/helpers'
|
||||
|
||||
const { mockDetectCandidate } = vi.hoisted(() => ({ mockDetectCandidate: vi.fn() }))
|
||||
vi.mock('@/lib/invoices/duplicate-payment-detection', () => ({
|
||||
detectDuplicatePaymentVoucher: mockDetectCandidate,
|
||||
detectExplainingVoucherSetForTransaction: vi.fn(async () => null),
|
||||
}))
|
||||
|
||||
import { tools } from '../server'
|
||||
|
||||
const match = tools.find((t) => t.name === 'gnubok_match_transaction_to_invoice')!
|
||||
|
||||
const TX_ID = '11111111-1111-4111-8111-111111111111'
|
||||
const INV_ID = '22222222-2222-4222-8222-222222222222'
|
||||
const JE_MANUAL = '55555555-5555-4555-8555-555555555555'
|
||||
const JE_OTHER = '66666666-6666-4666-8666-666666666666'
|
||||
|
||||
const txRow = {
|
||||
id: TX_ID,
|
||||
description: 'SWISH INBET',
|
||||
merchant_name: null,
|
||||
amount: 1000,
|
||||
currency: 'SEK',
|
||||
amount_sek: null,
|
||||
exchange_rate: null,
|
||||
date: '2026-05-15',
|
||||
invoice_id: null,
|
||||
}
|
||||
|
||||
const invoiceRow = {
|
||||
id: INV_ID,
|
||||
invoice_number: 'F-2026001',
|
||||
status: 'sent',
|
||||
document_type: 'invoice',
|
||||
total: 1000,
|
||||
currency: 'SEK',
|
||||
invoice_date: '2026-05-01',
|
||||
customer: { name: 'Kund AB' },
|
||||
}
|
||||
|
||||
const candidate = {
|
||||
journal_entry_id: JE_MANUAL,
|
||||
voucher_label: 'A12',
|
||||
entry_date: '2026-05-15',
|
||||
description: 'Inbetalning faktura',
|
||||
amount: 1000,
|
||||
bank_account_number: '1930',
|
||||
reason: 'exact_amount_same_date',
|
||||
amount_verified: true,
|
||||
unverified_reason: null,
|
||||
}
|
||||
|
||||
function run(supabase: unknown, extra: Record<string, unknown> = {}) {
|
||||
return match.execute(
|
||||
{ transaction_id: TX_ID, invoice_id: INV_ID, ...extra },
|
||||
'company-1',
|
||||
'user-1',
|
||||
supabase as never,
|
||||
{ type: 'api_key' } as never,
|
||||
)
|
||||
}
|
||||
|
||||
function enqueuePreGuard(enqueue: (r: { data?: unknown; error?: unknown }) => void) {
|
||||
enqueue({ data: txRow, error: null })
|
||||
enqueue({ data: invoiceRow, error: null })
|
||||
}
|
||||
|
||||
function enqueueStage(enqueue: (r: { data?: unknown; error?: unknown }) => void) {
|
||||
enqueue({ data: { bookkeeping_locked_through: null }, error: null }) // company_settings
|
||||
enqueue({ data: { id: 'fp-1', is_closed: false, locked_at: null }, error: null }) // fiscal_periods
|
||||
enqueue({ data: { id: 'op-match-1' }, error: null }) // pending_operations insert
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
mockDetectCandidate.mockResolvedValue(null)
|
||||
})
|
||||
|
||||
describe('gnubok_match_transaction_to_invoice: soft-duplicate guard at stage time', () => {
|
||||
it('refuses to stage, coded MATCH_INVOICE_POSSIBLE_DUPLICATE, naming the voucher, the link tool and the force binding', async () => {
|
||||
mockDetectCandidate.mockResolvedValue(candidate)
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
const err = await run(supabase).then(() => null, (e: Error & { code?: string }) => e)
|
||||
expect(err).toBeInstanceOf(Error)
|
||||
expect(err!.code).toBe('MATCH_INVOICE_POSSIBLE_DUPLICATE')
|
||||
expect(err!.message).toContain('verifikat A12')
|
||||
expect(err!.message).toContain('gnubok_link_transaction_to_journal_entry')
|
||||
expect(err!.message).toContain(`expected_journal_entry_id="${JE_MANUAL}"`)
|
||||
expect(mockDetectCandidate).toHaveBeenCalledWith(
|
||||
supabase,
|
||||
expect.objectContaining({ companyId: 'company-1', transactionId: TX_ID, transactionAmount: 1000, transactionCurrency: 'SEK' }),
|
||||
)
|
||||
const tables = (supabase.from as ReturnType<typeof vi.fn>).mock.calls.map((c) => c[0])
|
||||
expect(tables).not.toContain('pending_operations')
|
||||
})
|
||||
|
||||
it('stages with a compliance warning when force echoes the detected candidate, and persists the binding', async () => {
|
||||
mockDetectCandidate.mockResolvedValue(candidate)
|
||||
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
enqueueStage(enqueue)
|
||||
|
||||
const result = (await run(supabase, { force: true, expected_journal_entry_id: JE_MANUAL })) as {
|
||||
staged: boolean
|
||||
operation_id?: string
|
||||
preview: Record<string, unknown>
|
||||
}
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.operation_id).toBe('op-match-1')
|
||||
expect(result.preview.compliance_warning).toContain('A12')
|
||||
const inserted = findCall('pending_operations', 'insert')?.[0] as { params: Record<string, unknown> }
|
||||
expect(inserted.params).toMatchObject({
|
||||
transaction_id: TX_ID,
|
||||
invoice_id: INV_ID,
|
||||
force: true,
|
||||
expected_journal_entry_id: JE_MANUAL,
|
||||
})
|
||||
})
|
||||
|
||||
it('refuses a stale force id as MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH', async () => {
|
||||
mockDetectCandidate.mockResolvedValue(candidate)
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
const err = await run(supabase, { force: true, expected_journal_entry_id: JE_OTHER }).then(
|
||||
() => null,
|
||||
(e: Error & { code?: string }) => e,
|
||||
)
|
||||
expect(err!.code).toBe('MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH')
|
||||
expect(err!.message).toContain(JE_OTHER)
|
||||
expect(err!.message).toContain(JE_MANUAL)
|
||||
})
|
||||
|
||||
it('refuses force when no candidate is detected any more (force is moot)', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
await expect(run(supabase, { force: true, expected_journal_entry_id: JE_MANUAL })).rejects.toMatchObject({
|
||||
code: 'MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH',
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects force without expected_journal_entry_id before any query runs', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(run(supabase, { force: true })).rejects.toMatchObject({ code: 'VALIDATION_ERROR' })
|
||||
expect(supabase.from).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('rejects a non-string expected_journal_entry_id at the boundary instead of silently dropping it', async () => {
|
||||
for (const bad of [42, '', [JE_MANUAL]]) {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(run(supabase, { expected_journal_entry_id: bad })).rejects.toMatchObject({ code: 'VALIDATION_ERROR' })
|
||||
expect(supabase.from).not.toHaveBeenCalled()
|
||||
}
|
||||
})
|
||||
|
||||
it('fails open when the detector throws without force, but the approval card says the check did not run', async () => {
|
||||
mockDetectCandidate.mockRejectedValue(new Error('scan failed'))
|
||||
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
enqueueStage(enqueue)
|
||||
|
||||
const result = (await run(supabase)) as { staged: boolean; preview: Record<string, unknown> }
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.preview.compliance_warning).toContain('Dubblettkontrollen kunde inte köras')
|
||||
// Persisted with the op: MatchTransactionInvoicePreview renders it on /pending.
|
||||
const inserted = findCall('pending_operations', 'insert')?.[0] as { preview_data: Record<string, unknown> }
|
||||
expect(inserted.preview_data.compliance_warning).toContain('Dubblettkontrollen kunde inte köras')
|
||||
})
|
||||
|
||||
it('refuses force=true when the detector throws: an override that cannot be re-verified is never staged', async () => {
|
||||
mockDetectCandidate.mockRejectedValue(new Error('scan failed'))
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
|
||||
await expect(run(supabase, { force: true, expected_journal_entry_id: JE_MANUAL })).rejects.toMatchObject({
|
||||
code: 'MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH',
|
||||
})
|
||||
const tables = (supabase.from as ReturnType<typeof vi.fn>).mock.calls.map((c) => c[0])
|
||||
expect(tables).not.toContain('pending_operations')
|
||||
})
|
||||
|
||||
it('stages a clean match without a binding or a warning', async () => {
|
||||
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
||||
enqueuePreGuard(enqueue)
|
||||
enqueueStage(enqueue)
|
||||
|
||||
const result = (await run(supabase)) as { staged: boolean; preview: Record<string, unknown> }
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.preview.compliance_warning).toBeUndefined()
|
||||
const inserted = findCall('pending_operations', 'insert')?.[0] as { params: Record<string, unknown> }
|
||||
expect(inserted.params).toEqual({ transaction_id: TX_ID, invoice_id: INV_ID })
|
||||
})
|
||||
})
|
||||
@@ -390,6 +390,20 @@ describe('tools/list payload size guard', () => {
|
||||
// description, no example; the lookup itself now goes through the
|
||||
// shared resolver with the cache, so the case is also rarer.
|
||||
//
|
||||
// * Held at 60K with the force binding on the two match tools
|
||||
// (2026-09-06, #2294): force + expected_journal_entry_ids on
|
||||
// gnubok_match_batch_allocate and force + expected_journal_entry_id on
|
||||
// gnubok_match_transaction_to_invoice, the override an agent needs
|
||||
// once the already-explained guard refuses at stage time (the refusal
|
||||
// message carries the exact ids to echo, so the property descriptions
|
||||
// are one clause each). ~100 tokens against 93 of headroom, paid for
|
||||
// inside the same two tools: the two "UUID of ..." property
|
||||
// descriptions on the single tool dropped (names are the contract, as
|
||||
// on the batch tool), and the batch tool's "Use when ..." sentence
|
||||
// folded into its first sentence. Measured 59 988 on the accounted
|
||||
// projection after the trims; headroom is 12, so the next addition
|
||||
// demotes a read first.
|
||||
//
|
||||
// Long-term answer to growth is no longer a ceiling bump. gnubok_call_tool
|
||||
// makes `catalogVisibility: 'search'` usable for READ tools on hosts that
|
||||
// can only invoke what tools/list showed them, which is the constraint that
|
||||
|
||||
@@ -272,6 +272,13 @@ import { getSuggestedCategories, buildMerchantHistory, merchantHistoryFor } from
|
||||
import { detectBookingDuplicate } from '@/lib/transactions/booking-duplicate-detection'
|
||||
import { buildDuplicateBookingClaim } from '@/lib/transactions/categorize-core'
|
||||
import { findDuplicatePaymentCandidatesForInvoice } from '@/lib/invoices/duplicate-payment-candidates'
|
||||
import {
|
||||
describeExplainingSet,
|
||||
guardAlreadyExplained,
|
||||
guardDuplicatePaymentVoucher,
|
||||
type AlreadyExplainedOutcome,
|
||||
type DuplicateCandidateOutcome,
|
||||
} from '@/lib/invoices/already-explained-guard'
|
||||
import { getEmailService } from '@/lib/email/service'
|
||||
import { hasCapability, capabilityBlockedError } from '@/lib/entitlements/has-capability'
|
||||
import { MCP_TOOL_CAPABILITY_MAP } from '@/lib/entitlements/keys'
|
||||
@@ -558,6 +565,79 @@ function registryError(code: string): Error {
|
||||
return Object.assign(new Error(getErrorEntry(code)?.message_sv ?? code), { code })
|
||||
}
|
||||
|
||||
/**
|
||||
* The already-explained refusal for gnubok_match_batch_allocate, coded
|
||||
* BATCH_TX_POSSIBLE_DUPLICATE (same code the dashboard route answers with).
|
||||
* The MCP error envelope carries no `details`, so the vouchers, the link
|
||||
* call that resolves the row and the exact force binding are all in the
|
||||
* message: that is what the agent reads. One voucher is also linkable
|
||||
* through gnubok_link_transaction_to_journal_entry (which can settle a
|
||||
* kundfaktura at the same time); several need the bank 1:N pair on
|
||||
* gnubok_reconcile_match.
|
||||
*/
|
||||
function alreadyExplainedRefusal(
|
||||
outcome: Extract<AlreadyExplainedOutcome, { status: 'blocked' }>,
|
||||
transactionId: string,
|
||||
cashAccountId: string | null,
|
||||
): Error {
|
||||
const { set } = outcome
|
||||
const ids = set.vouchers.map((v) => v.journal_entry_id)
|
||||
const accountKey = `bank:${cashAccountId ?? '<cash_account_id>'}`
|
||||
const link =
|
||||
ids.length === 1
|
||||
? `gnubok_link_transaction_to_journal_entry (transaction_id="${transactionId}", journal_entry_id="${ids[0]}", invoice_id om en kundfaktura ska markeras betald samtidigt) ` +
|
||||
`eller gnubok_reconcile_match (account_key "${accountKey}", pairs [{ external_ids: ["${transactionId}"], journal_entry_ids: ["${ids[0]}"] }])`
|
||||
: `gnubok_reconcile_match (account_key "${accountKey}", pairs [{ external_ids: ["${transactionId}"], journal_entry_ids: ${JSON.stringify(ids)}, allocations: [{ journal_entry_id, amount }] per verifikat, summan = radens belopp })`
|
||||
const message = outcome.force_rejected
|
||||
? `force=true avvisad: expected_journal_entry_ids är inte exakt de verifikat som förklarar raden just nu (${describeExplainingSet(set)}). ` +
|
||||
`Koppla raden till dem i stället: ${link}. Om raden verkligen är en separat affärshändelse: anropa igen med force=true och expected_journal_entry_ids=${JSON.stringify(ids)}.`
|
||||
: `Transaktionen ser redan ut att vara bokförd som ${describeExplainingSet(set)}: bokförda verifikat utan bankkoppling på kontot summerar exakt till beloppet. ` +
|
||||
`Bokför inte igen; koppla raden till dem: ${link}. Endast om raden verkligen är en separat affärshändelse: anropa igen med force=true och expected_journal_entry_ids=${JSON.stringify(ids)}.`
|
||||
return Object.assign(new Error(message), { code: 'BATCH_TX_POSSIBLE_DUPLICATE' })
|
||||
}
|
||||
|
||||
/**
|
||||
* Staged into preview.compliance_warning when a duplicate / already-explained
|
||||
* check threw at stage time without force. The stage fails open (the commit
|
||||
* executor re-runs the check as the hard gate), but the approver must see
|
||||
* that the check did not run rather than approve as if it had.
|
||||
*/
|
||||
const DUPLICATE_CHECK_FAILED_NOTE =
|
||||
'Dubblettkontrollen kunde inte köras vid stagingen: kontrollera manuellt att raden inte redan är bokförd ' +
|
||||
'(verifikat utan bankkoppling på kontot) innan du godkänner. Kontrollen körs igen vid godkännandet.'
|
||||
|
||||
/**
|
||||
* The soft-duplicate refusal for gnubok_match_transaction_to_invoice, coded
|
||||
* like the dashboard route: MATCH_INVOICE_POSSIBLE_DUPLICATE without force,
|
||||
* MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH when force names a stale or absent
|
||||
* candidate.
|
||||
*/
|
||||
function duplicateCandidateRefusal(
|
||||
outcome: Extract<DuplicateCandidateOutcome, { status: 'blocked' | 'mismatch' }>,
|
||||
): Error {
|
||||
if (outcome.status === 'mismatch') {
|
||||
return Object.assign(
|
||||
new Error(
|
||||
`force=true avvisad: expected_journal_entry_id ${outcome.expected_journal_entry_id ?? '(saknas)'} är inte den verifikation dubblettkontrollen hittar just nu ` +
|
||||
`(${outcome.detected_journal_entry_id ?? 'ingen dubblett hittad: anropa igen utan force'}).`,
|
||||
),
|
||||
{ code: 'MATCH_INVOICE_FORCE_CANDIDATE_MISMATCH' },
|
||||
)
|
||||
}
|
||||
const c = outcome.candidate
|
||||
const amount = c.amount_verified
|
||||
? `${c.amount.toLocaleString('sv-SE', { minimumFractionDigits: 2, maximumFractionDigits: 2 })} kr`
|
||||
: 'belopp ej verifierat: raden saknar SEK-värde'
|
||||
return Object.assign(
|
||||
new Error(
|
||||
`Möjlig dubblettbokföring: verifikat ${c.voucher_label} (${c.entry_date}, konto ${c.bank_account_number}, ${amount}) ser redan ut att bokföra den här betalningen. ` +
|
||||
`Koppla transaktionen till den i stället: gnubok_link_transaction_to_journal_entry (journal_entry_id="${c.journal_entry_id}", invoice_id för att markera fakturan betald samtidigt). ` +
|
||||
`Endast om det verkligen är en separat betalning: anropa igen med force=true och expected_journal_entry_id="${c.journal_entry_id}".`,
|
||||
),
|
||||
{ code: 'MATCH_INVOICE_POSSIBLE_DUPLICATE' },
|
||||
)
|
||||
}
|
||||
|
||||
interface McpTool {
|
||||
name: string
|
||||
// Top-level Tool.title per MCP spec 2025-06-18 (human-facing label for
|
||||
@@ -10708,13 +10788,15 @@ export const tools: McpTool[] = [
|
||||
name: 'gnubok_match_transaction_to_invoice',
|
||||
keywords: ['matcha betalning', 'kundfaktura', 'inbetalning'],
|
||||
title: 'Match Transaction to Invoice',
|
||||
description: 'Match a bank transaction (income, amount>0) to a customer invoice. Confirm tx date/amount and invoice number/customer before staging. Supports partial payments and auto-storno of prior categorization.',
|
||||
description: 'Match 1 bank tx (income, amount>0) to a customer invoice. Confirm tx date/amount and invoice number first. Partial payments and auto-storno of a prior categorization supported. Stages.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
transaction_id: { type: 'string', description: 'UUID of the bank transaction' },
|
||||
invoice_id: { type: 'string', description: 'UUID of the invoice to match' },
|
||||
transaction_id: { type: 'string' },
|
||||
invoice_id: { type: 'string' },
|
||||
force: { type: 'boolean', description: 'Override a MATCH_INVOICE_POSSIBLE_DUPLICATE refusal.' },
|
||||
expected_journal_entry_id: { type: 'string', description: 'With force: the id the refusal named.' },
|
||||
},
|
||||
required: ['transaction_id', 'invoice_id'],
|
||||
},
|
||||
@@ -10724,11 +10806,26 @@ export const tools: McpTool[] = [
|
||||
const transactionId = args.transaction_id as string
|
||||
const invoiceId = args.invoice_id as string
|
||||
if (!transactionId || !invoiceId) throw new Error('transaction_id and invoice_id are required')
|
||||
// No host validates inputSchema at runtime: check the override shape
|
||||
// here so a malformed binding is a validation error, never a silently
|
||||
// dropped one that then reads as a force mismatch.
|
||||
const force = args.force === true
|
||||
if (
|
||||
args.expected_journal_entry_id !== undefined &&
|
||||
(typeof args.expected_journal_entry_id !== 'string' || !args.expected_journal_entry_id)
|
||||
) {
|
||||
throw codedError('VALIDATION_ERROR', 'expected_journal_entry_id must be a journal_entry_id string')
|
||||
}
|
||||
const expectedJournalEntryId = args.expected_journal_entry_id as string | undefined
|
||||
if (force && !expectedJournalEntryId) {
|
||||
throw codedError('VALIDATION_ERROR', 'expected_journal_entry_id is required when force=true')
|
||||
}
|
||||
|
||||
// Validate both exist and are matchable
|
||||
// Validate both exist and are matchable. amount_sek / exchange_rate feed
|
||||
// the duplicate guard: it compares this bank line against SEK ledger legs.
|
||||
const { data: transaction, error: txError } = await supabase
|
||||
.from('transactions')
|
||||
.select('id, description, merchant_name, amount, currency, date, invoice_id')
|
||||
.select('id, description, merchant_name, amount, currency, amount_sek, exchange_rate, date, invoice_id')
|
||||
.eq('id', transactionId)
|
||||
.eq('company_id', companyId)
|
||||
.single()
|
||||
@@ -10754,11 +10851,44 @@ export const tools: McpTool[] = [
|
||||
throw new Error('Invoice is not in a matchable state (must be sent, overdue, or partially_paid)')
|
||||
}
|
||||
|
||||
// Soft-duplicate guard at stage time (parity with the dashboard match
|
||||
// route's MATCH_INVOICE_POSSIBLE_DUPLICATE): a manual verifikation that
|
||||
// already books this receipt is surfaced NOW, so the agent links the
|
||||
// row to it instead of queuing a second voucher for approval. The
|
||||
// commit executor re-runs the same guard as the hard gate, re-binding
|
||||
// force to the candidate detected then (issue #2294).
|
||||
// A detector failure without force fails open, but never silently:
|
||||
// the approval card carries the warning (preview.compliance_warning)
|
||||
// so the approver knows the check did not run. With force the guard
|
||||
// returns a mismatch, refused below.
|
||||
let duplicateCheckFailed = false
|
||||
const duplicate = await guardDuplicatePaymentVoucher(
|
||||
supabase,
|
||||
companyId,
|
||||
transaction,
|
||||
{ force, expected_journal_entry_id: expectedJournalEntryId },
|
||||
{
|
||||
onDetectError: (err) => {
|
||||
duplicateCheckFailed = true
|
||||
log.warn('match_transaction_to_invoice: duplicate detection failed (continuing)', { error: err instanceof Error ? err.message : String(err) })
|
||||
},
|
||||
},
|
||||
)
|
||||
if (duplicate.status === 'blocked' || duplicate.status === 'mismatch') {
|
||||
throw duplicateCandidateRefusal(duplicate)
|
||||
}
|
||||
|
||||
const txDesc = transaction.merchant_name || transaction.description || transactionId
|
||||
|
||||
return stagePendingOperation(supabase, companyId, userId, 'match_transaction_invoice',
|
||||
`Matcha: ${txDesc} → ${invoice.invoice_number}`,
|
||||
{ transaction_id: transactionId, invoice_id: invoiceId },
|
||||
{
|
||||
transaction_id: transactionId,
|
||||
invoice_id: invoiceId,
|
||||
// The binding travels with the op so the commit executor can
|
||||
// re-validate it against the candidate detected at commit time.
|
||||
...(force ? { force: true, expected_journal_entry_id: expectedJournalEntryId } : {}),
|
||||
},
|
||||
{
|
||||
transaction_description: txDesc,
|
||||
transaction_amount: transaction.amount,
|
||||
@@ -10777,7 +10907,20 @@ export const tools: McpTool[] = [
|
||||
{
|
||||
description: 'After approval the transaction is linked and the invoice is marked paid. Use gnubok_get_ar_ledger to verify the customer balance.',
|
||||
tool: 'gnubok_get_ar_ledger',
|
||||
}
|
||||
},
|
||||
{
|
||||
dateForPeriodCheck: transaction.date,
|
||||
// Never silent: an honoured override names the voucher it books
|
||||
// over, and a check that could not run says so, on the approval
|
||||
// card and to the agent alike.
|
||||
...(duplicate.status === 'overridden'
|
||||
? {
|
||||
complianceNote: `Bokförs trots att verifikat ${duplicate.candidate.voucher_label} (${duplicate.candidate.entry_date}) redan ser ut att bokföra betalningen (force=true).`,
|
||||
}
|
||||
: duplicateCheckFailed
|
||||
? { complianceNote: DUPLICATE_CHECK_FAILED_NOTE }
|
||||
: {}),
|
||||
},
|
||||
)
|
||||
},
|
||||
},
|
||||
@@ -10786,7 +10929,7 @@ export const tools: McpTool[] = [
|
||||
name: 'gnubok_match_batch_allocate',
|
||||
keywords: ['klumpbetalning', 'fördela betalning', 'matcha betalningar'],
|
||||
title: 'Batch-Allocate Payment',
|
||||
description: 'Allocate 1 bank tx across N customer OR N supplier invoices (samlingsbetalning, BFL 5 kap 6§). Use when one receipt covers many invoices or one transfer pays many bills. Stages.',
|
||||
description: 'Allocate 1 bank tx across N customer OR N supplier invoices: one receipt covering many invoices, one transfer paying many bills (samlingsbetalning, BFL 5 kap 6§). Stages.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
@@ -10808,6 +10951,8 @@ export const tools: McpTool[] = [
|
||||
required: ['kind', 'amount'],
|
||||
},
|
||||
},
|
||||
force: { type: 'boolean', description: 'Override a BATCH_TX_POSSIBLE_DUPLICATE refusal.' },
|
||||
expected_journal_entry_ids: { type: 'array', items: { type: 'string' }, maxItems: 10, description: 'With force: exactly the ids the refusal named.' },
|
||||
},
|
||||
required: ['transaction_id', 'allocations'],
|
||||
},
|
||||
@@ -10825,6 +10970,25 @@ export const tools: McpTool[] = [
|
||||
if (!Array.isArray(allocations) || allocations.length === 0) {
|
||||
throw new Error('allocations is required (non-empty array)')
|
||||
}
|
||||
// No host validates inputSchema at runtime: check the override shape
|
||||
// here (array, 1 to 10 strings, the schema's contract) so a malformed
|
||||
// binding is a validation error, never a silently filtered one that
|
||||
// then reads as a force mismatch.
|
||||
const force = args.force === true
|
||||
const rawExpectedIds = args.expected_journal_entry_ids
|
||||
if (
|
||||
rawExpectedIds !== undefined &&
|
||||
(!Array.isArray(rawExpectedIds) ||
|
||||
rawExpectedIds.length === 0 ||
|
||||
rawExpectedIds.length > 10 ||
|
||||
rawExpectedIds.some((v) => typeof v !== 'string' || !v))
|
||||
) {
|
||||
throw codedError('VALIDATION_ERROR', 'expected_journal_entry_ids must be an array of 1 to 10 journal_entry_id strings')
|
||||
}
|
||||
const expectedJournalEntryIds = rawExpectedIds as string[] | undefined
|
||||
if (force && !expectedJournalEntryIds) {
|
||||
throw codedError('VALIDATION_ERROR', 'expected_journal_entry_ids is required when force=true')
|
||||
}
|
||||
// kind is the key every guard below branches on (direction, required
|
||||
// id, tenant pre-check). With kind absent, none of them fired: an
|
||||
// incoming +50 359 SEK payment against three kundfakturor staged as
|
||||
@@ -10841,9 +11005,11 @@ export const tools: McpTool[] = [
|
||||
}
|
||||
}
|
||||
|
||||
// amount_sek / exchange_rate / cash_account_id feed the already-explained
|
||||
// guard below: it sums SEK legs on the row's own settlement account.
|
||||
const { data: transaction, error: txError } = await supabase
|
||||
.from('transactions')
|
||||
.select('id, description, merchant_name, amount, currency, date, journal_entry_id')
|
||||
.select('id, description, merchant_name, amount, currency, amount_sek, exchange_rate, cash_account_id, date, journal_entry_id')
|
||||
.eq('id', transactionId)
|
||||
.eq('company_id', companyId)
|
||||
.single()
|
||||
@@ -10953,6 +11119,37 @@ export const tools: McpTool[] = [
|
||||
)
|
||||
}
|
||||
|
||||
// Already-explained guard at stage time: the same detector + force
|
||||
// binding the dashboard route runs (lib/invoices/already-explained-
|
||||
// guard.ts). A Bankgirot aggregate whose invoices were each marked paid
|
||||
// by hand is refused HERE, with the vouchers named, so the agent links
|
||||
// the row to them instead of asking the user to approve a second
|
||||
// booking. The commit executor re-runs the guard as the hard gate
|
||||
// (issue #2294).
|
||||
// A detector failure without force fails open, but never silently:
|
||||
// the approval card carries the warning (preview.compliance_warning,
|
||||
// rendered by GenericPreview) so the approver knows the check did not
|
||||
// run. With force the guard returns 'unverifiable', refused below.
|
||||
let explainedCheckFailed = false
|
||||
const explained = await guardAlreadyExplained(
|
||||
supabase,
|
||||
companyId,
|
||||
transaction,
|
||||
{ force, expected_journal_entry_ids: expectedJournalEntryIds },
|
||||
{
|
||||
onDetectError: (err) => {
|
||||
explainedCheckFailed = true
|
||||
log.warn('match_batch_allocate: explaining-voucher detection failed (continuing)', { error: err instanceof Error ? err.message : String(err) })
|
||||
},
|
||||
},
|
||||
)
|
||||
if (explained.status === 'blocked') {
|
||||
throw alreadyExplainedRefusal(explained, transactionId, transaction.cash_account_id ?? null)
|
||||
}
|
||||
if (explained.status === 'unverifiable') {
|
||||
throw registryError('BATCH_TX_EXPLAINED_CHECK_FAILED')
|
||||
}
|
||||
|
||||
const txDesc = transaction.merchant_name || transaction.description || transactionId
|
||||
// Swedish plurals: kundfaktura → kundfakturor (not kundfakturaor).
|
||||
// Same for leverantörsfaktura → leverantörsfakturor.
|
||||
@@ -10961,7 +11158,13 @@ export const tools: McpTool[] = [
|
||||
|
||||
return stagePendingOperation(supabase, companyId, userId, 'match_batch_allocate',
|
||||
`Fördela: ${txDesc} → ${summary}`,
|
||||
{ transaction_id: transactionId, allocations },
|
||||
{
|
||||
transaction_id: transactionId,
|
||||
allocations,
|
||||
// The binding travels with the op so the commit executor can
|
||||
// re-validate it against the set detected at commit time.
|
||||
...(force ? { force: true, expected_journal_entry_ids: expectedJournalEntryIds } : {}),
|
||||
},
|
||||
// GDPR Art.25: transaction_description is included in preview_data
|
||||
// so the user can recognise the tx at approval time (merchant_name
|
||||
// or fallback to bank description). Same trade-off documented on
|
||||
@@ -10983,7 +11186,19 @@ export const tools: McpTool[] = [
|
||||
description: 'After approval the combined verifikat is created and each invoice is advanced. Verify with gnubok_get_ar_ledger (customer) or gnubok_get_supplier_ledger.',
|
||||
tool: hasCustomer ? 'gnubok_get_ar_ledger' : 'gnubok_get_supplier_ledger',
|
||||
},
|
||||
{ dateForPeriodCheck: transaction.date }
|
||||
{
|
||||
dateForPeriodCheck: transaction.date,
|
||||
// Never silent: an honoured override names the vouchers it books
|
||||
// over, and a check that could not run says so, on the approval
|
||||
// card and to the agent alike.
|
||||
...(explained.status === 'overridden'
|
||||
? {
|
||||
complianceNote: `Bokförs trots att ${describeExplainingSet(explained.set)} redan förklarar raden (force=true).`,
|
||||
}
|
||||
: explainedCheckFailed
|
||||
? { complianceNote: DUPLICATE_CHECK_FAILED_NOTE }
|
||||
: {}),
|
||||
},
|
||||
)
|
||||
},
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user