fix(salary): surface employee-save failures and a typed 503 for the missing encryption key (#1996) (#2009)
* fix(salary): surface employee-save failures in the dialog and type the missing encryption key (#1996) Pressing Spara in "Ny anställd" could fail without any feedback: a thrown fetch or a non-JSON 5xx body escaped handleSubmit before setSaving(false) ran, leaving the button stuck on "Sparar..." and the dialog silent. Even when the toast did fire, the Radix modal aria-hides the root-layout Toaster, so assistive tech (and the E2E driver that found this) heard nothing, and the requestId support needs was never shown anywhere. - NewEmployeeDialog: fetch + parse run in a never-throwing helper, saving is released in finally, the body is parsed with json().catch(() => null) so an HTML/plain-text error page still maps through the HTTP-status map, and the failure is rendered inline (role="alert" in the footer) with "Ärende-id: <requestId>" next to the single destructive toast. - personnummer.ts: the production "key missing" throw now carries the registry code PERSONNUMMER_ENCRYPTION_NOT_CONFIGURED, and the SALARY registry gains a 503 entry naming PERSONNUMMER_ENCRYPTION_KEY with a "contact support" message and a remediation hint. withRouteContext emits the typed envelope automatically instead of INTERNAL_ERROR 500, which read as transient and invited retries that can never succeed. - Tests for the route (401, 400, 503 with requestId and no insert), the key guard, the registry entry, errorResponse dispatch on a coded Error, and getErrorMessage locale handling of the new envelope. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna * fix(salary): address review findings (#1996) - NewEmployeeDialog: fall back to the X-Request-Id response header when the body carries no error.requestId. The route hand-builds its 409 (duplicate personnummer) and generic insert-failure 500 bodies as flat strings, so the inline "Ärende-id" line was hidden for exactly the DB-failure class the issue names; withRouteContext sets the header on every response. - Route tests pin that the 409 and 500 insert-error arms carry X-Request-Id. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
Jakob Wennberg
parent
89ce837947
commit
ca93ef3fb6
+2
-1
@@ -1169,7 +1169,8 @@
|
||||
"hourly_suffix": "/hr",
|
||||
"employment_employee": "Employee",
|
||||
"employment_company_owner": "Company owner",
|
||||
"employment_board_member": "Board member"
|
||||
"employment_board_member": "Board member",
|
||||
"save_error_request_id": "Reference: {id}"
|
||||
},
|
||||
"register": {
|
||||
"subtitle": "Create an account to get started",
|
||||
|
||||
+2
-1
@@ -1169,7 +1169,8 @@
|
||||
"hourly_suffix": "/tim",
|
||||
"employment_employee": "Anställd",
|
||||
"employment_company_owner": "Företagsledare",
|
||||
"employment_board_member": "Styrelseledamot"
|
||||
"employment_board_member": "Styrelseledamot",
|
||||
"save_error_request_id": "Ärende-id: {id}"
|
||||
},
|
||||
"register": {
|
||||
"subtitle": "Skapa ett konto för att komma igång",
|
||||
|
||||
Reference in New Issue
Block a user