fix(salary): surface employee-save failures and a typed 503 for the missing encryption key (#1996) (#2009)
* fix(salary): surface employee-save failures in the dialog and type the missing encryption key (#1996) Pressing Spara in "Ny anställd" could fail without any feedback: a thrown fetch or a non-JSON 5xx body escaped handleSubmit before setSaving(false) ran, leaving the button stuck on "Sparar..." and the dialog silent. Even when the toast did fire, the Radix modal aria-hides the root-layout Toaster, so assistive tech (and the E2E driver that found this) heard nothing, and the requestId support needs was never shown anywhere. - NewEmployeeDialog: fetch + parse run in a never-throwing helper, saving is released in finally, the body is parsed with json().catch(() => null) so an HTML/plain-text error page still maps through the HTTP-status map, and the failure is rendered inline (role="alert" in the footer) with "Ärende-id: <requestId>" next to the single destructive toast. - personnummer.ts: the production "key missing" throw now carries the registry code PERSONNUMMER_ENCRYPTION_NOT_CONFIGURED, and the SALARY registry gains a 503 entry naming PERSONNUMMER_ENCRYPTION_KEY with a "contact support" message and a remediation hint. withRouteContext emits the typed envelope automatically instead of INTERNAL_ERROR 500, which read as transient and invited retries that can never succeed. - Tests for the route (401, 400, 503 with requestId and no insert), the key guard, the registry entry, errorResponse dispatch on a coded Error, and getErrorMessage locale handling of the new envelope. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna * fix(salary): address review findings (#1996) - NewEmployeeDialog: fall back to the X-Request-Id response header when the body carries no error.requestId. The route hand-builds its 409 (duplicate personnummer) and generic insert-failure 500 bodies as flat strings, so the inline "Ärende-id" line was hidden for exactly the DB-failure class the issue names; withRouteContext sets the header on every response. - Route tests pin that the 409 and 500 insert-error arms carry X-Request-Id. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
Jakob Wennberg
parent
89ce837947
commit
ca93ef3fb6
@@ -411,6 +411,28 @@ describe('getErrorMessage: API response body vs new Error(body.error)', () => {
|
||||
)
|
||||
})
|
||||
|
||||
// #1996: the envelope a missing PERSONNUMMER_ENCRYPTION_KEY now produces.
|
||||
it('a typed configuration-gap envelope yields the registry text per locale', () => {
|
||||
const configGap = {
|
||||
error: {
|
||||
code: 'PERSONNUMMER_ENCRYPTION_NOT_CONFIGURED',
|
||||
message:
|
||||
'Lönemodulen är inte konfigurerad: krypteringsnyckeln för personnummer (PERSONNUMMER_ENCRYPTION_KEY) saknas i driftmiljön. Kontakta supporten.',
|
||||
message_en:
|
||||
'Payroll is not configured: the personal-number encryption key (PERSONNUMMER_ENCRYPTION_KEY) is missing from the deployment environment. Contact support.',
|
||||
requestId: 'req_00000000-0000-4000-8000-000000000001',
|
||||
},
|
||||
}
|
||||
const sv = getErrorMessage(configGap, { context: 'salary', statusCode: 503, locale: 'sv' })
|
||||
expect(sv).toBe(configGap.error.message)
|
||||
const en = getErrorMessage(configGap, { context: 'salary', statusCode: 503, locale: 'en' })
|
||||
expect(en).toBe(configGap.error.message_en)
|
||||
// Neither locale falls back to the generic 503 "temporarily unavailable"
|
||||
// text: this failure is permanent until an operator sets the variable.
|
||||
expect(sv).not.toMatch(/tillfälligt/i)
|
||||
expect(en).not.toMatch(/temporarily/i)
|
||||
})
|
||||
|
||||
it('the same call handles an unparseable body via statusCode', () => {
|
||||
// `await response.json().catch(() => null)` on an HTML 403 page.
|
||||
expect(getErrorMessage(null, { statusCode: 403 })).toBe(
|
||||
|
||||
Reference in New Issue
Block a user