fix(connect): PR #1758 CodeRabbit follow-up: connector status hardening, i18n strings, doc alignment (#2098)
* fix(connect): PR #1758 CodeRabbit follow-up: harden connector status, i18n the connector-mode strings, align docs - getConnectorConfig() rebuilds baseUrl as origin + path: userinfo, query and fragment are stripped (warn-logged without the raw value) so nothing secret-shaped pasted into GNUBOK_CONNECT_URL survives into the /api/connector/status echo or the derived proxy URLs (CWE-200) - /api/connector/status responds Cache-Control: no-store on both branches (key prefix + wiring layout out of shared browser caches, CWE-525) - CWE-319 thread verified as no-change: both connector-mode helpers derive from getConnectorConfig(), which fails closed on non-https - SkatteverketConnectPanel tooltips and BankSyncNowButton gate/upsell strings moved to messages/sv.json + messages/en.json keys - DECISIONS.md: MD037 fix on line 1146 (backtick the glob), line 1147 reworded to grants-written-wiring-pending, decision lines appended (incl. declining the UpgradeNote children-append suggestion) - docs/SOVEREIGN.md availability wording aligned with SELF-HOSTING.md: infra merged, keys issued manually on request, client wiring pending Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UKZUp1nePr8sVDoLkMSxbS * docs(connect): skeptic follow-up: bank client wiring is merged (#2094), SKV pending, no keys issued until it lands Skeptic refutation on PR #2098: SOVEREIGN.md claimed the services 'do not carry traffic' while this branch already contains #2094 (EB client proxy routing), and 'issued manually on request' contradicted the standing no-key-before-full-PR6b rule while skatteverketConnectorMode() has no client consumer yet. SOVEREIGN.md, SELF-HOSTING.md and DECISIONS.md line 1147 now all say: bank client wiring merged and carries traffic with a key, Skatteverket client wiring ships in a following release, keys are not issued until it lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UKZUp1nePr8sVDoLkMSxbS --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
b74b5e3c0d
commit
ca12b1855e
@@ -309,8 +309,8 @@ function SkatteverketPersonalConnectionCard() {
|
||||
title={
|
||||
!hasSkatteverket
|
||||
? isSelfHosted()
|
||||
? 'Anslutning till Skatteverket kräver en connector-nyckel eller egna API-uppgifter'
|
||||
: 'Anslutning till Skatteverket kräver ett abonnemang'
|
||||
? t('connect_requires_connector_key')
|
||||
: t('connect_requires_subscription')
|
||||
: undefined
|
||||
}
|
||||
>
|
||||
@@ -374,8 +374,8 @@ function SkatteverketPersonalConnectionCard() {
|
||||
title={
|
||||
!hasSkatteverket
|
||||
? isSelfHosted()
|
||||
? 'Anslutning till Skatteverket kräver en connector-nyckel eller egna API-uppgifter'
|
||||
: 'Anslutning till Skatteverket kräver ett abonnemang'
|
||||
? t('connect_requires_connector_key')
|
||||
: t('connect_requires_subscription')
|
||||
: undefined
|
||||
}
|
||||
>
|
||||
|
||||
@@ -251,17 +251,17 @@ export default function BankSyncNowButton() {
|
||||
const selfHosted = isSelfHosted()
|
||||
const gateTitle = !hasBankSync
|
||||
? selfHosted
|
||||
? 'Bankkoppling kräver en connector-nyckel eller egna Enable Banking-uppgifter'
|
||||
: 'Bankkoppling kräver ett abonnemang'
|
||||
? t('bank_sync_requires_connector_key')
|
||||
: t('bank_sync_requires_subscription')
|
||||
: undefined
|
||||
const upsellNote = !hasBankSync ? (
|
||||
selfHosted ? (
|
||||
<span className="text-xs text-muted-foreground">Kräver connector-nyckel (GNUBOK_CONNECTOR_KEY).</span>
|
||||
<span className="text-xs text-muted-foreground">{t('bank_sync_upsell_connector_key')}</span>
|
||||
) : (
|
||||
<span className="text-xs text-muted-foreground">
|
||||
Kräver abonnemang.{' '}
|
||||
{t('bank_sync_upsell_subscription')}{' '}
|
||||
<a href="/settings/billing" className="underline underline-offset-2">
|
||||
Uppgradera
|
||||
{t('bank_sync_upsell_upgrade')}
|
||||
</a>
|
||||
</span>
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user