feat(parties): one suggestion per legal person, rename on rebuild, review list for SCB matches, model reading for memos (#2274)
* fix(parties): one suggestion per legal person, and a later run may rename an untouched one
Found while walking the queue end to end: two voucher keys naming the same
company ("TIC identity · … The Intelligence Company AB (publ)" and
"Utbetalning leverantörsfaktura …, The Intelligence Company AB (publ)")
became two suggestions and, after Lägg upp, two suppliers; and a suggestion
made before the legal-form anchoring kept its sentence-long name for good,
because apply_party_suggestions never touched a name.
- Suggestions whose display name is anchored on a legal form read out of
the voucher text (name_anchored) are grouped: one item, both keys as
aliases, stats summed. Such a name also attaches to an existing party
called exactly that, legal form included, unless an org number on either
side says otherwise. Registered company names are unique in Sweden; a
bank memo never groups or attaches by name.
- Migration 20260904030000: apply_party_suggestions renames a suggestion
nobody has touched (no decision, no user or registry fact) to an anchored
name from a later run, and reports 'renamed'. Confirmed and decided
parties keep their names.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(parties): read legal_name for exact-name attach; say a row is foreign instead of offering SCB
next build: ExistingParty had no legal_name, so the exact-legal-name index
did not compile. The query now selects it.
Queue rows whose voucher text places the company abroad show
"Utländskt bolag (Nederländerna), finns inte i SCB" instead of a search
that cannot succeed; the promote dialog counts them separately from rows
that merely lack an org number; the dossier shows the country.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(parties): carry country on the dossier row
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* feat(parties): one review list for SCB matches, a model reading for bank memos, refresh demoted
- Review list ("Hitta org.nr (n)" in the queue toolbar): every suggestion
SCB could hold but that lacks an org number is asked for, one row at a
time under SCB's rate limit; rows with exactly one active match are
shown ticked and approved in one click, the rest keep the per-row
picker. Nothing is written before the click.
- Model reading (lib/parties/ai-name.ts, through getAiService): when the
rules find no legal form or country in the texts, one call reads the
counterpart out of the bank memo; kept as a 'model' fact, shown as
"Läst ur verifikatet", used as the query, never as a hard key. On
demand only, never when the queue builds.
- "Uppdatera förslag" moves from the page header to a ghost button in the
toolbar: the queue builds itself now.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(parties): review list passes the dialog overflow guard; plural for match counts
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(parties): gate the model reading on the company's AI capability
Same gate as every other model call on company data: the capability the
company holds by plan and can switch off. No call, no fact, no reading
without it.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5.1
Jakob Wennberg
parent
be0478c219
commit
c6ca119e73
@@ -127,7 +127,7 @@ describe('apply_party_suggestions (pg)', () => {
|
||||
})
|
||||
|
||||
const first = await apply(c.companyId, c.userId, [item({ org_number: '556666-1012' })])
|
||||
expect(first).toEqual({ created: 1, attached: 0, identities: 1, facts: 1 })
|
||||
expect(first).toEqual({ created: 1, attached: 0, identities: 1, facts: 1, renamed: 0 })
|
||||
const party = await getPool().query<{ id: string; status: string; org_number: string; alias_keys: string[]; suggested_reason: { attach: string }; origin: string }>(
|
||||
`SELECT id, status, org_number, alias_keys, suggested_reason, origin FROM public.parties WHERE company_id = $1`,
|
||||
[c.companyId],
|
||||
@@ -141,7 +141,7 @@ describe('apply_party_suggestions (pg)', () => {
|
||||
const second = await apply(c.companyId, c.userId, [
|
||||
item({ key: 'loopia webbhotell', alias_keys: ['loopia webbhotell'], org_number: LOOPIA_ORG, identities: [{ scheme: 'bankgiro', value: '53170900', first_seen: '2026-03-10', last_seen: '2026-03-10', seen_count: 2 }] }),
|
||||
])
|
||||
expect(second).toEqual({ created: 0, attached: 1, identities: 1, facts: 0 })
|
||||
expect(second).toEqual({ created: 0, attached: 1, identities: 1, facts: 0, renamed: 0 })
|
||||
const after = await getPool().query<{ n: string; alias_keys: string[] }>(
|
||||
`SELECT (SELECT count(*) FROM public.parties WHERE company_id = $1)::text AS n, alias_keys FROM public.parties WHERE id = $2`,
|
||||
[c.companyId, partyId],
|
||||
@@ -174,6 +174,31 @@ describe('apply_party_suggestions (pg)', () => {
|
||||
expect([...rows.rows[0]!.alias_keys].sort()).toEqual(['framer utlägg', 'utlägg framer'])
|
||||
})
|
||||
|
||||
it('renames an untouched suggestion to a legal-form anchored name on a later run, never a decided one or a memo', async () => {
|
||||
const c = await seedCompany()
|
||||
await apply(c.companyId, c.userId, [{ key: 'tic identity', display_name: 'TIC identity' }])
|
||||
const renamed = await apply(c.companyId, c.userId, [
|
||||
{ key: 'tic identity', display_name: 'The Intelligence Company AB (publ)', name_anchored: true },
|
||||
])
|
||||
expect(renamed).toMatchObject({ created: 0, attached: 1, renamed: 1 })
|
||||
const after = await getPool().query<{ id: string; display_name: string }>(
|
||||
`SELECT id, display_name FROM public.parties WHERE company_id = $1`,
|
||||
[c.companyId],
|
||||
)
|
||||
expect(after.rows).toHaveLength(1)
|
||||
expect(after.rows[0]!.display_name).toBe('The Intelligence Company AB (publ)')
|
||||
|
||||
// A memo-shaped name (not anchored) never replaces anything.
|
||||
const memo = await apply(c.companyId, c.userId, [{ key: 'tic identity', display_name: 'TIC IDENTITY BG 0000005786439' }])
|
||||
expect(memo).toMatchObject({ renamed: 0 })
|
||||
// Once a person has decided on the row, no later run touches its name.
|
||||
await decide(c.companyId, c.userId, [after.rows[0]!.id], 'confirm')
|
||||
const decided = await apply(c.companyId, c.userId, [{ key: 'tic identity', display_name: 'The Intelligence Company Nordic AB', name_anchored: true }])
|
||||
expect(decided).toMatchObject({ renamed: 0 })
|
||||
const final = await getPool().query<{ display_name: string }>(`SELECT display_name FROM public.parties WHERE company_id = $1`, [c.companyId])
|
||||
expect(final.rows[0]!.display_name).toBe('The Intelligence Company AB (publ)')
|
||||
})
|
||||
|
||||
it('never merges on name: same core text becomes a second suggested party', async () => {
|
||||
const c = await seedCompany()
|
||||
await apply(c.companyId, c.userId, [{ key: 'fortnox', display_name: 'Fortnox AB', org_number: ORG }])
|
||||
|
||||
Reference in New Issue
Block a user