feat(assistant): say what the conversation is anchored to (#1222)

* feat(assistant): say what the conversation is anchored to agent_conversations.context_ref has been written since the first intents shipped and read by nothing. The panel ignored it, so a thread resumed three days later showed the messages with no indication of which invoice or which bokslut it concerned, even though the row knew. /chat did worse: it printed the ref raw, so the subtitle under someone's own conversation read "invoice:5f3a-9c21-...", a database identifier shown to an accountant. Both surfaces now render the same chip, which names the thing and links to it. This matters more since the panel docks: sitting beside the page, "what is this about" is a question the surface should answer rather than the user's memory. The mapping is a data map in route-mapping.ts, not a switch in a component (plan seam 8.5), so a flow run's ref renders in both surfaces with no change to either. A ref it cannot read renders nothing rather than a broken chip. Two refs deliberately have no link. There is no /transactions/[id] route, so a transaction chip points at the list. The document inbox is an extension mounted under /e/[sector], and core must not hardcode a path that exists only when the extension is enabled, so that one is named without being linked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(assistant): review triage: make the colon test observable, drop an overclaim The colon-splitting test asserted on a kpi ref, and kpi discards its id, so it passed even with a parser that dropped everything after the second colon. Moved to invoice:abc:2026, where the id reaches the href. Verified by switching indexOf to lastIndexOf and confirming the test fails. ContextChip's comment said a flow run's ref renders with no change to either surface. It does not: an unknown kind maps to null and renders nothing until the map gains an entry. The seam is that adding one is a single entry in one file, which is what the comment now says. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-07-27 11:26:16 +02:00
parent 60cc51fe21
commit bcbe9b0903
5 changed files with 206 additions and 7 deletions
@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest'
-import { routeToIntent } from '../route-mapping'
+import { routeToIntent, contextRefToTarget } from '../route-mapping'

 describe('routeToIntent', () => {
  it('falls back to general.help when pathname is null/undefined/empty', () => {
@@ -110,3 +110,65 @@ describe('routeToIntent', () => {
    expect(out.intentId).toBe('general.help')
  })
 })
+
+describe('contextRefToTarget', () => {
+  /**
+   * Every shape the app actually writes. Collected by grepping the call sites
+   * rather than invented, so a new intent that writes a ref this cannot read
+   * shows up as a chip that never renders, not as a wrong link.
+   */
+  it('resolves each ref the app writes today', () => {
+    expect(contextRefToTarget('invoice:abc-123')).toEqual({
+      label: 'Faktura',
+      href: '/invoices/abc-123',
+    })
+    expect(contextRefToTarget('supplier_invoice:abc-123')).toEqual({
+      label: 'Leverantörsfaktura',
+      href: '/supplier-invoices/abc-123',
+    })
+    expect(contextRefToTarget('transaction:abc-123')).toEqual({
+      label: 'Transaktion',
+      href: '/transactions',
+    })
+    expect(contextRefToTarget('verifikation:new')).toEqual({
+      label: 'Verifikation',
+      href: '/bookkeeping',
+    })
+    expect(contextRefToTarget('bokslut:overview')).toEqual({
+      label: 'Bokslut',
+      href: '/bookkeeping/year-end',
+    })
+    expect(contextRefToTarget('kpi:översikt')).toEqual({ label: 'Nyckeltal', href: '/kpi' })
+  })
+
+  it('names the document inbox without linking it', () => {
+    // It is an extension route under /e/[sector]; core cannot hardcode a path
+    // that only exists when the extension is enabled.
+    expect(contextRefToTarget('inbox:bulk')).toEqual({
+      label: 'Dokumentinkorgen',
+      href: null,
+    })
+  })
+
+  it('returns nothing rather than a broken chip for refs it cannot read', () => {
+    expect(contextRefToTarget(null)).toBeNull()
+    expect(contextRefToTarget(undefined)).toBeNull()
+    expect(contextRefToTarget('')).toBeNull()
+    expect(contextRefToTarget('invoice')).toBeNull()
+    expect(contextRefToTarget('invoice:')).toBeNull()
+    expect(contextRefToTarget(':abc')).toBeNull()
+    expect(contextRefToTarget('flow_run:abc')).toBeNull()
+  })
+
+  it('keeps ids that need escaping out of the path', () => {
+    // Ids reach this from the database, not from the router.
+    expect(contextRefToTarget('invoice:a b/c')?.href).toBe('/invoices/a%20b%2Fc')
+  })
+
+  it('keeps the id intact when it contains a colon', () => {
+    // Split on the FIRST colon. Asserted on a kind that PUTS the id in the
+    // href: kpi discards its id, so the same assertion there would pass even
+    // if the parser dropped everything after the second colon.
+    expect(contextRefToTarget('invoice:abc:2026')?.href).toBe('/invoices/abc%3A2026')
+  })
+})
@@ -113,3 +113,56 @@ export function routeToIntent(pathname: string | null | undefined): RouteIntent

  return GENERAL_HELP(pathname)
 }
+
+/**
+ * The reverse direction: what a stored `context_ref` was about.
+ *
+ * `agent_conversations.context_ref` has been written since the first intents
+ * landed and has never been read by anything. Resuming a thread from three days
+ * ago therefore showed the messages with no indication of which invoice, which
+ * verifikat, which bokslut it concerned, even though the row knew. That matters
+ * more now the panel docks beside the page: "what is this conversation anchored
+ * to" is a question the surface should answer, not the user's memory.
+ *
+ * A data map rather than a switch in a component (plan seam 8.5), so flows can
+ * add their own ref kinds here and every surface picks them up at once.
+ */
+export interface ContextRefTarget {
+  /** Human noun for the thing, already in Swedish. */
+  label: string
+  /** Where to go to look at it, or null when there is no stable page. */
+  href: string | null
+}
+
+export function contextRefToTarget(ref: string | null | undefined): ContextRefTarget | null {
+  if (!ref) return null
+  const separator = ref.indexOf(':')
+  if (separator <= 0) return null
+  const kind = ref.slice(0, separator)
+  const id = ref.slice(separator + 1)
+  if (!id) return null
+
+  switch (kind) {
+    case 'invoice':
+      return { label: 'Faktura', href: `/invoices/${encodeURIComponent(id)}` }
+    case 'supplier_invoice':
+      return { label: 'Leverantörsfaktura', href: `/supplier-invoices/${encodeURIComponent(id)}` }
+    // No /transactions/[id] route exists: the list is the only page that can
+    // show it, so that is where the chip goes rather than a link that 404s.
+    case 'transaction':
+      return { label: 'Transaktion', href: '/transactions' }
+    case 'verifikation':
+      return { label: 'Verifikation', href: '/bookkeeping' }
+    case 'bokslut':
+      return { label: 'Bokslut', href: '/bookkeeping/year-end' }
+    case 'kpi':
+      return { label: 'Nyckeltal', href: '/kpi' }
+    // The document inbox is an extension, mounted under /e/[sector]. Core must
+    // not import from @/extensions or hardcode a route that only exists when
+    // the extension is enabled, so this names the context without linking it.
+    case 'inbox':
+      return { label: 'Dokumentinkorgen', href: null }
+    default:
+      return null
+  }
+}