feat(agent): telemetry + CI-gate quick wins from the "AI systems that ship" audit (#677)
* feat(agent): telemetry completeness + durability, CI gates, commit_method provenance Quick wins from the "Building AI systems that ship" audit: - mcp.tool_called gains errorMessage (message_sv, truncated 500 chars) on all failure exits; new mcp.skill_loaded event on every gnubok_load_skill (all tiers) so atom usage is finally measurable - event_log: (event_type, created_at) index; cleanup cron keeps mcp.*/agent.* telemetry 180 days (delivery events stay 30) - CI: lint ratchet (npm run check:lint — 60 legacy errors baselined, fails only on NEW errors) and a pg-real coverage gate (migrations touching trigger/RPC/RLS/DEFERRABLE require a *.pg.test.ts change; escape hatch: -- pg-test: covered-by/skip) - journal_entries.commit_method CHECK widened with 'api_key'/'agent'; the MCP approve path records 'api_key' truthfully instead of 'user_accept' (agent_first_vision §8 P0-1). 'agent' is reserved — ALL MCP traffic (incl. claude.ai OAuth, whose access_token is a minted API key) authenticates as api_key today Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(import): derive opening balances from prior-year #UB when SIE lacks #IB (#675) SIE files exported without #IB 0 rows (only #UB -1) previously imported with zero opening balances. getEffectiveOpeningBalances() now derives IB from prior-year UB for balance-sheet accounts when explicit #IB is absent, surfaces the derivation as an info issue in the import preview, and excludes share-capital vouchers from opening-balance detection. Detection regexes are shared between parser and importer so the two checks cannot drift. 507 lib/import tests pass. (Authored in a parallel session in this checkout; included per request.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(review): address PR #677 bot findings — RoPA entry, execFileSync, gate scope note Triage of the compliance-swarm + Greptile findings: Applied: - .compliance/ropa.yaml: new mcp.telemetry processing activity declaring the 180-day mcp.*/agent.* retention, lawful basis, data categories, and the no-args/no-results minimisation (ISO A.8.10, GDPR Art.5(1)(c) — the retention split is now formally documented, referenced from the cron) - check-pg-test-coverage.mjs: execFileSync with argv array — no shell, so a hostile base-ref can't inject (ASVS V13.2.1); verified an injection attempt exits 2 without executing - check-pg-test-coverage.mjs: documented the PR-level (not per-migration) scope of the gate so reviewers know to check coverage per migration when a PR carries several risky migrations (Greptile P2) Acknowledged, no change: - errorMessage PII risk: messages are domain-mapped strings; event_log already persists far richer delivery payloads under the same RLS; now declared in ropa.yaml - cron error envelope: errorResponse maps to the canonical safe envelope and the endpoint is CRON_SECRET-gated - two-pass delete "partial state": TTL deletes are idempotent — the next daily run sweeps whatever a failed pass left behind - skill_loaded actorLabel/sessionId: mirrors the pre-existing mcp.tool_called payload; sessionId is the join key the analytics exist for Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Opus 4.8
Claude Opus 4.8
parent
076bb169f8
commit
bc61862e76
@@ -1,5 +1,12 @@
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { parseSIEFile, validateSIEFile, detectEncoding, decodeBuffer } from '../sie-parser'
|
||||
import {
|
||||
parseSIEFile,
|
||||
validateSIEFile,
|
||||
detectEncoding,
|
||||
decodeBuffer,
|
||||
getEffectiveOpeningBalances,
|
||||
hasOpeningBalanceVoucherCandidate,
|
||||
} from '../sie-parser'
|
||||
|
||||
// --- SIE content fixtures ---
|
||||
|
||||
@@ -1090,3 +1097,195 @@ describe('parseSIEFile — silent-failure diagnostic warnings', () => {
|
||||
expect(spurious).toHaveLength(0)
|
||||
})
|
||||
})
|
||||
|
||||
describe('getEffectiveOpeningBalances — derive IB from #UB -1 (issue #675)', () => {
|
||||
// Issue #675 (ro66an): some systems export no #IB 0 records — the current
|
||||
// year's IB exists only via the continuity invariant IB(0) = UB(-1).
|
||||
const SIE_NO_IB0 = [
|
||||
'#FLAGGA 0',
|
||||
'#SIETYP 4',
|
||||
'#FNAMN "Continuity AB"',
|
||||
'#RAR 0 20240101 20241231',
|
||||
'#RAR -1 20230101 20231231',
|
||||
'#KONTO 1930 "Företagskonto"',
|
||||
'#KONTO 2010 "Eget kapital"',
|
||||
'#IB -1 1930 9483.08',
|
||||
'#UB 0 1930 160406.00',
|
||||
'#UB -1 1930 37400.78',
|
||||
'#UB -1 2010 -37400.78',
|
||||
].join('\n')
|
||||
|
||||
it('derives current-year IB from #UB -1 when no #IB 0 exists (issue example)', () => {
|
||||
const parsed = parseSIEFile(SIE_NO_IB0)
|
||||
const { balances, derivedFromPriorYearUB } = getEffectiveOpeningBalances(parsed)
|
||||
|
||||
expect(derivedFromPriorYearUB).toBe(true)
|
||||
expect(balances).toEqual([
|
||||
{ yearIndex: 0, account: '1930', amount: 37400.78 },
|
||||
{ yearIndex: 0, account: '2010', amount: -37400.78 },
|
||||
])
|
||||
})
|
||||
|
||||
it('never uses #IB -1 (previous year IB) as the derivation source', () => {
|
||||
const parsed = parseSIEFile(SIE_NO_IB0)
|
||||
const { balances } = getEffectiveOpeningBalances(parsed)
|
||||
|
||||
expect(balances.some((b) => b.amount === 9483.08)).toBe(false)
|
||||
})
|
||||
|
||||
it('returns explicit #IB 0 untouched when present — #UB -1 is never merged in', () => {
|
||||
const content = [
|
||||
SIE_NO_IB0,
|
||||
'#IB 0 1930 37400.78',
|
||||
'#IB 0 2010 -37400.78',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
const { balances, derivedFromPriorYearUB } = getEffectiveOpeningBalances(parsed)
|
||||
|
||||
expect(derivedFromPriorYearUB).toBe(false)
|
||||
expect(balances).toHaveLength(2)
|
||||
expect(balances.every((b) => b.yearIndex === 0)).toBe(true)
|
||||
})
|
||||
|
||||
it('yields to an opening-balance voucher candidate — no derivation (precedence 2 beats 3)', () => {
|
||||
// The voucher serves as IB during import (tagged source_type
|
||||
// 'opening_balance'); deriving from #UB -1 as well would double-count.
|
||||
// Also the timezone regression test: the voucher date is a local-time
|
||||
// Date, so a toISOString()-based comparison would miss the FY start on
|
||||
// machines west or east of UTC and wrongly re-enable derivation.
|
||||
const content = [
|
||||
SIE_NO_IB0,
|
||||
'#VER A 1 20240101 "Ingående balans"',
|
||||
'{',
|
||||
'#TRANS 1930 {} 37400.78',
|
||||
'#TRANS 2010 {} -37400.78',
|
||||
'}',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
|
||||
expect(hasOpeningBalanceVoucherCandidate(parsed)).toBe(true)
|
||||
|
||||
const { balances, derivedFromPriorYearUB } = getEffectiveOpeningBalances(parsed)
|
||||
expect(derivedFromPriorYearUB).toBe(false)
|
||||
expect(balances).toEqual([])
|
||||
})
|
||||
|
||||
it('does not treat a share-capital voucher on FY start as an OB candidate', () => {
|
||||
const content = [
|
||||
SIE_NO_IB0,
|
||||
'#VER A 1 20240101 "Insättning aktiekapital ingående balans"',
|
||||
'{',
|
||||
'#TRANS 1930 {} 25000.00',
|
||||
'#TRANS 2081 {} -25000.00',
|
||||
'}',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
|
||||
expect(hasOpeningBalanceVoucherCandidate(parsed)).toBe(false)
|
||||
expect(getEffectiveOpeningBalances(parsed).derivedFromPriorYearUB).toBe(true)
|
||||
})
|
||||
|
||||
it('does not treat a voucher with P&L lines as an OB candidate', () => {
|
||||
const content = [
|
||||
SIE_NO_IB0,
|
||||
'#VER A 1 20240101 "Ingående balans"',
|
||||
'{',
|
||||
'#TRANS 1930 {} 1000.00',
|
||||
'#TRANS 3001 {} -1000.00',
|
||||
'}',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
|
||||
expect(hasOpeningBalanceVoucherCandidate(parsed)).toBe(false)
|
||||
expect(getEffectiveOpeningBalances(parsed).derivedFromPriorYearUB).toBe(true)
|
||||
})
|
||||
|
||||
it('does not treat an IB-worded voucher on another date as an OB candidate', () => {
|
||||
const content = [
|
||||
SIE_NO_IB0,
|
||||
'#VER A 1 20240315 "Ingående balans"',
|
||||
'{',
|
||||
'#TRANS 1930 {} 1000.00',
|
||||
'#TRANS 2010 {} -1000.00',
|
||||
'}',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
|
||||
expect(hasOpeningBalanceVoucherCandidate(parsed)).toBe(false)
|
||||
expect(getEffectiveOpeningBalances(parsed).derivedFromPriorYearUB).toBe(true)
|
||||
})
|
||||
|
||||
it('filters P&L accounts out of the derived set (result accounts open at zero)', () => {
|
||||
const content = [
|
||||
SIE_NO_IB0,
|
||||
'#UB -1 3001 -5000.00',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
const { balances } = getEffectiveOpeningBalances(parsed)
|
||||
|
||||
expect(balances.some((b) => b.account === '3001')).toBe(false)
|
||||
expect(balances).toHaveLength(2)
|
||||
})
|
||||
|
||||
it('returns nothing when neither #IB 0 nor #UB -1 exists', () => {
|
||||
const content = [
|
||||
'#FLAGGA 0',
|
||||
'#SIETYP 4',
|
||||
'#FNAMN "First Year AB"',
|
||||
'#RAR 0 20240101 20241231',
|
||||
'#KONTO 1930 "Företagskonto"',
|
||||
'#IB -1 1930 9483.08',
|
||||
'#UB 0 1930 160406.00',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
const { balances, derivedFromPriorYearUB } = getEffectiveOpeningBalances(parsed)
|
||||
|
||||
expect(derivedFromPriorYearUB).toBe(false)
|
||||
expect(balances).toEqual([])
|
||||
})
|
||||
|
||||
it('carries quantity along on derived balances', () => {
|
||||
const content = [
|
||||
SIE_NO_IB0.replace('#UB -1 1930 37400.78', '#UB -1 1930 37400.78 5'),
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
const { balances } = getEffectiveOpeningBalances(parsed)
|
||||
|
||||
expect(balances.find((b) => b.account === '1930')?.quantity).toBe(5)
|
||||
})
|
||||
|
||||
describe('validateSIEFile with derived IB', () => {
|
||||
it('warns that IB will be derived from #UB -1', () => {
|
||||
const parsed = parseSIEFile(SIE_NO_IB0)
|
||||
const validation = validateSIEFile(parsed)
|
||||
|
||||
expect(validation.valid).toBe(true)
|
||||
expect(validation.warnings.join(' ')).toMatch(/härleds från föregående års utgående balans/i)
|
||||
})
|
||||
|
||||
it('runs the imbalance check on the derived set (unallocated prior-year result)', () => {
|
||||
const content = [
|
||||
'#FLAGGA 0',
|
||||
'#SIETYP 4',
|
||||
'#FNAMN "Obalans AB"',
|
||||
'#RAR 0 20240101 20241231',
|
||||
'#KONTO 1930 "Företagskonto"',
|
||||
// Derived IB sums to +37400.78 — prior-year result never allocated
|
||||
'#UB -1 1930 37400.78',
|
||||
].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
const validation = validateSIEFile(parsed)
|
||||
|
||||
expect(validation.warnings.join(' ')).toMatch(/balanserar inte/i)
|
||||
expect(validation.warnings.join(' ')).toMatch(/37400\.78/)
|
||||
})
|
||||
|
||||
it('does not warn about derivation when explicit #IB 0 exists', () => {
|
||||
const content = [SIE_NO_IB0, '#IB 0 1930 37400.78', '#IB 0 2010 -37400.78'].join('\n')
|
||||
const parsed = parseSIEFile(content)
|
||||
const validation = validateSIEFile(parsed)
|
||||
|
||||
expect(validation.warnings.join(' ')).not.toMatch(/härleds från föregående års utgående balans/i)
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user