feat(bank-sync): close the F2 report: gap backfill, consent and paused chip states, agent-triggered sync (#2165)
* fix(bank-sync): cron backfills the gap since the last successful sync The daily incremental sync always asked the bank for the last 7 days. Any pause longer than that (a lapsed subscription paid again, a consent renewed after expiry, an outage) silently lost the days in between: the connection came back, looked healthy, and the missing transactions never arrived. The lookback now widens to cover the gap since last_synced_at plus one day of overlap, capped at the 90-day PSD2 limit, and a gap of a month or more asks for strategy=longest like the manual sync route does. Dedup via external_id makes the overlap harmless. First syncs keep their 90-day path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * feat(bank-sync): chip warns seven days before a bank consent expires The transactions-page chip only reacted once a connection was already dead (expired/error) or had gone stale. A consent that is about to end looked healthy until the morning it stopped syncing. New "expiring" state when a live connection's consent_expires is within seven days, the same threshold as the consent-expiry email in the sync cron. Precedence: attention, expiring, stale, healthy. getChipState moves to lib/transactions/bank-sync-chip-state.ts so the precedence is unit-tested; the component keeps the rendering only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * feat(bank-sync): chip says paused when the subscription lapsed The daily cron filters connections by the bank_sync capability, so a company whose trial or subscription ended keeps status=active rows with a frozen last_synced_at. The chip read that as "stale, check the connection", which sends the user to re-authorise a connection that is perfectly alive. 56 of 191 active connections on prod were in this state on 2026-09-01. New "paused" state, ranked above everything else, when the company lacks bank_sync: hosted points at billing, self-host at the connector key, the same split BankSyncNowButton already makes. getChipState takes an options object so the clock stays out of render (react-hooks/purity). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * feat(api): agent-triggerable bank sync in v1 and MCP Closes the first wish in the F2 report: an integration could read bank data but never refresh it. New POST /api/v1/companies/{id}/bank-connections/ {connectionId}/sync and MCP gnubok_sync_bank, both on a shared runner (extensions/general/enable-banking/lib/trigger-sync.ts). Cost is bounded structurally, not by policy: the window is never caller-controlled (the cron's gap-aware 7 to 90 day lookback), a connection synced within 15 minutes answers BANK_SYNC_COOLDOWN with next_allowed_at (429 + Retry-After on v1; synced=false in-band on MCP so the agent reads on instead of retrying), and a failing connection is throttled per process by attempt time. A dead session is flipped to expired with a remediation that hands the user the connect link: no API call revives a consent. Gated on bank_sync like gnubok_connect_bank; scope transactions:write. Registry, scope map, load-routes, spec snapshot and the generated accounted-api skill updated; five BANK_SYNC_* / BANK_SESSION_EXPIRED codes added to the structured-error registry. The web Synka-nu route is left as is (see DECISIONS.md). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * test(bank-sync): use the options object in the remaining chip-state calls Four multi-line calls still passed the clock positionally after getChipState moved to an options object; tsc flagged them (vitest did not, the extra argument was ignored at runtime). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * fix(api): address skeptic findings on the agent-triggered bank sync Three refutations from the pre-publish skeptic pass: 1. Core imported the extension. The v1 sync route pulled the runner straight from @/extensions, which the core-build gate rejects and which left a live bank endpoint on zero-extension builds. The route now resolves it through the registry's services channel against a contract in lib/bank-sync/trigger-sync-contract.ts (same pattern as the Skatteverket read service) and answers EXTENSION_DISABLED when the extension is absent. 2. The idempotency cache stored the handler-level 429. A same-key retry after Retry-After, which is the documented retry, replayed the stale cooldown as a 400 for the cache's 24-hour TTL. withApiV1 no longer caches 429 responses; regression test added. The endpoint's pitfall no longer claims Idempotency-Key is mandatory (it was never enforced). 3. Two cron tests read the clock twice and failed whenever a millisecond passed between the reads. They now pin the clock with fake timers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * fix(bank-sync): durable cooldown lease and review wording Resolves the PR #2165 review findings in one pass. Superagent P1: the attempt throttle was a process-local Map, so two agent calls on different serverless instances (or a retry after a cold start on a failing connection) could each bill an Enable Banking call, contradicting the one-sync-per-15-minutes promise. New bank_connections.sync_lease_until (migration 20260902150000), claimed with one conditional UPDATE before the bank is called; Postgres row locking makes exactly one claimer win, the rest answer BANK_SYNC_COOLDOWN. The lease stays for the full window on success and failure. Tests cover the claim order, a failed attempt seen from a second instance, a lost race, and an expired lease. CodeRabbit: the =1 plural branch now reads "in 1 day" / "om 1 dag" (daysUntilConsentExpiry rounds a partial day up, so "tomorrow" could be today); the cooldown pitfall on the v1 endpoint, the MCP description and the in-band cooldown instruction now say a cooldown can follow a failed attempt and tell the agent to compare last_synced_at before deciding. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub * fix(bank-sync): lease claim as a literal filter for the schema guard CI's no-phantom-columns guard counts runtime-built query expressions and its ceiling is exact; the templated `.or('sync_lease_until.is.null,...')` claim added one. The column now defaults to epoch (NOT NULL), so "never claimed" is just "expired long ago" and the atomic claim is a single literal `.lte('sync_lease_until', now)` the guard can check. Migration is unshipped (same PR), so it is edited in place. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub * fix(bank-sync): runner verifies company membership before the lease Superagent (round 3): the MCP path reached the shared runner without a membership check of its own. Both callers do enforce it upstream (withApiV1's company resolution and resolveMcpCompanyContext in the MCP dispatcher), but the runner writes transactions and bills a bank call, so it now checks company_members itself, before the cooldown and the lease claim, and answers NOT_FOUND for a non-member. The viewer check that was buried inside the sync block moves up with it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Fable 5.1
Claude Fable 5.1
parent
723a0f537b
commit
b68c082ef5
@@ -0,0 +1,153 @@
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
// Agent-triggered PSD2 sync: the MCP twin of
|
||||
// POST /api/v1/companies/{id}/bank-connections/{connectionId}/sync.
|
||||
// The runner itself is covered in extensions/general/enable-banking; this
|
||||
// file pins the tool's contract: scope, capability gate, the in-band
|
||||
// cooldown answer, and that real failures flow through the coded envelope.
|
||||
|
||||
const mocks = vi.hoisted(() => ({
|
||||
triggerConnectionSync: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('@/extensions/general/enable-banking/lib/trigger-sync', async () => {
|
||||
const actual = await vi.importActual<
|
||||
typeof import('@/extensions/general/enable-banking/lib/trigger-sync')
|
||||
>('@/extensions/general/enable-banking/lib/trigger-sync')
|
||||
return {
|
||||
...actual,
|
||||
triggerConnectionSync: (...args: unknown[]) => mocks.triggerConnectionSync(...args),
|
||||
}
|
||||
})
|
||||
|
||||
import { TOOL_SCOPE_MAP } from '@/lib/auth/api-keys'
|
||||
import { eventBus } from '@/lib/events/bus'
|
||||
import { MCP_TOOL_CAPABILITY_MAP } from '@/lib/entitlements/keys'
|
||||
import { tools } from '../server'
|
||||
|
||||
const COMPANY_ID = '11111111-1111-4111-8111-111111111111'
|
||||
const CONNECTION_ID = '22222222-2222-4222-8222-222222222222'
|
||||
const tool = tools.find((t) => t.name === 'gnubok_sync_bank')!
|
||||
|
||||
describe('gnubok_sync_bank', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
eventBus.clear()
|
||||
})
|
||||
afterEach(() => {
|
||||
vi.unstubAllEnvs()
|
||||
})
|
||||
|
||||
it('is a transactions:write tool gated on bank_sync and flagged open-world', () => {
|
||||
expect(TOOL_SCOPE_MAP.gnubok_sync_bank).toBe('transactions:write')
|
||||
expect(MCP_TOOL_CAPABILITY_MAP.gnubok_sync_bank).toBe('bank_sync')
|
||||
expect(tool.annotations.readOnlyHint).toBe(false)
|
||||
expect(tool.annotations.openWorldHint).toBe(true)
|
||||
expect(tool.inputSchema).toMatchObject({ additionalProperties: false, required: ['connection_id'] })
|
||||
})
|
||||
|
||||
it('runs the shared sync runner for the company and reports the outcome', async () => {
|
||||
mocks.triggerConnectionSync.mockResolvedValue({
|
||||
ok: true,
|
||||
connection_id: CONNECTION_ID,
|
||||
bank: 'Swedbank',
|
||||
imported: 3,
|
||||
duplicates: 12,
|
||||
from_date: '2026-08-26',
|
||||
to_date: '2026-09-02',
|
||||
last_synced_at: '2026-09-02T09:14:03.000Z',
|
||||
})
|
||||
const supabase = {} as never
|
||||
const result = (await tool.execute(
|
||||
{ connection_id: CONNECTION_ID },
|
||||
COMPANY_ID,
|
||||
'user-1',
|
||||
supabase,
|
||||
)) as Record<string, unknown>
|
||||
|
||||
expect(mocks.triggerConnectionSync).toHaveBeenCalledWith(
|
||||
supabase,
|
||||
expect.objectContaining({ companyId: COMPANY_ID, userId: 'user-1', connectionId: CONNECTION_ID }),
|
||||
)
|
||||
expect(result).toMatchObject({
|
||||
synced: true,
|
||||
connection_id: CONNECTION_ID,
|
||||
bank: 'Swedbank',
|
||||
imported: 3,
|
||||
duplicates: 12,
|
||||
last_synced_at: '2026-09-02T09:14:03.000Z',
|
||||
next_allowed_at: null,
|
||||
})
|
||||
expect(result.instructions).toContain('3 new transaction')
|
||||
})
|
||||
|
||||
it('tells the agent nothing was missing when the bank had no news', async () => {
|
||||
mocks.triggerConnectionSync.mockResolvedValue({
|
||||
ok: true,
|
||||
connection_id: CONNECTION_ID,
|
||||
bank: 'SEB',
|
||||
imported: 0,
|
||||
duplicates: 4,
|
||||
from_date: '2026-08-26',
|
||||
to_date: '2026-09-02',
|
||||
last_synced_at: '2026-09-02T09:14:03.000Z',
|
||||
})
|
||||
const result = (await tool.execute(
|
||||
{ connection_id: CONNECTION_ID },
|
||||
COMPANY_ID,
|
||||
'user-1',
|
||||
{} as never,
|
||||
)) as Record<string, unknown>
|
||||
expect(result.synced).toBe(true)
|
||||
expect(result.instructions).toContain('nothing new')
|
||||
})
|
||||
|
||||
it('answers a cooldown in-band with next_allowed_at instead of throwing', async () => {
|
||||
mocks.triggerConnectionSync.mockResolvedValue({
|
||||
ok: false,
|
||||
code: 'BANK_SYNC_COOLDOWN',
|
||||
connection_id: CONNECTION_ID,
|
||||
next_allowed_at: '2026-09-02T09:29:03.000Z',
|
||||
retry_after_seconds: 600,
|
||||
})
|
||||
const result = (await tool.execute(
|
||||
{ connection_id: CONNECTION_ID },
|
||||
COMPANY_ID,
|
||||
'user-1',
|
||||
{} as never,
|
||||
)) as Record<string, unknown>
|
||||
expect(result).toMatchObject({
|
||||
synced: false,
|
||||
connection_id: CONNECTION_ID,
|
||||
next_allowed_at: '2026-09-02T09:29:03.000Z',
|
||||
})
|
||||
expect(result.instructions).toContain('next_allowed_at')
|
||||
// A cooldown can follow a FAILED attempt too (durable lease): the agent
|
||||
// must be told to check freshness rather than assume it.
|
||||
expect(result.instructions).toContain('last_synced_at')
|
||||
})
|
||||
|
||||
it.each([
|
||||
'NOT_FOUND',
|
||||
'BANK_SYNC_NOT_ACTIVE',
|
||||
'BANK_SYNC_NO_ACCOUNTS',
|
||||
'BANK_SESSION_EXPIRED',
|
||||
'BANK_SYNC_FAILED',
|
||||
] as const)('throws a coded error for %s so the dispatch envelope carries the remediation', async (code) => {
|
||||
mocks.triggerConnectionSync.mockResolvedValue({ ok: false, code, connection_id: CONNECTION_ID })
|
||||
await expect(
|
||||
tool.execute({ connection_id: CONNECTION_ID }, COMPANY_ID, 'user-1', {} as never),
|
||||
).rejects.toMatchObject({ code })
|
||||
})
|
||||
|
||||
it('passes a blank connection_id through as an empty string (runner answers NOT_FOUND)', async () => {
|
||||
mocks.triggerConnectionSync.mockResolvedValue({ ok: false, code: 'NOT_FOUND', connection_id: '' })
|
||||
await expect(tool.execute({}, COMPANY_ID, 'user-1', {} as never)).rejects.toMatchObject({
|
||||
code: 'NOT_FOUND',
|
||||
})
|
||||
expect(mocks.triggerConnectionSync).toHaveBeenCalledWith(
|
||||
expect.anything(),
|
||||
expect.objectContaining({ connectionId: '' }),
|
||||
)
|
||||
})
|
||||
})
|
||||
@@ -251,6 +251,7 @@ import { findDuplicatePaymentCandidatesForInvoice } from '@/lib/invoices/duplica
|
||||
import { getEmailService } from '@/lib/email/service'
|
||||
import { hasCapability, capabilityBlockedError } from '@/lib/entitlements/has-capability'
|
||||
import { MCP_TOOL_CAPABILITY_MAP } from '@/lib/entitlements/keys'
|
||||
import { triggerConnectionSync } from '@/extensions/general/enable-banking/lib/trigger-sync'
|
||||
import {
|
||||
completePendingDocumentUpload,
|
||||
createPendingDocumentUpload,
|
||||
@@ -3759,6 +3760,85 @@ export const tools: McpTool[] = [
|
||||
},
|
||||
},
|
||||
|
||||
{
|
||||
name: 'gnubok_sync_bank',
|
||||
keywords: ['synka bank', 'banksynk', 'hämta banktransaktioner', 'uppdatera bank', 'synka nu'],
|
||||
title: 'Sync Bank Now',
|
||||
description:
|
||||
'Sync one PSD2 bank connection now instead of waiting for the nightly run. Use when gnubok_connect_bank shows a stale last_synced_at on an active connection. Server picks the window; synced=false with next_allowed_at means a sync ran or was attempted within 15 min.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
required: ['connection_id'],
|
||||
properties: {
|
||||
connection_id: {
|
||||
type: 'string',
|
||||
description: 'connection_id from gnubok_connect_bank.',
|
||||
},
|
||||
},
|
||||
},
|
||||
outputSchema: {
|
||||
type: 'object',
|
||||
properties: {
|
||||
synced: { type: 'boolean' },
|
||||
connection_id: { type: 'string' },
|
||||
bank: { type: ['string', 'null'] },
|
||||
imported: { type: 'integer' },
|
||||
duplicates: { type: 'integer' },
|
||||
last_synced_at: { type: ['string', 'null'] },
|
||||
next_allowed_at: { type: ['string', 'null'] },
|
||||
instructions: { type: 'string' },
|
||||
},
|
||||
required: ['synced', 'connection_id', 'instructions'],
|
||||
},
|
||||
annotations: ANNOTATIONS_WRITE_OPEN_WORLD,
|
||||
async execute(args, companyId, userId, supabase) {
|
||||
const connectionId = typeof args.connection_id === 'string' ? args.connection_id.trim() : ''
|
||||
const result = await triggerConnectionSync(supabase, {
|
||||
companyId,
|
||||
userId,
|
||||
connectionId,
|
||||
log,
|
||||
})
|
||||
|
||||
if (!result.ok) {
|
||||
// Cooldown is not a failure: the data is fresh. Say so in-band so the
|
||||
// agent reads on instead of retrying; everything else is a real
|
||||
// error and flows through the structured envelope (BANK_SYNC_* codes
|
||||
// carry the remediation, incl. "hand the user the connect link").
|
||||
if (result.code === 'BANK_SYNC_COOLDOWN') {
|
||||
return {
|
||||
synced: false,
|
||||
connection_id: result.connection_id,
|
||||
bank: null,
|
||||
last_synced_at: null,
|
||||
next_allowed_at: result.next_allowed_at ?? null,
|
||||
instructions:
|
||||
'A sync ran or was attempted on this connection within the last 15 minutes. Check last_synced_at via gnubok_connect_bank: if it is fresh, transactions and balances are already current, continue with gnubok_list_uncategorized_transactions. If it is still stale, the previous attempt failed; retry once after next_allowed_at, never before.',
|
||||
}
|
||||
}
|
||||
throw Object.assign(
|
||||
new Error(`Bank sync refused for connection ${result.connection_id}: ${result.code}`),
|
||||
{ code: result.code },
|
||||
)
|
||||
}
|
||||
|
||||
return {
|
||||
synced: true,
|
||||
connection_id: result.connection_id,
|
||||
bank: result.bank,
|
||||
imported: result.imported,
|
||||
duplicates: result.duplicates,
|
||||
last_synced_at: result.last_synced_at,
|
||||
next_allowed_at: null,
|
||||
instructions:
|
||||
result.imported > 0
|
||||
? `${result.imported} new transaction(s) fetched from the bank (${result.from_date} to ${result.to_date}). Continue with gnubok_list_uncategorized_transactions.`
|
||||
: `The bank had nothing new for ${result.from_date} to ${result.to_date}: the data was already complete. Banks report with up to 48 hours of delay, so today's transactions often arrive tomorrow; do not call again for that.`,
|
||||
}
|
||||
},
|
||||
},
|
||||
|
||||
{
|
||||
name: 'gnubok_connect_skatteverket',
|
||||
keywords: ['skatteverket', 'koppla skatteverket', 'deklarationsombud'],
|
||||
|
||||
Reference in New Issue
Block a user