feat(bank-sync): close the F2 report: gap backfill, consent and paused chip states, agent-triggered sync (#2165)
* fix(bank-sync): cron backfills the gap since the last successful sync The daily incremental sync always asked the bank for the last 7 days. Any pause longer than that (a lapsed subscription paid again, a consent renewed after expiry, an outage) silently lost the days in between: the connection came back, looked healthy, and the missing transactions never arrived. The lookback now widens to cover the gap since last_synced_at plus one day of overlap, capped at the 90-day PSD2 limit, and a gap of a month or more asks for strategy=longest like the manual sync route does. Dedup via external_id makes the overlap harmless. First syncs keep their 90-day path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * feat(bank-sync): chip warns seven days before a bank consent expires The transactions-page chip only reacted once a connection was already dead (expired/error) or had gone stale. A consent that is about to end looked healthy until the morning it stopped syncing. New "expiring" state when a live connection's consent_expires is within seven days, the same threshold as the consent-expiry email in the sync cron. Precedence: attention, expiring, stale, healthy. getChipState moves to lib/transactions/bank-sync-chip-state.ts so the precedence is unit-tested; the component keeps the rendering only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * feat(bank-sync): chip says paused when the subscription lapsed The daily cron filters connections by the bank_sync capability, so a company whose trial or subscription ended keeps status=active rows with a frozen last_synced_at. The chip read that as "stale, check the connection", which sends the user to re-authorise a connection that is perfectly alive. 56 of 191 active connections on prod were in this state on 2026-09-01. New "paused" state, ranked above everything else, when the company lacks bank_sync: hosted points at billing, self-host at the connector key, the same split BankSyncNowButton already makes. getChipState takes an options object so the clock stays out of render (react-hooks/purity). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * feat(api): agent-triggerable bank sync in v1 and MCP Closes the first wish in the F2 report: an integration could read bank data but never refresh it. New POST /api/v1/companies/{id}/bank-connections/ {connectionId}/sync and MCP gnubok_sync_bank, both on a shared runner (extensions/general/enable-banking/lib/trigger-sync.ts). Cost is bounded structurally, not by policy: the window is never caller-controlled (the cron's gap-aware 7 to 90 day lookback), a connection synced within 15 minutes answers BANK_SYNC_COOLDOWN with next_allowed_at (429 + Retry-After on v1; synced=false in-band on MCP so the agent reads on instead of retrying), and a failing connection is throttled per process by attempt time. A dead session is flipped to expired with a remediation that hands the user the connect link: no API call revives a consent. Gated on bank_sync like gnubok_connect_bank; scope transactions:write. Registry, scope map, load-routes, spec snapshot and the generated accounted-api skill updated; five BANK_SYNC_* / BANK_SESSION_EXPIRED codes added to the structured-error registry. The web Synka-nu route is left as is (see DECISIONS.md). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * test(bank-sync): use the options object in the remaining chip-state calls Four multi-line calls still passed the clock positionally after getChipState moved to an options object; tsc flagged them (vitest did not, the extra argument was ignored at runtime). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * fix(api): address skeptic findings on the agent-triggered bank sync Three refutations from the pre-publish skeptic pass: 1. Core imported the extension. The v1 sync route pulled the runner straight from @/extensions, which the core-build gate rejects and which left a live bank endpoint on zero-extension builds. The route now resolves it through the registry's services channel against a contract in lib/bank-sync/trigger-sync-contract.ts (same pattern as the Skatteverket read service) and answers EXTENSION_DISABLED when the extension is absent. 2. The idempotency cache stored the handler-level 429. A same-key retry after Retry-After, which is the documented retry, replayed the stale cooldown as a 400 for the cache's 24-hour TTL. withApiV1 no longer caches 429 responses; regression test added. The endpoint's pitfall no longer claims Idempotency-Key is mandatory (it was never enforced). 3. Two cron tests read the clock twice and failed whenever a millisecond passed between the reads. They now pin the clock with fake timers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS * fix(bank-sync): durable cooldown lease and review wording Resolves the PR #2165 review findings in one pass. Superagent P1: the attempt throttle was a process-local Map, so two agent calls on different serverless instances (or a retry after a cold start on a failing connection) could each bill an Enable Banking call, contradicting the one-sync-per-15-minutes promise. New bank_connections.sync_lease_until (migration 20260902150000), claimed with one conditional UPDATE before the bank is called; Postgres row locking makes exactly one claimer win, the rest answer BANK_SYNC_COOLDOWN. The lease stays for the full window on success and failure. Tests cover the claim order, a failed attempt seen from a second instance, a lost race, and an expired lease. CodeRabbit: the =1 plural branch now reads "in 1 day" / "om 1 dag" (daysUntilConsentExpiry rounds a partial day up, so "tomorrow" could be today); the cooldown pitfall on the v1 endpoint, the MCP description and the in-band cooldown instruction now say a cooldown can follow a failed attempt and tell the agent to compare last_synced_at before deciding. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub * fix(bank-sync): lease claim as a literal filter for the schema guard CI's no-phantom-columns guard counts runtime-built query expressions and its ceiling is exact; the templated `.or('sync_lease_until.is.null,...')` claim added one. The column now defaults to epoch (NOT NULL), so "never claimed" is just "expired long ago" and the atomic claim is a single literal `.lte('sync_lease_until', now)` the guard can check. Migration is unshipped (same PR), so it is edited in place. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub * fix(bank-sync): runner verifies company membership before the lease Superagent (round 3): the MCP path reached the shared runner without a membership check of its own. Both callers do enforce it upstream (withApiV1's company resolution and resolveMcpCompanyContext in the MCP dispatcher), but the runner writes transactions and bills a bank call, so it now checks company_members itself, before the cooldown and the lease claim, and answers NOT_FOUND for a non-member. The viewer check that was buried inside the sync block moves up with it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Fable 5.1
Claude Fable 5.1
parent
723a0f537b
commit
b68c082ef5
@@ -457,3 +457,67 @@ describe('GET /api/extensions/enable-banking/sync/cron: failure log level', () =
|
||||
consoleError.mockRestore()
|
||||
})
|
||||
})
|
||||
|
||||
describe('GET /api/extensions/enable-banking/sync/cron: incremental lookback', () => {
|
||||
const DAY_MS = 24 * 60 * 60 * 1000
|
||||
// Pin the clock: the route reads Date.now() after the fixture does, and a
|
||||
// single elapsed millisecond makes Math.ceil in incrementalLookbackDays
|
||||
// count one more day than the fixture intended.
|
||||
const NOW = Date.parse('2026-09-02T05:00:00.000Z')
|
||||
const isoDate = (msAgo: number) => new Date(NOW - msAgo).toISOString().split('T')[0]
|
||||
const syncedDaysAgo = (days: number) => new Date(NOW - days * DAY_MS).toISOString()
|
||||
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers({ toFake: ['Date'] })
|
||||
vi.setSystemTime(NOW)
|
||||
})
|
||||
afterEach(() => {
|
||||
vi.useRealTimers()
|
||||
})
|
||||
|
||||
it('uses the 7-day window when the connection synced yesterday', async () => {
|
||||
state.active = [connection({ last_synced_at: syncedDaysAgo(1) })]
|
||||
mocks.probeSessionHealth.mockResolvedValue('alive')
|
||||
|
||||
await GET(cronRequest())
|
||||
|
||||
expect(mocks.syncAccountTransactions).toHaveBeenCalledTimes(1)
|
||||
const [, , , , , fromDate, , , options] = mocks.syncAccountTransactions.mock.calls[0]
|
||||
expect(fromDate).toBe(isoDate(7 * DAY_MS))
|
||||
expect(options).not.toHaveProperty('strategy')
|
||||
})
|
||||
|
||||
it('widens the window to cover a gap since the last sync', async () => {
|
||||
// A subscription that lapsed for 20 days and was paid again: a fixed
|
||||
// 7-day window would silently drop the 13 days in between.
|
||||
state.active = [connection({ last_synced_at: syncedDaysAgo(20) })]
|
||||
mocks.probeSessionHealth.mockResolvedValue('alive')
|
||||
|
||||
await GET(cronRequest())
|
||||
|
||||
expect(mocks.syncAccountTransactions).toHaveBeenCalledTimes(1)
|
||||
const [, , , , , fromDate] = mocks.syncAccountTransactions.mock.calls[0]
|
||||
expect(fromDate).toBe(isoDate(21 * DAY_MS))
|
||||
})
|
||||
|
||||
it('asks for the deepest history the bank serves on a gap of a month or more', async () => {
|
||||
state.active = [connection({ last_synced_at: syncedDaysAgo(40) })]
|
||||
mocks.probeSessionHealth.mockResolvedValue('alive')
|
||||
|
||||
await GET(cronRequest())
|
||||
|
||||
const [, , , , , fromDate, , , options] = mocks.syncAccountTransactions.mock.calls[0]
|
||||
expect(fromDate).toBe(isoDate(41 * DAY_MS))
|
||||
expect(options).toMatchObject({ strategy: 'longest' })
|
||||
})
|
||||
|
||||
it('caps the widened window at 90 days', async () => {
|
||||
state.active = [connection({ last_synced_at: syncedDaysAgo(200) })]
|
||||
mocks.probeSessionHealth.mockResolvedValue('alive')
|
||||
|
||||
await GET(cronRequest())
|
||||
|
||||
const [, , , , , fromDate] = mocks.syncAccountTransactions.mock.calls[0]
|
||||
expect(fromDate).toBe(isoDate(90 * DAY_MS))
|
||||
})
|
||||
})
|
||||
|
||||
@@ -29,6 +29,11 @@ import { getBranding } from '@/lib/branding/service'
|
||||
import { fetchAllRows } from '@/lib/supabase/fetch-all'
|
||||
import { updateBalancesFromSync } from '@/lib/cash-accounts/service'
|
||||
import type { StoredAccount } from '@/extensions/general/enable-banking/types'
|
||||
import {
|
||||
INCREMENTAL_LOOKBACK_DAYS,
|
||||
MAX_LOOKBACK_DAYS,
|
||||
incrementalLookbackDays,
|
||||
} from '@/extensions/general/enable-banking/lib/cron-lookback'
|
||||
|
||||
ensureInitialized()
|
||||
|
||||
@@ -194,17 +199,28 @@ export const GET = withCronContext('cron.bank_sync', async (_request, ctx) => {
|
||||
}
|
||||
|
||||
const toDate = new Date().toISOString().split('T')[0]
|
||||
// First sync: 90-day lookback (PSD2 max). Subsequent: 7-day window.
|
||||
// First sync: 90-day lookback (PSD2 max). Subsequent: 7-day window,
|
||||
// widened to cover any gap since the last successful sync (a paused
|
||||
// subscription that was paid again, a renewed consent) so the days in
|
||||
// between are not lost. See cron-lookback.ts.
|
||||
// Gate on initial_sync_completed_at, not last_synced_at: manual "Sync now"
|
||||
// sets last_synced_at without doing the deep backfill, and we want the cron
|
||||
// to still fall back to 90 days if the inline activation backfill failed.
|
||||
const isFirstSync = !connection.initial_sync_completed_at
|
||||
const lookbackDays = isFirstSync ? 90 : 7
|
||||
const lookbackDays = isFirstSync
|
||||
? MAX_LOOKBACK_DAYS
|
||||
: incrementalLookbackDays(connection.last_synced_at)
|
||||
if (isFirstSync) {
|
||||
ctx.log.info('first sync for connection: using 90-day lookback', {
|
||||
connectionId: connection.id,
|
||||
lookbackDays,
|
||||
})
|
||||
} else if (lookbackDays > INCREMENTAL_LOOKBACK_DAYS) {
|
||||
ctx.log.info('gap since last sync: widening lookback', {
|
||||
connectionId: connection.id,
|
||||
lastSyncedAt: connection.last_synced_at,
|
||||
lookbackDays,
|
||||
})
|
||||
}
|
||||
const fromDate = new Date(Date.now() - lookbackDays * 24 * 60 * 60 * 1000)
|
||||
.toISOString()
|
||||
@@ -246,11 +262,12 @@ export const GET = withCronContext('cron.bank_sync', async (_request, ctx) => {
|
||||
.maybeSingle()
|
||||
|
||||
// First sync uses strategy=longest to pull the deepest history available
|
||||
// from the ASPSP. Incremental syncs skip it: the implicit default is
|
||||
// faster and we already have the older data.
|
||||
// from the ASPSP, and so does a gap backfill of a month or more (same
|
||||
// threshold as the manual sync route). Routine incremental syncs skip
|
||||
// it: the implicit default is faster and we already have the older data.
|
||||
const syncOptions = {
|
||||
...(sieOverlap ? { skipAutoCategorization: true } : {}),
|
||||
...(isFirstSync ? { strategy: 'longest' as const } : {}),
|
||||
...(isFirstSync || lookbackDays >= 30 ? { strategy: 'longest' as const } : {}),
|
||||
}
|
||||
|
||||
const syncResults = await Promise.all(
|
||||
|
||||
Reference in New Issue
Block a user