Fix/skv connection flow (#1015)
* feat(salary): one-click AGI submission with filing state machine and success feedback The AGI panel required users to know that "Ladda ner AGI-fil" was the generate step, then click submit, signing link, and kvittens manually. A nollkorning filing stalled on "AGI-XML saknas" pointing at a UI path that does not exist. - New primary button "Lamna in till Skatteverket" chains the existing endpoints client-side: generate XML if missing, POST underlag, poll kontrollresultat, create signing link, open Mina Sidor in a tab opened synchronously at click (popup-blocker safe). Inline stepper shows each step; the four old buttons become collapsed advanced/recovery actions, auto-expanded in stale-draft and rejected states. XML download stays visible and free for manual filing. - deriveAgiFilingState() + useAgiSubmission() lift the per-period submission record to the run page: the progress rail and salary hero now render the real state machine (generated, underlag inskickat, vantar pa BankID-signatur, inlamnad med kvittensnummer) instead of telling users to "lamna in" an already-submitted declaration. - Success card with kvittensnummer and signature metadata once signed, plus a toast when a poll flips the state while the page is open. - AGI kvittens cron every 15 min instead of every 2 h so filings signed on another device get stamped and emailed promptly. - Advanced submit also auto-generates, and the stale "Lon -> AGI -> Generera" error text now points at the real buttons. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(enable-banking): instant OAuth callback feedback and dead-attempt cleanup The bank redirect landed on a blank page for the several seconds the callback spent exchanging the PSD2 session and mirroring accounts, and every failed connect attempt left a status='error' row that rendered forever as an "Atgard kravs" card next to a successful retry, showing duplicate connections to the same bank. - Stream a branded "Slutfor bankanslutningen" progress page from the callback: the shell flushes before the session exchange starts and a script/meta redirect follows when the work completes, with a 30s slow-work escape hatch. Fast outcomes (denial, bad params, unknown state) keep their plain redirects. - Delete never-activated connection rows (no session_id, no accounts_data) on denial or exchange failure, and sweep leftovers for the same bank on the next connect. Established connections keep their "Atgard krävs" card via the accounts_data guard; FKs are ON DELETE SET NULL so deletion has no dependents. - Show "Banken ar ansluten: hamtar dina konton" while the settings panel loads after the callback instead of an anonymous spinner. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): reject re-send of issued invoices and gate bookkeeping on the sent flip A direct POST to /api/invoices/[id]/send against an already-issued invoice re-emailed the customer and posted a second revenue verifikat (createInvoiceJournalEntry has no dedup), overwriting journal_entry_id and orphaning the first entry. Only the UI hid the button; the v1 route and the MCP commit executor already rejected non-drafts. - Non-draft invoices now return 409 INVOICE_ALREADY_SENT. - The draft to sent status flip is an optimistic lock (status guard plus row-count check); journal entry, accrual schedules, PDF archival and the invoice.sent event only run for the request that won the flip. - On a flip failure the journal entry is deferred: the row stays draft and a retry re-runs the pipeline, ending with exactly one verifikat. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): payment links, failure visibility and sandbox guard for recurring auto-send - sendInvoiceFromSchedule now auto-creates an online payment link via applyPaymentLinkToInvoice before rendering and passes the payment link QR to the PDF: parity with the dashboard and v1 send routes, which recurring invoices silently lacked. - The recurring cron persists last_run_warning both when a claimed run throws (hourly retries stay visible on the schedule) and when a stale schedule is rolled forward, so a deterministic failure can no longer skip a month silently. - Auto-send is blocked for sandbox companies at the email chokepoint (freeze-and-retain: the invoice is still generated as a draft), covering both the cron and the run-now route with one guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(salary): close the Fortnox payroll API gaps (phases 1-4) Payroll now runs end-to-end through the open API, including onboarding a client from another payroll system, with every write staged for approval. - v1: per-employee payslips (list/detail/PDF), payslip line writes, run roster attach/remove, absence ranges (per-day storage), jamkning fields, cutover opening balances (single + atomic bulk PUT), vacation balance + vacation-year-close. PUT added to the wrapper's idempotency/ test-key set (test keys could otherwise write through PUT). - MCP: 10 new tools (get_employee/get_payslip/list_absence/ get_vacation_balance reads + staged update_payslip_line, register_absence, create_employee, update_employee, set_employee_opening_balances, close_vacation_year), executors, risk tiers, op-type CHECK expansions. create_employee encrypts personnummer at staging: pending_operations never holds plaintext. - Scope-map audit retrofit: 11 formerly unmapped tools now scoped; BREAKING for keys that relied on the 4 default-allow writes. - Cutover: employee_opening_balances (derived lock trigger, self-unlocks on run correction), engine YTD/karens/liability integration, Ingaende saldon section in the employee editor. - Arbetsschema-lite: employees.hours_per_week/workdays_per_week drive the hourly/daily divisors; legacy 173/21 preserved exactly at defaults so existing pay math is byte-identical. - Vacation ledger + semesterberedning/arsavslut: recomputed per-year day balances (synced on book/correct, non-fatal), year-close with the min-20 floor, 5-year sparade-dagar expiry to forced payout, and a 2920/2940 drift adjustment via the bookkeeping engine; Semester dashboard card with preview-then-confirm dialog. - Fix: Zod 4 defaults leak through .partial(), which made every sparse employee PATCH fail validation and reset defaulted columns. Migrations 20260713100000/101000/110000/121000/122000 (applied to staging with version rows; prod via merge). vacation_ledger renamed from 20260713120000 to avoid colliding with vat_declaration_totals_rpc. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * perf: cut dashboard page-load latency (region, round trips, caching, VAT RPC) The dominant cost was infrastructure: Vercel functions ran in iad1 (Washington D.C.) while Supabase (DB + auth) lives in eu-north-1 (Stockholm), so every request paid 4-5 transatlantic round trips of auth + company resolution before doing any real work (measured 530-1900ms for single-query GETs in prod logs). Pin functions to arn1 and cut the redundant work on top: - vercel.json: functions to arn1, same city as the database - getActiveCompanyId: preference + first-membership queries run in parallel; the fallback result doubles as validation in the common single-company case (one round trip instead of two sequential) - withRouteContext: Server-Timing header and authMs/companyMs/handlerMs in the op-completed log, so latency is attributable per phase - dashboard layout: nav badge counts off the critical path; DashboardNav loads them client-side via the new use-worklist-badges SWR hook with debounced realtime revalidation - swr (new dependency, approved): global provider; useCompanySettings shares one cache entry across consumers and renders from cache on back-navigation instead of re-showing skeletons - /pending: realtime refetch debounced; bulk operations previously fired 4 requests per row-change event - VAT declaration: new get_vat_declaration_totals RPC returns per-account totals, settlement-shape detection (#984) and source_type counts in ONE round trip instead of paging every entry+line through PostgREST. Account lists stay TS-side parameters so ACCOUNT_RUTA remains the single source of truth. Shape-exclusion coverage moved to tests/pg/vat-declaration-totals-rpc.pg.test.ts; DDL already applied to staging. - bundle: CommandPalette lazy-mounts on first Ctrl/Cmd+K, AgentChat dynamic-imports the markdown parser, @vercel/speed-insights (new dependency, approved) added for real-user timings The /salary fetch-waterfall fix from the same effort already landed inside 2084a756. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): settle öre-rounded payments from the mark-paid flow An invoice with öresavrundning shows a rounded "Att betala" on the PDF; the customer pays that amount (up to 50 öre off the stored öre total) and the invoice-page mark-paid flow rejected it with MATCH_AMOUNT_EXCEEDS_REMAINING: a dead end, while the bank-transaction match flow already absorbed the residual to 3740. - PaymentBookingDialog now proposes the rounded bank leg plus the 3740 residual line (credit when rounded up, debit when rounded down), resolved via getDisplayTotal from the per-invoice override and company_settings.ore_rounding. - settleInvoicePayment and the v1 mark-paid route absorb the sub-krona residual, gated by planInvoicePaymentForLines: absorption applies ONLY when the caller lines carry the exact residual on 3740; otherwise the strict plan applies (sub-krona partials stay partial, no-3740 overshoots keep the 400), so the GL can never diverge from the AR sub-ledger. - planInvoicePayment absorb-band boundary tightened to >= 1 kr: an exactly-1-kr overshoot used to slip past both the guard and the absorb branch and silently over-record paid_amount (pre-existing on the bank-match path). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): resolve all 7 PR compliance findings - ASVS V3.3: per-request CSP nonce on the enable-banking finalize page (mirrors the mcp-oauth consent page); inline scripts are nonce-bound - ASVS V16: decouple callback finalize work from the response stream (eager promise + next/server after()) so a client disconnect cannot drop session persistence or the consent_granted audit emit - ISO 27001 A.8.15: failed audit-event emits log through the structured logger with a stable message for log-based alerting - ASVS V2.3: recurring-invoice cron and run-now routes resolve isSandboxCompany themselves and pass an explicit suppressAutoSend flag (defence in depth around the email chokepoint, freeze-and-retain kept) - ISO 27001 A.8.11: stagePendingOperation rejects plaintext personnummer-bearing keys in params/preview_data (key-based guard; EF org numbers make value-matching unsafe) - ASVS V4.5: employee PATCH body is truly sparse; cleared number fields are omitted instead of resetting DB values to hardcoded fallbacks - ASVS V8.2.1: route-level tests pin the v1 cross-company deny (404 by convention, not 403) on the payslip PDF endpoint Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat: implement vacation-year basis change validation and error handling - Added tests to block vacation-year basis changes when open balances exist. - Implemented error handling for open-balances guard query failures in the settings route. - Enhanced absence route to reject reversed date ranges with a validation error. - Updated absence handling to use atomic upserts instead of delete+insert for better performance and reliability. - Refactored salary calculation logic to correctly handle age-based avgifter rates according to Skatteverket's rules. - Improved error messaging for vacation year closure adjustments. - Adjusted employee opening balances handling to preserve audit information during upserts. * feat(settings): add validation to block vacation-year basis change with open balances feat(absence): reject reversed date ranges in absence queries fix(absence): update absence handling to use atomic upserts instead of delete+insert fix(employee): improve validation for jamkning dates in employee updates fix(opening-balances): ensure created_by field is preserved during upserts test(absence): enhance tests for absence range and date validations test(calculation): add tests for age-based avgifter rates and edge cases test(semesterberedning): validate vacation year closure adjustments and error handling test(employee-opening-balances): update tests to reflect changes in salary_run_employees schema * fix(migrations): implement NOT VALID constraints for pending_operations and add validation migration --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Fable 5
Claude Fable 5
parent
e7e3c35f9e
commit
b6332e9ff4
@@ -97,9 +97,22 @@ describe('tools/list payload size guard', () => {
|
||||
// already-minimal ~24-token description. Headroom before the change was
|
||||
// under 10 tokens, so even this smallest possible addition crossed;
|
||||
// other descriptions are at their trimmed floor per the entries above.
|
||||
// * 45.5K → 50K with the payroll gap-closure (8 tools): 3 reads
|
||||
// (gnubok_get_employee, gnubok_get_payslip, gnubok_list_absence) + 5
|
||||
// staged writes (update_payslip_line, register_absence,
|
||||
// create_employee, update_employee, set_employee_opening_balances).
|
||||
// create/update_employee carry the full employee-config inputSchema
|
||||
// (~27 properties each: the whole point is agent-driveable payroll
|
||||
// onboarding), and every staged write inlines STAGED_OPERATION_SCHEMA
|
||||
// + _meta. Property descriptions trimmed to enum-only where the name
|
||||
// is self-evident; the remainder is wire contract, not prose.
|
||||
// * 50K → 51K with the vacation workflow (gap-closure Phase 3):
|
||||
// gnubok_get_vacation_balance (ledger read) + gnubok_close_vacation_year
|
||||
// (staged HIGH semesterårsavslut with STAGED_OPERATION_SCHEMA + _meta).
|
||||
// Fortnox gap category E closed; both schemas already minimal.
|
||||
// Long-term answer to growth is leaning harder on gnubok_search_tools: if this
|
||||
// fires again, prefer trimming descriptions or making a tool opt-in via search
|
||||
// before bumping further.
|
||||
expect(approxTokens).toBeLessThan(45_500)
|
||||
expect(approxTokens).toBeLessThan(51_000)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -0,0 +1,261 @@
|
||||
/**
|
||||
* Tests for the payroll MCP read tools (payroll gap-closure 1.6):
|
||||
* gnubok_get_employee, gnubok_get_payslip, gnubok_list_absence.
|
||||
*
|
||||
* PII rule under test: personnummer is ALWAYS masked on the MCP surface
|
||||
* (LLM context is a leak surface); there is no full-value drill-in here,
|
||||
* unlike v1's GET /employees/{id}.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createQueuedMockSupabase } from '@/tests/helpers'
|
||||
|
||||
import { tools } from '../server'
|
||||
|
||||
const getEmployee = tools.find((t) => t.name === 'gnubok_get_employee')!
|
||||
const getPayslip = tools.find((t) => t.name === 'gnubok_get_payslip')!
|
||||
const listAbsence = tools.find((t) => t.name === 'gnubok_list_absence')!
|
||||
const getVacationBalance = tools.find((t) => t.name === 'gnubok_get_vacation_balance')!
|
||||
|
||||
// Synthetic fixture personnummer (year 1900, zero suffix): must not look
|
||||
// like production-format PII.
|
||||
const SAMPLE_PERSONNUMMER = '190001010000'
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
describe('tool registration', () => {
|
||||
it('all three read tools exist and are read-only', () => {
|
||||
for (const tool of [getEmployee, getPayslip, listAbsence]) {
|
||||
expect(tool).toBeDefined()
|
||||
expect(tool.annotations?.readOnlyHint).toBe(true)
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_get_employee', () => {
|
||||
const EMPLOYEE_ROW = {
|
||||
id: 'bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb',
|
||||
first_name: 'Anna',
|
||||
last_name: 'Andersson',
|
||||
personnummer: SAMPLE_PERSONNUMMER,
|
||||
employment_type: 'employee',
|
||||
employment_start: '2024-01-15',
|
||||
employment_end: null,
|
||||
employment_degree: 100,
|
||||
salary_type: 'monthly',
|
||||
monthly_salary: 35000,
|
||||
hourly_rate: null,
|
||||
tax_table_number: 33,
|
||||
tax_column: 1,
|
||||
tax_municipality: 'Stockholm',
|
||||
is_sidoinkomst: false,
|
||||
f_skatt_status: 'a_skatt',
|
||||
f_skatt_verified_at: null,
|
||||
jamkning_percentage: 15,
|
||||
jamkning_valid_from: '2026-01-01',
|
||||
jamkning_valid_to: null,
|
||||
clearing_number: '6000',
|
||||
bank_account_number: '12345678',
|
||||
vacation_rule: 'procentregeln',
|
||||
vacation_days_per_year: 25,
|
||||
vacation_days_saved: 3,
|
||||
semestertillagg_rate: 0.0043,
|
||||
vaxa_stod_eligible: false,
|
||||
vaxa_stod_start: null,
|
||||
vaxa_stod_end: null,
|
||||
default_dimensions: {},
|
||||
is_active: true,
|
||||
}
|
||||
|
||||
it('returns the grouped config with masked personnummer and qualified id', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: EMPLOYEE_ROW })
|
||||
|
||||
const result = (await getEmployee.execute(
|
||||
{ employee_id: EMPLOYEE_ROW.id }, 'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as Record<string, unknown>
|
||||
|
||||
expect(result.employee_id).toBe(EMPLOYEE_ROW.id)
|
||||
expect(result.personnummer_masked).toBe('19000101-XXXX')
|
||||
expect((result.tax as Record<string, unknown>).jamkning_percentage).toBe(15)
|
||||
expect((result.vacation as Record<string, unknown>).vacation_days_saved).toBe(3)
|
||||
// Raw personnummer never leaks anywhere in the payload, and there is no
|
||||
// bare `id` key (qualified ids only).
|
||||
expect(JSON.stringify(result)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
expect(result.id).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
getEmployee.execute({ employee_id: 'nope' }, 'company-1', 'user-1', supabase as never, { type: 'api_key' }),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_get_payslip', () => {
|
||||
const SRE_ROW = {
|
||||
id: 'dddddddd-dddd-4ddd-8ddd-dddddddddddd',
|
||||
gross_salary: 35000,
|
||||
gross_deductions: 0,
|
||||
benefit_values: 0,
|
||||
taxable_income: 35000,
|
||||
tax_withheld: 8200,
|
||||
tax_withheld_override: null,
|
||||
net_deductions: 0,
|
||||
net_salary: 26800,
|
||||
avgifter_rate: 0.3142,
|
||||
avgifter_basis: 35000,
|
||||
avgifter_amount: 10997,
|
||||
avgifter_basis_override: null,
|
||||
avgifter_amount_override: null,
|
||||
avgifter_category: 'standard',
|
||||
override_reason: null,
|
||||
vacation_accrual: 4200,
|
||||
vacation_accrual_avgifter: 1319.64,
|
||||
ytd_gross: 70000,
|
||||
ytd_tax: 16400,
|
||||
ytd_net: 53600,
|
||||
sick_days: 0,
|
||||
vab_days: 0,
|
||||
parental_days: 0,
|
||||
vacation_days_taken: 0,
|
||||
calculation_breakdown: { steps: [] },
|
||||
employee: { first_name: 'Anna', last_name: 'Andersson', personnummer: SAMPLE_PERSONNUMMER },
|
||||
line_items: [
|
||||
{
|
||||
id: 'eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee',
|
||||
item_type: 'monthly_salary',
|
||||
description: 'Grundlön',
|
||||
quantity: null,
|
||||
unit_price: null,
|
||||
amount: 35000,
|
||||
is_taxable: true,
|
||||
is_avgift_basis: true,
|
||||
is_vacation_basis: true,
|
||||
is_gross_deduction: false,
|
||||
is_net_deduction: false,
|
||||
account_number: '7210',
|
||||
sort_order: 0,
|
||||
},
|
||||
],
|
||||
}
|
||||
|
||||
it('returns the payslip with qualified line ids and masked personnummer', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: SRE_ROW })
|
||||
|
||||
const result = (await getPayslip.execute(
|
||||
{ salary_run_id: 'run-1', employee_id: 'emp-1' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as {
|
||||
salary_run_employee_id: string
|
||||
employee_name: string
|
||||
personnummer_masked: string
|
||||
amounts: Record<string, number>
|
||||
line_items: Array<Record<string, unknown>>
|
||||
}
|
||||
|
||||
expect(result.salary_run_employee_id).toBe(SRE_ROW.id)
|
||||
expect(result.employee_name).toBe('Anna Andersson')
|
||||
expect(result.personnummer_masked).toBe('19000101-XXXX')
|
||||
expect(result.amounts.gross_salary).toBe(35000)
|
||||
expect(result.line_items).toHaveLength(1)
|
||||
expect(result.line_items[0].salary_line_item_id).toBe('eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee')
|
||||
expect(result.line_items[0].id).toBeUndefined()
|
||||
expect(JSON.stringify(result)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
})
|
||||
|
||||
it('throws when the employee is not in the run', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
getPayslip.execute(
|
||||
{ salary_run_id: 'run-1', employee_id: 'emp-x' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_get_vacation_balance', () => {
|
||||
it('returns the open balance with qualified id and remaining days', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({
|
||||
data: {
|
||||
id: 'vb-1',
|
||||
employee_id: 'emp-1',
|
||||
vacation_year_start: '2026-01-01',
|
||||
entitled_days: 25,
|
||||
accrued_days: 0,
|
||||
taken_days: 10,
|
||||
saved_days: { '2025': 5 },
|
||||
forced_payout_days: 0,
|
||||
},
|
||||
})
|
||||
|
||||
const result = (await getVacationBalance.execute(
|
||||
{ employee_id: 'emp-1' }, 'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as Record<string, unknown>
|
||||
|
||||
expect(result.employee_vacation_balance_id).toBe('vb-1')
|
||||
expect(result.remaining_days).toBe(15)
|
||||
expect(result.saved_days).toEqual({ '2025': 5 })
|
||||
expect(result.id).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws before the ledger has seeded', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
getVacationBalance.execute(
|
||||
{ employee_id: 'emp-x' }, 'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
),
|
||||
).rejects.toThrow(/No vacation balance/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_list_absence', () => {
|
||||
it('lists absence days with qualified ids', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
// Service: employees existence check, then the range query.
|
||||
enqueue({ data: { id: 'emp-1' } })
|
||||
enqueue({
|
||||
data: [
|
||||
{
|
||||
id: 'ffffffff-ffff-4fff-8fff-ffffffffffff',
|
||||
absence_date: '2026-03-03',
|
||||
absence_type: 'sick',
|
||||
hours: 8,
|
||||
notes: null,
|
||||
salary_run_employee_id: null,
|
||||
created_at: '2026-03-03T08:00:00Z',
|
||||
updated_at: '2026-03-03T08:00:00Z',
|
||||
},
|
||||
],
|
||||
})
|
||||
|
||||
const result = (await listAbsence.execute(
|
||||
{ employee_id: 'emp-1', from: '2026-03-01', to: '2026-03-31' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as { absence_days: Array<Record<string, unknown>>; count: number }
|
||||
|
||||
expect(result.count).toBe(1)
|
||||
expect(result.absence_days[0].salary_absence_day_id).toBe('ffffffff-ffff-4fff-8fff-ffffffffffff')
|
||||
expect(result.absence_days[0].absence_type).toBe('sick')
|
||||
expect(result.absence_days[0].id).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
listAbsence.execute(
|
||||
{ employee_id: 'emp-x', from: '2026-03-01', to: '2026-03-31' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,430 @@
|
||||
/**
|
||||
* Staging tests for the payroll write MCP tools (payroll gap-closure 1.7):
|
||||
* gnubok_update_payslip_line + gnubok_register_absence.
|
||||
*
|
||||
* Both STAGE a pending_operation (no direct writes); the executors in
|
||||
* lib/pending-operations/commit.ts are covered separately in
|
||||
* lib/pending-operations/__tests__/payroll-executors.test.ts.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createQueuedMockSupabase } from '@/tests/helpers'
|
||||
|
||||
const mockPreviewClose = vi.fn()
|
||||
vi.mock('@/lib/salary/semesterberedning', () => ({
|
||||
previewVacationYearClose: (...a: unknown[]) => mockPreviewClose(...a),
|
||||
commitVacationYearClose: vi.fn(),
|
||||
}))
|
||||
|
||||
import { tools } from '../server'
|
||||
import { decryptPersonnummer } from '@/lib/salary/personnummer'
|
||||
|
||||
const updatePayslipLine = tools.find((t) => t.name === 'gnubok_update_payslip_line')!
|
||||
const registerAbsence = tools.find((t) => t.name === 'gnubok_register_absence')!
|
||||
const createEmployee = tools.find((t) => t.name === 'gnubok_create_employee')!
|
||||
const updateEmployee = tools.find((t) => t.name === 'gnubok_update_employee')!
|
||||
const setOpeningBalances = tools.find((t) => t.name === 'gnubok_set_employee_opening_balances')!
|
||||
const closeVacationYear = tools.find((t) => t.name === 'gnubok_close_vacation_year')!
|
||||
|
||||
// Synthetic fixture personnummer (year 1900, zero suffix).
|
||||
const SAMPLE_PERSONNUMMER = '190001010000'
|
||||
|
||||
/** Flexible per-table mock that also captures insert payloads, so tests can
|
||||
* assert what stagePendingOperation persisted to pending_operations. */
|
||||
function makeCapturingSupabase(byTable: Record<string, { data?: unknown; error?: unknown } | Array<{ data?: unknown; error?: unknown }>>) {
|
||||
const queues = new Map<string, Array<{ data?: unknown; error?: unknown }>>()
|
||||
for (const [t, val] of Object.entries(byTable)) {
|
||||
queues.set(t, Array.isArray(val) ? [...val] : [val])
|
||||
}
|
||||
const inserts: Record<string, unknown[]> = {}
|
||||
const buildChain = (table: string): unknown => {
|
||||
const handler: ProxyHandler<object> = {
|
||||
get(_target, prop) {
|
||||
if (prop === 'then') {
|
||||
return (resolve: (v: unknown) => void) => {
|
||||
const q = queues.get(table)
|
||||
const next = q && q.length > 1 ? q.shift()! : (q?.[0] ?? { data: null, error: null })
|
||||
resolve({ count: null, ...next })
|
||||
}
|
||||
}
|
||||
return (...callArgs: unknown[]) => {
|
||||
if (prop === 'insert') {
|
||||
;(inserts[table] ??= []).push(callArgs[0])
|
||||
}
|
||||
return buildChain(table)
|
||||
}
|
||||
},
|
||||
}
|
||||
return new Proxy({}, handler)
|
||||
}
|
||||
return { inserts, from: vi.fn((table: string) => buildChain(table)) }
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
describe('gnubok_update_payslip_line', () => {
|
||||
const LINE_ROW = {
|
||||
id: 'line-1',
|
||||
salary_run_employee_id: 'sre-1',
|
||||
company_id: 'company-1',
|
||||
item_type: 'bonus',
|
||||
description: 'Kvartalsbonus',
|
||||
quantity: null,
|
||||
unit_price: null,
|
||||
amount: 5000,
|
||||
is_taxable: true,
|
||||
is_avgift_basis: true,
|
||||
is_vacation_basis: true,
|
||||
is_gross_deduction: false,
|
||||
is_net_deduction: false,
|
||||
account_number: '7210',
|
||||
sort_order: 0,
|
||||
created_at: '',
|
||||
updated_at: '',
|
||||
salary_run_employee: { salary_run_id: 'run-1' },
|
||||
}
|
||||
|
||||
it('stages with a merged preview and a recalculate next-hint', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'run-1', status: 'draft' } }) // service draft gate
|
||||
enqueue({ data: LINE_ROW }) // service loadLineInRun (dry-run preflight)
|
||||
enqueue({ data: { payment_date: '2026-03-25' } }) // run payment_date for period check
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: company_settings
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: fiscal_periods
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // pending_operations insert
|
||||
|
||||
const result = (await updatePayslipLine.execute(
|
||||
{ salary_run_id: 'run-1', salary_line_item_id: 'line-1', amount: 5500 },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
)) as {
|
||||
staged: boolean
|
||||
risk_level: string
|
||||
preview: Record<string, unknown>
|
||||
next?: { tool: string }
|
||||
}
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
expect(result.preview.new_amount).toBe(5500)
|
||||
expect(result.preview.salary_line_item_id).toBe('line-1')
|
||||
expect(result.next?.tool).toBe('gnubok_calculate_salary_run')
|
||||
})
|
||||
|
||||
it('throws when the run has advanced past draft (preflight)', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'run-1', status: 'booked' } })
|
||||
|
||||
await expect(
|
||||
updatePayslipLine.execute(
|
||||
{ salary_run_id: 'run-1', salary_line_item_id: 'line-1', amount: 5500 },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/SALARY_RUN_LINE_NOT_DRAFT/)
|
||||
})
|
||||
|
||||
it('rejects an empty patch', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
updatePayslipLine.execute(
|
||||
{ salary_run_id: 'run-1', salary_line_item_id: 'line-1' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/At least one/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_register_absence', () => {
|
||||
it('stages with day-count preview and dateForPeriodCheck', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'emp-1' } }) // service assertEmployee (dry-run preflight)
|
||||
enqueue({ data: { first_name: 'Anna', last_name: 'Andersson' } }) // name for title/preview
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: company_settings
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: fiscal_periods
|
||||
enqueue({ data: { id: 'op-2' }, error: null }) // pending_operations insert
|
||||
|
||||
const result = (await registerAbsence.execute(
|
||||
{ employee_id: 'emp-1', from: '2026-03-02', to: '2026-03-06', absence_type: 'sick' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
)) as {
|
||||
staged: boolean
|
||||
risk_level: string
|
||||
preview: Record<string, unknown>
|
||||
}
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
// 2026-03-02 (Mon) .. 2026-03-06 (Fri) = 5 weekdays.
|
||||
expect(result.preview.day_count).toBe(5)
|
||||
expect(result.preview.employee_name).toBe('Anna Andersson')
|
||||
expect((result.preview.dates_sample as string[])[0]).toBe('2026-03-02')
|
||||
})
|
||||
|
||||
it('throws for a range beyond the cap', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'emp-1' } })
|
||||
|
||||
await expect(
|
||||
registerAbsence.execute(
|
||||
{ employee_id: 'emp-1', from: '2026-01-01', to: '2026-12-31', absence_type: 'sick' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/ABSENCE_RANGE_TOO_LARGE/)
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
|
||||
await expect(
|
||||
registerAbsence.execute(
|
||||
{ employee_id: 'emp-x', from: '2026-03-02', to: '2026-03-06', absence_type: 'sick' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/EMPLOYEE_NOT_FOUND/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_create_employee', () => {
|
||||
const validArgs = {
|
||||
first_name: 'Anna',
|
||||
last_name: 'Andersson',
|
||||
personnummer: SAMPLE_PERSONNUMMER,
|
||||
employment_start: '2026-01-15',
|
||||
salary_type: 'monthly',
|
||||
monthly_salary: 35000,
|
||||
tax_table_number: 33,
|
||||
tax_municipality: 'Stockholm',
|
||||
}
|
||||
|
||||
it('encrypts personnummer at staging: params never carry the plaintext', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
company_settings: { data: { entity_type: 'ab' } }, // entity-type preflight
|
||||
fiscal_periods: { data: null },
|
||||
pending_operations: { data: { id: 'op-3' }, error: null },
|
||||
})
|
||||
|
||||
const result = (await createEmployee.execute(
|
||||
validArgs, 'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; risk_level: string; preview: Record<string, unknown> }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
expect(result.preview.personnummer_masked).toBe('19000101-XXXX')
|
||||
|
||||
// The staged params must carry the ENCRYPTED value + last4, never the
|
||||
// raw personnummer: pending_operations is a persisted table.
|
||||
const inserted = supabaseMock.inserts.pending_operations?.[0] as {
|
||||
params: Record<string, unknown>
|
||||
title: string
|
||||
preview_data: Record<string, unknown>
|
||||
}
|
||||
expect(inserted).toBeDefined()
|
||||
expect(inserted.params.personnummer).toBeUndefined()
|
||||
expect(inserted.params.personnummer_last4).toBe('0000')
|
||||
expect(decryptPersonnummer(inserted.params.personnummer_encrypted as string)).toBe(SAMPLE_PERSONNUMMER)
|
||||
expect(JSON.stringify(inserted.params)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
expect(JSON.stringify(inserted.preview_data)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
expect(inserted.title).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
})
|
||||
|
||||
it('rejects invalid input via CreateEmployeeSchema (missing salary)', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
createEmployee.execute(
|
||||
{ ...validArgs, monthly_salary: undefined },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/Invalid employee/)
|
||||
})
|
||||
|
||||
it('blocks EF owners on payroll (entity-type preflight)', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { entity_type: 'ef' } }) // company_settings
|
||||
|
||||
await expect(
|
||||
createEmployee.execute(
|
||||
{ ...validArgs, employment_type: 'company_owner' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow()
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_update_employee', () => {
|
||||
const EXISTING = {
|
||||
id: 'emp-1',
|
||||
first_name: 'Anna',
|
||||
last_name: 'Andersson',
|
||||
monthly_salary: 35000,
|
||||
clearing_number: '6000',
|
||||
bank_account_number: '12345678',
|
||||
}
|
||||
|
||||
it('stages with a field-level changes preview and bank-change flag', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
employees: { data: EXISTING },
|
||||
fiscal_periods: { data: null },
|
||||
company_settings: { data: null },
|
||||
pending_operations: { data: { id: 'op-4' }, error: null },
|
||||
})
|
||||
|
||||
const result = (await updateEmployee.execute(
|
||||
{ employee_id: 'emp-1', monthly_salary: 38000, bank_account_number: '87654321' },
|
||||
'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; preview: { changes: Array<{ field: string; from: unknown; to: unknown }>; bank_details_changed: boolean } }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.preview.bank_details_changed).toBe(true)
|
||||
const salaryChange = result.preview.changes.find((c) => c.field === 'monthly_salary')
|
||||
expect(salaryChange).toEqual({ field: 'monthly_salary', from: 35000, to: 38000 })
|
||||
})
|
||||
|
||||
it('rejects personnummer changes at the tool boundary', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
updateEmployee.execute(
|
||||
{ employee_id: 'emp-1', personnummer: '190001029999' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/immutable/)
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
updateEmployee.execute(
|
||||
{ employee_id: 'emp-x', monthly_salary: 38000 },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_set_employee_opening_balances', () => {
|
||||
const EMPLOYEE_ID = 'bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb'
|
||||
const CURRENT_YEAR = new Date().getFullYear()
|
||||
const validItem = {
|
||||
employee_id: EMPLOYEE_ID,
|
||||
cutover_date: `${CURRENT_YEAR}-07-01`,
|
||||
ytd_gross: 210000,
|
||||
ytd_tax: 48000,
|
||||
ytd_net: 162000,
|
||||
vacation_paid_days_remaining: 12.5,
|
||||
vacation_saved_days_by_year: { [`${CURRENT_YEAR - 1}`]: 5 },
|
||||
opening_semester_liability: 42000,
|
||||
opening_semester_liability_avgifter: 13196.4,
|
||||
karens_periods_adjustment: 1,
|
||||
}
|
||||
|
||||
it('stages after preflighting the whole batch (happy path)', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
employees: {
|
||||
data: [{ id: EMPLOYEE_ID, employment_start: '2024-01-15', is_active: true }],
|
||||
},
|
||||
salary_run_employees: { data: [] },
|
||||
pending_operations: { data: { id: 'op-5' }, error: null },
|
||||
})
|
||||
|
||||
const result = (await setOpeningBalances.execute(
|
||||
{ items: [validItem] },
|
||||
'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; risk_level: string; preview: Record<string, unknown> }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
expect(result.preview.employee_count).toBe(1)
|
||||
expect(result.preview.total_ytd_gross).toBe(210000)
|
||||
// The write table is never touched at staging.
|
||||
const inserted = supabaseMock.inserts.employee_opening_balances
|
||||
expect(inserted).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws with the per-item error list when locked', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
employees: {
|
||||
data: [{ id: EMPLOYEE_ID, employment_start: '2024-01-15', is_active: true }],
|
||||
},
|
||||
salary_run_employees: {
|
||||
data: [{ employee_id: EMPLOYEE_ID, salary_run: { id: 'run-1', status: 'booked' } }],
|
||||
},
|
||||
})
|
||||
|
||||
await expect(
|
||||
setOpeningBalances.execute(
|
||||
{ items: [validItem] },
|
||||
'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/Locked by booked salary run/)
|
||||
})
|
||||
|
||||
it('rejects invalid items via the shared Zod schema', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
setOpeningBalances.execute(
|
||||
{ items: [{ ...validItem, cutover_date: `${CURRENT_YEAR}-07-15` }] },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/Invalid opening balances/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_close_vacation_year', () => {
|
||||
const SAMPLE_REPORT = {
|
||||
vacation_year_start: '2025-01-01',
|
||||
vacation_year_end: '2025-12-31',
|
||||
next_year_start: '2026-01-01',
|
||||
basis: 'calendar',
|
||||
rows: [
|
||||
{
|
||||
employee_id: 'emp-1',
|
||||
employee_name: 'Anna Andersson',
|
||||
saveable_days: 5,
|
||||
expiring_days: 2,
|
||||
},
|
||||
],
|
||||
sek: {
|
||||
computed_liability: 18690.84,
|
||||
computed_avgifter: 5872.66,
|
||||
booked_2920: 10000,
|
||||
booked_2940: 3142,
|
||||
drift_2920: 8690.84,
|
||||
drift_2940: 2730.66,
|
||||
adjustment_needed: true,
|
||||
},
|
||||
adjustment_date: '2025-12-31',
|
||||
}
|
||||
|
||||
it('stages HIGH risk with the review report in the preview', async () => {
|
||||
mockPreviewClose.mockResolvedValue({ ok: true, data: SAMPLE_REPORT })
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { salary_vacation_year_basis: 'calendar' } }) // basis lookup (year default)
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: company_settings
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: fiscal_periods
|
||||
enqueue({ data: { id: 'op-6' }, error: null }) // pending_operations insert
|
||||
|
||||
const result = (await closeVacationYear.execute(
|
||||
{}, 'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; risk_level: string; preview: Record<string, unknown> }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('high')
|
||||
expect(result.preview.employee_count).toBe(1)
|
||||
expect(result.preview.drift_2920).toBe(8690.84)
|
||||
expect(result.preview.adjustment_needed).toBe(true)
|
||||
})
|
||||
|
||||
it('fails staging when the preview refuses (already closed)', async () => {
|
||||
mockPreviewClose.mockResolvedValue({ ok: false, code: 'VACATION_YEAR_ALREADY_CLOSED' })
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { salary_vacation_year_basis: 'calendar' } })
|
||||
|
||||
await expect(
|
||||
closeVacationYear.execute(
|
||||
{ vacation_year_start: '2025-01-01' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/VACATION_YEAR_ALREADY_CLOSED/)
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,80 @@
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { assertNoPlaintextPersonnummer } from '../staging-pii-guard'
|
||||
|
||||
describe('assertNoPlaintextPersonnummer', () => {
|
||||
it('throws on a top-level plaintext personnummer key in params', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{ first_name: 'Test', personnummer: '198501011234' },
|
||||
'params',
|
||||
),
|
||||
).toThrow(/params contains plaintext PII key "personnummer"/)
|
||||
})
|
||||
|
||||
it('throws when the key is nested inside a patch object (update-style staging)', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{ employee_id: 'e-1', patch: { personnummer: '198501011234' } },
|
||||
'params',
|
||||
),
|
||||
).toThrow(/plaintext PII key "personnummer"/)
|
||||
})
|
||||
|
||||
it('throws when the key hides inside an array of row objects', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{ rows: [{ amount: 100 }, { ssn: '850101-1234' }] },
|
||||
'preview_data',
|
||||
),
|
||||
).toThrow(/preview_data contains plaintext PII key "ssn"/)
|
||||
})
|
||||
|
||||
it('allows the encrypted/masked derivatives that create_employee stages', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{
|
||||
first_name: 'Test',
|
||||
personnummer_encrypted: 'v1:abcdef',
|
||||
personnummer_last4: '1234',
|
||||
personnummer_masked: '850101-****',
|
||||
},
|
||||
'params',
|
||||
),
|
||||
).not.toThrow()
|
||||
})
|
||||
|
||||
it('allows ordinary payloads: UUIDs, dates, aggregates, names', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{
|
||||
employee_id: 'b7f8d1a2-0000-0000-0000-000000000000',
|
||||
from: '2026-07-01',
|
||||
to: '2026-07-05',
|
||||
absence_type: 'sick',
|
||||
hours_per_day: 8,
|
||||
notes: null,
|
||||
},
|
||||
'params',
|
||||
),
|
||||
).not.toThrow()
|
||||
})
|
||||
|
||||
it('fails closed when the payload nests past the scan depth (PII could hide below)', () => {
|
||||
// Before the fail-closed change, the scanner silently accepted anything
|
||||
// past MAX_DEPTH, so this personnummer would have been persisted.
|
||||
const payload = {
|
||||
l1: { l2: { l3: { l4: { l5: { l6: { l7: { personnummer: '198501011234' } } } } } } },
|
||||
}
|
||||
expect(() => assertNoPlaintextPersonnummer(payload, 'params')).toThrow(
|
||||
/cannot be scanned for plaintext PII/,
|
||||
)
|
||||
})
|
||||
|
||||
it('does not value-match: an EF org number equal to a personnummer passes under a business key', () => {
|
||||
// For enskild firma the org number IS the owner's personnummer; the
|
||||
// guard is key-based so legitimate counterparty data stays stageable.
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer({ org_number: '850101-1234' }, 'params'),
|
||||
).not.toThrow()
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user