Fix/skv connection flow (#1015)
* feat(salary): one-click AGI submission with filing state machine and success feedback The AGI panel required users to know that "Ladda ner AGI-fil" was the generate step, then click submit, signing link, and kvittens manually. A nollkorning filing stalled on "AGI-XML saknas" pointing at a UI path that does not exist. - New primary button "Lamna in till Skatteverket" chains the existing endpoints client-side: generate XML if missing, POST underlag, poll kontrollresultat, create signing link, open Mina Sidor in a tab opened synchronously at click (popup-blocker safe). Inline stepper shows each step; the four old buttons become collapsed advanced/recovery actions, auto-expanded in stale-draft and rejected states. XML download stays visible and free for manual filing. - deriveAgiFilingState() + useAgiSubmission() lift the per-period submission record to the run page: the progress rail and salary hero now render the real state machine (generated, underlag inskickat, vantar pa BankID-signatur, inlamnad med kvittensnummer) instead of telling users to "lamna in" an already-submitted declaration. - Success card with kvittensnummer and signature metadata once signed, plus a toast when a poll flips the state while the page is open. - AGI kvittens cron every 15 min instead of every 2 h so filings signed on another device get stamped and emailed promptly. - Advanced submit also auto-generates, and the stale "Lon -> AGI -> Generera" error text now points at the real buttons. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(enable-banking): instant OAuth callback feedback and dead-attempt cleanup The bank redirect landed on a blank page for the several seconds the callback spent exchanging the PSD2 session and mirroring accounts, and every failed connect attempt left a status='error' row that rendered forever as an "Atgard kravs" card next to a successful retry, showing duplicate connections to the same bank. - Stream a branded "Slutfor bankanslutningen" progress page from the callback: the shell flushes before the session exchange starts and a script/meta redirect follows when the work completes, with a 30s slow-work escape hatch. Fast outcomes (denial, bad params, unknown state) keep their plain redirects. - Delete never-activated connection rows (no session_id, no accounts_data) on denial or exchange failure, and sweep leftovers for the same bank on the next connect. Established connections keep their "Atgard krävs" card via the accounts_data guard; FKs are ON DELETE SET NULL so deletion has no dependents. - Show "Banken ar ansluten: hamtar dina konton" while the settings panel loads after the callback instead of an anonymous spinner. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): reject re-send of issued invoices and gate bookkeeping on the sent flip A direct POST to /api/invoices/[id]/send against an already-issued invoice re-emailed the customer and posted a second revenue verifikat (createInvoiceJournalEntry has no dedup), overwriting journal_entry_id and orphaning the first entry. Only the UI hid the button; the v1 route and the MCP commit executor already rejected non-drafts. - Non-draft invoices now return 409 INVOICE_ALREADY_SENT. - The draft to sent status flip is an optimistic lock (status guard plus row-count check); journal entry, accrual schedules, PDF archival and the invoice.sent event only run for the request that won the flip. - On a flip failure the journal entry is deferred: the row stays draft and a retry re-runs the pipeline, ending with exactly one verifikat. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): payment links, failure visibility and sandbox guard for recurring auto-send - sendInvoiceFromSchedule now auto-creates an online payment link via applyPaymentLinkToInvoice before rendering and passes the payment link QR to the PDF: parity with the dashboard and v1 send routes, which recurring invoices silently lacked. - The recurring cron persists last_run_warning both when a claimed run throws (hourly retries stay visible on the schedule) and when a stale schedule is rolled forward, so a deterministic failure can no longer skip a month silently. - Auto-send is blocked for sandbox companies at the email chokepoint (freeze-and-retain: the invoice is still generated as a draft), covering both the cron and the run-now route with one guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(salary): close the Fortnox payroll API gaps (phases 1-4) Payroll now runs end-to-end through the open API, including onboarding a client from another payroll system, with every write staged for approval. - v1: per-employee payslips (list/detail/PDF), payslip line writes, run roster attach/remove, absence ranges (per-day storage), jamkning fields, cutover opening balances (single + atomic bulk PUT), vacation balance + vacation-year-close. PUT added to the wrapper's idempotency/ test-key set (test keys could otherwise write through PUT). - MCP: 10 new tools (get_employee/get_payslip/list_absence/ get_vacation_balance reads + staged update_payslip_line, register_absence, create_employee, update_employee, set_employee_opening_balances, close_vacation_year), executors, risk tiers, op-type CHECK expansions. create_employee encrypts personnummer at staging: pending_operations never holds plaintext. - Scope-map audit retrofit: 11 formerly unmapped tools now scoped; BREAKING for keys that relied on the 4 default-allow writes. - Cutover: employee_opening_balances (derived lock trigger, self-unlocks on run correction), engine YTD/karens/liability integration, Ingaende saldon section in the employee editor. - Arbetsschema-lite: employees.hours_per_week/workdays_per_week drive the hourly/daily divisors; legacy 173/21 preserved exactly at defaults so existing pay math is byte-identical. - Vacation ledger + semesterberedning/arsavslut: recomputed per-year day balances (synced on book/correct, non-fatal), year-close with the min-20 floor, 5-year sparade-dagar expiry to forced payout, and a 2920/2940 drift adjustment via the bookkeeping engine; Semester dashboard card with preview-then-confirm dialog. - Fix: Zod 4 defaults leak through .partial(), which made every sparse employee PATCH fail validation and reset defaulted columns. Migrations 20260713100000/101000/110000/121000/122000 (applied to staging with version rows; prod via merge). vacation_ledger renamed from 20260713120000 to avoid colliding with vat_declaration_totals_rpc. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * perf: cut dashboard page-load latency (region, round trips, caching, VAT RPC) The dominant cost was infrastructure: Vercel functions ran in iad1 (Washington D.C.) while Supabase (DB + auth) lives in eu-north-1 (Stockholm), so every request paid 4-5 transatlantic round trips of auth + company resolution before doing any real work (measured 530-1900ms for single-query GETs in prod logs). Pin functions to arn1 and cut the redundant work on top: - vercel.json: functions to arn1, same city as the database - getActiveCompanyId: preference + first-membership queries run in parallel; the fallback result doubles as validation in the common single-company case (one round trip instead of two sequential) - withRouteContext: Server-Timing header and authMs/companyMs/handlerMs in the op-completed log, so latency is attributable per phase - dashboard layout: nav badge counts off the critical path; DashboardNav loads them client-side via the new use-worklist-badges SWR hook with debounced realtime revalidation - swr (new dependency, approved): global provider; useCompanySettings shares one cache entry across consumers and renders from cache on back-navigation instead of re-showing skeletons - /pending: realtime refetch debounced; bulk operations previously fired 4 requests per row-change event - VAT declaration: new get_vat_declaration_totals RPC returns per-account totals, settlement-shape detection (#984) and source_type counts in ONE round trip instead of paging every entry+line through PostgREST. Account lists stay TS-side parameters so ACCOUNT_RUTA remains the single source of truth. Shape-exclusion coverage moved to tests/pg/vat-declaration-totals-rpc.pg.test.ts; DDL already applied to staging. - bundle: CommandPalette lazy-mounts on first Ctrl/Cmd+K, AgentChat dynamic-imports the markdown parser, @vercel/speed-insights (new dependency, approved) added for real-user timings The /salary fetch-waterfall fix from the same effort already landed inside 2084a756. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): settle öre-rounded payments from the mark-paid flow An invoice with öresavrundning shows a rounded "Att betala" on the PDF; the customer pays that amount (up to 50 öre off the stored öre total) and the invoice-page mark-paid flow rejected it with MATCH_AMOUNT_EXCEEDS_REMAINING: a dead end, while the bank-transaction match flow already absorbed the residual to 3740. - PaymentBookingDialog now proposes the rounded bank leg plus the 3740 residual line (credit when rounded up, debit when rounded down), resolved via getDisplayTotal from the per-invoice override and company_settings.ore_rounding. - settleInvoicePayment and the v1 mark-paid route absorb the sub-krona residual, gated by planInvoicePaymentForLines: absorption applies ONLY when the caller lines carry the exact residual on 3740; otherwise the strict plan applies (sub-krona partials stay partial, no-3740 overshoots keep the 400), so the GL can never diverge from the AR sub-ledger. - planInvoicePayment absorb-band boundary tightened to >= 1 kr: an exactly-1-kr overshoot used to slip past both the guard and the absorb branch and silently over-record paid_amount (pre-existing on the bank-match path). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(security): resolve all 7 PR compliance findings - ASVS V3.3: per-request CSP nonce on the enable-banking finalize page (mirrors the mcp-oauth consent page); inline scripts are nonce-bound - ASVS V16: decouple callback finalize work from the response stream (eager promise + next/server after()) so a client disconnect cannot drop session persistence or the consent_granted audit emit - ISO 27001 A.8.15: failed audit-event emits log through the structured logger with a stable message for log-based alerting - ASVS V2.3: recurring-invoice cron and run-now routes resolve isSandboxCompany themselves and pass an explicit suppressAutoSend flag (defence in depth around the email chokepoint, freeze-and-retain kept) - ISO 27001 A.8.11: stagePendingOperation rejects plaintext personnummer-bearing keys in params/preview_data (key-based guard; EF org numbers make value-matching unsafe) - ASVS V4.5: employee PATCH body is truly sparse; cleared number fields are omitted instead of resetting DB values to hardcoded fallbacks - ASVS V8.2.1: route-level tests pin the v1 cross-company deny (404 by convention, not 403) on the payslip PDF endpoint Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat: implement vacation-year basis change validation and error handling - Added tests to block vacation-year basis changes when open balances exist. - Implemented error handling for open-balances guard query failures in the settings route. - Enhanced absence route to reject reversed date ranges with a validation error. - Updated absence handling to use atomic upserts instead of delete+insert for better performance and reliability. - Refactored salary calculation logic to correctly handle age-based avgifter rates according to Skatteverket's rules. - Improved error messaging for vacation year closure adjustments. - Adjusted employee opening balances handling to preserve audit information during upserts. * feat(settings): add validation to block vacation-year basis change with open balances feat(absence): reject reversed date ranges in absence queries fix(absence): update absence handling to use atomic upserts instead of delete+insert fix(employee): improve validation for jamkning dates in employee updates fix(opening-balances): ensure created_by field is preserved during upserts test(absence): enhance tests for absence range and date validations test(calculation): add tests for age-based avgifter rates and edge cases test(semesterberedning): validate vacation year closure adjustments and error handling test(employee-opening-balances): update tests to reflect changes in salary_run_employees schema * fix(migrations): implement NOT VALID constraints for pending_operations and add validation migration --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Fable 5
Claude Fable 5
parent
e7e3c35f9e
commit
b6332e9ff4
@@ -0,0 +1,199 @@
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
|
||||
// Entitlement gate passes in these tests; the gate itself is covered by
|
||||
// capability-gate.test.ts.
|
||||
vi.mock('@/lib/entitlements/has-capability', async (importOriginal) => {
|
||||
const actual = await importOriginal<typeof import('@/lib/entitlements/has-capability')>()
|
||||
return { ...actual, requireCapability: vi.fn() }
|
||||
})
|
||||
|
||||
const { mockStartAuthorization, mockGetPreferredAuthMethod } = vi.hoisted(() => ({
|
||||
mockStartAuthorization: vi.fn(),
|
||||
mockGetPreferredAuthMethod: vi.fn(),
|
||||
}))
|
||||
|
||||
vi.mock('../lib/api-client', async (importOriginal) => {
|
||||
const actual = await importOriginal<typeof import('../lib/api-client')>()
|
||||
return {
|
||||
...actual,
|
||||
startAuthorization: (...args: unknown[]) => mockStartAuthorization(...args),
|
||||
getPreferredAuthMethod: (...args: unknown[]) => mockGetPreferredAuthMethod(...args),
|
||||
}
|
||||
})
|
||||
|
||||
import { enableBankingExtension } from '../index'
|
||||
import { requireCapability } from '@/lib/entitlements/has-capability'
|
||||
import type { ExtensionContext } from '@/lib/extensions/types'
|
||||
|
||||
interface RecordedCall {
|
||||
method: string
|
||||
args: unknown[]
|
||||
}
|
||||
|
||||
interface RecordedChain {
|
||||
_calls: RecordedCall[]
|
||||
[key: string]: unknown
|
||||
}
|
||||
|
||||
function makeChain(result: { data?: unknown; error?: unknown }): RecordedChain {
|
||||
const calls: RecordedCall[] = []
|
||||
const chain: Record<string, unknown> = { _calls: calls }
|
||||
for (const m of ['select', 'eq', 'in', 'is', 'order', 'limit', 'update', 'delete', 'insert']) {
|
||||
chain[m] = vi.fn((...args: unknown[]) => {
|
||||
calls.push({ method: m, args })
|
||||
return chain
|
||||
})
|
||||
}
|
||||
chain.maybeSingle = vi.fn().mockResolvedValue({ data: result.data ?? null, error: result.error ?? null })
|
||||
chain.single = vi.fn().mockResolvedValue({ data: result.data ?? null, error: result.error ?? null })
|
||||
chain.then = (resolve: (v: unknown) => void) => resolve({ data: result.data ?? null, error: result.error ?? null })
|
||||
return chain as RecordedChain
|
||||
}
|
||||
|
||||
function makeContext(fromImpl: (table: string) => unknown): ExtensionContext {
|
||||
return {
|
||||
userId: 'user-1',
|
||||
companyId: 'company-1',
|
||||
extensionId: 'enable-banking',
|
||||
requestId: 'req_test',
|
||||
supabase: {
|
||||
auth: {
|
||||
getUser: vi.fn().mockResolvedValue({ data: { user: { id: 'user-1' } }, error: null }),
|
||||
},
|
||||
from: vi.fn(fromImpl),
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
} as any,
|
||||
emit: vi.fn().mockResolvedValue(undefined),
|
||||
log: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn(), child: vi.fn() },
|
||||
settings: {
|
||||
get: vi.fn().mockResolvedValue(null),
|
||||
set: vi.fn().mockResolvedValue(undefined),
|
||||
clear: vi.fn().mockResolvedValue(undefined),
|
||||
},
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
} as any
|
||||
}
|
||||
|
||||
function connectRoute() {
|
||||
const route = enableBankingExtension.apiRoutes?.find(
|
||||
(r) => r.method === 'POST' && r.path === '/connect',
|
||||
)
|
||||
expect(route, 'POST /connect must be registered').toBeDefined()
|
||||
return route!
|
||||
}
|
||||
|
||||
function makeConnectRequest() {
|
||||
return new Request('https://test.local/api/extensions/ext/enable-banking/connect', {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
body: JSON.stringify({ aspsp_name: 'Nordea', aspsp_country: 'SE', psu_type: 'business' }),
|
||||
})
|
||||
}
|
||||
|
||||
describe('POST /connect never-activated row cleanup', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
vi.mocked(requireCapability).mockResolvedValue(null)
|
||||
mockGetPreferredAuthMethod.mockResolvedValue(undefined)
|
||||
mockStartAuthorization.mockResolvedValue({
|
||||
url: 'https://bank.example/auth',
|
||||
authorization_id: 'auth-1',
|
||||
})
|
||||
})
|
||||
|
||||
it('deletes stale pending and error zombies instead of parking them in error', async () => {
|
||||
const chains: RecordedChain[] = []
|
||||
let call = 0
|
||||
const ctx = makeContext(() => {
|
||||
call++
|
||||
let chain: RecordedChain
|
||||
if (call === 1) {
|
||||
// Latest pending row is stale (45s > 30s threshold): not a live attempt.
|
||||
chain = makeChain({
|
||||
data: { id: 'stale-1', created_at: new Date(Date.now() - 45_000).toISOString() },
|
||||
})
|
||||
} else if (call === 2) {
|
||||
// The sweep: returns the deleted never-activated rows.
|
||||
chain = makeChain({ data: [{ id: 'stale-1' }, { id: 'old-error' }] })
|
||||
} else {
|
||||
// Insert of the fresh connection row.
|
||||
chain = makeChain({ data: { id: 'new-conn' } })
|
||||
}
|
||||
chains.push(chain)
|
||||
return chain
|
||||
})
|
||||
|
||||
const response = await connectRoute().handler(makeConnectRequest(), ctx)
|
||||
|
||||
expect(response.status).toBe(200)
|
||||
const body = (await response.json()) as { connection_id: string; authorization_url: string }
|
||||
expect(body.connection_id).toBe('new-conn')
|
||||
expect(body.authorization_url).toBe('https://bank.example/auth')
|
||||
|
||||
// The sweep DELETEs never-activated rows: stale pendings and error rows
|
||||
// from failed attempts, guarded so established connections (session_id or
|
||||
// accounts_data present) are untouched.
|
||||
const sweep = chains[1]
|
||||
const methods = sweep._calls.map((c) => c.method)
|
||||
expect(methods).toContain('delete')
|
||||
const inCall = sweep._calls.find((c) => c.method === 'in')
|
||||
expect(inCall?.args).toEqual(['status', ['pending', 'error']])
|
||||
const isCalls = sweep._calls.filter((c) => c.method === 'is')
|
||||
expect(isCalls.map((c) => c.args)).toEqual(
|
||||
expect.arrayContaining([
|
||||
['session_id', null],
|
||||
['accounts_data', null],
|
||||
]),
|
||||
)
|
||||
|
||||
// Nothing gets parked as status='error' anymore: no update on any chain.
|
||||
for (const chain of chains) {
|
||||
expect(chain._calls.some((c) => c.method === 'update')).toBe(false)
|
||||
}
|
||||
})
|
||||
|
||||
it('still rejects a duplicate connect while a recent pending attempt is live', async () => {
|
||||
const chains: RecordedChain[] = []
|
||||
const ctx = makeContext(() => {
|
||||
// Latest pending row is 5s old: the user is mid-redirect at the bank.
|
||||
const chain = makeChain({
|
||||
data: { id: 'live-1', created_at: new Date(Date.now() - 5_000).toISOString() },
|
||||
})
|
||||
chains.push(chain)
|
||||
return chain
|
||||
})
|
||||
|
||||
const response = await connectRoute().handler(makeConnectRequest(), ctx)
|
||||
|
||||
expect(response.status).toBe(409)
|
||||
// No sweep while an attempt is live: the live pending row must survive.
|
||||
for (const chain of chains) {
|
||||
expect(chain._calls.some((c) => c.method === 'delete')).toBe(false)
|
||||
}
|
||||
expect(mockStartAuthorization).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('sweeps error zombies even when no pending row exists', async () => {
|
||||
const chains: RecordedChain[] = []
|
||||
let call = 0
|
||||
const ctx = makeContext(() => {
|
||||
call++
|
||||
let chain: RecordedChain
|
||||
if (call === 1) {
|
||||
chain = makeChain({ data: null })
|
||||
} else if (call === 2) {
|
||||
chain = makeChain({ data: [{ id: 'old-error' }] })
|
||||
} else {
|
||||
chain = makeChain({ data: { id: 'new-conn' } })
|
||||
}
|
||||
chains.push(chain)
|
||||
return chain
|
||||
})
|
||||
|
||||
const response = await connectRoute().handler(makeConnectRequest(), ctx)
|
||||
|
||||
expect(response.status).toBe(200)
|
||||
const sweep = chains[1]
|
||||
expect(sweep._calls.some((c) => c.method === 'delete')).toBe(true)
|
||||
})
|
||||
})
|
||||
@@ -107,6 +107,11 @@ function makeContext(connection: Record<string, unknown>, updateSpy: Mock, inser
|
||||
chain.gte = vi.fn(() => chain)
|
||||
chain.limit = vi.fn(() => chain)
|
||||
chain.order = vi.fn(() => chain)
|
||||
// The fresh-connect path sweeps never-activated rows before inserting:
|
||||
// .delete().eq(...).in(...).is(...).select('id') must chain through.
|
||||
chain.delete = vi.fn(() => chain)
|
||||
chain.in = vi.fn(() => chain)
|
||||
chain.is = vi.fn(() => chain)
|
||||
chain.insert = vi.fn((payload: unknown) => {
|
||||
insertSpy?.(payload)
|
||||
return chain
|
||||
|
||||
@@ -2,11 +2,12 @@
|
||||
|
||||
import { useState, useEffect, useRef } from 'react'
|
||||
import Link from 'next/link'
|
||||
import { useSearchParams } from 'next/navigation'
|
||||
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card'
|
||||
import { Button } from '@/components/ui/button'
|
||||
import { useToast } from '@/components/ui/use-toast'
|
||||
import { DestructiveConfirmDialog, useDestructiveConfirm } from '@/components/ui/destructive-confirm-dialog'
|
||||
import { AlertTriangle, Loader2, Upload } from 'lucide-react'
|
||||
import { AlertTriangle, CheckCircle, Loader2, Upload } from 'lucide-react'
|
||||
import { cn } from '@/lib/utils'
|
||||
import { createClient } from '@/lib/supabase/client'
|
||||
import { notifyBankSyncUpdated } from '@/lib/transactions/bank-sync-signal'
|
||||
@@ -26,6 +27,13 @@ import type { StoredAccount } from '../types'
|
||||
export default function BankingSettingsPanel() {
|
||||
const { toast } = useToast()
|
||||
const supabase = createClient()
|
||||
// The OAuth callback lands here with ?select_accounts=<id> once a bank is
|
||||
// successfully connected. Read via useSearchParams (SSR/hydration-safe) so
|
||||
// the first-load spinner can say "bank connected, fetching accounts"
|
||||
// instead of an anonymous spinner. The param itself is consumed and
|
||||
// stripped by the auto-open effect below.
|
||||
const searchParams = useSearchParams()
|
||||
const arrivedFromBankCallback = !!searchParams?.get('select_accounts')
|
||||
|
||||
const { dialogProps, confirm } = useDestructiveConfirm()
|
||||
const { company } = useCompany()
|
||||
@@ -365,6 +373,24 @@ export default function BankingSettingsPanel() {
|
||||
}
|
||||
|
||||
if (isLoading) {
|
||||
// Coming back from the bank's consent flow the connection already exists,
|
||||
// so tell the user that instead of showing an anonymous spinner: this is
|
||||
// the last silent gap between "approved at the bank" and the account
|
||||
// picker opening.
|
||||
if (arrivedFromBankCallback) {
|
||||
return (
|
||||
<div className="flex h-32 flex-col items-center justify-center gap-3">
|
||||
<div className="flex items-center gap-2 text-sm font-medium">
|
||||
<CheckCircle className="h-4 w-4 text-success" />
|
||||
<span>Banken är ansluten</span>
|
||||
</div>
|
||||
<div className="flex items-center gap-2 text-sm text-muted-foreground">
|
||||
<Loader2 className="h-4 w-4 animate-spin" />
|
||||
<span>Hämtar dina konton…</span>
|
||||
</div>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
return (
|
||||
<div className="flex items-center justify-center h-32">
|
||||
<Loader2 className="h-6 w-6 animate-spin text-muted-foreground" />
|
||||
|
||||
@@ -238,18 +238,33 @@ export const enableBankingExtension: Extension = {
|
||||
{ status: 409 }
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
// Clean up stale pending connections (older than threshold)
|
||||
log.info('[enable-banking] Cleaning up stale pending connections', {
|
||||
stale_id: recentPending.id,
|
||||
age_ms: pendingAge,
|
||||
// Sweep failed attempts that never became a live connection:
|
||||
// stale 'pending' rows (abandoned redirects past the threshold)
|
||||
// and 'error' rows left by earlier denied/failed connects.
|
||||
// DELETE instead of marking 'error': a parked 'error' row renders
|
||||
// forever as an "Åtgärd krävs" card, so a failed attempt followed
|
||||
// by a successful retry showed up as two connections to the same
|
||||
// bank. The session_id/accounts_data guards protect established
|
||||
// connections (anything that ever completed the callback has
|
||||
// accounts_data); never-activated rows have no dependents, and
|
||||
// the transactions/cash_accounts FKs are ON DELETE SET NULL.
|
||||
const { data: sweptRows } = await supabase
|
||||
.from('bank_connections')
|
||||
.delete()
|
||||
.eq('company_id', companyId)
|
||||
.eq('bank_name', resolvedAspspName)
|
||||
.in('status', ['pending', 'error'])
|
||||
.is('session_id', null)
|
||||
.is('accounts_data', null)
|
||||
.select('id')
|
||||
|
||||
if (sweptRows?.length) {
|
||||
log.info('[enable-banking] Swept never-activated connection attempts', {
|
||||
count: sweptRows.length,
|
||||
bank: resolvedAspspName,
|
||||
})
|
||||
await supabase
|
||||
.from('bank_connections')
|
||||
.update({ status: 'error', error_message: 'Superseded by new connection attempt', oauth_state: null })
|
||||
.eq('company_id', companyId)
|
||||
.eq('bank_name', resolvedAspspName)
|
||||
.eq('status', 'pending')
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -97,9 +97,22 @@ describe('tools/list payload size guard', () => {
|
||||
// already-minimal ~24-token description. Headroom before the change was
|
||||
// under 10 tokens, so even this smallest possible addition crossed;
|
||||
// other descriptions are at their trimmed floor per the entries above.
|
||||
// * 45.5K → 50K with the payroll gap-closure (8 tools): 3 reads
|
||||
// (gnubok_get_employee, gnubok_get_payslip, gnubok_list_absence) + 5
|
||||
// staged writes (update_payslip_line, register_absence,
|
||||
// create_employee, update_employee, set_employee_opening_balances).
|
||||
// create/update_employee carry the full employee-config inputSchema
|
||||
// (~27 properties each: the whole point is agent-driveable payroll
|
||||
// onboarding), and every staged write inlines STAGED_OPERATION_SCHEMA
|
||||
// + _meta. Property descriptions trimmed to enum-only where the name
|
||||
// is self-evident; the remainder is wire contract, not prose.
|
||||
// * 50K → 51K with the vacation workflow (gap-closure Phase 3):
|
||||
// gnubok_get_vacation_balance (ledger read) + gnubok_close_vacation_year
|
||||
// (staged HIGH semesterårsavslut with STAGED_OPERATION_SCHEMA + _meta).
|
||||
// Fortnox gap category E closed; both schemas already minimal.
|
||||
// Long-term answer to growth is leaning harder on gnubok_search_tools: if this
|
||||
// fires again, prefer trimming descriptions or making a tool opt-in via search
|
||||
// before bumping further.
|
||||
expect(approxTokens).toBeLessThan(45_500)
|
||||
expect(approxTokens).toBeLessThan(51_000)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -0,0 +1,261 @@
|
||||
/**
|
||||
* Tests for the payroll MCP read tools (payroll gap-closure 1.6):
|
||||
* gnubok_get_employee, gnubok_get_payslip, gnubok_list_absence.
|
||||
*
|
||||
* PII rule under test: personnummer is ALWAYS masked on the MCP surface
|
||||
* (LLM context is a leak surface); there is no full-value drill-in here,
|
||||
* unlike v1's GET /employees/{id}.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createQueuedMockSupabase } from '@/tests/helpers'
|
||||
|
||||
import { tools } from '../server'
|
||||
|
||||
const getEmployee = tools.find((t) => t.name === 'gnubok_get_employee')!
|
||||
const getPayslip = tools.find((t) => t.name === 'gnubok_get_payslip')!
|
||||
const listAbsence = tools.find((t) => t.name === 'gnubok_list_absence')!
|
||||
const getVacationBalance = tools.find((t) => t.name === 'gnubok_get_vacation_balance')!
|
||||
|
||||
// Synthetic fixture personnummer (year 1900, zero suffix): must not look
|
||||
// like production-format PII.
|
||||
const SAMPLE_PERSONNUMMER = '190001010000'
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
describe('tool registration', () => {
|
||||
it('all three read tools exist and are read-only', () => {
|
||||
for (const tool of [getEmployee, getPayslip, listAbsence]) {
|
||||
expect(tool).toBeDefined()
|
||||
expect(tool.annotations?.readOnlyHint).toBe(true)
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_get_employee', () => {
|
||||
const EMPLOYEE_ROW = {
|
||||
id: 'bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb',
|
||||
first_name: 'Anna',
|
||||
last_name: 'Andersson',
|
||||
personnummer: SAMPLE_PERSONNUMMER,
|
||||
employment_type: 'employee',
|
||||
employment_start: '2024-01-15',
|
||||
employment_end: null,
|
||||
employment_degree: 100,
|
||||
salary_type: 'monthly',
|
||||
monthly_salary: 35000,
|
||||
hourly_rate: null,
|
||||
tax_table_number: 33,
|
||||
tax_column: 1,
|
||||
tax_municipality: 'Stockholm',
|
||||
is_sidoinkomst: false,
|
||||
f_skatt_status: 'a_skatt',
|
||||
f_skatt_verified_at: null,
|
||||
jamkning_percentage: 15,
|
||||
jamkning_valid_from: '2026-01-01',
|
||||
jamkning_valid_to: null,
|
||||
clearing_number: '6000',
|
||||
bank_account_number: '12345678',
|
||||
vacation_rule: 'procentregeln',
|
||||
vacation_days_per_year: 25,
|
||||
vacation_days_saved: 3,
|
||||
semestertillagg_rate: 0.0043,
|
||||
vaxa_stod_eligible: false,
|
||||
vaxa_stod_start: null,
|
||||
vaxa_stod_end: null,
|
||||
default_dimensions: {},
|
||||
is_active: true,
|
||||
}
|
||||
|
||||
it('returns the grouped config with masked personnummer and qualified id', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: EMPLOYEE_ROW })
|
||||
|
||||
const result = (await getEmployee.execute(
|
||||
{ employee_id: EMPLOYEE_ROW.id }, 'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as Record<string, unknown>
|
||||
|
||||
expect(result.employee_id).toBe(EMPLOYEE_ROW.id)
|
||||
expect(result.personnummer_masked).toBe('19000101-XXXX')
|
||||
expect((result.tax as Record<string, unknown>).jamkning_percentage).toBe(15)
|
||||
expect((result.vacation as Record<string, unknown>).vacation_days_saved).toBe(3)
|
||||
// Raw personnummer never leaks anywhere in the payload, and there is no
|
||||
// bare `id` key (qualified ids only).
|
||||
expect(JSON.stringify(result)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
expect(result.id).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
getEmployee.execute({ employee_id: 'nope' }, 'company-1', 'user-1', supabase as never, { type: 'api_key' }),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_get_payslip', () => {
|
||||
const SRE_ROW = {
|
||||
id: 'dddddddd-dddd-4ddd-8ddd-dddddddddddd',
|
||||
gross_salary: 35000,
|
||||
gross_deductions: 0,
|
||||
benefit_values: 0,
|
||||
taxable_income: 35000,
|
||||
tax_withheld: 8200,
|
||||
tax_withheld_override: null,
|
||||
net_deductions: 0,
|
||||
net_salary: 26800,
|
||||
avgifter_rate: 0.3142,
|
||||
avgifter_basis: 35000,
|
||||
avgifter_amount: 10997,
|
||||
avgifter_basis_override: null,
|
||||
avgifter_amount_override: null,
|
||||
avgifter_category: 'standard',
|
||||
override_reason: null,
|
||||
vacation_accrual: 4200,
|
||||
vacation_accrual_avgifter: 1319.64,
|
||||
ytd_gross: 70000,
|
||||
ytd_tax: 16400,
|
||||
ytd_net: 53600,
|
||||
sick_days: 0,
|
||||
vab_days: 0,
|
||||
parental_days: 0,
|
||||
vacation_days_taken: 0,
|
||||
calculation_breakdown: { steps: [] },
|
||||
employee: { first_name: 'Anna', last_name: 'Andersson', personnummer: SAMPLE_PERSONNUMMER },
|
||||
line_items: [
|
||||
{
|
||||
id: 'eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee',
|
||||
item_type: 'monthly_salary',
|
||||
description: 'Grundlön',
|
||||
quantity: null,
|
||||
unit_price: null,
|
||||
amount: 35000,
|
||||
is_taxable: true,
|
||||
is_avgift_basis: true,
|
||||
is_vacation_basis: true,
|
||||
is_gross_deduction: false,
|
||||
is_net_deduction: false,
|
||||
account_number: '7210',
|
||||
sort_order: 0,
|
||||
},
|
||||
],
|
||||
}
|
||||
|
||||
it('returns the payslip with qualified line ids and masked personnummer', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: SRE_ROW })
|
||||
|
||||
const result = (await getPayslip.execute(
|
||||
{ salary_run_id: 'run-1', employee_id: 'emp-1' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as {
|
||||
salary_run_employee_id: string
|
||||
employee_name: string
|
||||
personnummer_masked: string
|
||||
amounts: Record<string, number>
|
||||
line_items: Array<Record<string, unknown>>
|
||||
}
|
||||
|
||||
expect(result.salary_run_employee_id).toBe(SRE_ROW.id)
|
||||
expect(result.employee_name).toBe('Anna Andersson')
|
||||
expect(result.personnummer_masked).toBe('19000101-XXXX')
|
||||
expect(result.amounts.gross_salary).toBe(35000)
|
||||
expect(result.line_items).toHaveLength(1)
|
||||
expect(result.line_items[0].salary_line_item_id).toBe('eeeeeeee-eeee-4eee-8eee-eeeeeeeeeeee')
|
||||
expect(result.line_items[0].id).toBeUndefined()
|
||||
expect(JSON.stringify(result)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
})
|
||||
|
||||
it('throws when the employee is not in the run', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
getPayslip.execute(
|
||||
{ salary_run_id: 'run-1', employee_id: 'emp-x' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_get_vacation_balance', () => {
|
||||
it('returns the open balance with qualified id and remaining days', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({
|
||||
data: {
|
||||
id: 'vb-1',
|
||||
employee_id: 'emp-1',
|
||||
vacation_year_start: '2026-01-01',
|
||||
entitled_days: 25,
|
||||
accrued_days: 0,
|
||||
taken_days: 10,
|
||||
saved_days: { '2025': 5 },
|
||||
forced_payout_days: 0,
|
||||
},
|
||||
})
|
||||
|
||||
const result = (await getVacationBalance.execute(
|
||||
{ employee_id: 'emp-1' }, 'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as Record<string, unknown>
|
||||
|
||||
expect(result.employee_vacation_balance_id).toBe('vb-1')
|
||||
expect(result.remaining_days).toBe(15)
|
||||
expect(result.saved_days).toEqual({ '2025': 5 })
|
||||
expect(result.id).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws before the ledger has seeded', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
getVacationBalance.execute(
|
||||
{ employee_id: 'emp-x' }, 'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
),
|
||||
).rejects.toThrow(/No vacation balance/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_list_absence', () => {
|
||||
it('lists absence days with qualified ids', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
// Service: employees existence check, then the range query.
|
||||
enqueue({ data: { id: 'emp-1' } })
|
||||
enqueue({
|
||||
data: [
|
||||
{
|
||||
id: 'ffffffff-ffff-4fff-8fff-ffffffffffff',
|
||||
absence_date: '2026-03-03',
|
||||
absence_type: 'sick',
|
||||
hours: 8,
|
||||
notes: null,
|
||||
salary_run_employee_id: null,
|
||||
created_at: '2026-03-03T08:00:00Z',
|
||||
updated_at: '2026-03-03T08:00:00Z',
|
||||
},
|
||||
],
|
||||
})
|
||||
|
||||
const result = (await listAbsence.execute(
|
||||
{ employee_id: 'emp-1', from: '2026-03-01', to: '2026-03-31' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
)) as { absence_days: Array<Record<string, unknown>>; count: number }
|
||||
|
||||
expect(result.count).toBe(1)
|
||||
expect(result.absence_days[0].salary_absence_day_id).toBe('ffffffff-ffff-4fff-8fff-ffffffffffff')
|
||||
expect(result.absence_days[0].absence_type).toBe('sick')
|
||||
expect(result.absence_days[0].id).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
listAbsence.execute(
|
||||
{ employee_id: 'emp-x', from: '2026-03-01', to: '2026-03-31' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'api_key' },
|
||||
),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,430 @@
|
||||
/**
|
||||
* Staging tests for the payroll write MCP tools (payroll gap-closure 1.7):
|
||||
* gnubok_update_payslip_line + gnubok_register_absence.
|
||||
*
|
||||
* Both STAGE a pending_operation (no direct writes); the executors in
|
||||
* lib/pending-operations/commit.ts are covered separately in
|
||||
* lib/pending-operations/__tests__/payroll-executors.test.ts.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createQueuedMockSupabase } from '@/tests/helpers'
|
||||
|
||||
const mockPreviewClose = vi.fn()
|
||||
vi.mock('@/lib/salary/semesterberedning', () => ({
|
||||
previewVacationYearClose: (...a: unknown[]) => mockPreviewClose(...a),
|
||||
commitVacationYearClose: vi.fn(),
|
||||
}))
|
||||
|
||||
import { tools } from '../server'
|
||||
import { decryptPersonnummer } from '@/lib/salary/personnummer'
|
||||
|
||||
const updatePayslipLine = tools.find((t) => t.name === 'gnubok_update_payslip_line')!
|
||||
const registerAbsence = tools.find((t) => t.name === 'gnubok_register_absence')!
|
||||
const createEmployee = tools.find((t) => t.name === 'gnubok_create_employee')!
|
||||
const updateEmployee = tools.find((t) => t.name === 'gnubok_update_employee')!
|
||||
const setOpeningBalances = tools.find((t) => t.name === 'gnubok_set_employee_opening_balances')!
|
||||
const closeVacationYear = tools.find((t) => t.name === 'gnubok_close_vacation_year')!
|
||||
|
||||
// Synthetic fixture personnummer (year 1900, zero suffix).
|
||||
const SAMPLE_PERSONNUMMER = '190001010000'
|
||||
|
||||
/** Flexible per-table mock that also captures insert payloads, so tests can
|
||||
* assert what stagePendingOperation persisted to pending_operations. */
|
||||
function makeCapturingSupabase(byTable: Record<string, { data?: unknown; error?: unknown } | Array<{ data?: unknown; error?: unknown }>>) {
|
||||
const queues = new Map<string, Array<{ data?: unknown; error?: unknown }>>()
|
||||
for (const [t, val] of Object.entries(byTable)) {
|
||||
queues.set(t, Array.isArray(val) ? [...val] : [val])
|
||||
}
|
||||
const inserts: Record<string, unknown[]> = {}
|
||||
const buildChain = (table: string): unknown => {
|
||||
const handler: ProxyHandler<object> = {
|
||||
get(_target, prop) {
|
||||
if (prop === 'then') {
|
||||
return (resolve: (v: unknown) => void) => {
|
||||
const q = queues.get(table)
|
||||
const next = q && q.length > 1 ? q.shift()! : (q?.[0] ?? { data: null, error: null })
|
||||
resolve({ count: null, ...next })
|
||||
}
|
||||
}
|
||||
return (...callArgs: unknown[]) => {
|
||||
if (prop === 'insert') {
|
||||
;(inserts[table] ??= []).push(callArgs[0])
|
||||
}
|
||||
return buildChain(table)
|
||||
}
|
||||
},
|
||||
}
|
||||
return new Proxy({}, handler)
|
||||
}
|
||||
return { inserts, from: vi.fn((table: string) => buildChain(table)) }
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
describe('gnubok_update_payslip_line', () => {
|
||||
const LINE_ROW = {
|
||||
id: 'line-1',
|
||||
salary_run_employee_id: 'sre-1',
|
||||
company_id: 'company-1',
|
||||
item_type: 'bonus',
|
||||
description: 'Kvartalsbonus',
|
||||
quantity: null,
|
||||
unit_price: null,
|
||||
amount: 5000,
|
||||
is_taxable: true,
|
||||
is_avgift_basis: true,
|
||||
is_vacation_basis: true,
|
||||
is_gross_deduction: false,
|
||||
is_net_deduction: false,
|
||||
account_number: '7210',
|
||||
sort_order: 0,
|
||||
created_at: '',
|
||||
updated_at: '',
|
||||
salary_run_employee: { salary_run_id: 'run-1' },
|
||||
}
|
||||
|
||||
it('stages with a merged preview and a recalculate next-hint', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'run-1', status: 'draft' } }) // service draft gate
|
||||
enqueue({ data: LINE_ROW }) // service loadLineInRun (dry-run preflight)
|
||||
enqueue({ data: { payment_date: '2026-03-25' } }) // run payment_date for period check
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: company_settings
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: fiscal_periods
|
||||
enqueue({ data: { id: 'op-1' }, error: null }) // pending_operations insert
|
||||
|
||||
const result = (await updatePayslipLine.execute(
|
||||
{ salary_run_id: 'run-1', salary_line_item_id: 'line-1', amount: 5500 },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
)) as {
|
||||
staged: boolean
|
||||
risk_level: string
|
||||
preview: Record<string, unknown>
|
||||
next?: { tool: string }
|
||||
}
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
expect(result.preview.new_amount).toBe(5500)
|
||||
expect(result.preview.salary_line_item_id).toBe('line-1')
|
||||
expect(result.next?.tool).toBe('gnubok_calculate_salary_run')
|
||||
})
|
||||
|
||||
it('throws when the run has advanced past draft (preflight)', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'run-1', status: 'booked' } })
|
||||
|
||||
await expect(
|
||||
updatePayslipLine.execute(
|
||||
{ salary_run_id: 'run-1', salary_line_item_id: 'line-1', amount: 5500 },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/SALARY_RUN_LINE_NOT_DRAFT/)
|
||||
})
|
||||
|
||||
it('rejects an empty patch', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
updatePayslipLine.execute(
|
||||
{ salary_run_id: 'run-1', salary_line_item_id: 'line-1' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/At least one/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_register_absence', () => {
|
||||
it('stages with day-count preview and dateForPeriodCheck', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'emp-1' } }) // service assertEmployee (dry-run preflight)
|
||||
enqueue({ data: { first_name: 'Anna', last_name: 'Andersson' } }) // name for title/preview
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: company_settings
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: fiscal_periods
|
||||
enqueue({ data: { id: 'op-2' }, error: null }) // pending_operations insert
|
||||
|
||||
const result = (await registerAbsence.execute(
|
||||
{ employee_id: 'emp-1', from: '2026-03-02', to: '2026-03-06', absence_type: 'sick' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
)) as {
|
||||
staged: boolean
|
||||
risk_level: string
|
||||
preview: Record<string, unknown>
|
||||
}
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
// 2026-03-02 (Mon) .. 2026-03-06 (Fri) = 5 weekdays.
|
||||
expect(result.preview.day_count).toBe(5)
|
||||
expect(result.preview.employee_name).toBe('Anna Andersson')
|
||||
expect((result.preview.dates_sample as string[])[0]).toBe('2026-03-02')
|
||||
})
|
||||
|
||||
it('throws for a range beyond the cap', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { id: 'emp-1' } })
|
||||
|
||||
await expect(
|
||||
registerAbsence.execute(
|
||||
{ employee_id: 'emp-1', from: '2026-01-01', to: '2026-12-31', absence_type: 'sick' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/ABSENCE_RANGE_TOO_LARGE/)
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
|
||||
await expect(
|
||||
registerAbsence.execute(
|
||||
{ employee_id: 'emp-x', from: '2026-03-02', to: '2026-03-06', absence_type: 'sick' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/EMPLOYEE_NOT_FOUND/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_create_employee', () => {
|
||||
const validArgs = {
|
||||
first_name: 'Anna',
|
||||
last_name: 'Andersson',
|
||||
personnummer: SAMPLE_PERSONNUMMER,
|
||||
employment_start: '2026-01-15',
|
||||
salary_type: 'monthly',
|
||||
monthly_salary: 35000,
|
||||
tax_table_number: 33,
|
||||
tax_municipality: 'Stockholm',
|
||||
}
|
||||
|
||||
it('encrypts personnummer at staging: params never carry the plaintext', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
company_settings: { data: { entity_type: 'ab' } }, // entity-type preflight
|
||||
fiscal_periods: { data: null },
|
||||
pending_operations: { data: { id: 'op-3' }, error: null },
|
||||
})
|
||||
|
||||
const result = (await createEmployee.execute(
|
||||
validArgs, 'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; risk_level: string; preview: Record<string, unknown> }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
expect(result.preview.personnummer_masked).toBe('19000101-XXXX')
|
||||
|
||||
// The staged params must carry the ENCRYPTED value + last4, never the
|
||||
// raw personnummer: pending_operations is a persisted table.
|
||||
const inserted = supabaseMock.inserts.pending_operations?.[0] as {
|
||||
params: Record<string, unknown>
|
||||
title: string
|
||||
preview_data: Record<string, unknown>
|
||||
}
|
||||
expect(inserted).toBeDefined()
|
||||
expect(inserted.params.personnummer).toBeUndefined()
|
||||
expect(inserted.params.personnummer_last4).toBe('0000')
|
||||
expect(decryptPersonnummer(inserted.params.personnummer_encrypted as string)).toBe(SAMPLE_PERSONNUMMER)
|
||||
expect(JSON.stringify(inserted.params)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
expect(JSON.stringify(inserted.preview_data)).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
expect(inserted.title).not.toContain(SAMPLE_PERSONNUMMER)
|
||||
})
|
||||
|
||||
it('rejects invalid input via CreateEmployeeSchema (missing salary)', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
createEmployee.execute(
|
||||
{ ...validArgs, monthly_salary: undefined },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/Invalid employee/)
|
||||
})
|
||||
|
||||
it('blocks EF owners on payroll (entity-type preflight)', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { entity_type: 'ef' } }) // company_settings
|
||||
|
||||
await expect(
|
||||
createEmployee.execute(
|
||||
{ ...validArgs, employment_type: 'company_owner' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow()
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_update_employee', () => {
|
||||
const EXISTING = {
|
||||
id: 'emp-1',
|
||||
first_name: 'Anna',
|
||||
last_name: 'Andersson',
|
||||
monthly_salary: 35000,
|
||||
clearing_number: '6000',
|
||||
bank_account_number: '12345678',
|
||||
}
|
||||
|
||||
it('stages with a field-level changes preview and bank-change flag', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
employees: { data: EXISTING },
|
||||
fiscal_periods: { data: null },
|
||||
company_settings: { data: null },
|
||||
pending_operations: { data: { id: 'op-4' }, error: null },
|
||||
})
|
||||
|
||||
const result = (await updateEmployee.execute(
|
||||
{ employee_id: 'emp-1', monthly_salary: 38000, bank_account_number: '87654321' },
|
||||
'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; preview: { changes: Array<{ field: string; from: unknown; to: unknown }>; bank_details_changed: boolean } }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.preview.bank_details_changed).toBe(true)
|
||||
const salaryChange = result.preview.changes.find((c) => c.field === 'monthly_salary')
|
||||
expect(salaryChange).toEqual({ field: 'monthly_salary', from: 35000, to: 38000 })
|
||||
})
|
||||
|
||||
it('rejects personnummer changes at the tool boundary', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
updateEmployee.execute(
|
||||
{ employee_id: 'emp-1', personnummer: '190001029999' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/immutable/)
|
||||
})
|
||||
|
||||
it('throws for an unknown employee', async () => {
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: null })
|
||||
await expect(
|
||||
updateEmployee.execute(
|
||||
{ employee_id: 'emp-x', monthly_salary: 38000 },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/not found/i)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_set_employee_opening_balances', () => {
|
||||
const EMPLOYEE_ID = 'bbbbbbbb-bbbb-4bbb-8bbb-bbbbbbbbbbbb'
|
||||
const CURRENT_YEAR = new Date().getFullYear()
|
||||
const validItem = {
|
||||
employee_id: EMPLOYEE_ID,
|
||||
cutover_date: `${CURRENT_YEAR}-07-01`,
|
||||
ytd_gross: 210000,
|
||||
ytd_tax: 48000,
|
||||
ytd_net: 162000,
|
||||
vacation_paid_days_remaining: 12.5,
|
||||
vacation_saved_days_by_year: { [`${CURRENT_YEAR - 1}`]: 5 },
|
||||
opening_semester_liability: 42000,
|
||||
opening_semester_liability_avgifter: 13196.4,
|
||||
karens_periods_adjustment: 1,
|
||||
}
|
||||
|
||||
it('stages after preflighting the whole batch (happy path)', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
employees: {
|
||||
data: [{ id: EMPLOYEE_ID, employment_start: '2024-01-15', is_active: true }],
|
||||
},
|
||||
salary_run_employees: { data: [] },
|
||||
pending_operations: { data: { id: 'op-5' }, error: null },
|
||||
})
|
||||
|
||||
const result = (await setOpeningBalances.execute(
|
||||
{ items: [validItem] },
|
||||
'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; risk_level: string; preview: Record<string, unknown> }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('medium')
|
||||
expect(result.preview.employee_count).toBe(1)
|
||||
expect(result.preview.total_ytd_gross).toBe(210000)
|
||||
// The write table is never touched at staging.
|
||||
const inserted = supabaseMock.inserts.employee_opening_balances
|
||||
expect(inserted).toBeUndefined()
|
||||
})
|
||||
|
||||
it('throws with the per-item error list when locked', async () => {
|
||||
const supabaseMock = makeCapturingSupabase({
|
||||
employees: {
|
||||
data: [{ id: EMPLOYEE_ID, employment_start: '2024-01-15', is_active: true }],
|
||||
},
|
||||
salary_run_employees: {
|
||||
data: [{ employee_id: EMPLOYEE_ID, salary_run: { id: 'run-1', status: 'booked' } }],
|
||||
},
|
||||
})
|
||||
|
||||
await expect(
|
||||
setOpeningBalances.execute(
|
||||
{ items: [validItem] },
|
||||
'company-1', 'user-1', supabaseMock as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/Locked by booked salary run/)
|
||||
})
|
||||
|
||||
it('rejects invalid items via the shared Zod schema', async () => {
|
||||
const { supabase } = createQueuedMockSupabase()
|
||||
await expect(
|
||||
setOpeningBalances.execute(
|
||||
{ items: [{ ...validItem, cutover_date: `${CURRENT_YEAR}-07-15` }] },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/Invalid opening balances/)
|
||||
})
|
||||
})
|
||||
|
||||
describe('gnubok_close_vacation_year', () => {
|
||||
const SAMPLE_REPORT = {
|
||||
vacation_year_start: '2025-01-01',
|
||||
vacation_year_end: '2025-12-31',
|
||||
next_year_start: '2026-01-01',
|
||||
basis: 'calendar',
|
||||
rows: [
|
||||
{
|
||||
employee_id: 'emp-1',
|
||||
employee_name: 'Anna Andersson',
|
||||
saveable_days: 5,
|
||||
expiring_days: 2,
|
||||
},
|
||||
],
|
||||
sek: {
|
||||
computed_liability: 18690.84,
|
||||
computed_avgifter: 5872.66,
|
||||
booked_2920: 10000,
|
||||
booked_2940: 3142,
|
||||
drift_2920: 8690.84,
|
||||
drift_2940: 2730.66,
|
||||
adjustment_needed: true,
|
||||
},
|
||||
adjustment_date: '2025-12-31',
|
||||
}
|
||||
|
||||
it('stages HIGH risk with the review report in the preview', async () => {
|
||||
mockPreviewClose.mockResolvedValue({ ok: true, data: SAMPLE_REPORT })
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { salary_vacation_year_basis: 'calendar' } }) // basis lookup (year default)
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: company_settings
|
||||
enqueue({ data: null }) // resolvePeriodStatusForDate: fiscal_periods
|
||||
enqueue({ data: { id: 'op-6' }, error: null }) // pending_operations insert
|
||||
|
||||
const result = (await closeVacationYear.execute(
|
||||
{}, 'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
)) as { staged: boolean; risk_level: string; preview: Record<string, unknown> }
|
||||
|
||||
expect(result.staged).toBe(true)
|
||||
expect(result.risk_level).toBe('high')
|
||||
expect(result.preview.employee_count).toBe(1)
|
||||
expect(result.preview.drift_2920).toBe(8690.84)
|
||||
expect(result.preview.adjustment_needed).toBe(true)
|
||||
})
|
||||
|
||||
it('fails staging when the preview refuses (already closed)', async () => {
|
||||
mockPreviewClose.mockResolvedValue({ ok: false, code: 'VACATION_YEAR_ALREADY_CLOSED' })
|
||||
const { supabase, enqueue } = createQueuedMockSupabase()
|
||||
enqueue({ data: { salary_vacation_year_basis: 'calendar' } })
|
||||
|
||||
await expect(
|
||||
closeVacationYear.execute(
|
||||
{ vacation_year_start: '2025-01-01' },
|
||||
'company-1', 'user-1', supabase as never, { type: 'agent_chat' },
|
||||
),
|
||||
).rejects.toThrow(/VACATION_YEAR_ALREADY_CLOSED/)
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,80 @@
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { assertNoPlaintextPersonnummer } from '../staging-pii-guard'
|
||||
|
||||
describe('assertNoPlaintextPersonnummer', () => {
|
||||
it('throws on a top-level plaintext personnummer key in params', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{ first_name: 'Test', personnummer: '198501011234' },
|
||||
'params',
|
||||
),
|
||||
).toThrow(/params contains plaintext PII key "personnummer"/)
|
||||
})
|
||||
|
||||
it('throws when the key is nested inside a patch object (update-style staging)', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{ employee_id: 'e-1', patch: { personnummer: '198501011234' } },
|
||||
'params',
|
||||
),
|
||||
).toThrow(/plaintext PII key "personnummer"/)
|
||||
})
|
||||
|
||||
it('throws when the key hides inside an array of row objects', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{ rows: [{ amount: 100 }, { ssn: '850101-1234' }] },
|
||||
'preview_data',
|
||||
),
|
||||
).toThrow(/preview_data contains plaintext PII key "ssn"/)
|
||||
})
|
||||
|
||||
it('allows the encrypted/masked derivatives that create_employee stages', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{
|
||||
first_name: 'Test',
|
||||
personnummer_encrypted: 'v1:abcdef',
|
||||
personnummer_last4: '1234',
|
||||
personnummer_masked: '850101-****',
|
||||
},
|
||||
'params',
|
||||
),
|
||||
).not.toThrow()
|
||||
})
|
||||
|
||||
it('allows ordinary payloads: UUIDs, dates, aggregates, names', () => {
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer(
|
||||
{
|
||||
employee_id: 'b7f8d1a2-0000-0000-0000-000000000000',
|
||||
from: '2026-07-01',
|
||||
to: '2026-07-05',
|
||||
absence_type: 'sick',
|
||||
hours_per_day: 8,
|
||||
notes: null,
|
||||
},
|
||||
'params',
|
||||
),
|
||||
).not.toThrow()
|
||||
})
|
||||
|
||||
it('fails closed when the payload nests past the scan depth (PII could hide below)', () => {
|
||||
// Before the fail-closed change, the scanner silently accepted anything
|
||||
// past MAX_DEPTH, so this personnummer would have been persisted.
|
||||
const payload = {
|
||||
l1: { l2: { l3: { l4: { l5: { l6: { l7: { personnummer: '198501011234' } } } } } } },
|
||||
}
|
||||
expect(() => assertNoPlaintextPersonnummer(payload, 'params')).toThrow(
|
||||
/cannot be scanned for plaintext PII/,
|
||||
)
|
||||
})
|
||||
|
||||
it('does not value-match: an EF org number equal to a personnummer passes under a business key', () => {
|
||||
// For enskild firma the org number IS the owner's personnummer; the
|
||||
// guard is key-based so legitimate counterparty data stays stageable.
|
||||
expect(() =>
|
||||
assertNoPlaintextPersonnummer({ org_number: '850101-1234' }, 'params'),
|
||||
).not.toThrow()
|
||||
})
|
||||
})
|
||||
@@ -59,6 +59,7 @@ import {
|
||||
} from '@/lib/api/idempotency'
|
||||
import { toToolError, type NextActionHint } from './tool-result'
|
||||
import { findSupplierCandidates } from './supplier-candidates'
|
||||
import { assertNoPlaintextPersonnummer } from './staging-pii-guard'
|
||||
import { generateBalanceSheet } from '@/lib/reports/balance-sheet'
|
||||
import { generateGeneralLedger } from '@/lib/reports/general-ledger'
|
||||
import { decryptPersonnummer, maskPersonnummer } from '@/lib/salary/personnummer'
|
||||
@@ -291,6 +292,12 @@ async function stagePendingOperation(
|
||||
period_status?: PeriodStatusForDate
|
||||
next?: NextActionHint
|
||||
}> {
|
||||
// PII chokepoint (ISO 27001 A.8.11): no staged payload may persist a
|
||||
// plaintext personnummer. Enforced here so every current and future
|
||||
// staging tool inherits the rule, not just the ones that remembered it.
|
||||
assertNoPlaintextPersonnummer(params, 'params')
|
||||
assertNoPlaintextPersonnummer(previewData, 'preview_data')
|
||||
|
||||
const riskLevel = getRiskLevel(operationType)
|
||||
const branding = getBranding().appName.toLowerCase()
|
||||
|
||||
@@ -9041,6 +9048,787 @@ export const tools: McpTool[] = [
|
||||
}
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_get_employee',
|
||||
title: 'Get Employee',
|
||||
description: 'Get one employee\'s full payroll config: salary, tax table/column, jamkning, F-skatt, vacation rule, vaxa-stod, bank details, dimensions. Personnummer masked. Use after gnubok_list_employees to drill into one employee before payroll work.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
},
|
||||
required: ['employee_id'],
|
||||
},
|
||||
outputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string' },
|
||||
first_name: { type: 'string' },
|
||||
last_name: { type: 'string' },
|
||||
personnummer_masked: { type: 'string' },
|
||||
employment: { type: 'object', description: 'Type, start/end, degree' },
|
||||
pay: { type: 'object', description: 'Salary type + amounts' },
|
||||
tax: { type: 'object', description: 'Table, column, municipality, jamkning, F-skatt, sidoinkomst' },
|
||||
vacation: { type: 'object', description: 'Rule, days per year, saved days, tillagg rate' },
|
||||
vaxa_stod: { type: 'object', description: 'Eligibility window' },
|
||||
bank: { type: 'object', description: 'Clearing + account (payment routing)' },
|
||||
default_dimensions: { type: 'object' },
|
||||
is_active: { type: 'boolean' },
|
||||
},
|
||||
required: ['employee_id', 'first_name', 'last_name', 'personnummer_masked', 'is_active'],
|
||||
},
|
||||
annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false },
|
||||
async execute(args, companyId, _userId, supabase) {
|
||||
const employeeId = args.employee_id as string
|
||||
if (!employeeId) throw new Error('employee_id is required')
|
||||
const { data: e, error } = await supabase
|
||||
.from('employees')
|
||||
.select(
|
||||
'id, first_name, last_name, personnummer, employment_type, employment_start, employment_end, employment_degree, hours_per_week, workdays_per_week, salary_type, monthly_salary, hourly_rate, tax_table_number, tax_column, tax_municipality, is_sidoinkomst, f_skatt_status, f_skatt_verified_at, jamkning_percentage, jamkning_valid_from, jamkning_valid_to, clearing_number, bank_account_number, vacation_rule, vacation_days_per_year, vacation_days_saved, semestertillagg_rate, vaxa_stod_eligible, vaxa_stod_start, vaxa_stod_end, default_dimensions, is_active',
|
||||
)
|
||||
.eq('id', employeeId)
|
||||
.eq('company_id', companyId)
|
||||
.maybeSingle()
|
||||
if (error) throw new Error(`Database error: ${error.message}`)
|
||||
if (!e) throw new Error('Employee not found')
|
||||
// LLM context is a leak surface: personnummer is ALWAYS masked on MCP,
|
||||
// there is no full-value drill-in on this surface.
|
||||
return {
|
||||
employee_id: e.id,
|
||||
first_name: e.first_name,
|
||||
last_name: e.last_name,
|
||||
personnummer_masked: maskPersonnummer(decryptPersonnummer(e.personnummer as string)),
|
||||
employment: {
|
||||
employment_type: e.employment_type,
|
||||
employment_start: e.employment_start,
|
||||
employment_end: e.employment_end,
|
||||
employment_degree: e.employment_degree,
|
||||
hours_per_week: e.hours_per_week,
|
||||
workdays_per_week: e.workdays_per_week,
|
||||
},
|
||||
pay: {
|
||||
salary_type: e.salary_type,
|
||||
monthly_salary: e.monthly_salary,
|
||||
hourly_rate: e.hourly_rate,
|
||||
},
|
||||
tax: {
|
||||
tax_table_number: e.tax_table_number,
|
||||
tax_column: e.tax_column,
|
||||
tax_municipality: e.tax_municipality,
|
||||
is_sidoinkomst: e.is_sidoinkomst,
|
||||
f_skatt_status: e.f_skatt_status,
|
||||
f_skatt_verified_at: e.f_skatt_verified_at,
|
||||
jamkning_percentage: e.jamkning_percentage,
|
||||
jamkning_valid_from: e.jamkning_valid_from,
|
||||
jamkning_valid_to: e.jamkning_valid_to,
|
||||
},
|
||||
vacation: {
|
||||
vacation_rule: e.vacation_rule,
|
||||
vacation_days_per_year: e.vacation_days_per_year,
|
||||
vacation_days_saved: e.vacation_days_saved,
|
||||
semestertillagg_rate: e.semestertillagg_rate,
|
||||
},
|
||||
vaxa_stod: {
|
||||
eligible: e.vaxa_stod_eligible,
|
||||
start: e.vaxa_stod_start,
|
||||
end: e.vaxa_stod_end,
|
||||
},
|
||||
bank: {
|
||||
clearing_number: e.clearing_number,
|
||||
bank_account_number: e.bank_account_number,
|
||||
},
|
||||
default_dimensions: e.default_dimensions ?? {},
|
||||
is_active: e.is_active,
|
||||
}
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_get_payslip',
|
||||
title: 'Get Payslip (Lönebesked)',
|
||||
description: 'Get one employee\'s payslip in a salary run: gross, tax, avgifter, net, every line item and the step-by-step calculation breakdown. Personnummer masked. Use after gnubok_get_salary_run to verify how one employee\'s pay was computed.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
salary_run_id: { type: 'string', description: 'UUID of the salary run' },
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
},
|
||||
required: ['salary_run_id', 'employee_id'],
|
||||
},
|
||||
outputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
salary_run_employee_id: { type: 'string' },
|
||||
salary_run_id: { type: 'string' },
|
||||
employee_id: { type: 'string' },
|
||||
employee_name: { type: 'string' },
|
||||
personnummer_masked: { type: 'string' },
|
||||
amounts: { type: 'object', description: 'Gross, taxable, tax, net, avgifter, vacation accrual, YTD' },
|
||||
overrides: { type: 'object', description: 'Manual tax/avgifter overrides + reason (effective = override ?? calculated)' },
|
||||
absence_days: { type: 'object', description: 'Sick/vab/parental/vacation day counts' },
|
||||
line_items: { type: 'array', items: { type: 'object' }, description: 'Each with salary_line_item_id' },
|
||||
calculation_breakdown: { type: 'object', description: 'Step-by-step engine breakdown; null until calculated' },
|
||||
},
|
||||
required: ['salary_run_employee_id', 'salary_run_id', 'employee_id', 'employee_name', 'personnummer_masked', 'amounts', 'line_items'],
|
||||
},
|
||||
annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false },
|
||||
async execute(args, companyId, _userId, supabase) {
|
||||
const salaryRunId = args.salary_run_id as string
|
||||
const employeeId = args.employee_id as string
|
||||
if (!salaryRunId || !employeeId) throw new Error('salary_run_id and employee_id are required')
|
||||
const { data: sre, error } = await supabase
|
||||
.from('salary_run_employees')
|
||||
.select(
|
||||
'*, employee:employees(first_name, last_name, personnummer), line_items:salary_line_items(id, item_type, description, quantity, unit_price, amount, is_taxable, is_avgift_basis, is_vacation_basis, is_gross_deduction, is_net_deduction, account_number, sort_order)',
|
||||
)
|
||||
.eq('salary_run_id', salaryRunId)
|
||||
.eq('employee_id', employeeId)
|
||||
.eq('company_id', companyId)
|
||||
.maybeSingle()
|
||||
if (error) throw new Error(`Database error: ${error.message}`)
|
||||
if (!sre) throw new Error('Employee not found in this salary run')
|
||||
const emp = sre.employee as { first_name: string; last_name: string; personnummer: string } | null
|
||||
const lineItems = ((sre.line_items ?? []) as Array<Record<string, unknown>>)
|
||||
.slice()
|
||||
.sort((a, b) => ((a.sort_order as number) ?? 0) - ((b.sort_order as number) ?? 0))
|
||||
.map(({ id, ...rest }) => ({ salary_line_item_id: id, ...rest }))
|
||||
return {
|
||||
salary_run_employee_id: sre.id,
|
||||
salary_run_id: salaryRunId,
|
||||
employee_id: employeeId,
|
||||
employee_name: emp ? `${emp.first_name} ${emp.last_name}` : '',
|
||||
personnummer_masked: emp ? maskPersonnummer(decryptPersonnummer(emp.personnummer)) : '',
|
||||
amounts: {
|
||||
gross_salary: sre.gross_salary,
|
||||
gross_deductions: sre.gross_deductions,
|
||||
benefit_values: sre.benefit_values,
|
||||
taxable_income: sre.taxable_income,
|
||||
tax_withheld: sre.tax_withheld,
|
||||
net_deductions: sre.net_deductions,
|
||||
net_salary: sre.net_salary,
|
||||
avgifter_rate: sre.avgifter_rate,
|
||||
avgifter_basis: sre.avgifter_basis,
|
||||
avgifter_amount: sre.avgifter_amount,
|
||||
avgifter_category: sre.avgifter_category,
|
||||
vacation_accrual: sre.vacation_accrual,
|
||||
vacation_accrual_avgifter: sre.vacation_accrual_avgifter,
|
||||
ytd_gross: sre.ytd_gross,
|
||||
ytd_tax: sre.ytd_tax,
|
||||
ytd_net: sre.ytd_net,
|
||||
},
|
||||
overrides: {
|
||||
tax_withheld_override: sre.tax_withheld_override,
|
||||
avgifter_amount_override: sre.avgifter_amount_override,
|
||||
avgifter_basis_override: sre.avgifter_basis_override,
|
||||
override_reason: sre.override_reason,
|
||||
},
|
||||
absence_days: {
|
||||
sick_days: sre.sick_days,
|
||||
vab_days: sre.vab_days,
|
||||
parental_days: sre.parental_days,
|
||||
vacation_days_taken: sre.vacation_days_taken,
|
||||
},
|
||||
line_items: lineItems,
|
||||
calculation_breakdown: sre.calculation_breakdown ?? null,
|
||||
}
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_list_absence',
|
||||
title: 'List Absence (Frånvaro)',
|
||||
description: 'List an employee\'s registered absence days (sick, vab, parental, ...) in a date range, max 92 days. These per-day rows drive karensavdrag and sjuklön at calculation time. Use before gnubok_register_absence to see what is already registered.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
from: { type: 'string', description: 'Range start (YYYY-MM-DD, inclusive)' },
|
||||
to: { type: 'string', description: 'Range end (YYYY-MM-DD, inclusive, max 92 days)' },
|
||||
absence_type: {
|
||||
type: 'string',
|
||||
enum: ['sick', 'vab', 'parental', 'pregnancy', 'care_relative', 'study', 'unpaid_leave', 'other_leave'],
|
||||
description: 'Optional filter',
|
||||
},
|
||||
},
|
||||
required: ['employee_id', 'from', 'to'],
|
||||
},
|
||||
outputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
absence_days: { type: 'array', items: { type: 'object' }, description: 'Each with salary_absence_day_id' },
|
||||
count: { type: 'number' },
|
||||
},
|
||||
required: ['absence_days', 'count'],
|
||||
},
|
||||
annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false },
|
||||
async execute(args, companyId, _userId, supabase) {
|
||||
const { employee_id, from, to, absence_type } = args as {
|
||||
employee_id: string; from: string; to: string; absence_type?: string
|
||||
}
|
||||
if (!employee_id || !from || !to) throw new Error('employee_id, from and to are required')
|
||||
const { listAbsenceDays } = await import('@/lib/salary/absence')
|
||||
const result = await listAbsenceDays(supabase, {
|
||||
companyId,
|
||||
employeeId: employee_id,
|
||||
from,
|
||||
to,
|
||||
absenceType: absence_type,
|
||||
})
|
||||
if (!result.ok) throw new Error(result.code === 'EMPLOYEE_NOT_FOUND' ? 'Employee not found' : `Failed to list absence: ${result.code}`)
|
||||
const days = result.data.map(({ id, ...rest }) => ({ salary_absence_day_id: id, ...rest }))
|
||||
return { absence_days: days, count: days.length }
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_update_payslip_line',
|
||||
title: 'Update Payslip Line',
|
||||
description: 'Stage an edit to one payslip line (amount, description, quantity, unit price) in a DRAFT salary run. Commit via gnubok_approve_pending_operation, then re-run gnubok_calculate_salary_run: line edits never recompute tax by themselves.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
salary_run_id: { type: 'string', description: 'UUID of the salary run (must be draft)' },
|
||||
salary_line_item_id: { type: 'string', description: 'UUID of the payslip line to edit' },
|
||||
amount: { type: 'number', description: 'New amount (SEK)' },
|
||||
description: { type: 'string', description: 'New line description' },
|
||||
quantity: { type: 'number', description: 'New quantity' },
|
||||
unit_price: { type: 'number', description: 'New unit price (SEK)' },
|
||||
},
|
||||
required: ['salary_run_id', 'salary_line_item_id'],
|
||||
},
|
||||
outputSchema: STAGED_OPERATION_SCHEMA,
|
||||
annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: false, openWorldHint: false },
|
||||
async execute(args, companyId, userId, supabase, actor) {
|
||||
const { salary_run_id, salary_line_item_id, amount, description, quantity, unit_price } = args as {
|
||||
salary_run_id: string; salary_line_item_id: string
|
||||
amount?: number; description?: string; quantity?: number; unit_price?: number
|
||||
}
|
||||
if (!salary_run_id || !salary_line_item_id) {
|
||||
throw new Error('salary_run_id and salary_line_item_id are required')
|
||||
}
|
||||
const patch: Record<string, unknown> = {}
|
||||
if (amount !== undefined) patch.amount = amount
|
||||
if (description !== undefined) patch.description = description
|
||||
if (quantity !== undefined) patch.quantity = quantity
|
||||
if (unit_price !== undefined) patch.unit_price = unit_price
|
||||
if (Object.keys(patch).length === 0) {
|
||||
throw new Error('At least one of amount, description, quantity, unit_price is required')
|
||||
}
|
||||
|
||||
// Preflight via the shared service in dry-run: verifies draft status and
|
||||
// that the line belongs to this run, and yields the merged row for the
|
||||
// preview. No writes here: the commit path re-runs the service for real.
|
||||
const { updatePayslipLine } = await import('@/lib/salary/payslip-lines')
|
||||
const preflight = await updatePayslipLine(supabase, {
|
||||
companyId,
|
||||
salaryRunId: salary_run_id,
|
||||
lineId: salary_line_item_id,
|
||||
patch: patch as never,
|
||||
dryRun: true,
|
||||
})
|
||||
if (!preflight.ok) {
|
||||
throw new Error(`Cannot update payslip line: ${preflight.code}`)
|
||||
}
|
||||
const merged = preflight.data
|
||||
|
||||
const { data: run } = await supabase
|
||||
.from('salary_runs')
|
||||
.select('payment_date')
|
||||
.eq('id', salary_run_id)
|
||||
.eq('company_id', companyId)
|
||||
.maybeSingle()
|
||||
|
||||
return stagePendingOperation(
|
||||
supabase, companyId, userId, 'update_payslip_line',
|
||||
`Uppdatera lönebeskedsrad: ${merged.description}`,
|
||||
{ salary_run_id, salary_line_item_id, patch },
|
||||
{
|
||||
salary_run_id,
|
||||
salary_line_item_id,
|
||||
item_type: merged.item_type,
|
||||
description: merged.description,
|
||||
new_amount: merged.amount,
|
||||
changes: patch,
|
||||
},
|
||||
actor,
|
||||
{
|
||||
description: 'After approval, recalculate the run so tax and totals reflect the edit.',
|
||||
tool: 'gnubok_calculate_salary_run',
|
||||
},
|
||||
run?.payment_date ? { dateForPeriodCheck: run.payment_date as string } : {},
|
||||
)
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_register_absence',
|
||||
title: 'Register Absence (Frånvaro)',
|
||||
description: 'Stage absence registration (sick, vab, parental, ...) for an employee over a date range, max 92 days, weekends skipped unless included. Commit via gnubok_approve_pending_operation; recalculate any open salary run afterwards.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
from: { type: 'string', description: 'Range start (YYYY-MM-DD, inclusive)' },
|
||||
to: { type: 'string', description: 'Range end (YYYY-MM-DD, inclusive; single day = same as from)' },
|
||||
absence_type: {
|
||||
type: 'string',
|
||||
enum: ['sick', 'vab', 'parental', 'pregnancy', 'care_relative', 'study', 'unpaid_leave', 'other_leave'],
|
||||
description: 'Absence type',
|
||||
},
|
||||
hours_per_day: { type: 'number', description: 'Hours per day (default 8; use e.g. 4 for half days)' },
|
||||
notes: { type: 'string', description: 'Optional note' },
|
||||
include_weekends: { type: 'boolean', description: 'Also register Saturday/Sunday (default false)' },
|
||||
},
|
||||
required: ['employee_id', 'from', 'to', 'absence_type'],
|
||||
},
|
||||
outputSchema: STAGED_OPERATION_SCHEMA,
|
||||
annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: false, openWorldHint: false },
|
||||
async execute(args, companyId, userId, supabase, actor) {
|
||||
const { employee_id, from, to, absence_type, hours_per_day, notes, include_weekends } = args as {
|
||||
employee_id: string; from: string; to: string; absence_type: string
|
||||
hours_per_day?: number; notes?: string; include_weekends?: boolean
|
||||
}
|
||||
if (!employee_id || !from || !to || !absence_type) {
|
||||
throw new Error('employee_id, from, to and absence_type are required')
|
||||
}
|
||||
if (!/^\d{4}-\d{2}-\d{2}$/.test(from) || !/^\d{4}-\d{2}-\d{2}$/.test(to)) {
|
||||
throw new Error('from and to must be YYYY-MM-DD')
|
||||
}
|
||||
|
||||
// Preflight in dry-run: verifies the employee and expands the range so
|
||||
// the approver sees exactly which days would be written.
|
||||
const { upsertAbsenceRange } = await import('@/lib/salary/absence')
|
||||
const preflight = await upsertAbsenceRange(supabase, {
|
||||
companyId,
|
||||
employeeId: employee_id,
|
||||
from,
|
||||
to,
|
||||
absenceType: absence_type,
|
||||
hoursPerDay: hours_per_day,
|
||||
notes: notes ?? null,
|
||||
includeWeekends: include_weekends,
|
||||
dryRun: true,
|
||||
})
|
||||
if (!preflight.ok) {
|
||||
throw new Error(`Cannot register absence: ${preflight.code}`)
|
||||
}
|
||||
|
||||
const { data: emp } = await supabase
|
||||
.from('employees')
|
||||
.select('first_name, last_name')
|
||||
.eq('id', employee_id)
|
||||
.eq('company_id', companyId)
|
||||
.maybeSingle()
|
||||
const employeeName = emp ? `${emp.first_name} ${emp.last_name}` : employee_id
|
||||
|
||||
return stagePendingOperation(
|
||||
supabase, companyId, userId, 'register_absence',
|
||||
`Registrera frånvaro: ${employeeName}, ${absence_type} ${from}${to !== from ? ` till ${to}` : ''}`,
|
||||
{ employee_id, from, to, absence_type, hours_per_day: hours_per_day ?? 8, notes: notes ?? null, include_weekends: include_weekends ?? false },
|
||||
{
|
||||
employee_id,
|
||||
employee_name: employeeName,
|
||||
absence_type,
|
||||
from,
|
||||
to,
|
||||
day_count: preflight.data.count,
|
||||
hours_per_day: hours_per_day ?? 8,
|
||||
dates_sample: preflight.data.days.slice(0, 10).map((d) => (d as { absence_date: string }).absence_date),
|
||||
},
|
||||
actor,
|
||||
{
|
||||
description: 'If a draft salary run covers this period, recalculate it so sjuklön/karensavdrag lines update.',
|
||||
tool: 'gnubok_calculate_salary_run',
|
||||
},
|
||||
{ dateForPeriodCheck: from },
|
||||
)
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_create_employee',
|
||||
title: 'Create Employee',
|
||||
description: 'Stage creation of a new employee: salary, tax table, bank details, vacation rule. Personnummer is encrypted at staging and never stored in plaintext. Commit via gnubok_approve_pending_operation; then attach to a salary run.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
first_name: { type: 'string' },
|
||||
last_name: { type: 'string' },
|
||||
personnummer: { type: 'string', description: '12 digits (YYYYMMDDNNNN). Encrypted at staging.' },
|
||||
employment_type: { type: 'string', enum: ['employee', 'company_owner', 'board_member'] },
|
||||
employment_start: { type: 'string' },
|
||||
employment_end: { type: 'string' },
|
||||
employment_degree: { type: 'number', description: '1-100 (default 100)' },
|
||||
hours_per_week: { type: 'number', description: 'Schedule hours/week (default 40; drives hourly divisor)' },
|
||||
workdays_per_week: { type: 'number', description: 'Schedule days/week (default 5; drives daily divisor)' },
|
||||
salary_type: { type: 'string', enum: ['monthly', 'hourly'] },
|
||||
monthly_salary: { type: 'number' },
|
||||
hourly_rate: { type: 'number' },
|
||||
tax_table_number: { type: 'number', description: '29-42; required for A-skatt non-sidoinkomst' },
|
||||
tax_column: { type: 'number' },
|
||||
tax_municipality: { type: 'string' },
|
||||
is_sidoinkomst: { type: 'boolean' },
|
||||
f_skatt_status: { type: 'string', enum: ['a_skatt', 'f_skatt', 'fa_skatt', 'not_verified'] },
|
||||
clearing_number: { type: 'string' },
|
||||
bank_account_number: { type: 'string' },
|
||||
vacation_rule: { type: 'string', enum: ['procentregeln', 'sammaloneregeln', 'semesterersattning', 'none'] },
|
||||
vacation_days_per_year: { type: 'number' },
|
||||
email: { type: 'string' },
|
||||
phone: { type: 'string' },
|
||||
vaxa_stod_eligible: { type: 'boolean' },
|
||||
vaxa_stod_start: { type: 'string' },
|
||||
vaxa_stod_end: { type: 'string' },
|
||||
jamkning_percentage: { type: 'number' },
|
||||
jamkning_valid_from: { type: 'string' },
|
||||
jamkning_valid_to: { type: 'string' },
|
||||
},
|
||||
required: ['first_name', 'last_name', 'personnummer', 'employment_start'],
|
||||
},
|
||||
outputSchema: STAGED_OPERATION_SCHEMA,
|
||||
annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: false, openWorldHint: false },
|
||||
async execute(args, companyId, userId, supabase, actor) {
|
||||
const { CreateEmployeeSchema } = await import('@/lib/api/schemas')
|
||||
const parsed = CreateEmployeeSchema.safeParse(args)
|
||||
if (!parsed.success) {
|
||||
const first = parsed.error.issues[0]
|
||||
throw new Error(`Invalid employee: ${first ? `${first.path.join('.')}: ${first.message}` : 'validation failed'}`)
|
||||
}
|
||||
const body = parsed.data
|
||||
|
||||
// Preflight the EF-owner rule so staging fails early with a clean error.
|
||||
const { getCompanyEntityType } = await import('@/lib/company/context')
|
||||
const { isEmploymentTypeAllowedForEntity, EF_OWNER_EMPLOYMENT_ERROR } = await import('@/lib/salary/employment-rules')
|
||||
const entityType = await getCompanyEntityType(supabase, companyId)
|
||||
if (!isEmploymentTypeAllowedForEntity(entityType, body.employment_type)) {
|
||||
throw new Error(EF_OWNER_EMPLOYMENT_ERROR)
|
||||
}
|
||||
|
||||
// PII rule: encrypt AT STAGING TIME. pending_operations.params never
|
||||
// holds the plaintext personnummer; previews and titles carry the
|
||||
// masked form only.
|
||||
const { encryptPersonnummer, extractLast4 } = await import('@/lib/salary/personnummer')
|
||||
const { personnummer, ...fields } = body
|
||||
const params: Record<string, unknown> = {
|
||||
...fields,
|
||||
personnummer_encrypted: encryptPersonnummer(personnummer),
|
||||
personnummer_last4: extractLast4(personnummer),
|
||||
}
|
||||
const masked = maskPersonnummer(personnummer)
|
||||
|
||||
return stagePendingOperation(
|
||||
supabase, companyId, userId, 'create_employee',
|
||||
`Skapa anställd: ${body.first_name} ${body.last_name}`,
|
||||
params,
|
||||
{
|
||||
first_name: body.first_name,
|
||||
last_name: body.last_name,
|
||||
personnummer_masked: masked,
|
||||
employment_type: body.employment_type,
|
||||
employment_start: body.employment_start,
|
||||
salary_type: body.salary_type,
|
||||
monthly_salary: body.monthly_salary ?? null,
|
||||
hourly_rate: body.hourly_rate ?? null,
|
||||
tax_table_number: body.tax_table_number ?? null,
|
||||
bank_details_provided: !!(body.clearing_number && body.bank_account_number),
|
||||
},
|
||||
actor,
|
||||
{
|
||||
description: 'After approval, attach the employee to a salary run.',
|
||||
tool: 'gnubok_create_salary_run',
|
||||
},
|
||||
)
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_update_employee',
|
||||
title: 'Update Employee',
|
||||
description: 'Stage an update to an employee\'s payroll config: salary, tax, bank details, vacation rule, jamkning, vaxa-stod. Personnummer cannot be changed. Call gnubok_get_employee first to see current values; commit via gnubok_approve_pending_operation.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
first_name: { type: 'string' },
|
||||
last_name: { type: 'string' },
|
||||
employment_type: { type: 'string', enum: ['employee', 'company_owner', 'board_member'] },
|
||||
employment_start: { type: 'string' },
|
||||
employment_end: { type: 'string' },
|
||||
employment_degree: { type: 'number' },
|
||||
hours_per_week: { type: 'number' },
|
||||
workdays_per_week: { type: 'number' },
|
||||
salary_type: { type: 'string', enum: ['monthly', 'hourly'] },
|
||||
monthly_salary: { type: 'number' },
|
||||
hourly_rate: { type: 'number' },
|
||||
tax_table_number: { type: 'number' },
|
||||
tax_column: { type: 'number' },
|
||||
tax_municipality: { type: 'string' },
|
||||
is_sidoinkomst: { type: 'boolean' },
|
||||
f_skatt_status: { type: 'string', enum: ['a_skatt', 'f_skatt', 'fa_skatt', 'not_verified'] },
|
||||
clearing_number: { type: 'string' },
|
||||
bank_account_number: { type: 'string' },
|
||||
vacation_rule: { type: 'string', enum: ['procentregeln', 'sammaloneregeln', 'semesterersattning', 'none'] },
|
||||
vacation_days_per_year: { type: 'number' },
|
||||
email: { type: 'string' },
|
||||
phone: { type: 'string' },
|
||||
is_active: { type: 'boolean', description: 'false soft-deactivates (BFL retention keeps the row)' },
|
||||
vaxa_stod_eligible: { type: 'boolean' },
|
||||
vaxa_stod_start: { type: 'string' },
|
||||
vaxa_stod_end: { type: 'string' },
|
||||
jamkning_percentage: { type: ['number', 'null'], description: 'null clears the beslut' },
|
||||
jamkning_valid_from: { type: ['string', 'null'] },
|
||||
jamkning_valid_to: { type: ['string', 'null'] },
|
||||
},
|
||||
required: ['employee_id'],
|
||||
},
|
||||
outputSchema: STAGED_OPERATION_SCHEMA,
|
||||
annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: false, openWorldHint: false },
|
||||
async execute(args, companyId, userId, supabase, actor) {
|
||||
const { employee_id, ...rest } = args as { employee_id: string } & Record<string, unknown>
|
||||
if (!employee_id) throw new Error('employee_id is required')
|
||||
if ('personnummer' in rest) {
|
||||
throw new Error('personnummer cannot be changed: identity is immutable post-create')
|
||||
}
|
||||
|
||||
const patch: Record<string, unknown> = {}
|
||||
for (const [key, value] of Object.entries(rest)) {
|
||||
if (value !== undefined) patch[key] = value
|
||||
}
|
||||
if (Object.keys(patch).length === 0) {
|
||||
throw new Error('At least one field to update is required')
|
||||
}
|
||||
|
||||
const { data: existing, error } = await supabase
|
||||
.from('employees')
|
||||
.select('*')
|
||||
.eq('id', employee_id)
|
||||
.eq('company_id', companyId)
|
||||
.maybeSingle()
|
||||
if (error) throw new Error(`Database error: ${error.message}`)
|
||||
if (!existing) throw new Error('Employee not found')
|
||||
|
||||
const changes = Object.entries(patch).map(([field, to]) => ({
|
||||
field,
|
||||
from: (existing as Record<string, unknown>)[field] ?? null,
|
||||
to,
|
||||
}))
|
||||
const bankChanged = changes.some((c) => c.field === 'clearing_number' || c.field === 'bank_account_number')
|
||||
|
||||
return stagePendingOperation(
|
||||
supabase, companyId, userId, 'update_employee',
|
||||
`Uppdatera anställd: ${existing.first_name} ${existing.last_name}`,
|
||||
{ employee_id, patch },
|
||||
{
|
||||
employee_id,
|
||||
employee_name: `${existing.first_name} ${existing.last_name}`,
|
||||
changes,
|
||||
// Bank routing changes are the BEC/fraud surface: surface them
|
||||
// prominently so the approver cannot miss a rerouted payment.
|
||||
bank_details_changed: bankChanged,
|
||||
},
|
||||
actor,
|
||||
)
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_set_employee_opening_balances',
|
||||
title: 'Set Employee Opening Balances (Cutover)',
|
||||
description: 'Stage payroll cutover state for one or more employees migrating mid-year: YTD gross/tax/net, vacation days remaining, sparade dagar by origin year, opening semesterlöneskuld SEK, karens adjustment. Locked once the employee has a booked run.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
items: {
|
||||
type: 'array',
|
||||
minItems: 1,
|
||||
maxItems: 200,
|
||||
items: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
cutover_date: { type: 'string', description: 'First day of the first Accounted-run month (YYYY-MM-01)' },
|
||||
ytd_gross: { type: 'number' },
|
||||
ytd_tax: { type: 'number' },
|
||||
ytd_net: { type: 'number' },
|
||||
vacation_paid_days_remaining: { type: 'number' },
|
||||
vacation_saved_days_by_year: { type: 'object', description: 'Origin year -> days, e.g. {"2025": 5}' },
|
||||
opening_semester_liability: { type: 'number', description: 'SEK on 2920 (report-only; booked via SIE)' },
|
||||
opening_semester_liability_avgifter: { type: 'number', description: 'SEK on 2940' },
|
||||
karens_periods_adjustment: { type: 'number', description: 'Karens periods last 12 months not imported as absence rows (0-10)' },
|
||||
},
|
||||
required: ['employee_id', 'cutover_date'],
|
||||
},
|
||||
},
|
||||
},
|
||||
required: ['items'],
|
||||
},
|
||||
outputSchema: STAGED_OPERATION_SCHEMA,
|
||||
annotations: { readOnlyHint: false, destructiveHint: false, idempotentHint: true, openWorldHint: false },
|
||||
async execute(args, companyId, userId, supabase, actor) {
|
||||
const { OpeningBalancesBulkSchema } = await import('@/lib/api/schemas')
|
||||
const parsed = OpeningBalancesBulkSchema.safeParse(args)
|
||||
if (!parsed.success) {
|
||||
const first = parsed.error.issues[0]
|
||||
throw new Error(`Invalid opening balances: ${first ? `${first.path.join('.')}: ${first.message}` : 'validation failed'}`)
|
||||
}
|
||||
|
||||
// Preflight via the shared service in dry-run: employee existence,
|
||||
// employment_start ordering, lock state. Fails staging early with the
|
||||
// full per-item error list.
|
||||
const { setOpeningBalancesBulk } = await import('@/lib/salary/opening-balances')
|
||||
const preflight = await setOpeningBalancesBulk(supabase, {
|
||||
companyId,
|
||||
userId,
|
||||
items: parsed.data.items,
|
||||
dryRun: true,
|
||||
})
|
||||
if (!preflight.ok) {
|
||||
const itemSummary = preflight.itemErrors
|
||||
?.map((e) => `${e.employee_id}: ${e.message}`)
|
||||
.join('; ')
|
||||
throw new Error(`Cannot set opening balances: ${itemSummary ?? preflight.code}`)
|
||||
}
|
||||
|
||||
return stagePendingOperation(
|
||||
supabase, companyId, userId, 'set_employee_opening_balances',
|
||||
`Ingående lönesaldon: ${parsed.data.items.length} anställd(a)`,
|
||||
{ items: parsed.data.items },
|
||||
{
|
||||
employee_count: parsed.data.items.length,
|
||||
cutover_dates: [...new Set(parsed.data.items.map((i) => i.cutover_date))],
|
||||
total_ytd_gross: parsed.data.items.reduce((s, i) => s + (i.ytd_gross || 0), 0),
|
||||
total_opening_liability: parsed.data.items.reduce(
|
||||
(s, i) => s + (i.opening_semester_liability || 0),
|
||||
0,
|
||||
),
|
||||
},
|
||||
actor,
|
||||
{
|
||||
description: 'After approval, import pre-cutover absence history if needed, then create the first salary run.',
|
||||
tool: 'gnubok_create_salary_run',
|
||||
},
|
||||
)
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_get_vacation_balance',
|
||||
title: 'Get Vacation Balance (Semestersaldo)',
|
||||
description: 'Get one employee\'s current vacation balance: entitled/taken/remaining days, sparade dagar per origin year (5-year rule), forced payouts, and an estimated semesterlöneskuld in SEK. Ledger seeds on first booking. Use before gnubok_close_vacation_year.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_id: { type: 'string', description: 'UUID of the employee' },
|
||||
},
|
||||
required: ['employee_id'],
|
||||
},
|
||||
outputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
employee_vacation_balance_id: { type: 'string' },
|
||||
employee_id: { type: 'string' },
|
||||
vacation_year_start: { type: 'string' },
|
||||
entitled_days: { type: 'number' },
|
||||
accrued_days: { type: 'number' },
|
||||
taken_days: { type: 'number' },
|
||||
remaining_days: { type: 'number' },
|
||||
saved_days: { type: 'object', description: 'Origin year -> days' },
|
||||
forced_payout_days: { type: 'number' },
|
||||
},
|
||||
required: ['employee_vacation_balance_id', 'employee_id', 'vacation_year_start', 'entitled_days', 'taken_days', 'remaining_days'],
|
||||
},
|
||||
annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false },
|
||||
async execute(args, companyId, _userId, supabase) {
|
||||
const employeeId = args.employee_id as string
|
||||
if (!employeeId) throw new Error('employee_id is required')
|
||||
const { data: balance, error } = await supabase
|
||||
.from('employee_vacation_balances')
|
||||
.select('id, employee_id, vacation_year_start, entitled_days, accrued_days, taken_days, saved_days, forced_payout_days')
|
||||
.eq('company_id', companyId)
|
||||
.eq('employee_id', employeeId)
|
||||
.eq('status', 'open')
|
||||
.order('vacation_year_start', { ascending: false })
|
||||
.limit(1)
|
||||
.maybeSingle()
|
||||
if (error) throw new Error(`Database error: ${error.message}`)
|
||||
if (!balance) throw new Error('No vacation balance exists for the employee yet (the ledger seeds on first booking)')
|
||||
const { id, ...rest } = balance as { id: string } & Record<string, unknown>
|
||||
const entitled = (rest.entitled_days as number) ?? 0
|
||||
const taken = (rest.taken_days as number) ?? 0
|
||||
return {
|
||||
employee_vacation_balance_id: id,
|
||||
...rest,
|
||||
remaining_days: roundOre(entitled - taken),
|
||||
}
|
||||
},
|
||||
},
|
||||
{
|
||||
name: 'gnubok_close_vacation_year',
|
||||
title: 'Close Vacation Year (Semesterårsavslut)',
|
||||
description: 'Stage the vacation year close: rolls balances into the next year (min-20 floor, 5-year expiry to forced payout) and books a 2920/2940 drift adjustment when needed. High risk: review the preview report, then commit via gnubok_approve_pending_operation.',
|
||||
inputSchema: {
|
||||
type: 'object',
|
||||
additionalProperties: false,
|
||||
properties: {
|
||||
vacation_year_start: { type: 'string', description: 'YYYY-MM-DD; defaults to the most recently ended vacation year' },
|
||||
book_adjustment: { type: 'boolean', description: 'Book the 2920/2940 drift verifikat (default true)' },
|
||||
},
|
||||
},
|
||||
outputSchema: STAGED_OPERATION_SCHEMA,
|
||||
annotations: { readOnlyHint: false, destructiveHint: true, idempotentHint: true, openWorldHint: false },
|
||||
async execute(args, companyId, userId, supabase, actor) {
|
||||
const { previewVacationYearClose } = await import('@/lib/salary/semesterberedning')
|
||||
const { getVacationYearBasis } = await import('@/lib/salary/vacation-ledger')
|
||||
const { getClosableYearStart } = await import('@/lib/salary/vacation-year')
|
||||
|
||||
let yearStart = args.vacation_year_start as string | undefined
|
||||
if (!yearStart) {
|
||||
const basis = await getVacationYearBasis(supabase, companyId)
|
||||
yearStart = getClosableYearStart(new Date().toISOString().slice(0, 10), basis)
|
||||
}
|
||||
const bookAdjustment = args.book_adjustment !== false
|
||||
|
||||
// Preflight: the full review report. Staging fails early on
|
||||
// not-ended / already-closed years, and the approver sees the exact
|
||||
// day transitions + SEK drift that will commit.
|
||||
const preview = await previewVacationYearClose(supabase, companyId, yearStart)
|
||||
if (!preview.ok) {
|
||||
throw new Error(`Cannot close vacation year: ${preview.code}`)
|
||||
}
|
||||
const report = preview.data
|
||||
|
||||
return stagePendingOperation(
|
||||
supabase, companyId, userId, 'vacation_year_close',
|
||||
`Semesterårsavslut ${yearStart.slice(0, 4)} (${report.rows.length} anställda)`,
|
||||
{ vacation_year_start: yearStart, book_adjustment: bookAdjustment },
|
||||
{
|
||||
vacation_year_start: yearStart,
|
||||
vacation_year_end: report.vacation_year_end,
|
||||
employee_count: report.rows.length,
|
||||
total_saveable_days: report.rows.reduce((s, r) => s + r.saveable_days, 0),
|
||||
total_expiring_days: report.rows.reduce((s, r) => s + r.expiring_days, 0),
|
||||
computed_liability: report.sek.computed_liability,
|
||||
computed_avgifter: report.sek.computed_avgifter,
|
||||
booked_2920: report.sek.booked_2920,
|
||||
booked_2940: report.sek.booked_2940,
|
||||
drift_2920: report.sek.drift_2920,
|
||||
drift_2940: report.sek.drift_2940,
|
||||
adjustment_needed: report.sek.adjustment_needed,
|
||||
},
|
||||
actor,
|
||||
{
|
||||
description: 'After approval, pay out any forced-payout days as semesterersättning in the next salary run.',
|
||||
tool: 'gnubok_create_salary_run',
|
||||
},
|
||||
{ dateForPeriodCheck: report.adjustment_date },
|
||||
)
|
||||
},
|
||||
},
|
||||
|
||||
// ── Stream 1 Phase 1: Bookkeeping write (high-risk, always staged) ──
|
||||
|
||||
|
||||
@@ -0,0 +1,76 @@
|
||||
/**
|
||||
* PII chokepoint for staged operations (ISO 27001 A.8.11 / GDPR Art.5(1)(c)).
|
||||
*
|
||||
* pending_operations.params and .preview_data are persisted verbatim and
|
||||
* rendered in approval UIs, so no staging payload may carry a plaintext
|
||||
* personnummer. The one tool that legitimately receives one
|
||||
* (gnubok_create_employee) encrypts at staging time and stores only
|
||||
* `personnummer_encrypted` / `personnummer_last4` / `personnummer_masked`.
|
||||
* This guard runs inside stagePendingOperation, so every current and FUTURE
|
||||
* staging tool inherits the rule: a tool that forgets to encrypt fails loudly
|
||||
* at staging instead of silently persisting PII.
|
||||
*
|
||||
* Detection is key-based, not value-based: for enskild firma the org number
|
||||
* IS the owner's personnummer, so value-pattern matching would false-positive
|
||||
* on legitimate counterparty data. Keys are compared exactly; the derived
|
||||
* forms above are therefore allowed by construction.
|
||||
*/
|
||||
|
||||
const FORBIDDEN_KEYS = new Set(['personnummer', 'pnr', 'social_security_number', 'ssn'])
|
||||
|
||||
/**
|
||||
* Cycle/degenerate-payload stop: staged payloads are shallow JSON. Anything
|
||||
* nesting deeper is rejected (fail closed), never silently accepted: a
|
||||
* payload too deep to scan could hide a forbidden key below the limit.
|
||||
*/
|
||||
const MAX_DEPTH = 6
|
||||
|
||||
/** Sentinel: the payload nests past MAX_DEPTH, so it cannot be fully scanned. */
|
||||
const DEPTH_EXCEEDED = Symbol('depth-exceeded')
|
||||
|
||||
function findForbiddenKey(
|
||||
value: unknown,
|
||||
depth: number,
|
||||
): string | typeof DEPTH_EXCEEDED | null {
|
||||
if (value === null || typeof value !== 'object') return null
|
||||
if (depth > MAX_DEPTH) return DEPTH_EXCEEDED
|
||||
if (Array.isArray(value)) {
|
||||
for (const item of value) {
|
||||
const hit = findForbiddenKey(item, depth + 1)
|
||||
if (hit) return hit
|
||||
}
|
||||
return null
|
||||
}
|
||||
for (const [key, nested] of Object.entries(value as Record<string, unknown>)) {
|
||||
if (FORBIDDEN_KEYS.has(key)) return key
|
||||
const hit = findForbiddenKey(nested, depth + 1)
|
||||
if (hit) return hit
|
||||
}
|
||||
return null
|
||||
}
|
||||
|
||||
/**
|
||||
* Throws when `payload` (params or preview_data) carries a plaintext
|
||||
* personnummer-bearing key at any nesting level, or nests too deep to scan
|
||||
* (fail closed). `label` names the offending payload in the error so the
|
||||
* tool author sees exactly what to fix.
|
||||
*/
|
||||
export function assertNoPlaintextPersonnummer(
|
||||
payload: Record<string, unknown>,
|
||||
label: 'params' | 'preview_data',
|
||||
): void {
|
||||
const hit = findForbiddenKey(payload, 0)
|
||||
if (hit === DEPTH_EXCEEDED) {
|
||||
throw new Error(
|
||||
`Staging blocked: ${label} nests deeper than ${MAX_DEPTH} levels and cannot be scanned for plaintext PII. ` +
|
||||
'Flatten the payload; staged payloads are shallow JSON by design.',
|
||||
)
|
||||
}
|
||||
if (hit) {
|
||||
throw new Error(
|
||||
`Staging blocked: ${label} contains plaintext PII key "${hit}". ` +
|
||||
'pending_operations must never persist a plaintext personnummer; ' +
|
||||
'encrypt at staging time (see gnubok_create_employee: personnummer_encrypted + personnummer_last4).',
|
||||
)
|
||||
}
|
||||
}
|
||||
@@ -135,7 +135,7 @@ export async function buildAgiUnderlag(
|
||||
|
||||
if (declarationError || !declaration?.xml_content) {
|
||||
throw new Error(
|
||||
'AGI-XML saknas. Generera AGI-filen från lönekörningen först (Lön → AGI → Generera).',
|
||||
'AGI-XML saknas. Generera AGI-filen först: knappen "Lämna in till Skatteverket" på lönekörningen gör det automatiskt, eller klicka "Ladda ner AGI-fil".',
|
||||
)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user