fix(mcp): correct fiscal_periods column ref + remove agent auto-commit (#394)

* fix(mcp): correct fiscal_periods column ref + remove agent auto-commit

The MCP `gnubok_list_fiscal_periods` tool selected a non-existent
`fiscal_periods.status` column, causing `column fiscal_periods.status
does not exist` errors when agents called it. Fixed by selecting the
real columns (`is_closed`, `locked_at`, `closed_at`,
`opening_balances_set`) and deriving `status` in code.

Also removes the agent auto-commit feature (settings card, gating logic,
DB columns, tests). In its current shape only `create_customer` was
auto-commitable, so the toggle changed nothing meaningful in practice
while implying a level of agent autonomy that wasn't actually granted.
The risk-tier infrastructure on `pending_operations` (actor model,
risk_level) is kept since it's still used by the /pending UI filters.

Migration `20260505120000_drop_agent_auto_commit.sql` drops:
  - pending_operations.auto_commit_eligible
  - pending_operations.auto_committed_at
  - company_settings.agent_auto_commit_enabled
  - company_settings.agent_auto_commit_max_amount

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(mcp): explicitly pick fields in gnubok_list_fiscal_periods response

Greptile flagged that `...p` spreads raw DB columns (`is_closed`,
`locked_at`, `closed_at`) into the tool response alongside the
derived `status`. Drop the spread for an explicit field list so the
tool contract is the derived status only — agents don't need to
reason about raw columns, and future SELECT additions won't silently
leak.

Also drops `closed_at` from the SELECT since it wasn't read.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-05-05 21:16:01 +02:00
committed by GitHub
co-authored by Claude Opus 4.7
parent 5c52f24a49
commit b05f0e59b9
13 changed files with 62 additions and 686 deletions
+5 -16
View File
@@ -79,12 +79,6 @@ export interface CommitResult {
export interface CommitOptions {
/** Email address used as cc on send_invoice (typically the human user's email). */
userEmail?: string
/**
* When true, the op was auto-committed by a trusted agent (no human in the
* loop). The status row is updated with `auto_committed_at` so the UI can
* surface this on /pending and in audit reports.
*/
isAutoCommit?: boolean
}
// ── Helper: ensure fiscal period covers the date ──────────────────
@@ -1574,18 +1568,13 @@ export async function commitPendingOperation(
}
const now = new Date().toISOString()
const update: Record<string, unknown> = {
status: 'committed',
resolved_at: now,
result_data: result.data || {},
}
if (opts.isAutoCommit) {
update.auto_committed_at = now
}
await supabase
.from('pending_operations')
.update(update)
.update({
status: 'committed',
resolved_at: now,
result_data: result.data || {},
})
.eq('id', pendingOp.id)
return {