feat(settings): per-company data-analysis opt-in gating the calibration corpus (#1346) (#2007)

* feat(settings): per-company opt-in for data analysis of bookkeeping outcomes (#1346) Adds company_settings.data_analysis_opt_in (default false, no grandfathering) and gates every path that reads bookkeeping outcomes across companies on it: POST /api/agent/categorize/outcome stops writing calibration samples for companies that have not opted in, and the backtest / calibration-fit scripts filter to opted-in company ids. One helper (lib/company/data-analysis.ts) is the single gate for future analysis paths. A toggle on Inställningar > Företag states plainly what is analysed (proposed vs booked account, amount, confidence; no free text, no personal data) in sv and en. The flag is UI-only by design: consent is a human action, so it is absent from the v1 REST / MCP settings pick lists. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna * fix(settings): make data-analysis consent copy true for the backtest path (#1346) Addresses adversarial review findings on PR #2007: - Findings 1-3 (consent narrower than the gated processing): the flag also gates scripts/backtest-categorize.ts, which re-runs transaction descriptions, merchant names and matched underlag through the model. The sv/en toggle help and disclosure now state that explicitly as "evaluation runs" and no longer claim that free text or underlag are excluded. The migration header and COMMENT, the lib/company/data-analysis.ts docstring, the backtest script header and the DECISIONS line say the same. Kept the gate (un-gating would put the script back to reading every company with no consent at all). A test pins that both locales name those inputs and contain no "no free text / no underlag" denial. - Finding 4 (member sees an active switch that RLS rejects): the toggle is now enabled only for owner/admin, matching the company_settings update policy; the disclosure says only administrators can change the choice. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna * fix(scripts): address round-2 review findings (#1346) 1. [minor] Opted-in company filter was an unbounded PostgREST `in` list in the URL (scripts/fit-categorize-calibration.ts, scripts/backtest-categorize.ts). Both scripts now read the opted-in ids through a shared, paginated helper (listDataAnalysisOptedInCompanyIds, fetchAllRows so the pre-fetch no longer caps at 1000) and query per chunk of 100 ids (chunkCompanyIds). The fit script pages each chunk on the id PK; the backtest merges per-chunk results and re-cuts to the N most recent overall. Early exit on zero opt-ins is kept. Pinned with tests in lib/company/__tests__/data-analysis.test.ts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna * fix(scripts): coerce a null transaction description in the backtest (#1346) The typed row from the chunked consent query made description nullable, which TransactionForSelect does not accept; fall back to the original description or an empty string, as the untyped row did implicitly before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015nAd8XJ2RPCmG2eKoLBdna --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-28 17:38:36 +02:00
parent 33a58bec51
commit ad8566f1ae
16 changed files with 500 additions and 28 deletions
@@ -0,0 +1,97 @@
+'use client'
+
+import { useState } from 'react'
+import Link from 'next/link'
+import { useLocale, useTranslations } from 'next-intl'
+import { Switch } from '@/components/ui/switch'
+import { useToast } from '@/components/ui/use-toast'
+import { SettingsRow, SettingsRowNote } from '@/components/settings/SettingsRows'
+import { useSettings } from '@/components/settings/useSettings'
+import { useCompany } from '@/contexts/CompanyContext'
+import { cn } from '@/lib/utils'
+import { getErrorMessage, type ErrorLocale } from '@/lib/errors/get-error-message'
+
+/**
+ * Company-level consent toggle for data analysis (#1346). Persists
+ * company_settings.data_analysis_opt_in through the standard settings PUT.
+ * The flag is enforced server-side (lib/company/data-analysis.ts) on every
+ * path that reads bookkeeping outcomes across companies; this component only
+ * mirrors it and states plainly what is analysed. Off by default.
+ *
+ * Owner / admin only: the company_settings RLS update policy is admin-gated,
+ * so a plain member's PUT would fail with a misleading error. Consent is an
+ * admin decision anyway, so the switch renders disabled for everyone else.
+ */
+export function DataAnalysisToggle() {
+  const t = useTranslations('data_analysis')
+  const errorLocale = useLocale() as ErrorLocale
+  const { settings, updateSettings } = useSettings()
+  const { role } = useCompany()
+  const canConsent = role === 'owner' || role === 'admin'
+  const { toast } = useToast()
+  const [isSaving, setIsSaving] = useState(false)
+
+  const enabled = settings?.data_analysis_opt_in ?? false
+
+  async function handleChange(next: boolean) {
+    setIsSaving(true)
+    try {
+      const res = await fetch('/api/settings', {
+        method: 'PUT',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ data_analysis_opt_in: next }),
+      })
+      const json = await res.json().catch(() => null)
+      if (!res.ok) {
+        toast({
+          title: t('settings_save_failed_title'),
+          description: getErrorMessage(json, { locale: errorLocale }),
+          variant: 'destructive',
+        })
+        return
+      }
+      updateSettings({ data_analysis_opt_in: next })
+    } catch (err) {
+      // A rejected fetch never reaches the !res.ok arm above, and the switch
+      // is controlled by the settings context, so it stays where it was:
+      // without this toast the click looks like a dead control.
+      toast({
+        title: t('settings_save_failed_title'),
+        description: getErrorMessage(err, { locale: errorLocale }),
+        variant: 'destructive',
+      })
+    } finally {
+      setIsSaving(false)
+    }
+  }
+
+  const locked = isSaving || !canConsent
+
+  return (
+    <SettingsRow label={t('settings_heading')} help={t('settings_toggle_help')}>
+      <Switch
+        id="data-analysis-opt-in"
+        checked={enabled}
+        onCheckedChange={(next) => void handleChange(next)}
+        disabled={locked}
+      />
+      <label
+        htmlFor="data-analysis-opt-in"
+        className={cn('text-sm', locked ? 'text-muted-foreground' : 'cursor-pointer')}
+      >
+        {t('settings_toggle_label')}
+      </label>
+      <SettingsRowNote className="basis-full">
+        {t('settings_disclosure')}{' '}
+        <Link
+          href="/privacy"
+          target="_blank"
+          rel="noopener noreferrer"
+          className="underline underline-offset-4 transition-colors hover:text-foreground"
+        >
+          {t('settings_privacy_link')}
+        </Link>
+      </SettingsRowNote>
+    </SettingsRow>
+  )
+}
@@ -7,12 +7,13 @@ import { CompanyDangerZone } from '@/components/settings/CompanyDangerZone'
 import { CompanyInfoForm } from '@/components/settings/CompanyInfoForm'
 import { CompanyMembersSection } from '@/components/settings/CompanyMembersSection'
 import { CompanyProfileSection } from '@/components/settings/CompanyProfileSection'
+import { DataAnalysisToggle } from '@/components/settings/DataAnalysisToggle'
 import { FiscalPeriodEditor } from '@/components/settings/FiscalPeriodEditor'
 import { LogoUpload } from '@/components/settings/LogoUpload'
 import { SettingsFormWrapper } from '@/components/settings/SettingsFormWrapper'
 import { SettingsLoadError } from '@/components/settings/SettingsLoadError'
 import { SettingsLoadingSkeleton } from '@/components/settings/SettingsLoadingSkeleton'
-import { SettingsSectionHeader } from '@/components/settings/SettingsRows'
+import { SettingsGroup, SettingsSectionHeader } from '@/components/settings/SettingsRows'
 import { ShareCapitalForm } from '@/components/settings/ShareCapitalForm'
 import { useSettings } from '@/components/settings/useSettings'
 import type { CompanySettings } from '@/types'
@@ -21,6 +22,7 @@ export function CompanySettingsContent() {
  const router = useRouter()
  const tNav = useTranslations('settings_nav')
  const tIntro = useTranslations('settings_intro')
+  const tData = useTranslations('data_analysis')
  const { settings, isLoading, updateSettings, refetch } = useSettings()

  // Deep-link target for "Medlemmar och roller" (/settings/company#members):
@@ -97,6 +99,10 @@ export function CompanySettingsContent() {

      <CompanyProfileSection />

+      <SettingsGroup label={tData('group_label')}>
+        <DataAnalysisToggle />
+      </SettingsGroup>
+
      <CompanyDangerZone />
    </div>
  )