Bug/vat selection warning (#583)
* refactor: update VAT handling logic for non-registered sellers and improve related comments * chore: gate automated email flows behind 503 responses Disables user-facing access to invoice payment reminders and salary payslip email sending. Underlying lib code (reminder-processor, PDF templates, notification_settings) is preserved for easy re-enable. - Invoice reminders cron route returns 503; settings UI section removed. - Payslip send route returns 503; original implementation kept as _sendPayslipsImpl for future re-enable. - Push notifications were already extension-disabled, no change needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: remove Recapt feedback widget Strips the third-party Recapt SDK and its floating feedback bubble from the app. The in-app contact form keeps working via the existing email channel (/api/support/contact). Drops the Recapt entries from the CSP and the subprocessor list in the privacy policy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat: reject meaningless rättelser in correctEntry Guard against zero-economic-effect corrections in the storno engine: - Reject when proposed lines net to zero on every account (e.g. 1930 debit 100 / 1930 credit 100), which would erase the original posting without representing any affärshändelse (BFL 5 kap. 5 §). - Reject when proposed lines are an exact multiset match of the original entry — a rättelse must actually change something. New MeaninglessCorrectionError wired through bookkeepingErrorResponse (HTTP 400) and the Swedish error translator. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat: add date-range picker to resultat- and balansrapport Adds optional from/to date filtering to the four operational financial reports (resultatrapport, balansrapport, income-statement, balance-sheet) so users can view a month, quarter, or custom range inside a fiscal year without leaving the report. Defaults to YTD; "Hela året" preserves the prior full-period behaviour (URL-identical, cache-stable). - trial-balance engine accepts optional fromDate/toDate, rolling prior in-period activity into IB and clamping period activity to the window - 12 API routes accept and validate from_date/to_date query params - ReportDateRange chip picker persists preset per company, only renders on the four relevant tabs - FiscalYearSelector now emits the period object so the range picker has bounds without an extra fetch - PDF/XLSX filenames reflect the chosen range - Resultatrapport drops the prior-year column when narrowed (full-year vs partial-year would mislead) - 11 new tests (engine + parser); all existing report tests pass Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat: add support for marking journal entries as "no document required" - Introduced a new sidecar table `journal_entry_no_doc_required` to track entries that do not require separate documentation (e.g., bank fees, interest). - Implemented API routes for creating and deleting exemptions, including validation and authorization checks. - Added a toggle component in the UI to allow users to mark entries as exempt, with an optional reason. - Updated relevant tests to cover the new functionality, including RLS checks and cascading deletes. - Enhanced existing schemas and types to accommodate the new `vat_amount` field for supplier invoice items. * fix: address PR review findings on no-doc-required + VAT changes - pg-real cascade test wraps DELETE in gnubok.allow_delete='true' txn so the immutability trigger bypass fires (mirrors delete_last_voucher RPC). - Clamp supplier-invoice item vat_amount to <= line_total * vat_rate via Zod refinement (with 1-öre rounding tolerance) so the manual override can't inflate the 2641 debit beyond the statutory ceiling. - groupVatByRate falls back to line_total * rate when stored vat_amount is 0 with a positive rate, so legacy/import paths leaving the column at its NOT NULL DEFAULT 0 don't silently understate ruta 48. - ReportDateRange todayIso() and preset endpoints use local date components instead of toISOString() (UTC) — fixes the midnight-to-02:00 off-by-one that truncated a day from YTD / this-month / this-quarter for Swedish users. - NoDocRequiredToggle restores the previous reason on failed POST/DELETE so the rolled-back toggle state stays consistent with the rendered reason. - Document the company-scoped (not user-scoped) DELETE authorization policy on the no-document-required route. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Opus 4.7
Claude Opus 4.7
parent
627109b5bd
commit
a9b43ebeb7
@@ -23,7 +23,12 @@ interface Props {
|
||||
* Current selection. `null` means "all years" — no filter applied.
|
||||
*/
|
||||
value: string | null
|
||||
onChange: (periodId: string | null) => void
|
||||
/**
|
||||
* Called with the selected period id (or null for "all years"). The second
|
||||
* arg is the matching FiscalPeriod object so callers can read period_start
|
||||
* / period_end without an extra fetch.
|
||||
*/
|
||||
onChange: (periodId: string | null, period?: FiscalPeriod | null) => void
|
||||
/**
|
||||
* If true, include an "Alla räkenskapsår" option that clears the filter.
|
||||
* Pages that require a specific period (e.g. Reports) should pass false.
|
||||
@@ -107,12 +112,12 @@ export function FiscalYearSelector({
|
||||
if (value === null && typeof window !== 'undefined') {
|
||||
const stored = window.localStorage.getItem(STORAGE_KEY_PREFIX + company.id)
|
||||
if (stored === ALL_YEARS_VALUE) {
|
||||
if (includeAllOption) onChange(null)
|
||||
else if (fetched.length > 0) onChange(fetched[0].id)
|
||||
if (includeAllOption) onChange(null, null)
|
||||
else if (fetched.length > 0) onChange(fetched[0].id, fetched[0])
|
||||
} else if (stored && fetched.some((p) => p.id === stored)) {
|
||||
onChange(stored)
|
||||
onChange(stored, fetched.find((p) => p.id === stored) ?? null)
|
||||
} else if (!includeAllOption && fetched.length > 0) {
|
||||
onChange(fetched[0].id)
|
||||
onChange(fetched[0].id, fetched[0])
|
||||
}
|
||||
}
|
||||
|
||||
@@ -134,7 +139,8 @@ export function FiscalYearSelector({
|
||||
nextPeriodId ?? ALL_YEARS_VALUE,
|
||||
)
|
||||
}
|
||||
onChange(nextPeriodId)
|
||||
const nextPeriod = nextPeriodId ? periods.find((p) => p.id === nextPeriodId) ?? null : null
|
||||
onChange(nextPeriodId, nextPeriod)
|
||||
}
|
||||
|
||||
const selectValue = value ?? (includeAllOption ? ALL_YEARS_VALUE : '')
|
||||
|
||||
@@ -0,0 +1,237 @@
|
||||
'use client'
|
||||
|
||||
import { useCallback, useEffect, useMemo, useState } from 'react'
|
||||
import { useTranslations } from 'next-intl'
|
||||
import { useCompany } from '@/contexts/CompanyContext'
|
||||
import { Label } from '@/components/ui/label'
|
||||
import { Input } from '@/components/ui/input'
|
||||
import { cn } from '@/lib/utils'
|
||||
|
||||
export type DateRangeValue = {
|
||||
/** Inclusive lower bound. ISO YYYY-MM-DD. `undefined` = period start. */
|
||||
fromDate?: string
|
||||
/** Inclusive upper bound. ISO YYYY-MM-DD. `undefined` = period end. */
|
||||
toDate?: string
|
||||
}
|
||||
|
||||
type Preset = 'full_year' | 'ytd' | 'this_month' | 'last_month' | 'this_quarter' | 'custom'
|
||||
|
||||
interface Props {
|
||||
/** Selected fiscal period — bounds the range. */
|
||||
periodStart: string
|
||||
periodEnd: string
|
||||
value: DateRangeValue
|
||||
onChange: (next: DateRangeValue) => void
|
||||
className?: string
|
||||
}
|
||||
|
||||
const STORAGE_KEY_PREFIX = 'gnubok:report-range-preset:'
|
||||
|
||||
const PRESETS: Preset[] = ['full_year', 'ytd', 'this_month', 'last_month', 'this_quarter', 'custom']
|
||||
|
||||
function todayIso(): string {
|
||||
// Local calendar date — using toISOString() returns UTC, which falls a day
|
||||
// behind for Swedish users between midnight and 01:00/02:00 local time and
|
||||
// would silently truncate "today" from YTD / this-month / this-quarter.
|
||||
const d = new Date()
|
||||
const y = d.getFullYear()
|
||||
const m = String(d.getMonth() + 1).padStart(2, '0')
|
||||
const day = String(d.getDate()).padStart(2, '0')
|
||||
return `${y}-${m}-${day}`
|
||||
}
|
||||
|
||||
function clampToPeriod(date: string, periodStart: string, periodEnd: string): string {
|
||||
if (date < periodStart) return periodStart
|
||||
if (date > periodEnd) return periodEnd
|
||||
return date
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve a preset to a concrete range inside the fiscal period.
|
||||
*
|
||||
* Endpoints are always clamped to the period — e.g. "this month" outside the
|
||||
* period collapses to a zero-width range at whichever boundary you're nearest.
|
||||
* `full_year` returns `{}` so the API call omits the params entirely and the
|
||||
* report falls back to its full-period default (preserves cache parity with
|
||||
* the pre-feature behaviour).
|
||||
*/
|
||||
function resolvePreset(
|
||||
preset: Preset,
|
||||
periodStart: string,
|
||||
periodEnd: string,
|
||||
reference: string,
|
||||
): DateRangeValue {
|
||||
if (preset === 'full_year') return {}
|
||||
if (preset === 'custom') return {}
|
||||
|
||||
if (preset === 'ytd') {
|
||||
const to = clampToPeriod(reference, periodStart, periodEnd)
|
||||
return { fromDate: periodStart, toDate: to }
|
||||
}
|
||||
|
||||
const ref = new Date(reference)
|
||||
// Same UTC pitfall as todayIso(): Date.toISOString() returns UTC, so a
|
||||
// local Date constructed via `new Date(y, m, d)` round-trips to the wrong
|
||||
// calendar day in any timezone west of UTC. Use the local components.
|
||||
const toLocalIso = (d: Date) =>
|
||||
`${d.getFullYear()}-${String(d.getMonth() + 1).padStart(2, '0')}-${String(d.getDate()).padStart(2, '0')}`
|
||||
if (preset === 'this_month') {
|
||||
const y = ref.getFullYear()
|
||||
const m = ref.getMonth()
|
||||
const start = `${y}-${String(m + 1).padStart(2, '0')}-01`
|
||||
const end = toLocalIso(new Date(y, m + 1, 0))
|
||||
return {
|
||||
fromDate: clampToPeriod(start, periodStart, periodEnd),
|
||||
toDate: clampToPeriod(end, periodStart, periodEnd),
|
||||
}
|
||||
}
|
||||
if (preset === 'last_month') {
|
||||
const y = ref.getFullYear()
|
||||
const m = ref.getMonth() - 1
|
||||
const start = toLocalIso(new Date(y, m, 1))
|
||||
const end = toLocalIso(new Date(y, m + 1, 0))
|
||||
return {
|
||||
fromDate: clampToPeriod(start, periodStart, periodEnd),
|
||||
toDate: clampToPeriod(end, periodStart, periodEnd),
|
||||
}
|
||||
}
|
||||
if (preset === 'this_quarter') {
|
||||
const y = ref.getFullYear()
|
||||
const q = Math.floor(ref.getMonth() / 3)
|
||||
const start = `${y}-${String(q * 3 + 1).padStart(2, '0')}-01`
|
||||
const end = toLocalIso(new Date(y, q * 3 + 3, 0))
|
||||
return {
|
||||
fromDate: clampToPeriod(start, periodStart, periodEnd),
|
||||
toDate: clampToPeriod(end, periodStart, periodEnd),
|
||||
}
|
||||
}
|
||||
return {}
|
||||
}
|
||||
|
||||
/**
|
||||
* Date-range picker for the resultat-/balansrapport family.
|
||||
*
|
||||
* Default = "Hittills i år" (YTD) which matches Fortnox/Visma. A "Hela året"
|
||||
* preset clears the range entirely so the API falls back to full-period
|
||||
* behaviour. Custom range is clamped to the fiscal period — cross-year
|
||||
* ranges are out of scope.
|
||||
*/
|
||||
export function ReportDateRange({
|
||||
periodStart,
|
||||
periodEnd,
|
||||
value,
|
||||
onChange,
|
||||
className,
|
||||
}: Props) {
|
||||
const t = useTranslations('reports')
|
||||
const { company } = useCompany()
|
||||
const [preset, setPreset] = useState<Preset>('ytd')
|
||||
|
||||
// Restore last-used preset per company, then resolve it against the
|
||||
// current fiscal period. The period selector lives upstream — when it
|
||||
// changes, we re-resolve so the dates always sit inside the visible year.
|
||||
useEffect(() => {
|
||||
if (!company?.id || typeof window === 'undefined') return
|
||||
const stored = window.localStorage.getItem(STORAGE_KEY_PREFIX + company.id) as Preset | null
|
||||
const initial: Preset = stored && PRESETS.includes(stored) ? stored : 'ytd'
|
||||
setPreset(initial)
|
||||
if (initial !== 'custom') {
|
||||
onChange(resolvePreset(initial, periodStart, periodEnd, todayIso()))
|
||||
}
|
||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||
}, [company?.id, periodStart, periodEnd])
|
||||
|
||||
const handlePreset = useCallback(
|
||||
(next: Preset) => {
|
||||
setPreset(next)
|
||||
if (company?.id && typeof window !== 'undefined') {
|
||||
window.localStorage.setItem(STORAGE_KEY_PREFIX + company.id, next)
|
||||
}
|
||||
if (next === 'custom') {
|
||||
// Seed the custom inputs with whatever is currently active so the
|
||||
// user can nudge them rather than start from scratch.
|
||||
if (!value.fromDate && !value.toDate) {
|
||||
onChange({ fromDate: periodStart, toDate: clampToPeriod(todayIso(), periodStart, periodEnd) })
|
||||
}
|
||||
return
|
||||
}
|
||||
onChange(resolvePreset(next, periodStart, periodEnd, todayIso()))
|
||||
},
|
||||
[company?.id, onChange, periodEnd, periodStart, value.fromDate, value.toDate],
|
||||
)
|
||||
|
||||
const handleFromChange = (raw: string) => {
|
||||
const next = raw ? clampToPeriod(raw, periodStart, periodEnd) : undefined
|
||||
onChange({ fromDate: next, toDate: value.toDate })
|
||||
}
|
||||
const handleToChange = (raw: string) => {
|
||||
const next = raw ? clampToPeriod(raw, periodStart, periodEnd) : undefined
|
||||
onChange({ fromDate: value.fromDate, toDate: next })
|
||||
}
|
||||
|
||||
const presetLabels: Record<Preset, string> = useMemo(
|
||||
() => ({
|
||||
full_year: t('date_range_preset_full_year'),
|
||||
ytd: t('date_range_preset_ytd'),
|
||||
this_month: t('date_range_preset_this_month'),
|
||||
last_month: t('date_range_preset_last_month'),
|
||||
this_quarter: t('date_range_preset_this_quarter'),
|
||||
custom: t('date_range_preset_custom'),
|
||||
}),
|
||||
[t],
|
||||
)
|
||||
|
||||
return (
|
||||
<div className={cn('flex flex-col gap-2', className)}>
|
||||
<Label className="text-xs font-medium uppercase tracking-wider text-muted-foreground">
|
||||
{t('date_range_label')}
|
||||
</Label>
|
||||
<div className="flex flex-wrap items-center gap-1.5">
|
||||
{PRESETS.map((p) => {
|
||||
const active = preset === p
|
||||
return (
|
||||
<button
|
||||
key={p}
|
||||
type="button"
|
||||
onClick={() => handlePreset(p)}
|
||||
className={cn(
|
||||
'px-3 py-1.5 text-xs rounded-md border transition-colors duration-150',
|
||||
active
|
||||
? 'bg-secondary border-border text-foreground'
|
||||
: 'bg-transparent border-border text-muted-foreground hover:bg-secondary/60 hover:text-foreground',
|
||||
)}
|
||||
>
|
||||
{presetLabels[p]}
|
||||
</button>
|
||||
)
|
||||
})}
|
||||
</div>
|
||||
{preset === 'custom' && (
|
||||
<div className="flex flex-wrap items-end gap-3 mt-1">
|
||||
<div className="flex flex-col gap-1">
|
||||
<Label className="text-xs text-muted-foreground">{t('date_range_from')}</Label>
|
||||
<Input
|
||||
type="date"
|
||||
min={periodStart}
|
||||
max={periodEnd}
|
||||
value={value.fromDate ?? ''}
|
||||
onChange={(e) => handleFromChange(e.target.value)}
|
||||
className="w-[160px] tabular-nums"
|
||||
/>
|
||||
</div>
|
||||
<div className="flex flex-col gap-1">
|
||||
<Label className="text-xs text-muted-foreground">{t('date_range_to')}</Label>
|
||||
<Input
|
||||
type="date"
|
||||
min={periodStart}
|
||||
max={periodEnd}
|
||||
value={value.toDate ?? ''}
|
||||
onChange={(e) => handleToChange(e.target.value)}
|
||||
className="w-[160px] tabular-nums"
|
||||
/>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
)
|
||||
}
|
||||
Reference in New Issue
Block a user