Bug/template and sandbox (#589)

* Enhance booking template functionality and add sandbox extraction checks

* Implement Recapt integration for feedback submission and user identification

* Add Recapt identification component and bank sync status chip; update crontab entries

* Update .gitignore to ignore the entire scripts directory

* Refactor Recapt integration: add loader component, update privacy policy, and enhance bank sync status messages

* Fix .gitignore to correctly ignore the scripts directory
This commit is contained in:
Mattsson
2026-05-28 15:43:48 +02:00
committed by GitHub
parent 20989379bb
commit a9aff5a120
25 changed files with 927 additions and 70 deletions
@@ -123,6 +123,7 @@ describe('POST /items/:id/retry-extraction', () => {
data: { id: 'item-1', document_id: 'doc-1', correlation_id: null, created_supplier_invoice_id: null },
error: null,
})
enqueue({ data: { is_sandbox: false }, error: null }) // sandbox check
enqueue({
data: { storage_path: 'path/to.pdf', mime_type: 'application/pdf', file_name: 'invoice.pdf' },
error: null,
@@ -150,6 +151,7 @@ describe('POST /items/:id/retry-extraction', () => {
data: { id: 'item-1', document_id: 'doc-1', correlation_id: null, created_supplier_invoice_id: null },
error: null,
})
enqueue({ data: { is_sandbox: false }, error: null }) // sandbox check
enqueue({
data: { storage_path: 'path/to.pdf', mime_type: 'application/pdf', file_name: 'invoice.pdf' },
error: null,
@@ -0,0 +1,238 @@
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { PDFDocument } from 'pdf-lib'
import { invoiceInboxExtension } from '@/extensions/general/invoice-inbox'
import {
createQueuedMockSupabase,
createMockRequest,
parseJsonResponse,
} from '@/tests/helpers'
import type { ExtensionContext } from '@/lib/extensions/types'
// Mock the Bedrock call. The whole point of this file is to assert it is
// never invoked on sandbox companies.
vi.mock('@/extensions/general/invoice-inbox/lib/extract-invoice-fields', async () => {
const actual = await vi.importActual<
typeof import('@/extensions/general/invoice-inbox/lib/extract-invoice-fields')
>('@/extensions/general/invoice-inbox/lib/extract-invoice-fields')
return {
...actual,
extractInvoiceFields: vi.fn(),
}
})
vi.mock('@/lib/core/documents/document-service', () => ({
uploadDocument: vi.fn().mockResolvedValue({ id: 'doc-1' }),
}))
vi.mock('@/lib/rate-limits/inbox', () => ({
checkInboxUploadRateLimit: vi.fn().mockResolvedValue({ ok: true }),
}))
vi.mock('@/lib/processing-history/append', () => ({
appendProcessingHistory: vi.fn().mockResolvedValue(undefined),
}))
import { extractInvoiceFields } from '@/extensions/general/invoice-inbox/lib/extract-invoice-fields'
function findRoute(method: string, path: string) {
return invoiceInboxExtension.apiRoutes!.find(
(r) => r.method === method && r.path === path,
)!
}
const uploadRoute = findRoute('POST', '/upload')
const attachRoute = findRoute('POST', '/items/:id/attach-document')
const retryRoute = findRoute('POST', '/items/:id/retry-extraction')
function buildCtx(supabase: unknown): ExtensionContext {
return {
userId: 'user-1',
companyId: 'company-1',
extensionId: 'invoice-inbox',
supabase: supabase as ExtensionContext['supabase'],
emit: vi.fn(),
settings: { get: vi.fn(), set: vi.fn() },
storage: { from: vi.fn() } as unknown as ExtensionContext['storage'],
log: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() } as unknown as ExtensionContext['log'],
services: {},
} as ExtensionContext
}
async function makePdfBuffer(pageCount: number): Promise<Uint8Array> {
const pdf = await PDFDocument.create()
for (let i = 0; i < pageCount; i++) pdf.addPage([612, 792])
return pdf.save()
}
function makeMultipartRequest(form: FormData, path: string): Request {
return new Request(`http://localhost:3000${path}`, {
method: 'POST',
body: form,
})
}
// Supabase mock routed by table name. The /upload handler hits
// company_settings (sandbox check), invoice_inbox_items (insert), and
// suppliers (match) in that order via separate .from() chains.
function makeUploadSupabase(opts: {
isSandbox: boolean
captured: { row?: Record<string, unknown> }
}) {
const settingsChain = {
select: vi.fn().mockReturnThis(),
eq: vi.fn().mockReturnThis(),
maybeSingle: vi.fn().mockResolvedValue({ data: { is_sandbox: opts.isSandbox }, error: null }),
}
const supplierChain = {
select: vi.fn().mockReturnThis(),
eq: vi.fn().mockReturnThis(),
ilike: vi.fn().mockReturnThis(),
limit: vi.fn().mockReturnThis(),
maybeSingle: vi.fn().mockResolvedValue({ data: null }),
}
const inboxChain = {
insert: vi.fn((row: Record<string, unknown>) => {
opts.captured.row = row
return {
select: vi.fn().mockReturnValue({
single: vi.fn().mockResolvedValue({
data: { id: 'inbox-1', status: 'received', matched_supplier_id: null, ...row },
error: null,
}),
}),
}
}),
update: vi.fn().mockReturnValue({
eq: vi.fn().mockReturnThis(),
}),
}
return {
from: vi.fn((table: string) => {
if (table === 'company_settings') return settingsChain
if (table === 'invoice_inbox_items') return inboxChain
return supplierChain
}),
}
}
beforeEach(() => {
vi.clearAllMocks()
})
describe('Sandbox companies skip Bedrock extraction', () => {
describe('POST /upload', () => {
it('skips extraction and reports skip_reason=sandbox', async () => {
const captured: { row?: Record<string, unknown> } = {}
const supabase = makeUploadSupabase({ isSandbox: true, captured })
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'receipt.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const res = await uploadRoute.handler(makeMultipartRequest(form, '/upload'), buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).not.toHaveBeenCalled()
expect(body.data.extraction_skipped).toBe(true)
expect(body.data.skip_reason).toBe('sandbox')
expect(captured.row?.extraction_skipped).toBe(true)
})
it('runs extraction normally for non-sandbox companies', async () => {
const captured: { row?: Record<string, unknown> } = {}
const supabase = makeUploadSupabase({ isSandbox: false, captured })
vi.mocked(extractInvoiceFields).mockResolvedValueOnce({
data: {
supplier: { name: null, orgNumber: null, vatNumber: null, address: null, bankgiro: null, plusgiro: null },
invoice: { invoiceNumber: null, invoiceDate: null, dueDate: null, paymentReference: null, currency: 'SEK' },
lineItems: [],
totals: { subtotal: null, vatAmount: null, total: null },
vatBreakdown: [],
confidence: 0,
},
rawText: 'ok',
})
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'receipt.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const res = await uploadRoute.handler(makeMultipartRequest(form, '/upload'), buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).toHaveBeenCalledOnce()
expect(body.data.extraction_skipped).toBe(false)
expect(body.data.skip_reason).toBeNull()
})
})
describe('POST /items/:id/attach-document', () => {
it('skips extraction when company is a sandbox', async () => {
// Lookup order: item exists → upload doc → sandbox check → update row.
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({
data: {
id: 'item-1',
document_id: null,
status: 'received',
correlation_id: null,
created_supplier_invoice_id: null,
},
error: null,
})
// sandbox check inside the try block
enqueue({ data: { is_sandbox: true }, error: null })
// update row
enqueue({ data: null, error: null })
// uploadDocument is mocked at the module level; no need to enqueue.
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'attach.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const req = new Request('http://localhost:3000/items/item-1/attach-document?_id=item-1', {
method: 'POST',
body: form,
})
const res = await attachRoute.handler(req, buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).not.toHaveBeenCalled()
expect(body.data.extraction_skipped).toBe(true)
expect(body.data.skip_reason).toBe('sandbox')
})
})
describe('POST /items/:id/retry-extraction', () => {
it('returns 409 with a Swedish message when the company is a sandbox', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
// item lookup
enqueue({
data: { id: 'item-1', document_id: 'doc-1', correlation_id: null, created_supplier_invoice_id: null },
error: null,
})
// sandbox check → true
enqueue({ data: { is_sandbox: true }, error: null })
const req = createMockRequest('/items/item-1/retry-extraction', {
method: 'POST',
searchParams: { _id: 'item-1' },
})
const res = await retryRoute.handler(req, buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ error: string }>(res)
expect(status).toBe(409)
expect(body.error).toMatch(/sandlådan/i)
expect(extractInvoiceFields).not.toHaveBeenCalled()
})
})
})
+47 -10
View File
@@ -69,6 +69,23 @@ async function countPdfPages(buffer: ArrayBuffer): Promise<number | null> {
}
}
// Sandbox companies (24h anonymous demo accounts) skip the Bedrock extraction
// pipeline entirely. The document still uploads, the inbox row still lands,
// and the user can fill the fields in by hand — but no Claude tokens are
// spent on a throwaway account. See migration 20260311120000 for the column.
async function isSandboxCompany(
supabase: import('@supabase/supabase-js').SupabaseClient,
companyId: string,
): Promise<boolean> {
const { data, error } = await supabase
.from('company_settings')
.select('is_sandbox')
.eq('company_id', companyId)
.maybeSingle()
if (error || !data) return false
return data.is_sandbox === true
}
// Partial-update schema for the /items/:id/fields PATCH route. Only the
// scalar fields the UI exposes for inline editing — line items and
// vatBreakdown stay AI-managed for now and are preserved by the merge.
@@ -195,12 +212,17 @@ async function uploadAndExtract(
file.type === 'application/pdf' ? await countPdfPages(file.buffer) : null
const gatedByPageCount =
pageCount != null && pageCount > MAX_PAGES_FOR_AUTO_EXTRACT
const skipExtraction = !!opts.skipExtraction || gatedByPageCount
const skipReason: 'too_many_pages' | 'client_opt_out' | null = gatedByPageCount
? 'too_many_pages'
: opts.skipExtraction
? 'client_opt_out'
: null
const sandbox = await isSandboxCompany(supabase, companyId)
// Skip-reason priority: sandbox > page-count > client opt-out. Sandbox
// wins because it's a hard cost-control rule, not a heuristic.
const skipReason: 'too_many_pages' | 'client_opt_out' | 'sandbox' | null = sandbox
? 'sandbox'
: gatedByPageCount
? 'too_many_pages'
: opts.skipExtraction
? 'client_opt_out'
: null
const skipExtraction = skipReason !== null
// Bring-your-own-extraction: skip the Bedrock call entirely and seed an
// empty extraction skeleton. The caller is expected to PUT the parsed
@@ -772,12 +794,20 @@ export const invoiceInboxExtension: Extension = {
// Same page-count gate as /upload (issue #553) — attaching a 6-page
// sales report to an existing inbox row should not block on Bedrock.
// Sandbox companies skip Bedrock unconditionally.
const pageCount =
file.type === 'application/pdf' ? await countPdfPages(buffer) : null
const gatedByPageCount =
pageCount != null && pageCount > MAX_PAGES_FOR_AUTO_EXTRACT
const sandbox = await isSandboxCompany(ctx.supabase, ctx.companyId)
const skipReason: 'too_many_pages' | 'sandbox' | null = sandbox
? 'sandbox'
: gatedByPageCount
? 'too_many_pages'
: null
const skipExtraction = skipReason !== null
const { data: extracted } = gatedByPageCount
const { data: extracted } = skipExtraction
? { data: emptyResult() }
: await extractInvoiceFields({
buffer: Buffer.from(buffer),
@@ -790,7 +820,7 @@ export const invoiceInboxExtension: Extension = {
.update({
document_id: doc.id,
extracted_data: extracted as unknown as Record<string, unknown>,
extraction_skipped: gatedByPageCount,
extraction_skipped: skipExtraction,
})
.eq('id', id)
.eq('company_id', ctx.companyId)
@@ -827,8 +857,8 @@ export const invoiceInboxExtension: Extension = {
document_id: doc.id,
inbox_item_id: id,
extracted_data: extracted,
extraction_skipped: gatedByPageCount,
skip_reason: gatedByPageCount ? 'too_many_pages' : null,
extraction_skipped: skipExtraction,
skip_reason: skipReason,
page_count: pageCount,
},
})
@@ -1073,6 +1103,13 @@ export const invoiceInboxExtension: Extension = {
)
}
if (await isSandboxCompany(ctx.supabase, ctx.companyId)) {
return NextResponse.json(
{ error: 'AI-tolkning är inte tillgänglig i sandlådan.' },
{ status: 409 },
)
}
const { data: doc } = await ctx.supabase
.from('document_attachments')
.select('storage_path, mime_type, file_name')