feat: comprehensive UI design audit and normalization (#28)

* feat: import system improvements, INK2 fix, and Swedish text corrections

- SIE parser: Windows-1252 and CP437 encoding detection and decoding
- Bank file parser: add Nordea Business (Företag) CSV format
- Bank file parser: improve format detection for SEB, Länsförsäkringar, generic CSV
- INK2 engine: calculate årets resultat (7222) from income statement for open fiscal years
- Dashboard: parallel Supabase queries, simplified dashboard page
- Fix Swedish characters (å, ä, ö) in BAS data descriptions, validation messages, AI consent disclosures
- Import wizard UI improvements across all steps
- Migration: add 'bas_range' match type to sie_account_mappings constraint
- Extensive new tests for SIE parser encoding and bank file parser

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: arcim migration wizard UX fixes, Sentry setup, and extension scaffolding

Arcim migration wizard improvements:
- Progress bar now excludes non-interactive steps (migrating/result)
- Fix OAuth text to match target="_blank" behavior (new tab, not redirect)
- Display month names instead of "Månad X" in preview
- Fix Swedish typo "förifylla" in no-company-info message
- Replace native checkboxes with shadcn Switch in options step
- Add ConfirmationDialog before starting migration
- Show progress percentage during migration
- Add "Nästa steg" guidance and navigation links in result step
- Add "Försök igen" button in error state (returns to options)
- Add Bokio company ID help text (GUID from URL)
- Add Fortnox integration add-on hint on connection failure

Also includes: SIE import system improvements, INK2 fixes, Swedish text
corrections, Sentry error tracking setup, and arcim-migration extension
scaffolding.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: address PR review feedback

- Fix OAuth error recovery blank page (restore provider from URL params)
- Pass real userId to MigrationWizard instead of empty string
- Remove ~50 debug console.log statements from sie-import.ts
- Fix comment referencing account 3740 → 3741

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: comprehensive UI design audit and normalization

Dashboard audit:
- Fix muted-foreground contrast (4.31:1 → 5.08:1) for WCAG AA
- Add prefers-reduced-motion media query for all animations
- Replace border-l-2 accent anti-pattern with subtle full-border colors
- Add aria-expanded to toggle buttons, role="status" to live counters
- Fix touch targets on deadline buttons (28px → 36px)
- Vary section spacing for rhythm (mb-12/mb-10/mb-8)
- Remove unused imports and dead code

Transactions audit + hardening:
- Add pagination (200 per page) with "Ladda fler" button
- Replace height animation with transform-only exit animation
- Show batch progress in floating action bar during processing
- Fix batch bar mobile overlap (bottom-20 on mobile)
- Replace clickable badges with proper button elements
- Add safe area padding to fullscreen swipe view
- Add response.ok check to suggestion fetch
- Add truncation to invoice number buttons

Invoicing audit:
- Remove border-l-4 accent pattern from invoice cards
- Replace string concatenation with cn() utility

Systemic sweep (34 files):
- All page headings: font-bold → font-display font-medium (Fraunces)
- All stat numbers: font-bold → font-display font-medium tabular-nums
- All hard-coded blue/amber/emerald colors → design tokens
- Remove all dark mode overrides (tokens handle automatically)
- Tint pure white card background to 99%

Design context added to CLAUDE.md with brand personality,
aesthetic direction, and 5 design principles.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: bookkeeping flow audit — design system, accessibility, UX

- Replace raw <select> with shadcn Select component (JournalEntryForm)
- Add confirmation dialog for account deletion (ChartOfAccountsManager)
- Remove console.error from production code (JournalEntryList, JournalEntryForm)
- Fix contradictory h-7/min-h-[44px] button sizing → h-10 (ChartOfAccountsManager)
- Increase BAS catalog "Lägg till" touch target h-7 → h-9
- Improve loading state with spinner (JournalEntryList)
- Improve empty state with icon, description, and guidance (JournalEntryList)
- Add response.ok check on journal entry fetch
- Add aria-expanded to entry expand buttons
- Add tabular-nums to desktop debit/credit columns

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: onboarding and empty state improvements

Onboarding:
- Replace font-serif with font-display (Fraunces) for brand consistency
- Remove console.error calls from production code

Empty states:
- Fix broken /transactions/new link in EmptyTransactions (route doesn't exist)
- Add actionHref fallback to EmptyCustomers when no onAction prop provided
- Improve EmptyTransactions description copy

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: clarify Swedish UX copy — terminology, errors, descriptions

Terminology consistency:
- "Försenad" → "Förfallen" for overdue invoices (customers/[id])
- "bokföringsorder" → actionable description in bookkeeping page
- "verifikation har bifogats" → "underlag har bifogats" in doc warning
- "Fortsätt ändå" → "Bokför utan underlag" (specific action)

Error messages — replace generic "Fel" + "Något gick fel" with specific:
- "Något gick fel vid bokföring" → "Transaktionen kunde inte bokföras"
- "Något gick fel vid matchning" → "Transaktionen kunde inte matchas"
- "Kunde inte hämta X" → "Kunde inte ladda X" + recovery hint
- Add "Försök igen" guidance to all error toasts

Page descriptions — replace redundant with actionable:
- Invoices: "Skapa och hantera" → "Skicka, följ betalningar, skapa kreditnotor"
- Bookkeeping: list of features → actionable description

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: design critique — dashboard affordance, reports description

Dashboard:
- Add ChevronRight indicator to clickable summary cards
  (Att få betalt, Koppla bank) to distinguish from static cards
- Add cursor-pointer to linked cards

Reports:
- Replace feature list description with actionable guidance
  "Huvudbok, grundbok..." → "Generera skattedeklarationer..."

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: replace generic "Fel" error toasts with specific messages

Deadlines: 5 generic "Fel" → specific per-action titles
  (create, toggle, edit, delete, load)
Expenses detail: 5 generic "Fel" → specific per-action titles
  (load, approve, pay, credit, delete)
Expenses new: 3 generic "Fel" → instructional validation messages
  (supplier name, supplier selection, invoice number)
Customers: 1 generic "Fel" → specific load error with recovery hint

All error toasts now follow pattern:
  title = what failed, description = how to recover

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: replace all remaining generic "Fel" error toasts (37 instances)

Systematic sweep across 12 dashboard pages replacing generic
title: 'Fel' with context-specific error titles:

- Load errors: "Kunde inte ladda [resurs]"
- Action errors: "[Åtgärd] misslyckades"
- Validation: "[Fält] saknas"

Every error toast now tells the user what failed without needing
to read the description. Recovery hints added where missing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: import flow — normalize stat typography, remove console.warn

- Replace font-bold with font-display font-medium on 13 stat numbers
  across SIEPreviewStep, BankFilePreviewStep, BankFileConfirmStep,
  ImportResultStep (missed by systemic sweep since these are in
  components/import/, not app/(dashboard)/)
- Add tabular-nums to stat numbers displaying counts/currency
- Remove console.warn in ArcimMigrationWorkspace

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: final cleanup — console statements, remaining font-bold stats

Remove production console statements:
- Step1EntityType: remove debug console.warn (dead code after onNext)
- TransactionBookingDialog: remove console.error on doc link failure
- JournalEntryAttachments: remove 3 console.error calls

Normalize remaining font-bold stat displays:
- SwipeCategorizationView: 3 instances (completion, amount displays)
- NEDeclarationView: yearly result heading + value

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address Greptile review feedback

loadMoreTransactions: add inbox item enrichment matching fetchTransactions
- Paginated transactions now fetch invoice_inbox_items in parallel
- Fixes missing document indicator, template suggestions, and inbox
  match card for transactions loaded via "Ladda fler"

fetchAllPages: add maxPages guard (default 500) to prevent infinite loop
- If Arcim gateway returns hasMore:true indefinitely, the loop now
  exits after 500 pages instead of running forever

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-03-14 14:48:40 +01:00
committed by GitHub
co-authored by Claude Opus 4.6
parent a438c50e9c
commit a7be1aab17
62 changed files with 688 additions and 515 deletions
+11 -12
View File
@@ -8,7 +8,6 @@ import { Button } from '@/components/ui/button'
import { useToast } from '@/components/ui/use-toast'
import { Deadline, DeadlineStatus, TAX_DEADLINE_TYPE_LABELS, DEADLINE_STATUS_LABELS } from '@/types'
import { getReportUrl } from '@/lib/tax/deadline-config'
import { STATUS_COLORS } from '@/lib/calendar/utils'
// Use the labels from types
const STATUS_LABELS = DEADLINE_STATUS_LABELS
@@ -139,12 +138,12 @@ export function TaxTodoWidget({ deadlines, onStatusChange }: TaxTodoWidgetProps)
return (
<div
key={deadline.id}
className={`p-3 rounded-lg border ${
className={`p-3 rounded-lg ${
isOverdue
? 'border-destructive/50 bg-destructive/5'
? 'bg-destructive/5 border border-destructive/30'
: isActionNeeded
? 'border-warning/40 bg-warning/10'
: 'border-border bg-background'
? 'bg-warning/5 border border-warning/20'
: ''
}`}
>
<div className="flex items-start justify-between gap-2">
@@ -177,8 +176,8 @@ export function TaxTodoWidget({ deadlines, onStatusChange }: TaxTodoWidgetProps)
{/* Link to report if available */}
{reportLink && (
<Link href={reportLink}>
<Button variant="ghost" size="sm" className="h-7 px-2">
<ExternalLink className="h-3 w-3" />
<Button variant="ghost" size="sm" className="h-9 px-2.5">
<ExternalLink className="h-3.5 w-3.5" />
</Button>
</Link>
)}
@@ -188,12 +187,12 @@ export function TaxTodoWidget({ deadlines, onStatusChange }: TaxTodoWidgetProps)
<Button
variant="outline"
size="sm"
className="h-7 px-2 text-xs"
className="h-9 px-3 text-xs"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'in_progress')}
>
{isUpdating ? (
<Loader2 className="h-3 w-3 animate-spin" />
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
'Påbörja'
)}
@@ -205,15 +204,15 @@ export function TaxTodoWidget({ deadlines, onStatusChange }: TaxTodoWidgetProps)
<Button
variant="default"
size="sm"
className="h-7 px-2 text-xs gap-1"
className="h-9 px-3 text-xs gap-1"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'submitted')}
>
{isUpdating ? (
<Loader2 className="h-3 w-3 animate-spin" />
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<>
<Send className="h-3 w-3" />
<Send className="h-3.5 w-3.5" />
Inskickad
</>
)}
@@ -9,9 +9,7 @@ import { useToast } from '@/components/ui/use-toast'
import { Deadline, DeadlineStatus } from '@/types'
import {
getUpcomingDeadlines,
PRIORITY_LABELS,
STATUS_LABELS,
STATUS_COLORS,
} from '@/lib/calendar/utils'
import { Calendar, ChevronRight, AlertTriangle, Clock, Check, Send, Loader2 } from 'lucide-react'
@@ -125,18 +123,23 @@ export function UpcomingDeadlinesWidget({ deadlines, maxItems = 5, onStatusChang
<CardContent className="space-y-2">
{displayDeadlines.map((deadline) => {
const isUpdating = updatingId === deadline.id
const statusColors = STATUS_COLORS[deadline.status] || STATUS_COLORS.upcoming
return (
<div
key={deadline.id}
className={`flex items-center justify-between p-2 rounded-lg border ${statusColors.border} ${statusColors.bg}`}
className={`flex items-center justify-between p-2 rounded-lg ${
deadline.status === 'overdue'
? 'bg-destructive/5 border border-destructive/30'
: deadline.status === 'action_needed'
? 'bg-warning/5 border border-warning/20'
: ''
}`}
>
<div className="flex items-center gap-2 min-w-0 flex-1">
{deadline.status === 'overdue' ? (
<AlertTriangle className="h-4 w-4 text-destructive flex-shrink-0" />
) : deadline.status === 'action_needed' ? (
<Clock className="h-4 w-4 text-orange-600 flex-shrink-0" />
<Clock className="h-4 w-4 text-warning-foreground flex-shrink-0" />
) : (
<Clock className="h-4 w-4 text-muted-foreground flex-shrink-0" />
)}
@@ -167,15 +170,15 @@ export function UpcomingDeadlinesWidget({ deadlines, maxItems = 5, onStatusChang
<Button
variant="ghost"
size="sm"
className="h-7 px-2"
className="h-9 px-2.5"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'submitted')}
title="Markera som inskickad"
>
{isUpdating ? (
<Loader2 className="h-3 w-3 animate-spin" />
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<Send className="h-3 w-3" />
<Send className="h-3.5 w-3.5" />
)}
</Button>
)}
@@ -184,15 +187,15 @@ export function UpcomingDeadlinesWidget({ deadlines, maxItems = 5, onStatusChang
<Button
variant="ghost"
size="sm"
className="h-7 px-2"
className="h-9 px-2.5"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'confirmed')}
title="Markera som bekräftad"
>
{isUpdating ? (
<Loader2 className="h-3 w-3 animate-spin" />
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<Check className="h-3 w-3" />
<Check className="h-3.5 w-3.5" />
)}
</Button>
)}