feat(dimensions): show the value's name after picking, and let an unused custom dimension be deleted (#2219) (#2255)

* feat(dimensions): show the value's name after picking, and let an unused custom dimension be deleted (#2219)

Two things from the same Discord report, both in bookkeeping from the
transaction view:

1. After picking a kostnadsställe the field showed only the code ("1").
   DimensionCombobox now writes the value's full name under the field once
   a code is committed, exactly as AccountCombobox does for the account
   name (looked up in the full registry so an archived code stays
   readable). The input text itself stays the code: the blur/revert logic
   keys on it.

2. A self-created dimension could not be removed at all: the DB already
   allowed it (enforce_dimension_registry_guards lets a non-system
   dimension go when no posted/reversed line carries its number, and the
   value retention trigger fires on the cascade), but no route or UI
   asked. New DELETE /api/dimensions/[id]: 400 DIMENSION_SYSTEM_DELETE for
   kostnadsställe/projekt, the guard's own Swedish P0001 verbatim as 409
   DIMENSION_REFERENCED, 404, and a happy path; the register gets a quiet
   "Ta bort dimension" link for the active custom dimension behind a
   DestructiveConfirmDialog. Keys added to sv and en.

Closes #2219

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VnConrmMCxJRQ5kfiPPWyy

* test: satisfy the TypeScript ratchet for two test files main inherited from #2247 and #2242

accounts-route.test.ts built SyncResult literals without the
requestedFromDate / historyNarrowed fields #2247 added (vitest does not
typecheck, so it passed locally); fiscal-periods route.test.ts got two
more one-argument POST(req) calls from #2242 in a file already at its
ratchet baseline. Both files now typecheck; the ratchet runs clean.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VnConrmMCxJRQ5kfiPPWyy

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-09-03 19:20:09 +02:00
committed by GitHub
co-authored by Claude Fable 5.1 Jakob Wennberg
parent 2c3ffaf51c
commit a48508e5b0
10 changed files with 269 additions and 9 deletions
+4
View File
@@ -5398,6 +5398,10 @@
"settings_open_register": "Open cost centres & projects",
"new_dimension": "New dimension",
"new_dimension_title": "New dimension",
"delete_dimension": "Delete dimension",
"delete_dimension_confirm_title": "Delete the dimension?",
"delete_dimension_confirm_description": "“{name}” and all its values are deleted permanently. Only possible while no voucher is booked on the dimension; otherwise archive it instead.",
"dimension_deleted_title": "Dimension deleted",
"dim_form_name_invalid": "Enter a name (1–60 characters).",
"dim_form_number_label": "Number",
"dim_form_number_help": "Leave empty for the next free number (20+). SIE reserves 1–19.",
+4
View File
@@ -5398,6 +5398,10 @@
"settings_open_register": "Öppna kostnadsställen & projekt",
"new_dimension": "Ny dimension",
"new_dimension_title": "Ny dimension",
"delete_dimension": "Ta bort dimension",
"delete_dimension_confirm_title": "Ta bort dimensionen?",
"delete_dimension_confirm_description": "”{name}” och alla dess värden tas bort permanent. Det går bara när inget verifikat är bokfört på dimensionen, annars avaktiverar du den istället.",
"dimension_deleted_title": "Dimension borttagen",
"dim_form_name_invalid": "Ange ett namn (1–60 tecken).",
"dim_form_number_label": "Nummer",
"dim_form_number_help": "Lämna tomt för nästa lediga (20+). SIE reserverar 1–19.",