admin/accounted
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(invoices): repair send dialog fiscal-period query + editable issu… (#1066)

Browse Source 
* fix(invoices): repair send dialog fiscal-period query + editable issuance lines

The send/mark-sent dialog queried fiscal_periods with start_date/end_date
instead of period_start/period_end; the query always 400ed, and since PR
#1023 made that fatal the dialog closed instantly, blocking mark-as-sent
and email send for everyone.

Also lets accrual companies edit the proposed journal lines before booking
(both send and mark-sent), mirroring the mark-paid editor: untouched
proposals still book via the server generator; edited lines book verbatim
with balance validated at three layers. Credit notes and periodiserade
invoices keep the read-only preview. The dialog now also respects
defer_invoice_booking (#967).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): harden custom issuance-line validation per review findings

Extract the custom-line parse + balance check into a shared validator so
the send and mark-sent routes cannot drift. Reject rows carrying both
debit and credit, and 29xx interim accounts (custom lines skip accrual
schedule creation, so a 29xx balance would never be dissolved). Validate
the payload only after the invoice ownership fetch, and emit structured
log events when user-edited lines are booked or deliberately ignored, so
manual overrides are visible in audit review.

Account existence needs no route-level check: the engine already resolves
every account against the company chart and throws AccountsNotInChartError.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): address CodeRabbit findings on issuance line editing

Reject malformed JSON bodies with 400 instead of silently booking
generated lines; restrict line editing to SEK invoices (custom lines
cannot carry FX metadata); round each line before the client balance
check to match the server; stop claiming a voucher was created in the
mark-sent toast for deferred-booking companies; add programmatic labels
to the editor inputs and remove-row buttons.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Mattsson
2026-07-19 00:39:56 +02:00
committed by GitHub
co-authored by Claude Fable 5
parent 46b8e2bfea
commit 9c8e540338
12 changed files with 944 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/api/schemas.ts
+16
View File
@@ -668,6 +668,22 @@ export const MarkInvoicePaidSchema = z.object({
force: z.boolean().optional(),
})
export const MarkInvoiceSentSchema = z.object({
// Optional user-edited issuance lines ("Markera som skickad och bokför").
// When present they replace the generated invoice entry verbatim: the route
// validates balance and books exactly these lines, and accrual schedules
// are NOT created (what the user reviewed is what books). Only honored on
// the accrual book-at-issue path; ignored for credit notes, cash-method
// and deferred-booking companies, which don't book at mark-sent.
lines: z.array(z.object({
account_number: accountNumber,
debit_amount: nonNegativeAmount.default(0),
credit_amount: nonNegativeAmount.default(0),
line_description: z.string().optional(),
dimensions: DimensionsBagSchema.optional(),
})).min(2).optional(),
})
// ============================================================
// Customer schemas
// ============================================================