feat: enable banking hardening, arcim inference, SIE fixes, onboarding (#32)
* feat: import system improvements, INK2 fix, and Swedish text corrections - SIE parser: Windows-1252 and CP437 encoding detection and decoding - Bank file parser: add Nordea Business (Företag) CSV format - Bank file parser: improve format detection for SEB, Länsförsäkringar, generic CSV - INK2 engine: calculate årets resultat (7222) from income statement for open fiscal years - Dashboard: parallel Supabase queries, simplified dashboard page - Fix Swedish characters (å, ä, ö) in BAS data descriptions, validation messages, AI consent disclosures - Import wizard UI improvements across all steps - Migration: add 'bas_range' match type to sie_account_mappings constraint - Extensive new tests for SIE parser encoding and bank file parser Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: arcim migration wizard UX fixes, Sentry setup, and extension scaffolding Arcim migration wizard improvements: - Progress bar now excludes non-interactive steps (migrating/result) - Fix OAuth text to match target="_blank" behavior (new tab, not redirect) - Display month names instead of "Månad X" in preview - Fix Swedish typo "förifylla" in no-company-info message - Replace native checkboxes with shadcn Switch in options step - Add ConfirmationDialog before starting migration - Show progress percentage during migration - Add "Nästa steg" guidance and navigation links in result step - Add "Försök igen" button in error state (returns to options) - Add Bokio company ID help text (GUID from URL) - Add Fortnox integration add-on hint on connection failure Also includes: SIE import system improvements, INK2 fixes, Swedish text corrections, Sentry error tracking setup, and arcim-migration extension scaffolding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address PR review feedback - Fix OAuth error recovery blank page (restore provider from URL params) - Pass real userId to MigrationWizard instead of empty string - Remove ~50 debug console.log statements from sie-import.ts - Fix comment referencing account 3740 → 3741 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: comprehensive UI design audit and normalization Dashboard audit: - Fix muted-foreground contrast (4.31:1 → 5.08:1) for WCAG AA - Add prefers-reduced-motion media query for all animations - Replace border-l-2 accent anti-pattern with subtle full-border colors - Add aria-expanded to toggle buttons, role="status" to live counters - Fix touch targets on deadline buttons (28px → 36px) - Vary section spacing for rhythm (mb-12/mb-10/mb-8) - Remove unused imports and dead code Transactions audit + hardening: - Add pagination (200 per page) with "Ladda fler" button - Replace height animation with transform-only exit animation - Show batch progress in floating action bar during processing - Fix batch bar mobile overlap (bottom-20 on mobile) - Replace clickable badges with proper button elements - Add safe area padding to fullscreen swipe view - Add response.ok check to suggestion fetch - Add truncation to invoice number buttons Invoicing audit: - Remove border-l-4 accent pattern from invoice cards - Replace string concatenation with cn() utility Systemic sweep (34 files): - All page headings: font-bold → font-display font-medium (Fraunces) - All stat numbers: font-bold → font-display font-medium tabular-nums - All hard-coded blue/amber/emerald colors → design tokens - Remove all dark mode overrides (tokens handle automatically) - Tint pure white card background to 99% Design context added to CLAUDE.md with brand personality, aesthetic direction, and 5 design principles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: bookkeeping flow audit — design system, accessibility, UX - Replace raw <select> with shadcn Select component (JournalEntryForm) - Add confirmation dialog for account deletion (ChartOfAccountsManager) - Remove console.error from production code (JournalEntryList, JournalEntryForm) - Fix contradictory h-7/min-h-[44px] button sizing → h-10 (ChartOfAccountsManager) - Increase BAS catalog "Lägg till" touch target h-7 → h-9 - Improve loading state with spinner (JournalEntryList) - Improve empty state with icon, description, and guidance (JournalEntryList) - Add response.ok check on journal entry fetch - Add aria-expanded to entry expand buttons - Add tabular-nums to desktop debit/credit columns Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: onboarding and empty state improvements Onboarding: - Replace font-serif with font-display (Fraunces) for brand consistency - Remove console.error calls from production code Empty states: - Fix broken /transactions/new link in EmptyTransactions (route doesn't exist) - Add actionHref fallback to EmptyCustomers when no onAction prop provided - Improve EmptyTransactions description copy Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: clarify Swedish UX copy — terminology, errors, descriptions Terminology consistency: - "Försenad" → "Förfallen" for overdue invoices (customers/[id]) - "bokföringsorder" → actionable description in bookkeeping page - "verifikation har bifogats" → "underlag har bifogats" in doc warning - "Fortsätt ändå" → "Bokför utan underlag" (specific action) Error messages — replace generic "Fel" + "Något gick fel" with specific: - "Något gick fel vid bokföring" → "Transaktionen kunde inte bokföras" - "Något gick fel vid matchning" → "Transaktionen kunde inte matchas" - "Kunde inte hämta X" → "Kunde inte ladda X" + recovery hint - Add "Försök igen" guidance to all error toasts Page descriptions — replace redundant with actionable: - Invoices: "Skapa och hantera" → "Skicka, följ betalningar, skapa kreditnotor" - Bookkeeping: list of features → actionable description Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: design critique — dashboard affordance, reports description Dashboard: - Add ChevronRight indicator to clickable summary cards (Att få betalt, Koppla bank) to distinguish from static cards - Add cursor-pointer to linked cards Reports: - Replace feature list description with actionable guidance "Huvudbok, grundbok..." → "Generera skattedeklarationer..." Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: replace generic "Fel" error toasts with specific messages Deadlines: 5 generic "Fel" → specific per-action titles (create, toggle, edit, delete, load) Expenses detail: 5 generic "Fel" → specific per-action titles (load, approve, pay, credit, delete) Expenses new: 3 generic "Fel" → instructional validation messages (supplier name, supplier selection, invoice number) Customers: 1 generic "Fel" → specific load error with recovery hint All error toasts now follow pattern: title = what failed, description = how to recover Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: replace all remaining generic "Fel" error toasts (37 instances) Systematic sweep across 12 dashboard pages replacing generic title: 'Fel' with context-specific error titles: - Load errors: "Kunde inte ladda [resurs]" - Action errors: "[Åtgärd] misslyckades" - Validation: "[Fält] saknas" Every error toast now tells the user what failed without needing to read the description. Recovery hints added where missing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: import flow — normalize stat typography, remove console.warn - Replace font-bold with font-display font-medium on 13 stat numbers across SIEPreviewStep, BankFilePreviewStep, BankFileConfirmStep, ImportResultStep (missed by systemic sweep since these are in components/import/, not app/(dashboard)/) - Add tabular-nums to stat numbers displaying counts/currency - Remove console.warn in ArcimMigrationWorkspace Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: final cleanup — console statements, remaining font-bold stats Remove production console statements: - Step1EntityType: remove debug console.warn (dead code after onNext) - TransactionBookingDialog: remove console.error on doc link failure - JournalEntryAttachments: remove 3 console.error calls Normalize remaining font-bold stat displays: - SwipeCategorizationView: 3 instances (completion, amount displays) - NEDeclarationView: yearly result heading + value Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address Greptile review feedback loadMoreTransactions: add inbox item enrichment matching fetchTransactions - Paginated transactions now fetch invoice_inbox_items in parallel - Fixes missing document indicator, template suggestions, and inbox match card for transactions loaded via "Ladda fler" fetchAllPages: add maxPages guard (default 500) to prevent infinite loop - If Arcim gateway returns hasMore:true indefinitely, the loop now exits after 500 pages instead of running forever Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: minimize CLAUDE.md — remove derivable content, fix stale data Remove ~230 lines (51% reduction) of content that duplicates what's already in the source code (directory tree, function tables, type definitions, migration lists). Update migration count (63→65), add missing test helpers, fix cron job list. Keep all high-value sections: accounting guard rails, BAS accounts, VAT rutor, design context. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: enable banking hardening, arcim entity inference, SIE import fixes, and onboarding improvements - Enable Banking: OAuth CSRF state tokens, JWT caching, retry with timeouts, raw PSD2 response archival (BFL 7 kap), expired/error connection UI, consent expiry notifications, pagination safety limits - Arcim migration: Smarter entity type inference from org numbers, VAT prefixes, company name suffixes (GmbH, Ltd, etc.), and country codes - SIE import: Parser and import fixes with new migration - BAS accounts: Added vehicle accounts (1241, 1242, 1249, 1259) - Dashboard: New SIE import and stale uncategorized transaction queries - Onboarding: Enhanced NewUserChecklist - Period service: Improvements with updated tests - Transaction ingest: Updated logic and tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address Greptile review — credit note type, EU country codes, notification thresholds, migration timestamps - Fix dead ternary: credit notes now correctly stored as 'credit_note' instead of 'invoice' - Add 'GR' (Greece ISO 3166-1) to EU_COUNTRIES alongside 'EL' (VAT prefix) - Fix consent notification condition: fire at exactly 7 days or ≤3 days, not every day in 7-day window - Deduplicate migration timestamps: rename SIE migration to 20260316120100 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Opus 4.6
Claude Opus 4.6
parent
56fb117d16
commit
98cd253bce
@@ -51,11 +51,85 @@ function getOrgNumber(party: PartyDto): string | null {
|
||||
return party.legalEntity?.companyId || null
|
||||
}
|
||||
|
||||
const EU_COUNTRIES = ['AT', 'BE', 'BG', 'CY', 'CZ', 'DE', 'DK', 'EE', 'EL', 'ES', 'FI', 'FR', 'HR', 'HU', 'IE', 'IT', 'LT', 'LU', 'LV', 'MT', 'NL', 'PL', 'PT', 'RO', 'SI', 'SK']
|
||||
const EU_COUNTRIES = ['AT', 'BE', 'BG', 'CY', 'CZ', 'DE', 'DK', 'EE', 'EL', 'ES', 'FI', 'FR', 'GR', 'HR', 'HU', 'IE', 'IT', 'LT', 'LU', 'LV', 'MT', 'NL', 'PL', 'PT', 'RO', 'SI', 'SK']
|
||||
|
||||
/**
|
||||
* Check if a string looks like a Swedish org number (XXXXXX-XXXX or 10 digits).
|
||||
* Swedish org numbers are 10 digits where the third digit is >= 2 (to distinguish
|
||||
* from personal numbers where month 01-12 appears in positions 3-4).
|
||||
*/
|
||||
function looksLikeSwedishOrgNumber(orgNumber: string | null | undefined): boolean {
|
||||
if (!orgNumber) return false
|
||||
const digits = orgNumber.replace(/[-\s]/g, '')
|
||||
if (digits.length !== 10 || !/^\d+$/.test(digits)) return false
|
||||
// Third digit >= 2 distinguishes org numbers from personal numbers
|
||||
const thirdDigit = parseInt(digits[2], 10)
|
||||
return thirdDigit >= 2
|
||||
}
|
||||
|
||||
/**
|
||||
* Company name suffixes that indicate a foreign (non-Swedish) entity.
|
||||
* These override the default swedish_business assumption when no other
|
||||
* signals (VAT, country code, org number) are available.
|
||||
*/
|
||||
const FOREIGN_SUFFIXES: { suffix: string; region: 'eu' | 'non_eu' }[] = [
|
||||
// German
|
||||
{ suffix: 'gmbh', region: 'eu' },
|
||||
{ suffix: 'ag', region: 'eu' },
|
||||
{ suffix: 'e.v.', region: 'eu' },
|
||||
{ suffix: 'ohg', region: 'eu' },
|
||||
{ suffix: 'kg', region: 'eu' },
|
||||
{ suffix: 'ug', region: 'eu' },
|
||||
// French
|
||||
{ suffix: 'sarl', region: 'eu' },
|
||||
{ suffix: 's.a.r.l.', region: 'eu' },
|
||||
{ suffix: 'sas', region: 'eu' },
|
||||
// Dutch/Belgian
|
||||
{ suffix: 'b.v.', region: 'eu' },
|
||||
{ suffix: 'n.v.', region: 'eu' },
|
||||
{ suffix: 'bv', region: 'eu' },
|
||||
{ suffix: 'nv', region: 'eu' },
|
||||
// Spanish/Italian
|
||||
{ suffix: 's.l.', region: 'eu' },
|
||||
{ suffix: 's.r.l.', region: 'eu' },
|
||||
// Finnish
|
||||
{ suffix: 'oy', region: 'eu' },
|
||||
{ suffix: 'oyj', region: 'eu' },
|
||||
// Danish/Norwegian
|
||||
{ suffix: 'a/s', region: 'eu' },
|
||||
{ suffix: 'aps', region: 'eu' },
|
||||
// Anglo (could be UK, US, etc. — treat as non-EU since UK left)
|
||||
{ suffix: 'ltd', region: 'non_eu' },
|
||||
{ suffix: 'limited', region: 'non_eu' },
|
||||
{ suffix: 'llc', region: 'non_eu' },
|
||||
{ suffix: 'inc', region: 'non_eu' },
|
||||
{ suffix: 'corp', region: 'non_eu' },
|
||||
{ suffix: 'plc', region: 'non_eu' },
|
||||
// Irish (EU)
|
||||
{ suffix: 'dac', region: 'eu' },
|
||||
]
|
||||
|
||||
function inferRegionFromName(name: string | undefined): 'eu' | 'non_eu' | null {
|
||||
if (!name) return null
|
||||
const lower = name.toLowerCase().trim()
|
||||
for (const { suffix, region } of FOREIGN_SUFFIXES) {
|
||||
// Match as a word boundary at the end: "Acme GmbH" but not "Gmbhsson"
|
||||
if (lower.endsWith(suffix) || lower.endsWith(suffix + '.')) {
|
||||
// Check that there's a space or start before the suffix
|
||||
const pos = lower.lastIndexOf(suffix)
|
||||
if (pos === 0 || lower[pos - 1] === ' ') {
|
||||
return region
|
||||
}
|
||||
}
|
||||
}
|
||||
return null
|
||||
}
|
||||
|
||||
function inferTypeFromVatOrCountry(
|
||||
vatNumber: string | undefined,
|
||||
countryCode: string | undefined
|
||||
countryCode: string | undefined,
|
||||
orgNumber?: string | null,
|
||||
companyName?: string
|
||||
): 'swedish_business' | 'eu_business' | 'non_eu_business' {
|
||||
// 1. VAT number prefix is the strongest signal
|
||||
if (vatNumber) {
|
||||
@@ -65,20 +139,68 @@ function inferTypeFromVatOrCountry(
|
||||
return 'non_eu_business'
|
||||
}
|
||||
|
||||
// 2. Fall back to address country
|
||||
// 2. Explicit country code
|
||||
const country = countryCode?.toUpperCase()
|
||||
if (!country || country === 'SE') return 'swedish_business'
|
||||
if (EU_COUNTRIES.includes(country)) return 'eu_business'
|
||||
return 'non_eu_business'
|
||||
if (country === 'SE') return 'swedish_business'
|
||||
if (country && EU_COUNTRIES.includes(country)) return 'eu_business'
|
||||
if (country) return 'non_eu_business'
|
||||
|
||||
// 3. Swedish-format org number is strong evidence of domestic entity
|
||||
if (looksLikeSwedishOrgNumber(orgNumber)) return 'swedish_business'
|
||||
|
||||
// 4. Non-Swedish org number format (wrong digit count) → not Swedish
|
||||
if (orgNumber) {
|
||||
const digits = orgNumber.replace(/[-\s]/g, '')
|
||||
if (digits.length > 0 && digits.length !== 10) {
|
||||
// Not a Swedish org number — use name heuristic or default to non_eu
|
||||
const nameRegion = inferRegionFromName(companyName)
|
||||
if (nameRegion === 'eu') return 'eu_business'
|
||||
return 'non_eu_business'
|
||||
}
|
||||
}
|
||||
|
||||
// 5. Company name suffix heuristic (GmbH, Ltd, etc.)
|
||||
const nameRegion = inferRegionFromName(companyName)
|
||||
if (nameRegion === 'eu') return 'eu_business'
|
||||
if (nameRegion === 'non_eu') return 'non_eu_business'
|
||||
|
||||
// 6. No signal at all — default to swedish_business (most common in Swedish systems)
|
||||
return 'swedish_business'
|
||||
}
|
||||
|
||||
function inferCustomerType(dto: CustomerDto): CustomerType {
|
||||
if (dto.type === 'private') return 'individual'
|
||||
return inferTypeFromVatOrCountry(dto.vatNumber, dto.party.postalAddress?.countryCode)
|
||||
return inferTypeFromVatOrCountry(
|
||||
dto.vatNumber,
|
||||
dto.party.postalAddress?.countryCode,
|
||||
getOrgNumber(dto.party),
|
||||
dto.party.name
|
||||
)
|
||||
}
|
||||
|
||||
function inferSupplierType(dto: SupplierDto): SupplierType {
|
||||
return inferTypeFromVatOrCountry(dto.vatNumber, dto.party.postalAddress?.countryCode)
|
||||
return inferTypeFromVatOrCountry(
|
||||
dto.vatNumber,
|
||||
dto.party.postalAddress?.countryCode,
|
||||
getOrgNumber(dto.party),
|
||||
dto.party.name
|
||||
)
|
||||
}
|
||||
|
||||
/**
|
||||
* Infer customer/supplier type from a PartyDto (used by orchestrator for
|
||||
* minimal entity creation from invoice data).
|
||||
*/
|
||||
export function inferTypeFromParty(
|
||||
party: PartyDto,
|
||||
vatNumber?: string
|
||||
): 'swedish_business' | 'eu_business' | 'non_eu_business' {
|
||||
return inferTypeFromVatOrCountry(
|
||||
vatNumber,
|
||||
party.postalAddress?.countryCode,
|
||||
getOrgNumber(party),
|
||||
party.name
|
||||
)
|
||||
}
|
||||
|
||||
function inferVatTreatment(taxPercent?: number, currencyCode?: string): VatTreatment {
|
||||
@@ -183,7 +305,7 @@ export function mapSalesInvoice(
|
||||
your_reference: null,
|
||||
our_reference: null,
|
||||
notes: dto.note || null,
|
||||
document_type: isCreditNote ? 'invoice' : 'invoice',
|
||||
document_type: isCreditNote ? 'credit_note' : 'invoice',
|
||||
paid_at: dto.paymentStatus.paid ? dto.paymentStatus.lastPaymentDate || dto.issueDate : null,
|
||||
paid_amount: dto.paymentStatus.paid ? total : round2(total - dto.paymentStatus.balance.value),
|
||||
}
|
||||
|
||||
@@ -27,6 +27,7 @@ import {
|
||||
mapSalesInvoice,
|
||||
mapSupplierInvoice,
|
||||
mapCompanyInfo,
|
||||
inferTypeFromParty,
|
||||
} from './entity-mapper'
|
||||
|
||||
export interface MigrationOptions {
|
||||
@@ -246,12 +247,13 @@ export async function executeMigration(options: MigrationOptions): Promise<Migra
|
||||
}
|
||||
|
||||
if (!customerId) {
|
||||
const customerType = inferTypeFromParty(inv.customer)
|
||||
const minimalCustomer = {
|
||||
user_id: userId,
|
||||
name: inv.customer.name,
|
||||
customer_type: 'swedish_business',
|
||||
customer_type: customerType,
|
||||
default_payment_terms: 30,
|
||||
country: 'SE',
|
||||
country: inv.customer.postalAddress?.countryCode || (customerType === 'swedish_business' ? 'SE' : null),
|
||||
vat_number_validated: false,
|
||||
}
|
||||
const { data: created, error: custErr } = await supabase
|
||||
@@ -356,13 +358,14 @@ export async function executeMigration(options: MigrationOptions): Promise<Migra
|
||||
}
|
||||
|
||||
if (!supplierId) {
|
||||
const supplierType = inferTypeFromParty(inv.supplier)
|
||||
const minimalSupplier = {
|
||||
user_id: userId,
|
||||
name: inv.supplier.name,
|
||||
supplier_type: 'swedish_business',
|
||||
supplier_type: supplierType,
|
||||
default_payment_terms: 30,
|
||||
default_currency: 'SEK',
|
||||
country: 'SE',
|
||||
country: inv.supplier.postalAddress?.countryCode || (supplierType === 'swedish_business' ? 'SE' : null),
|
||||
}
|
||||
const { data: created, error: supErr } = await supabase
|
||||
.from('suppliers')
|
||||
|
||||
Reference in New Issue
Block a user