Bug/document linking (#688)

* feat: enhance supplier invoice payment process and settings handling

- Implemented linking of invoice documents to journal entries for cash payments in the supplier invoice payment process.
- Refactored settings fetching logic to improve loading states and error handling across various settings components.
- Introduced a new SettingsLoadError component to handle cases where settings fetch fails or returns no data.
- Updated useSettings hook to manage loading and error states more effectively, allowing for retries on failure.
- Enhanced tests for supplier invoice creation to ensure document IDs are persisted correctly for cash method payments.

* feat(salary): enable monthly salary edits in draft runs and handle zero-total declarations

components/settings/sections/BookkeepingSettingsContent.tsx

@@ -4,6 +4,7 @@ import Link from 'next/link'
 import { useState } from 'react'
 import { useTranslations } from 'next-intl'
 import { SettingsFormWrapper } from '@/components/settings/SettingsFormWrapper'
+import { SettingsLoadError } from '@/components/settings/SettingsLoadError'
 import { SettingsLoadingSkeleton } from '@/components/settings/SettingsLoadingSkeleton'
 import { PeriodLockingSettings } from '@/components/settings/PeriodLockingSettings'
 import { VoucherSeriesManager } from '@/components/settings/VoucherSeriesManager'
@@ -20,7 +21,7 @@ const SERIES_OPTIONS = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'.split('')
 
 export function BookkeepingSettingsContent() {
   const t = useTranslations('settings_bookkeeping')
-  const { settings, isLoading, updateSettings } = useSettings()
+  const { settings, isLoading, updateSettings, refetch } = useSettings()
   const { company } = useCompany()
   // Local mirror of the company-level accounting_framework so the K2/K3
   // selector can reflect its own saves without waiting for the layout to
@@ -30,7 +31,8 @@ export function BookkeepingSettingsContent() {
     company?.accounting_framework ?? 'k2',
   )
 
-  if (isLoading || !settings) return <SettingsLoadingSkeleton />
+  if (isLoading) return <SettingsLoadingSkeleton />
+  if (!settings) return <SettingsLoadError onRetry={refetch} />
 
   function handleSave(formData: FormData) {
     const autoLockValue = formData.get('auto_lock_period_days') as string

components/settings/sections/CompanySettingsContent.tsx

@@ -8,15 +8,17 @@ import { CompanyProfileSection } from '@/components/settings/CompanyProfileSecti
 import { FiscalPeriodEditor } from '@/components/settings/FiscalPeriodEditor'
 import { LogoUpload } from '@/components/settings/LogoUpload'
 import { SettingsFormWrapper } from '@/components/settings/SettingsFormWrapper'
+import { SettingsLoadError } from '@/components/settings/SettingsLoadError'
 import { SettingsLoadingSkeleton } from '@/components/settings/SettingsLoadingSkeleton'
 import { useSettings } from '@/components/settings/useSettings'
 import type { CompanySettings } from '@/types'
 
 export function CompanySettingsContent() {
   const router = useRouter()
-  const { settings, isLoading, updateSettings } = useSettings()
+  const { settings, isLoading, updateSettings, refetch } = useSettings()
 
-  if (isLoading || !settings) return <SettingsLoadingSkeleton />
+  if (isLoading) return <SettingsLoadingSkeleton />
+  if (!settings) return <SettingsLoadError onRetry={refetch} />
 
   function handleSave(formData: FormData) {
     const updates: Record<string, unknown> = {

components/settings/sections/InvoicingSettingsContent.tsx

@@ -6,6 +6,7 @@ import { InvoiceSettingsForm } from '@/components/settings/InvoiceSettingsForm'
 import { InvoicePreviewCard } from '@/components/settings/InvoicePreviewCard'
 import { PdfPrintSettings } from '@/components/settings/PdfPrintSettings'
 import { SettingsFormWrapper } from '@/components/settings/SettingsFormWrapper'
+import { SettingsLoadError } from '@/components/settings/SettingsLoadError'
 import { SettingsLoadingSkeleton } from '@/components/settings/SettingsLoadingSkeleton'
 import { useSettings } from '@/components/settings/useSettings'
 import { useToast } from '@/components/ui/use-toast'
@@ -14,10 +15,11 @@ import type { CompanySettings } from '@/types'
 
 export function InvoicingSettingsContent() {
   const t = useTranslations('settings_invoicing')
-  const { settings, isLoading, updateSettings } = useSettings()
+  const { settings, isLoading, updateSettings, refetch } = useSettings()
   const { toast } = useToast()
 
-  if (isLoading || !settings) return <SettingsLoadingSkeleton />
+  if (isLoading) return <SettingsLoadingSkeleton />
+  if (!settings) return <SettingsLoadError onRetry={refetch} />
 
   function handleSave(formData: FormData) {
     const bankErrors = validateBankFields(formData)

components/settings/sections/TaxSettingsContent.tsx

@@ -1,46 +1,27 @@
 'use client'
 
-import { useEffect, useState } from 'react'
+import { useEffect } from 'react'
 import { useTranslations } from 'next-intl'
 import { useSearchParams, useRouter } from 'next/navigation'
 import { TaxSettingsForm } from '@/components/settings/TaxSettingsForm'
 import { SettingsFormWrapper } from '@/components/settings/SettingsFormWrapper'
+import { SettingsLoadError } from '@/components/settings/SettingsLoadError'
 import { SettingsLoadingSkeleton } from '@/components/settings/SettingsLoadingSkeleton'
 import { SkatteverketConnectPanel } from '@/components/settings/SkatteverketConnectPanel'
 import { useSettings } from '@/components/settings/useSettings'
 import { useToast } from '@/components/ui/use-toast'
-import { useCompany } from '@/contexts/CompanyContext'
-import { createClient } from '@/lib/supabase/client'
 import { ENABLED_EXTENSION_IDS } from '@/lib/extensions/_generated/enabled-extensions'
 import type { CompanySettings } from '@/types'
 
 export function TaxSettingsContent() {
-  const { settings, isLoading, updateSettings } = useSettings()
-  const { company } = useCompany()
+  const { settings, isLoading, updateSettings, refetch } = useSettings()
   const t = useTranslations('settings_skatteverket')
   const searchParams = useSearchParams()
   const router = useRouter()
   const { toast } = useToast()
 
-  const [isSandbox, setIsSandbox] = useState(false)
-
   const hasSkatteverketExtension = ENABLED_EXTENSION_IDS.has('skatteverket')
 
-  // Sandbox companies don't connect to the real Skatteverket — hide the panel,
-  // matching the old Skatteverket tab's visibility gate.
-  useEffect(() => {
-    if (!company?.id) return
-    const supabase = createClient()
-    supabase
-      .from('company_settings')
-      .select('is_sandbox')
-      .eq('company_id', company.id)
-      .single()
-      .then(({ data }) => {
-        if (data?.is_sandbox) setIsSandbox(true)
-      })
-  }, [company?.id])
-
   // Skatteverket OAuth callback — the connect flow returns to /settings/tax with
   // a status query param (returnTo set in SkatteverketConnectPanel).
   useEffect(() => {
@@ -61,7 +42,8 @@ export function TaxSettingsContent() {
     }
   }, [searchParams, router, toast, t])
 
-  if (isLoading || !settings) return <SettingsLoadingSkeleton />
+  if (isLoading) return <SettingsLoadingSkeleton />
+  if (!settings) return <SettingsLoadError onRetry={refetch} />
 
   function handleSave(formData: FormData) {
     const vatRegistered = formData.get('vat_registered') === 'true'
@@ -88,7 +70,10 @@ export function TaxSettingsContent() {
     }
   }
 
-  const showSkatteverket = hasSkatteverketExtension && !isSandbox
+  // Sandbox companies don't connect to the real Skatteverket — hide the panel,
+  // matching the old Skatteverket tab's visibility gate. Read straight off the
+  // already-loaded settings row (no separate query needed).
+  const showSkatteverket = hasSkatteverketExtension && !settings.is_sandbox
 
   return (
     <div className="space-y-8">