fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) (#2347)
* fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) The invoice-to-verifikat link is written on the invoice side only (invoices.journal_entry_id, invoice_payments.journal_entry_id), while the missing-underlag predicate and the periodisk sammanstallning resolved the invoice from the entry's own source columns. A SIE-imported sale matched to its invoice afterwards therefore kept warning "Underlag saknas" and was left out of the EU sales list, although the account-based momsdeklaration showed it and the verifikat page already listed the invoice as its underlag. - verifikat_without_documents / transactions_without_documents: customer- invoice hanvisning arm (BFL 5 kap 7 §), tenant-scoped on the link row; new migration 20260906135702, pinned by a pg-real test. - getInvoiceReferencesForJournalEntries(): one TS mirror of that arm, used by the journal-list filter and bulk exempt, /api/documents/counts (new invoice_references map) and the transactions list; the push cron mirrors it with its global reads. - Journal list: no "Underlag saknas" chip for a covered entry, matching the engine's own invoice rows and the verifikat detail page. - Periodisk sammanstallning: entries fetched by their EU-revenue lines and attributed through every link (engine source_id, invoices.journal_entry_id, invoice_payments.journal_entry_id); kontantmetod invoice_cash_payment entries are filed too, which the old source_type filter dropped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6 * fix(underlag): issued invoices only, blocking mixed-customer settlements in PS, chunk-level degrade (#2298 review) - The customer-invoice hanvisning arms (RPCs, both TS resolvers, push cron) now require an ISSUED invoice: status not in ('draft', 'cancelled'), the schema's own definition (migration 20260427150000). NON_ISSUED_INVOICE_ STATUSES in lib/invoices/matchable-statuses.ts is the shared constant; the pg test pins a draft-linked and a cancelled-payment entry as still missing. - Periodisk sammanstallning: one verifikat linked to invoices of different customers is no longer attributed to the first invoice; it is left out of the accumulators and reported once as a blocking MIXED_CUSTOMER_SETTLEMENT naming the voucher, the customer count and the amount. Same-customer settlements are filed in full. - Transactions list: a failed invoice-reference lookup leaves that chunk's verdict unknown (no badges) and continues with the remaining chunks instead of abandoning them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5.1
Jakob Wennberg
parent
cce0de5704
commit
7448490fb7
@@ -5,15 +5,17 @@ import { NEEDS_DOC_SOURCE_TYPES } from '@/lib/worklist/categories'
|
||||
import { escapeLikePattern } from '@/lib/invoices/duplicate-payment-guard'
|
||||
import { parseVoucher } from '@/lib/bookkeeping/voucher-series-resolver'
|
||||
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
||||
import { getInvoiceReferencesForJournalEntries } from '@/lib/core/bookkeeping/journal-entry-references'
|
||||
|
||||
/**
|
||||
* Shared resolution of "posted verifikat that lack underlag", scoped by the
|
||||
* journal list's filters. Single TS mirror of the verifikat_without_documents
|
||||
* RPC predicate (posted + document-requiring source type, no current-version
|
||||
* document, no BFL 5 kap 7 § hänvisning via a supplier invoice whose retained
|
||||
* document is anchored to a journal entry, no journal_entry_no_doc_required
|
||||
* exemption). Used by the bulk "Inget underlag krävs" route and the journal
|
||||
* list's missing_underlag filter so the two can never disagree.
|
||||
* document is anchored to a journal entry or via a customer invoice that
|
||||
* points at the entry, no journal_entry_no_doc_required exemption). Used by
|
||||
* the bulk "Inget underlag krävs" route and the journal list's
|
||||
* missing_underlag filter so the two can never disagree.
|
||||
*/
|
||||
|
||||
export interface MissingUnderlagFilters {
|
||||
@@ -233,6 +235,17 @@ export async function resolveMissingUnderlagEntries(
|
||||
for (const r of (exemptRes.data ?? []) as { journal_entry_id: string }[]) {
|
||||
exempt.add(r.journal_entry_id)
|
||||
}
|
||||
// BFL 5 kap 7 § hänvisning, customer side (#2298): an entry a register
|
||||
// invoice points at (registration link or invoice_payments row, e.g. a
|
||||
// SIE-imported sale matched to its invoice afterwards) is backed by that
|
||||
// invoice. Mirrors the verifikat_without_documents RPC's customer arm.
|
||||
let invoiceRefs: Map<string, string[]>
|
||||
try {
|
||||
invoiceRefs = await getInvoiceReferencesForJournalEntries(supabase, companyId, chunk)
|
||||
} catch (err) {
|
||||
throw new MissingUnderlagQueryError(getUserErrorMessage(err))
|
||||
}
|
||||
for (const journalEntryId of invoiceRefs.keys()) withDoc.add(journalEntryId)
|
||||
}
|
||||
|
||||
return candidates.filter((e) => !withDoc.has(e.id) && !exempt.has(e.id))
|
||||
|
||||
Reference in New Issue
Block a user