fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) (#2347)
* fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) The invoice-to-verifikat link is written on the invoice side only (invoices.journal_entry_id, invoice_payments.journal_entry_id), while the missing-underlag predicate and the periodisk sammanstallning resolved the invoice from the entry's own source columns. A SIE-imported sale matched to its invoice afterwards therefore kept warning "Underlag saknas" and was left out of the EU sales list, although the account-based momsdeklaration showed it and the verifikat page already listed the invoice as its underlag. - verifikat_without_documents / transactions_without_documents: customer- invoice hanvisning arm (BFL 5 kap 7 §), tenant-scoped on the link row; new migration 20260906135702, pinned by a pg-real test. - getInvoiceReferencesForJournalEntries(): one TS mirror of that arm, used by the journal-list filter and bulk exempt, /api/documents/counts (new invoice_references map) and the transactions list; the push cron mirrors it with its global reads. - Journal list: no "Underlag saknas" chip for a covered entry, matching the engine's own invoice rows and the verifikat detail page. - Periodisk sammanstallning: entries fetched by their EU-revenue lines and attributed through every link (engine source_id, invoices.journal_entry_id, invoice_payments.journal_entry_id); kontantmetod invoice_cash_payment entries are filed too, which the old source_type filter dropped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6 * fix(underlag): issued invoices only, blocking mixed-customer settlements in PS, chunk-level degrade (#2298 review) - The customer-invoice hanvisning arms (RPCs, both TS resolvers, push cron) now require an ISSUED invoice: status not in ('draft', 'cancelled'), the schema's own definition (migration 20260427150000). NON_ISSUED_INVOICE_ STATUSES in lib/invoices/matchable-statuses.ts is the shared constant; the pg test pins a draft-linked and a cancelled-payment entry as still missing. - Periodisk sammanstallning: one verifikat linked to invoices of different customers is no longer attributed to the first invoice; it is left out of the accumulators and reported once as a blocking MIXED_CUSTOMER_SETTLEMENT naming the voucher, the customer count and the amount. Same-customer settlements are filed in full. - Transactions list: a failed invoice-reference lookup leaves that chunk's verdict unknown (no badges) and continues with the remaining chunks instead of abandoning them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
co-authored by
Claude Fable 5.1
Jakob Wennberg
Claude Fable 5.1
Jakob Wennberg
parent
cce0de5704
commit
7448490fb7
@@ -246,6 +246,11 @@ export default function JournalEntryList({
|
||||
const [count, setCount] = useState(0)
|
||||
const [page, setPage] = useState(0)
|
||||
const [attachmentCounts, setAttachmentCounts] = useState<Record<string, number>>({})
|
||||
// Entries a customer invoice points at (registration link or payment row):
|
||||
// backed by that invoice under BFL 5 kap 7 § (hänvisning), the same verdict
|
||||
// the dashboard badge (verifikat_without_documents) and the verifikat page
|
||||
// reach. Not a document, so no paperclip; but no "Underlag saknas" either.
|
||||
const [invoiceReferenced, setInvoiceReferenced] = useState<Set<string>>(new Set())
|
||||
// Counts arrive in a second request, after the rows are already painted.
|
||||
// Until they land, every row looks like it has no underlag, so rendering the
|
||||
// chip eagerly flashes a false "Saknar underlag" compliance warning on every
|
||||
@@ -353,6 +358,7 @@ export default function JournalEntryList({
|
||||
const fetchAttachmentCounts = useCallback(async (entryIds: string[], isCurrent: () => boolean = () => true) => {
|
||||
if (entryIds.length === 0) {
|
||||
setAttachmentCounts({})
|
||||
setInvoiceReferenced(new Set())
|
||||
setAttachmentCountsLoaded(true)
|
||||
return
|
||||
}
|
||||
@@ -370,18 +376,23 @@ export default function JournalEntryList({
|
||||
batches.push(entryIds.slice(i, i + COUNTS_BATCH_SIZE))
|
||||
}
|
||||
try {
|
||||
const empty = { counts: {} as Record<string, number>, referenced: [] as string[] }
|
||||
const results = await Promise.all(
|
||||
batches.map(async (batch) => {
|
||||
const res = await fetch(
|
||||
`/api/documents/counts?journal_entry_ids=${batch.join(',')}`
|
||||
)
|
||||
if (!res.ok) return {} as Record<string, number>
|
||||
const { data } = await res.json()
|
||||
return (data || {}) as Record<string, number>
|
||||
if (!res.ok) return empty
|
||||
const { data, invoice_references } = await res.json()
|
||||
return {
|
||||
counts: (data || {}) as Record<string, number>,
|
||||
referenced: Object.keys((invoice_references || {}) as Record<string, number>),
|
||||
}
|
||||
})
|
||||
)
|
||||
if (!isCurrent()) return
|
||||
setAttachmentCounts(Object.assign({}, ...results))
|
||||
setAttachmentCounts(Object.assign({}, ...results.map((r) => r.counts)))
|
||||
setInvoiceReferenced(new Set(results.flatMap((r) => r.referenced)))
|
||||
} catch {
|
||||
// Non-critical: silently ignore
|
||||
} finally {
|
||||
@@ -810,8 +821,9 @@ export default function JournalEntryList({
|
||||
entry.status === 'posted' &&
|
||||
NEEDS_ATTACHMENT.has(entry.source_type) &&
|
||||
!attachmentCounts[entry.id] &&
|
||||
!invoiceReferenced.has(entry.id) &&
|
||||
!noDocRequired.has(entry.id),
|
||||
[attachmentCounts, noDocRequired],
|
||||
[attachmentCounts, invoiceReferenced, noDocRequired],
|
||||
)
|
||||
|
||||
const handleBatchExempt = async () => {
|
||||
@@ -1631,7 +1643,7 @@ export default function JournalEntryList({
|
||||
<span className="text-xs tabular-nums">{attachmentCounts[entry.id]}</span>
|
||||
</button>
|
||||
) : (
|
||||
attachmentCountsLoaded && NEEDS_ATTACHMENT.has(entry.source_type) && entry.status === 'posted' && (
|
||||
attachmentCountsLoaded && NEEDS_ATTACHMENT.has(entry.source_type) && entry.status === 'posted' && !invoiceReferenced.has(entry.id) && (
|
||||
noDocRequired.has(entry.id) ? (
|
||||
<span title={t('no_doc_required_indicator_tooltip')}>
|
||||
<CircleSlash className="h-3.5 w-3.5 text-muted-foreground" />
|
||||
|
||||
Reference in New Issue
Block a user