fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) (#2347)

* fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298)

The invoice-to-verifikat link is written on the invoice side only
(invoices.journal_entry_id, invoice_payments.journal_entry_id), while the
missing-underlag predicate and the periodisk sammanstallning resolved the
invoice from the entry's own source columns. A SIE-imported sale matched to
its invoice afterwards therefore kept warning "Underlag saknas" and was left
out of the EU sales list, although the account-based momsdeklaration showed
it and the verifikat page already listed the invoice as its underlag.

- verifikat_without_documents / transactions_without_documents: customer-
  invoice hanvisning arm (BFL 5 kap 7 §), tenant-scoped on the link row;
  new migration 20260906135702, pinned by a pg-real test.
- getInvoiceReferencesForJournalEntries(): one TS mirror of that arm, used
  by the journal-list filter and bulk exempt, /api/documents/counts (new
  invoice_references map) and the transactions list; the push cron mirrors
  it with its global reads.
- Journal list: no "Underlag saknas" chip for a covered entry, matching
  the engine's own invoice rows and the verifikat detail page.
- Periodisk sammanstallning: entries fetched by their EU-revenue lines and
  attributed through every link (engine source_id, invoices.journal_entry_id,
  invoice_payments.journal_entry_id); kontantmetod invoice_cash_payment
  entries are filed too, which the old source_type filter dropped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6

* fix(underlag): issued invoices only, blocking mixed-customer settlements in PS, chunk-level degrade (#2298 review)

- The customer-invoice hanvisning arms (RPCs, both TS resolvers, push cron)
  now require an ISSUED invoice: status not in ('draft', 'cancelled'), the
  schema's own definition (migration 20260427150000). NON_ISSUED_INVOICE_
  STATUSES in lib/invoices/matchable-statuses.ts is the shared constant; the
  pg test pins a draft-linked and a cancelled-payment entry as still missing.
- Periodisk sammanstallning: one verifikat linked to invoices of different
  customers is no longer attributed to the first invoice; it is left out of
  the accumulators and reported once as a blocking MIXED_CUSTOMER_SETTLEMENT
  naming the voucher, the customer count and the amount. Same-customer
  settlements are filed in full.
- Transactions list: a failed invoice-reference lookup leaves that chunk's
  verdict unknown (no badges) and continues with the remaining chunks instead
  of abandoning them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-09-06 19:04:30 +02:00
committed by GitHub
co-authored by Claude Fable 5.1 Jakob Wennberg
parent cce0de5704
commit 7448490fb7
16 changed files with 1429 additions and 125 deletions
+23 -3
View File
@@ -2,6 +2,7 @@ import { NextResponse } from 'next/server'
import { z } from 'zod'
import { withRouteContext } from '@/lib/api/with-route-context'
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
import { getInvoiceReferencesForJournalEntries } from '@/lib/core/bookkeeping/journal-entry-references'
const uuidSchema = z.string().uuid()
@@ -12,8 +13,8 @@ const uuidSchema = z.string().uuid()
* into a PostgREST .or() filter string, so validation doubles as injection
* protection).
*
* Counts BOTH direct attachments (document_attachments.journal_entry_id) and
* documents retained on a supplier invoice that references the entry
* `data` counts BOTH direct attachments (document_attachments.journal_entry_id)
* and documents retained on a supplier invoice that references the entry
* (registration/payment FK or a supplier_invoice_payments row). BFL 5 kap 7 §
* accepts underlag via hänvisning, and the expanded-row view
* (JournalEntryAttachments) already lists referenced docs: counting only
@@ -23,6 +24,14 @@ const uuidSchema = z.string().uuid()
* guards, so they must not silence the missing-underlag warning (mirrors the
* verifikat_without_documents RPC). Documents are deduplicated per entry so a
* doc that is both directly linked and referenced counts once.
*
* `invoice_references` counts, per requested entry, the customer invoices
* that point at it (invoices.journal_entry_id or an invoice_payments row):
* the customer-side hänvisning (#2298). Kept apart from `data` because a
* register invoice is not a document row: the list must not offer a
* paperclip with nothing behind it, but it must stop warning "Underlag
* saknas" for an entry the verifikat page already lists an invoice on.
* Same verdict as the RPC's customer arm and the verifikat detail page.
*/
export const GET = withRouteContext('document.counts', async (request, ctx) => {
const { supabase, companyId } = ctx
@@ -125,6 +134,13 @@ export const GET = withRouteContext('document.counts', async (request, ctx) => {
add(row.journal_entry_id, row.supplier_invoice.document_id)
}
let invoiceRefs: Map<string, string[]>
try {
invoiceRefs = await getInvoiceReferencesForJournalEntries(supabase, companyId, ids)
} catch (err) {
return NextResponse.json({ error: getUserErrorMessage(err) }, { status: 500 })
}
// Referenced entries outside the requested set (an SI FK can point at an
// entry the caller didn't ask about) must not leak into the response.
const requested = new Set(ids)
@@ -132,6 +148,10 @@ export const GET = withRouteContext('document.counts', async (request, ctx) => {
for (const [journalEntryId, docIds] of docsByEntry) {
if (requested.has(journalEntryId)) counts[journalEntryId] = docIds.size
}
const invoiceReferences: Record<string, number> = {}
for (const [journalEntryId, invoiceIds] of invoiceRefs) {
if (requested.has(journalEntryId)) invoiceReferences[journalEntryId] = invoiceIds.length
}
return NextResponse.json({ data: counts })
return NextResponse.json({ data: counts, invoice_references: invoiceReferences })
})