admin/accounted
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) (#2347)

Browse Source 
* fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298)

The invoice-to-verifikat link is written on the invoice side only
(invoices.journal_entry_id, invoice_payments.journal_entry_id), while the
missing-underlag predicate and the periodisk sammanstallning resolved the
invoice from the entry's own source columns. A SIE-imported sale matched to
its invoice afterwards therefore kept warning "Underlag saknas" and was left
out of the EU sales list, although the account-based momsdeklaration showed
it and the verifikat page already listed the invoice as its underlag.

- verifikat_without_documents / transactions_without_documents: customer-
  invoice hanvisning arm (BFL 5 kap 7 §), tenant-scoped on the link row;
  new migration 20260906135702, pinned by a pg-real test.
- getInvoiceReferencesForJournalEntries(): one TS mirror of that arm, used
  by the journal-list filter and bulk exempt, /api/documents/counts (new
  invoice_references map) and the transactions list; the push cron mirrors
  it with its global reads.
- Journal list: no "Underlag saknas" chip for a covered entry, matching
  the engine's own invoice rows and the verifikat detail page.
- Periodisk sammanstallning: entries fetched by their EU-revenue lines and
  attributed through every link (engine source_id, invoices.journal_entry_id,
  invoice_payments.journal_entry_id); kontantmetod invoice_cash_payment
  entries are filed too, which the old source_type filter dropped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6

* fix(underlag): issued invoices only, blocking mixed-customer settlements in PS, chunk-level degrade (#2298 review)

- The customer-invoice hanvisning arms (RPCs, both TS resolvers, push cron)
  now require an ISSUED invoice: status not in ('draft', 'cancelled'), the
  schema's own definition (migration 20260427150000). NON_ISSUED_INVOICE_
  STATUSES in lib/invoices/matchable-statuses.ts is the shared constant; the
  pg test pins a draft-linked and a cancelled-payment entry as still missing.
- Periodisk sammanstallning: one verifikat linked to invoices of different
  customers is no longer attributed to the first invoice; it is left out of
  the accumulators and reported once as a blocking MIXED_CUSTOMER_SETTLEMENT
  naming the voucher, the customer count and the amount. Same-customer
  settlements are filed in full.
- Transactions list: a failed invoice-reference lookup leaves that chunk's
  verdict unknown (no badges) and continues with the remaining chunks instead
  of abandoning them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Jakob Wennberg
2026-09-06 19:04:30 +02:00
committed by GitHub
co-authored by Claude Fable 5.1 Jakob Wennberg
parent cce0de5704
commit 7448490fb7
16 changed files with 1429 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/api/bookkeeping/journal-entries/__tests__/route.test.ts
+32
View File
@@ -377,6 +377,8 @@ describe('GET /api/bookkeeping/journal-entries', () => {
enqueue({ data: [], error: null }) // no SI references
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [{ journal_entry_id: E3 }], error: null }) // E3 exempt
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
const fullRow = makeJournalEntry({ id: E2 })
enqueue({ data: [fullRow], error: null }) // page rows
@@ -415,6 +417,8 @@ describe('GET /api/bookkeeping/journal-entries', () => {
enqueue({ data: [], error: null }) // no SI references
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
enqueue({ data: [makeJournalEntry({ id: E2 })], error: null }) // page rows
const request = createMockRequest('/api/bookkeeping/journal-entries', {
@@ -450,6 +454,8 @@ describe('GET /api/bookkeeping/journal-entries', () => {
})
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
enqueue({ data: [makeJournalEntry({ id: E2 })], error: null }) // page rows
const request = createMockRequest('/api/bookkeeping/journal-entries', {
@@ -464,6 +470,30 @@ describe('GET /api/bookkeeping/journal-entries', () => {
expect(body.count).toBe(1)
})
it('treats a customer invoice pointing at the entry as underlag (#2298)', async () => {
// E1: a SIE-imported voucher the user matched to an invoice created in
// Accounted (invoice_payments row). E2: nothing points at it.
enqueue({ data: [candidate(E1, 1), candidate(E2, 2)], error: null })
enqueue({ data: [], error: null }) // no direct documents
enqueue({ data: [], error: null }) // no SI references
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [], error: null }) // no direct invoice links
enqueue({ data: [{ id: 'pay-1', invoice_id: 'inv-1', journal_entry_id: E1 }], error: null })
enqueue({ data: [makeJournalEntry({ id: E2 })], error: null }) // page rows
const request = createMockRequest('/api/bookkeeping/journal-entries', {
searchParams: { missing_underlag: 'true', exclude_draft: 'true' },
})
const { status, body } = await parseJsonResponse<{ data: { id: string }[]; count: number }>(
await GET(request, { params: Promise.resolve({}) })
)
expect(status).toBe(200)
expect(body.data.map((e) => e.id)).toEqual([E2])
expect(body.count).toBe(1)
})
it('matches a voucher-label search against series+number, like the direct path', async () => {
// A voucher-shaped needle fans out to TWO candidate queries (description
// ilike, then series+number), unioned by id: a runtime-built .or()
@@ -474,6 +504,8 @@ describe('GET /api/bookkeeping/journal-entries', () => {
enqueue({ data: [], error: null }) // no SI references
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
enqueue({ data: [makeJournalEntry({ id: E1 })], error: null }) // page rows
const request = createMockRequest('/api/bookkeeping/journal-entries', {
app/api/bookkeeping/no-doc-required/bulk-missing/__tests__/route.test.ts
+26
View File
@@ -64,12 +64,17 @@ describe('POST /api/bookkeeping/no-doc-required/bulk-missing', () => {
expect((await parseJsonResponse(res)).status).toBe(400)
})
// Queue order per candidate chunk mirrors resolveMissingUnderlagEntries:
// documents, SI references, SI payment-row references, exemptions, then the
// customer-invoice resolver (invoices by journal_entry_id, invoice_payments).
it('dry_run counts only entries that are missing AND not exempt', async () => {
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
enqueue({ data: [{ journal_entry_id: 'a' }], error: null }) // a has a document
enqueue({ data: [], error: null }) // no SI references with docs
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [{ journal_entry_id: 'b' }], error: null }) // b already exempt
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
const res = await POST(makeReq({ dry_run: true }))
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
@@ -108,18 +113,39 @@ describe('POST /api/bookkeeping/no-doc-required/bulk-missing', () => {
error: null,
})
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
const res = await POST(makeReq({ dry_run: true }))
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
expect(body.data.count).toBe(2) // c and d
})
it('dry_run excludes entries a customer invoice points at (#2298)', async () => {
// a: the invoice register links it directly (invoices.journal_entry_id)
// b: a SIE-imported voucher matched to an invoice (invoice_payments row)
// c: genuinely missing
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
enqueue({ data: [], error: null }) // no direct documents
enqueue({ data: [], error: null }) // no SI references
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [{ id: 'inv-1', journal_entry_id: 'a' }], error: null })
enqueue({ data: [{ id: 'pay-1', invoice_id: 'inv-2', journal_entry_id: 'b' }], error: null })
const res = await POST(makeReq({ dry_run: true }), { params: Promise.resolve({}) })
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
expect(body.data.count).toBe(1) // only c
})
it('marks the missing entries and returns the count', async () => {
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
enqueue({ data: [], error: null }) // no documents
enqueue({ data: [], error: null }) // no SI references with docs
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [{ journal_entry_id: 'a' }], error: null }) // a already exempt
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
enqueue({ error: null }) // helper upsert
const res = await POST(makeReq({ period_id: null, reason: 'Importerad' }))
const { status, body } = await parseJsonResponse<{ data: { exempted: number } }>(res)