Bug/journal entry creation (#480)

* fix(api): update commit entry status from 'manual' to 'user_accept'

* fix(logging): add logger mocks for commit and voucher atomicity tests
This commit is contained in:
Mattsson
2026-05-14 12:38:28 +02:00
committed by GitHub
parent 86c92da52b
commit 70fe8cbd80
4 changed files with 97 additions and 6 deletions
@@ -29,6 +29,15 @@ vi.mock('@/lib/bookkeeping/engine', () => ({
commitEntry: (...args: unknown[]) => mockCommitEntry(...args),
}))
vi.mock('@/lib/logger', () => ({
createLogger: () => ({
info: vi.fn(),
warn: vi.fn(),
error: vi.fn(),
child: vi.fn().mockReturnThis(),
}),
}))
import { POST } from '../route'
describe('POST /api/bookkeeping/journal-entries/[id]/commit', () => {
@@ -78,7 +87,7 @@ describe('POST /api/bookkeeping/journal-entries/[id]/commit', () => {
'company-1',
'user-1',
'entry-1',
'manual'
'user_accept'
)
})
@@ -5,9 +5,12 @@ import { bookkeepingErrorResponse } from '@/lib/bookkeeping/errors'
import { ensureInitialized } from '@/lib/init'
import { requireCompanyId } from '@/lib/company/context'
import { requireWritePermission } from '@/lib/auth/require-write'
import { createLogger } from '@/lib/logger'
ensureInitialized()
const log = createLogger('api.bookkeeping.commit')
export async function POST(
request: Request,
{ params }: { params: Promise<{ id: string }> }
@@ -26,11 +29,18 @@ export async function POST(
const companyId = await requireCompanyId(supabase, user.id)
try {
const posted = await commitEntry(supabase, companyId, user.id, id, 'manual')
const posted = await commitEntry(supabase, companyId, user.id, id, 'user_accept')
return NextResponse.json({ data: posted })
} catch (err) {
const typed = bookkeepingErrorResponse(err)
if (typed) return typed
// Untyped error path: engine logging didn't fire, so log here.
log.error('commit endpoint failed (untyped)', err as Error, {
companyId,
userId: user.id,
entityType: 'journal_entry',
entityId: id,
})
return NextResponse.json(
{ error: err instanceof Error ? err.message : 'Failed to commit entry' },
{ status: 400 }