From 4f96ce920a81a7492aa8f692a906bab5a9db9b7e Mon Sep 17 00:00:00 2001
From: Jonas Hagberg <jonas@lindan.se>
Date: Mon, 29 Jun 2026 22:13:59 +0200
Subject: [PATCH] fix(arcim-migration): dedup customers/suppliers by name when
 org-number is absent (#788)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The register import skips already-imported customers and suppliers by
org-number only. Records without an org-number (private-person customers,
suppliers like PostNord/IKANO) can never match, so every re-sync re-creates
them — and their invoices — producing 2x, 3x, 4x duplicate rows.

The nameToCustomerId / nameToSupplierId maps were already built and populated
but never consulted for dedup. Use them as a fallback: match on org-number
when present, otherwise on name. This mirrors the sales-invoice customer-stub
path, which already keys on `org ?? name`. When an org-number is present we
still match on it alone, avoiding false-positive name collisions across
distinct legal entities.

Signed-off-by: Jonas Hagberg <jonas@lindan.se>
---
 .../lib/migration-orchestrator.ts             | 24 +++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/extensions/general/arcim-migration/lib/migration-orchestrator.ts b/extensions/general/arcim-migration/lib/migration-orchestrator.ts
index fa6ae005..fccc35f1 100644
--- a/extensions/general/arcim-migration/lib/migration-orchestrator.ts
+++ b/extensions/general/arcim-migration/lib/migration-orchestrator.ts
@@ -191,9 +191,18 @@ export async function executeMigration(options: MigrationOptions): Promise<Migra
             continue
           }
 
+          // Dedup against already-imported records: prefer org-number, but fall
+          // back to name when the party has no org-number. Otherwise org-less
+          // customers (private persons) are re-created on every re-sync, since
+          // the org-number map can never match them.
           const orgNumber = getOrgNumberFromParty(customer.party)
-          if (orgNumber && orgNumberToCustomerId.has(orgNumber)) {
-            customerIdMap.set(customer.id, orgNumberToCustomerId.get(orgNumber)!)
+          const existingCustomerId = orgNumber
+            ? orgNumberToCustomerId.get(orgNumber)
+            : customer.party.name
+              ? nameToCustomerId.get(customer.party.name)
+              : undefined
+          if (existingCustomerId) {
+            customerIdMap.set(customer.id, existingCustomerId)
             skipReasons.duplicate = (skipReasons.duplicate ?? 0) + 1
             skipped++
             continue
@@ -272,9 +281,16 @@ export async function executeMigration(options: MigrationOptions): Promise<Migra
             continue
           }
 
+          // Same org-number-then-name dedup as customers, so org-less suppliers
+          // (e.g. PostNord, IKANO BANK) aren't duplicated on every re-sync.
           const orgNumber = getOrgNumberFromParty(supplier.party)
-          if (orgNumber && orgNumberToSupplierId.has(orgNumber)) {
-            supplierIdMap.set(supplier.id, orgNumberToSupplierId.get(orgNumber)!)
+          const existingSupplierId = orgNumber
+            ? orgNumberToSupplierId.get(orgNumber)
+            : supplier.party.name
+              ? nameToSupplierId.get(supplier.party.name)
+              : undefined
+          if (existingSupplierId) {
+            supplierIdMap.set(supplier.id, existingSupplierId)
             skipReasons.duplicate = (skipReasons.duplicate ?? 0) + 1
             skipped++
             continue