perf(reference-data): sweep the remaining raw reads onto the session cache, ratchet to 0 (#1941)
Final consumer migration of the responsiveness plan: the 35 files still fetching fiscal periods, settings, accounts, cash accounts, dimensions or templates on their own now read lib/reference-data, and every client write site invalidates the shared cache instead of refetching locally. Settings and registries: FiscalYearsManager, FiscalPeriodEditor (period snapshotted once per company so a revalidation cannot reset dates being edited), BookingTemplatesPanel, ChartOfAccounts, ChartOfAccountsManager, EditAccountDialog, CorrectionEntryDialog, StrikeLinesDialog, InvoicePaymentAccountsSettings; the dimensions registry (DimensionsManager, DimensionCombobox, LineDimensionFields, DimensionFilter, bookkeeping/[id]) reads useDimensions and the ad-hoc fetchDimensions/fetchDimensionsCached helpers are deleted. Pages and pickers: CashAccountSelector (FyPicker-shaped restore, once per company load), use-account-names, FiscalYearGapNotice, OpeningBalancePeriodStep, BankFileConfirmStep, ImportReviewStep, the import page (invalidates accounts + periods after a SIE execute), customers list, invoices list + detail, pending, salary employee, asset dispose, year-end and periodisering pages (invalidate periods after closing), reports DimensionPnlView (its pivot picker read the wrong payload key and was always empty; it now populates), SkatteverketPanel, TemplatePicker, ArticleForm (vat_registered). Invoice dialogs and extensions: SendInvoiceDialog, PaymentBookingDialog (init reduced to the credit-note lookup + catalogue, proposal and voucher preview fire on open when cached; a local getSession replaces the network getUser for the fallback CC), InvoiceInboxWorkspace, TicWorkspace, ArcimMigrationWorkspace (invalidates after each SIE import step), enable-banking AccountPickerDialog. raw-reference-fetch ratchet: 35 -> 0 files. Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Jakob Wennberg
Claude Fable 5
parent
4560ccbfc9
commit
3ee3565d6d
@@ -15,6 +15,7 @@ import {
|
||||
} from '@/components/settings/SettingsRows'
|
||||
import { useToast } from '@/components/ui/use-toast'
|
||||
import { useCompany } from '@/contexts/CompanyContext'
|
||||
import { useCashAccounts } from '@/lib/reference-data/hooks'
|
||||
import { createClient } from '@/lib/supabase/client'
|
||||
import { formatIbanGroups, uniqueConnectionIban } from '@/lib/company/connection-iban'
|
||||
import { bankgiroFromTicSnapshot } from '@/lib/company/snapshot-bank'
|
||||
@@ -98,7 +99,16 @@ export function InvoicePaymentAccountsSettings({
|
||||
// rows (bank_connection_id nulled) and the connect picker mirrors deselected
|
||||
// accounts with enabled=false, so an unfiltered read could offer a closed or
|
||||
// third-party account. Only offered when the remaining rows agree on one IBAN.
|
||||
const [connectionIban, setConnectionIban] = useState<string | null>(null)
|
||||
const { cashAccounts } = useCashAccounts()
|
||||
const connectionIban = useMemo(
|
||||
() =>
|
||||
uniqueConnectionIban(
|
||||
cashAccounts.filter(
|
||||
(a) => a.enabled && a.currency === 'SEK' && a.bank_connection_id && a.iban,
|
||||
),
|
||||
),
|
||||
[cashAccounts],
|
||||
)
|
||||
const legacySekAccount = useMemo(
|
||||
() => legacySekInvoicePaymentAccount({
|
||||
bank_name: settings.bank_name,
|
||||
@@ -166,18 +176,6 @@ export function InvoicePaymentAccountsSettings({
|
||||
if (cancelled) return
|
||||
setSnapshotBankgiro(bankgiroFromTicSnapshot(data?.tic_snapshot, data?.org_number))
|
||||
})
|
||||
supabase
|
||||
.from('cash_accounts')
|
||||
.select('iban')
|
||||
.eq('company_id', company.id)
|
||||
.eq('enabled', true)
|
||||
.eq('currency', 'SEK')
|
||||
.not('bank_connection_id', 'is', null)
|
||||
.not('iban', 'is', null)
|
||||
.then(({ data }) => {
|
||||
if (cancelled) return
|
||||
setConnectionIban(uniqueConnectionIban(data))
|
||||
})
|
||||
return () => {
|
||||
cancelled = true
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user