fix(pending-ops): record posted ids and land failed_partial instead of clean rejected after partial commits (#842) (#1110)

Multi-step executors (match_transaction_invoice, credit_invoice) post an
irreversible voucher or persist a credit note and then run later fallible
steps. A failure there previously marked the whole op status=rejected,
hiding the posted entity and its id from operators.

- new migration 20260722134114: add failed_partial to the
  pending_operations status CHECK and treat it as terminal in both
  immutability triggers (immutable, undeletable, never re-claimable)
- PartialCommitError + ExecutorResult.partialPostedIds carry the posted
  ids; the dispatcher writes status=failed_partial with
  result_data.posted_ids and returns code=partial_commit
- instrument only the two named executors; hoist the read-only
  settlement-account resolution above the storno in the match executor
- consumer sweep: status union + query schema widened, failed_partial
  folds into the Avvisade tab with a badge and posted-ids detail line,
  bulk/reject routes and MCP tools message it explicitly, worklist and
  expiry sweep intentionally untouched (not pending work)
- tests: pg-real coverage for the new terminal semantics, dispatcher unit
  tests for both partial paths plus byte-for-byte regression guards

Fixes #842

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

app/(dashboard)/pending/page.tsx

@@ -275,6 +275,19 @@ function isAutoExpired(op: PendingOperation): boolean {
   return op.status === 'rejected' && rd?.auto_rejected === true && rd?.reason === 'expired'
 }
 
+/**
+ * failed_partial rows (issue #842): the executor posted an irreversible
+ * voucher/credit note and then failed a later step. The dispatcher persisted
+ * the ids of what WAS posted in result_data.posted_ids; render them so the
+ * reviewer can locate the orphaned entity.
+ */
+function failedPartialPostedIds(op: PendingOperation): string | null {
+  const rd = op.result_data as { posted_ids?: Record<string, string> } | null
+  const entries = Object.entries(rd?.posted_ids ?? {})
+  if (entries.length === 0) return null
+  return entries.map(([key, value]) => `${key}: ${value}`).join(', ')
+}
+
 function formatRelativeTime(dateStr: string): string {
   const now = new Date()
   const date = new Date(dateStr)
@@ -1253,6 +1266,11 @@ export default function PendingOperationsPage() {
                       {t('badge_auto_expired')}
                     </Badge>
                   )}
+                  {op.status === 'failed_partial' && (
+                    <Badge variant="warning" className="ml-1 h-4 px-1.5 py-0 text-[10px]">
+                      {t('badge_failed_partial')}
+                    </Badge>
+                  )}
                 </DataListMeta>
                 {showHighRiskWarning && (
                   <p className="mt-1 flex items-start gap-1 text-xs text-destructive">
@@ -1273,6 +1291,14 @@ export default function PendingOperationsPage() {
                     {t('auto_expired_detail')}
                   </p>
                 )}
+                {op.status === 'failed_partial' && (
+                  <p className="mt-1 text-xs text-muted-foreground">
+                    {t('failed_partial_detail')}
+                    {failedPartialPostedIds(op) && (
+                      <span className="font-mono"> ({failedPartialPostedIds(op)})</span>
+                    )}
+                  </p>
+                )}
               </DataListRow>
             )
           })

app/api/pending-operations/[id]/reject/route.ts

@@ -70,9 +70,13 @@ export const POST = withRouteContext<{ params: Promise<{ id: string }> }>(
           ? 'Operation already rejected.'
           : op.status === 'expired'
             ? 'Operation already expired and can no longer be rejected.'
-            : `Operation already ${op.status}: it was approved explicitly (most likely via the ` +
-              'Att göra / pending UI in parallel), not auto-committed. It can no longer be rejected; ' +
-              'reverse or correct the resulting verifikat instead.'
+            : op.status === 'failed_partial'
+              ? 'Operation already resolved as failed_partial: it failed after posting an ' +
+                'irreversible voucher. It can no longer be rejected; see result_data.posted_ids ' +
+                'for what was posted and correct it with a storno if needed.'
+              : `Operation already ${op.status}: it was approved explicitly (most likely via the ` +
+                'Att göra / pending UI in parallel), not auto-committed. It can no longer be rejected; ' +
+                'reverse or correct the resulting verifikat instead.'
       return NextResponse.json(
         { error: explained, status: op.status },
         { status: 409 }

app/api/pending-operations/bulk-commit/route.ts

@@ -21,6 +21,7 @@ const STATUS_LABELS_SV: Record<string, string> = {
   committing: 'godkänns just nu',
   committed: 'godkänd',
   rejected: 'avvisad',
+  failed_partial: 'delvis genomförd',
 }
 
 export const POST = withRouteContext(

app/api/pending-operations/bulk-reject/route.ts

@@ -16,6 +16,7 @@ const STATUS_LABELS_SV: Record<string, string> = {
   committed: 'godkänd',
   rejected: 'avvisad',
   expired: 'utgången',
+  failed_partial: 'delvis genomförd',
 }
 
 /**

app/api/pending-operations/route.ts

@@ -23,11 +23,19 @@ export const GET = withRouteContext(
     // newer rejections and the "Utgick automatiskt" context would never be seen.
     const orderColumn = status === 'pending' ? 'created_at' : 'resolved_at'
 
+    // 'failed_partial' rows (issue #842: op failed AFTER posting an
+    // irreversible voucher) surface inside the Avvisade tab rather than a
+    // fourth tab: they are resolved-with-failure and must stay visible to the
+    // operator, but a dedicated tab for a rare state would bury it. A direct
+    // ?status=failed_partial query still returns only those rows.
+    const statusesFor = (candidate: string): string[] =>
+      candidate === 'rejected' ? ['rejected', 'failed_partial'] : [candidate]
+
     const listPromise = supabase
       .from('pending_operations')
       .select('*', { count: 'exact' })
       .eq('company_id', companyId)
-      .eq('status', status)
+      .in('status', statusesFor(status))
       .order(orderColumn, { ascending: false, nullsFirst: false })
       .range(offset, offset + limit - 1)
 
@@ -45,7 +53,7 @@ export const GET = withRouteContext(
           .from('pending_operations')
           .select('id', { count: 'exact', head: true })
           .eq('company_id', companyId)
-          .eq('status', candidate),
+          .in('status', statusesFor(candidate)),
       ),
     ])
 
@@ -55,7 +63,7 @@ export const GET = withRouteContext(
       return NextResponse.json({ error: getUserErrorMessage(error) }, { status: 500 })
     }
 
-    const counts: Partial<Record<(typeof statuses)[number], number>> = {
+    const counts: Partial<Record<(typeof statuses)[number] | 'failed_partial', number>> = {
       [status]: count ?? 0,
     }
     otherStatuses.forEach((candidate, index) => {