Fix/chrome pdf preview csp (#572)
* feat: add option to exclude year-end closing entries in SIE export and related reports * delete docs * fix: allow Chrome's PDF viewer in verifikat document preview The /api/documents/:id/inline route shipped with `object-src 'none'` in its CSP, which blocked Chrome's built-in PDF viewer (it renders inline PDFs via an internal <embed>). Users on Chrome saw "Det här innehållet har blockerats" when expanding a PDF attachment in the bookkeeping view; Firefox (PDF.js) and Edge (own viewer) were unaffected, and JPGs worked because <img> isn't subject to object-src. Drops the CSP for this route to the minimum needed for embeddability: `frame-ancestors 'self'`. X-Content-Type-Options: nosniff plus the fixed Content-Type from the handler already block MIME confusion; X-Frame-Options: SAMEORIGIN + frame-ancestors still block clickjacking. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(auth): add webmail deep link to email confirmation screens Mirrors Stripe's signup UX: after asking the user to verify their email, detect their webmail provider from the domain and show a button that opens the inbox in a new tab. Gmail gets a from:<sender> search pre-populated; Outlook/Yahoo/iCloud/Proton open the inbox directly. Unknown / custom domains fall back to the existing copy. Sender address is configurable via NEXT_PUBLIC_BRANDING_AUTH_EMAIL_FROM (default noreply@gnubok.se) so white-label installs can match their Supabase Auth SMTP config. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(auth): unblock first-time password set for BankID users with MFA Supabase rejects updateUser({password}) and mfa.unenroll with "AAL2 session is required" whenever a TOTP factor is enrolled. BankID magic-link logins produce AAL1, and middleware skips MFA enforcement for bankid_linked users, so they had no path to AAL2 — leaving them unable to set a backup password or disable MFA without going through the email-recovery escape hatch. - /api/account/password: branch on app_metadata.has_password. First-time set writes via service.auth.admin.updateUserById (no existing credential to protect, AAL2 guard does not apply). Change-password keeps the user-session updateUser so AAL2 still fires for credential rotation. - /mfa/verify: accept a safeReturnTo query param and route there after successful verify, so step-up flows can land back where they came from. - SecuritySettings: detect the AAL2 error from both change-password and mfa.unenroll and redirect through /mfa/verify?returnTo=/settings/account instead of toasting a dead-end error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Add tests and rounding utility for öre precision in bokslut calculations - Implemented `roundOre` function for rounding SEK amounts to two decimal places, ensuring consistent monetary calculations. - Introduced `ORE_TOLERANCE` constant for comparing rounded amounts, facilitating invariant checks in financial entries. - Created comprehensive tests for `roundOre`, covering typical cases, edge cases, and idempotency. - Added year-end invariants tests to verify database-level guarantees for closing entries, ensuring they balance to the öre and reject discrepancies. - Developed end-to-end tests for the dispositions chain, validating the correctness of calculations across various scenarios. * fix: update PDF rendering to remove Swish QR code generation and set default to disable Swish visibility * fix: enhance security by rejecting data URIs in safeReturnTo function tests * fix: improve rounding logic in roundOre function and add customer_type migration * fix: add customer_type column to customers and enforce CHECK constraint --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Opus 4.7
Claude Opus 4.7
parent
0087b7be3f
commit
32d9978f1b
@@ -39,4 +39,9 @@ describe('safeReturnTo', () => {
|
||||
expect(safeReturnTo('settings', '/')).toBe('/')
|
||||
expect(safeReturnTo('javascript:alert(1)', '/')).toBe('/')
|
||||
})
|
||||
|
||||
it('rejects data: URIs', () => {
|
||||
expect(safeReturnTo('data:text/html,<script>alert(1)</script>', '/')).toBe('/')
|
||||
expect(safeReturnTo('data:,', '/')).toBe('/')
|
||||
})
|
||||
})
|
||||
|
||||
@@ -0,0 +1,78 @@
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { detectWebmailHint } from '../webmail-search'
|
||||
|
||||
const FROM = 'noreply@gnubok.se'
|
||||
|
||||
describe('detectWebmailHint', () => {
|
||||
it('returns Gmail with a pre-populated search for gmail.com', () => {
|
||||
const hint = detectWebmailHint('user@gmail.com', FROM)
|
||||
expect(hint).not.toBeNull()
|
||||
expect(hint!.id).toBe('gmail')
|
||||
expect(hint!.name).toBe('Gmail')
|
||||
expect(hint!.hasSearch).toBe(true)
|
||||
expect(hint!.url).toBe(
|
||||
`https://mail.google.com/mail/u/0/#search/${encodeURIComponent('from:noreply@gnubok.se')}`,
|
||||
)
|
||||
})
|
||||
|
||||
it('also handles googlemail.com as Gmail', () => {
|
||||
const hint = detectWebmailHint('user@googlemail.com', FROM)
|
||||
expect(hint!.id).toBe('gmail')
|
||||
expect(hint!.hasSearch).toBe(true)
|
||||
})
|
||||
|
||||
it('detects Outlook variants (outlook.com, hotmail.com, live.com, msn.com)', () => {
|
||||
for (const domain of ['outlook.com', 'hotmail.com', 'live.com', 'msn.com', 'hotmail.se']) {
|
||||
const hint = detectWebmailHint(`user@${domain}`, FROM)
|
||||
expect(hint?.id, domain).toBe('outlook')
|
||||
expect(hint?.hasSearch, domain).toBe(false)
|
||||
expect(hint?.url, domain).toBe('https://outlook.live.com/mail/0/inbox')
|
||||
}
|
||||
})
|
||||
|
||||
it('detects Yahoo variants', () => {
|
||||
for (const domain of ['yahoo.com', 'yahoo.co.uk', 'yahoo.se', 'ymail.com']) {
|
||||
const hint = detectWebmailHint(`user@${domain}`, FROM)
|
||||
expect(hint?.id, domain).toBe('yahoo')
|
||||
expect(hint?.hasSearch, domain).toBe(false)
|
||||
}
|
||||
})
|
||||
|
||||
it('detects iCloud variants (icloud.com, me.com, mac.com)', () => {
|
||||
for (const domain of ['icloud.com', 'me.com', 'mac.com']) {
|
||||
const hint = detectWebmailHint(`user@${domain}`, FROM)
|
||||
expect(hint?.id, domain).toBe('icloud')
|
||||
expect(hint?.hasSearch, domain).toBe(false)
|
||||
}
|
||||
})
|
||||
|
||||
it('detects Proton variants', () => {
|
||||
for (const domain of ['proton.me', 'protonmail.com', 'pm.me']) {
|
||||
const hint = detectWebmailHint(`user@${domain}`, FROM)
|
||||
expect(hint?.id, domain).toBe('proton')
|
||||
expect(hint?.hasSearch, domain).toBe(false)
|
||||
}
|
||||
})
|
||||
|
||||
it('is case-insensitive on the domain', () => {
|
||||
const hint = detectWebmailHint('User@GMAIL.COM', FROM)
|
||||
expect(hint?.id).toBe('gmail')
|
||||
})
|
||||
|
||||
it('returns null for unknown / custom domains', () => {
|
||||
expect(detectWebmailHint('me@mycompany.com', FROM)).toBeNull()
|
||||
expect(detectWebmailHint('me@example.org', FROM)).toBeNull()
|
||||
})
|
||||
|
||||
it('returns null for malformed email input', () => {
|
||||
expect(detectWebmailHint('not-an-email', FROM)).toBeNull()
|
||||
expect(detectWebmailHint('', FROM)).toBeNull()
|
||||
expect(detectWebmailHint('@gmail.com', FROM)).not.toBeNull()
|
||||
expect(detectWebmailHint('user@', FROM)).toBeNull()
|
||||
})
|
||||
|
||||
it('URL-encodes the sender address (handles special characters)', () => {
|
||||
const hint = detectWebmailHint('user@gmail.com', 'no+reply@gnubok.se')
|
||||
expect(hint!.url).toContain(encodeURIComponent('from:no+reply@gnubok.se'))
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,129 @@
|
||||
/**
|
||||
* Webmail deep links for the "check your email" screen after signup or
|
||||
* password reset. Mirrors Stripe's pattern: detect the user's webmail
|
||||
* provider from the email domain and link straight to their inbox, with
|
||||
* a `from:<sender>` search pre-populated where supported (Gmail).
|
||||
*
|
||||
* Custom domains (Google Workspace, Microsoft 365, Fastmail, etc.) can't
|
||||
* be detected from the address alone — callers should fall back to the
|
||||
* plain "check your inbox" copy when this returns null.
|
||||
*/
|
||||
|
||||
export type WebmailProviderId = 'gmail' | 'outlook' | 'yahoo' | 'icloud' | 'proton'
|
||||
|
||||
export interface WebmailHint {
|
||||
id: WebmailProviderId
|
||||
/** Display name, e.g. "Gmail". Not translated — provider names are global brands. */
|
||||
name: string
|
||||
/** URL that opens the user's inbox, ideally pre-populated with a from: search. */
|
||||
url: string
|
||||
/** True when the URL pre-populates a search for the sender (Gmail only today). */
|
||||
hasSearch: boolean
|
||||
}
|
||||
|
||||
const DOMAIN_TO_PROVIDER: Record<string, WebmailProviderId> = {
|
||||
// Google free tier
|
||||
'gmail.com': 'gmail',
|
||||
'googlemail.com': 'gmail',
|
||||
|
||||
// Microsoft free tier
|
||||
'outlook.com': 'outlook',
|
||||
'outlook.co.uk': 'outlook',
|
||||
'outlook.se': 'outlook',
|
||||
'hotmail.com': 'outlook',
|
||||
'hotmail.co.uk': 'outlook',
|
||||
'hotmail.se': 'outlook',
|
||||
'live.com': 'outlook',
|
||||
'live.se': 'outlook',
|
||||
'msn.com': 'outlook',
|
||||
|
||||
// Yahoo
|
||||
'yahoo.com': 'yahoo',
|
||||
'yahoo.co.uk': 'yahoo',
|
||||
'yahoo.se': 'yahoo',
|
||||
'ymail.com': 'yahoo',
|
||||
'rocketmail.com': 'yahoo',
|
||||
|
||||
// Apple
|
||||
'icloud.com': 'icloud',
|
||||
'me.com': 'icloud',
|
||||
'mac.com': 'icloud',
|
||||
|
||||
// Proton
|
||||
'proton.me': 'proton',
|
||||
'protonmail.com': 'proton',
|
||||
'protonmail.ch': 'proton',
|
||||
'pm.me': 'proton',
|
||||
}
|
||||
|
||||
const PROVIDER_NAMES: Record<WebmailProviderId, string> = {
|
||||
gmail: 'Gmail',
|
||||
outlook: 'Outlook',
|
||||
yahoo: 'Yahoo Mail',
|
||||
icloud: 'iCloud Mail',
|
||||
proton: 'Proton Mail',
|
||||
}
|
||||
|
||||
function extractDomain(email: string): string | null {
|
||||
const at = email.lastIndexOf('@')
|
||||
if (at === -1) return null
|
||||
const domain = email.slice(at + 1).trim().toLowerCase()
|
||||
return domain || null
|
||||
}
|
||||
|
||||
export function detectWebmailHint(email: string, fromAddress: string): WebmailHint | null {
|
||||
const domain = extractDomain(email)
|
||||
if (!domain) return null
|
||||
const id = DOMAIN_TO_PROVIDER[domain]
|
||||
if (!id) return null
|
||||
|
||||
const name = PROVIDER_NAMES[id]
|
||||
|
||||
switch (id) {
|
||||
case 'gmail': {
|
||||
// Hash-based search that survives client-side routing — the URL Stripe uses.
|
||||
const query = encodeURIComponent(`from:${fromAddress}`)
|
||||
return {
|
||||
id,
|
||||
name,
|
||||
url: `https://mail.google.com/mail/u/0/#search/${query}`,
|
||||
hasSearch: true,
|
||||
}
|
||||
}
|
||||
|
||||
case 'outlook':
|
||||
// Outlook's URL-based search has shifted between OWA / Outlook.com / Office
|
||||
// and no single deep link is reliable across all account types. Open the
|
||||
// inbox so the user can locate the email themselves.
|
||||
return {
|
||||
id,
|
||||
name,
|
||||
url: 'https://outlook.live.com/mail/0/inbox',
|
||||
hasSearch: false,
|
||||
}
|
||||
|
||||
case 'yahoo':
|
||||
return {
|
||||
id,
|
||||
name,
|
||||
url: 'https://mail.yahoo.com/',
|
||||
hasSearch: false,
|
||||
}
|
||||
|
||||
case 'icloud':
|
||||
return {
|
||||
id,
|
||||
name,
|
||||
url: 'https://www.icloud.com/mail/',
|
||||
hasSearch: false,
|
||||
}
|
||||
|
||||
case 'proton':
|
||||
return {
|
||||
id,
|
||||
name,
|
||||
url: 'https://mail.proton.me/',
|
||||
hasSearch: false,
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user