fix(journal-entry): add error logging for delete operation in journal… (#379)

* fix(journal-entry): add error logging for delete operation in journal entries * fix(journal-entry): enhance error logging and add tests for delete_last_voucher functionality * fix(journal-entry): restore enforce_journal_entry_immutability function to handle DELETE and un-reversal updates * fix(tests): refactor delete_last_voucher tests to use insertPostedEntryWithLines for consistency
2026-04-28 21:55:51 +02:00
parent cd64c0e3fb
commit 2d36dedf34
3 changed files with 221 additions and 0 deletions
@@ -0,0 +1,149 @@
+import { randomUUID } from 'node:crypto'
+import { describe, expect, it } from 'vitest'
+import { getPool, withUserContext } from '@/tests/pg/setup'
+import {
+  insertBalancedLines,
+  insertDraftJournalEntry,
+  seedCompany,
+} from '@/tests/pg/fixtures'
+
+// Set up a posted journal entry with balanced lines, going through draft so
+// the line-immutability trigger is happy. Returns the entry id.
+async function insertPostedEntryWithLines(params: {
+  userId: string
+  companyId: string
+  fiscalPeriodId: string
+  voucherNumber: number
+  reversesId?: string
+  sourceType?: string
+}): Promise<string> {
+  const id = randomUUID()
+  await getPool().query(
+    `INSERT INTO public.journal_entries
+       (id, user_id, company_id, fiscal_period_id, voucher_number, voucher_series,
+        entry_date, description, source_type, status, reverses_id)
+     VALUES ($1, $2, $3, $4, $5, 'A', '2026-06-01', 'Test entry', $6, 'draft', $7)`,
+    [
+      id,
+      params.userId,
+      params.companyId,
+      params.fiscalPeriodId,
+      params.voucherNumber,
+      params.sourceType ?? 'manual',
+      params.reversesId ?? null,
+    ],
+  )
+  await insertBalancedLines(id)
+  await getPool().query(
+    `UPDATE public.journal_entries SET status = 'posted' WHERE id = $1`,
+    [id],
+  )
+  return id
+}
+
+describe('delete_last_voucher.pg — RPC + immutability trigger interaction', () => {
+  it('deletes the last posted voucher in a series', async () => {
+    const { userId, companyId, fiscalPeriodId } = await seedCompany()
+    const entryId = await insertPostedEntryWithLines({
+      userId, companyId, fiscalPeriodId, voucherNumber: 1,
+    })
+
+    await withUserContext(userId, async (client) => {
+      await client.query(
+        `SELECT public.delete_last_voucher($1::uuid, $2::uuid)`,
+        [companyId, entryId],
+      )
+      // Verify inside the txn — withUserContext rolls back on exit, so an
+      // outer pool query would see the row again.
+      const after = await client.query(
+        `SELECT 1 FROM public.journal_entries WHERE id = $1`,
+        [entryId],
+      )
+      expect(after.rowCount).toBe(0)
+    })
+  })
+
+  it('flips original from reversed back to posted when its storno is deleted', async () => {
+    const { userId, companyId, fiscalPeriodId } = await seedCompany()
+
+    const originalId = await insertPostedEntryWithLines({
+      userId, companyId, fiscalPeriodId, voucherNumber: 1,
+    })
+
+    // Storno: insert with reverses_id already set so the immutability trigger
+    // never sees an UPDATE that adds it after the fact.
+    const stornoId = await insertPostedEntryWithLines({
+      userId, companyId, fiscalPeriodId, voucherNumber: 2,
+      sourceType: 'storno', reversesId: originalId,
+    })
+
+    // Mark original as reversed — posted → reversed is allowed by the state
+    // machine as long as no other fields change.
+    await getPool().query(
+      `UPDATE public.journal_entries SET status = 'reversed', reversed_by_id = $1 WHERE id = $2`,
+      [stornoId, originalId],
+    )
+
+    await withUserContext(userId, async (client) => {
+      await client.query(
+        `SELECT public.delete_last_voucher($1::uuid, $2::uuid)`,
+        [companyId, stornoId],
+      )
+      const restored = await client.query<{ status: string; reversed_by_id: string | null }>(
+        `SELECT status, reversed_by_id FROM public.journal_entries WHERE id = $1`,
+        [originalId],
+      )
+      expect(restored.rows[0]!.status).toBe('posted')
+      expect(restored.rows[0]!.reversed_by_id).toBeNull()
+    })
+  })
+
+  it('blocks direct DELETE on a posted entry without the bypass flag', async () => {
+    const { userId, companyId, fiscalPeriodId } = await seedCompany()
+    const entryId = await insertPostedEntryWithLines({
+      userId, companyId, fiscalPeriodId, voucherNumber: 1,
+    })
+
+    await expect(
+      getPool().query(`DELETE FROM public.journal_entries WHERE id = $1`, [entryId]),
+    ).rejects.toThrow(/Cannot delete journal entries/i)
+  })
+
+  it('blocks UPDATE of arbitrary fields on a posted entry even when bypass flag is set', async () => {
+    const { userId, companyId, fiscalPeriodId } = await seedCompany()
+    const entryId = await insertPostedEntryWithLines({
+      userId, companyId, fiscalPeriodId, voucherNumber: 1,
+    })
+
+    const client = await getPool().connect()
+    try {
+      await client.query(`SELECT set_config('gnubok.allow_delete', 'true', true)`)
+      await expect(
+        client.query(
+          `UPDATE public.journal_entries SET description = 'tampered' WHERE id = $1`,
+          [entryId],
+        ),
+      ).rejects.toThrow(/Cannot modify a posted journal entry/i)
+    } finally {
+      client.release()
+    }
+  })
+
+  it('blocks reversed → posted UPDATE without the bypass flag', async () => {
+    const { userId, companyId, fiscalPeriodId } = await seedCompany()
+    const entryId = await insertPostedEntryWithLines({
+      userId, companyId, fiscalPeriodId, voucherNumber: 1,
+    })
+    await getPool().query(
+      `UPDATE public.journal_entries SET status = 'reversed' WHERE id = $1`,
+      [entryId],
+    )
+
+    await expect(
+      getPool().query(
+        `UPDATE public.journal_entries SET status = 'posted' WHERE id = $1`,
+        [entryId],
+      ),
+    ).rejects.toThrow(/Cannot modify a reversed journal entry/i)
+  })
+})