Check/salary bankid api (#892)
* fix(bankid): harden login/signup flow — polling, signup rollback, metadata merge, enrichment lookup - middleware: read BankID enrichment from the bankid_enrichment table (the extension_data path has been dead since the multi-tenant refactor), so company-less BankID users land on /select-company instead of the manual wizard - BankIdAuth: hard 6-min poll deadline; every failed poll counts toward the give-up limit; guard overlapping ticks so completion runs exactly once (a double /complete regenerated the magic link and invalidated the first, failing logins intermittently); retry clicks wait out the start cooldown instead of silently no-oping; Swedish messages for 429/unknown start errors - bankid/complete: all-or-nothing signup — delete the created user when the identity insert, app_metadata update, or magic-link generation fails, so a retry starts clean instead of hitting account_exists with an unusable account - bankid/unlink: read-merge-write app_metadata so has_password survives unlink (BankID-only users could otherwise strand themselves with no login method) - login: BankID "create account" CTA now links to /register instead of dismissing the notice; sv.json: fix missing å/ä/ö in settings_bankid strings Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: move secondary guides into docs/, delete dead root files Move DOCKER.md, SELF-HOSTING.md, WHITELABEL.md and extensions.md (renamed EXTENSIONS.md) into a new docs/ folder and update all path references (README, setup.sh, .dockerignore image rules, docker-publish workflow comment, _example-branding, lib/branding/service.ts). Delete two dead root files: customer.json (stray API-test payload) and findings.md (point-in-time swarm audit export, criticals already filed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Emil <emilmattsson14@gmail.com> * fix(api): security & correctness hardening + withRouteContext MFA migration across API routes Audit of ~100 app/api routes. Highlights: Security - agent/conversations: list leaked colleagues' titles + message previews (company-scoped RLS, no user filter) -> user-scoped - calendar/feed PUT: raw body into .update() allowed feed_token fixation on a public unauthenticated URL -> strict schema, content toggles only - bokslutsdispositioner: unbounded schablonintaktRate could inflate the IL 30 kap 25% periodiseringsfond cap base -> bounded - agent profile/composer/onboarding: viewers could rewrite the agent profile while sibling /verify blocked them -> role-gated Correctness - account-totals / listAssets: unbounded queries silently truncated at 1000 rows (under-counted money; skipped assets at year-end depreciation) -> fetchAllRows with stable order (+3 more pagination fixes) - voucher-gaps: swallowed detect_voucher_gaps RPC errors (BFNAR gap view could show "no gaps" when the check never ran) -> surfaced - 5 phantom-success writes (OK on zero matched rows) fixed - assets K3 component-sum validated against stale acquisition_cost -> fixed - invite silent email-send failure -> response carries email_sent; deadlines/calendar cast-then-check JSON crashes -> Zod Convention - ~44 legacy routes converted to withRouteContext (MFA); added Zod validation, corrected status codes, console.* -> lib/logger Response shapes preserved for existing callers. ~110 new tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(bookkeeping): save a booking as a reusable template from Bokför direkt Add a "Spara som mall" action to the manual booking dialog so users can capture a kontering they just worked out as a booking template — right where they figured out how something should be booked. - derive amount-parameterised template lines from the concrete booking (settlement = the non-VAT leg nearest the total, 26xx = a VAT line with its rate snapped to the nearest standard rate, the rest = business ratios; line labels come from the loaded BAS chart) - extract the shared TemplateForm out of BookingTemplatesPanel so the booking dialog reuses the same editor, live preview and convertibility hints instead of duplicating them - save via the existing POST /api/settings/booking-templates endpoint Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(bokslut): render arsredovisning RR/BR at ÅRL post level — no kontonummer Bolagsverket rejected a user's filed årsredovisning with "Balansräkning och resultaträkning ska inte innehålla kontonummer": the PDF built every statement row as per-account "1930 Företagskonto" lines while the iXBRL filing path already aggregated to statutory posts, so the two artifacts diverged. The PDF statements now derive from the same K2 risbs mapping the iXBRL document uses (mapTrialBalancesToK2), via a new statement-rows.ts that emits post-level rows in uppställningsform order for both the K2 and K3 templates. Also fixed along the way: - Jämförelseår column (ÅRL 3:5 §) — previous-year trial balances now load and render; the old PDF had no comparatives at all. - mapping.warnings (unmapped accounts, RR ≠ 2099, obalans, reclass nudges) flow into ArsredovisningData.warnings so the wizard flags a non-fileable document before download. - Flerårsöversikt current/previous year overridden with the mapper's strict-3000–3799 Nettoomsattning, mirroring build-input's duplicate-fact rule, so the FB table ties to the RR. - FB eget kapital-table is post-level and drops obeskattade reserver (never eget kapital); K3 equity-changes statement uses real prior-year opening balances with derived utdelning/nyemission residuals that tie the roll-forward exactly to booked UB. - build-input dedupes warnings now that the PDF path runs the same mapping. Regression test asserts no RR/BR label ever contains a four-digit account number again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(reports): diagnose untransferred prior-year results behind balance-sheet differens Prod incident (97 kr): a multi-year SIE migration lacked one year's omforing av arets resultat; the residual corrupted every later derived opening balance and Balansrakningen showed a bare "Differens: 97 kr" with no explanation. Continuity checking cannot catch this failure mode (prior-year UB and derived IB match per-account by construction) - the invariant that actually breaks is per-year P&L = 0 for all non-latest years. - lib/reports/imbalance-diagnosis.ts: shared detector (findUntransferredResults + buildImbalanceDiagnosis) - Balansrakning/Balansrapport attach imbalance_diagnosis when unbalanced, naming the exact culprit years; rendered in web views + PDF; MCP gnubok_get_balance_sheet inherits the field via spread - SIE import: parse-time warning when a completed year's vouchers leave a P&L residual, plus a post-import DB walk surfacing culprits as warnings and structured details.untransferredResults; the Arcim migration workspace previously dropped result.warnings entirely and now renders them - opening-balance/correct: pre-flight the company lock date and return 409 OB_COMPANY_LOCK_DATE (retryable: false, lock date interpolated in the client message) instead of the retryable 500 that invited blind retries; catch-path maps a raced trigger rejection to the same code Diagnosis runs only on unbalanced paths (zero cost when healthy) and never fails the report or the import. No migration, nothing persisted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix: production error remediation — FX rates, deadlines, log levels, correction relink Batch of fixes for recurring Vercel runtime errors: - Riksbanken FX rates: persistent read-through cache (exchange_rates table), one retry honoring Retry-After on 429/5xx, bounded ingest concurrency, and an honest fallback — most recent cached observation or null, never a hardcoded rate silently booked into amount_sek. Unrated transactions stay repairable via refresh-exchange-rate. - Tax deadline regeneration inserts replacement rows before deleting the superseded set, so a failed insert no longer wipes a company's deadlines (the 23502 user_id regression did exactly that). Migration makes deadlines.user_id nullable for system-generated rows. - Route wrappers + errorResponse log 4xx outcomes at warn so only genuine 5xx reach Vercel's runtime-error clustering; client-supplied /api/log telemetry demoted to warn as well. - application/json documents (raw PSD2 responses archived per BFL) validate as parseable JSON with object/array root instead of always failing the magic-byte check. - correctEntry surfaces document-relink failures to callers, and the BFL document-immutability trigger now allows relinking underlag from a reversed entry to its correction (migration + pg test). - Middleware clears stale session cookies on /api requests too, using scope 'local' so cleanup doesn't re-trigger the failed token refresh. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skatteverket): persist token health and stop retrying dead consents Terminal auth errors (SESSION_EXPIRED, REFRESH_EXHAUSTED, MISSING_SCOPE, TOKEN_CORRUPTED) mark the token row needs_reconsent with the error code and timestamp — SKV per-flow refresh tokens live 65 minutes, so once expired nothing recovers without a fresh BankID consent. The AGI kvittens and skattekonto sync crons skip flagged connections instead of failing every night, and the settings panel prompts for re-consent proactively. A successful reconnect resets the row to active. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(banking): allocate distinct BAS ledger slots for PSD2 mirror accounts A bank returning N same-currency accounts used to map them all onto the currency default (1930/1932/1933/1934), tripping the UNIQUE (company_id, ledger_account) constraint per-account — swallowed errors left accounts silently unmirrored. allocatePsd2LedgerAccount now hands out the currency default first, then free 1931–1959 sub-account slots, skipping slots held by any existing row. - Callback persists allocations to accounts_data so the picker pre-fills reality; reconnect reuses previously mirrored ledgers instead of re-deriving (a user remap to 1935 survives). - Selection save resolves effective ledgers up front and rejects duplicates or cross-connection conflicts with a 400 instead of silently skipping the mirror. - Bank error codes + psu_type are forwarded to the settings page for every OAuth error, keying the Handelsbanken corporate fullmakt guidance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(agent): stage exact journal lines on categorization previews Categorization previews only carried debit/credit accounts, the GROSS amount, and separate VAT rows — read together that looks like an unbalanced 'gross on cost account + VAT debit' entry, and it misled both users and agents into rejecting correct proposals. The MCP preview and the pending-operation PATCH now materialize the exact lines the commit executor will post (net cost line, VAT line, gross bank line, SEK) via buildTransactionEntryLines, and PATCH re-derives them from the new mapping instead of spreading stale staged lines. ApprovalCard and /pending render the verifikat lines, falling back to the legacy summary only for operations staged before this fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(bookkeeping): prune unused imported accounts from the chart SIE imports routinely bring in hundreds of accounts that were never used and clutter the kontoplan. New account_usage_counts RPC (one grouped query instead of a count per account) backs GET /api/bookkeeping/accounts/usage, and POST /api/bookkeeping/accounts/prune deletes zero-usage accounts — dry-run first, then an explicit account list capped at 2000. Accounts with journal lines are skipped, never deleted. The chart manager shows a usage column and a prune dialog grouping custom accounts vs unused BAS-seeded ones. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): carry dimensions through v1 invoice and supplier-invoice surfaces Credit-note creation now copies default_dimensions and per-line dimensions from the original, so the reversing journal entry nets against the same dimension cells instead of dropping them. List/detail responses expose the dimension fields, and the OpenAPI spec snapshot follows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * perf: batch serial Supabase round-trips on hot dashboard paths Every dashboard render pays the layout's query chain, so serialized awaits are direct wall-clock: the layout, chat conversation, invoice detail, supplier detail, select-company, and agent-onboarding pages now run their independent lookups in parallel batches, and getCompanyCapabilities folds its disabled-config read into the same round-trip. JournalEntryList hydrates the saved fiscal-year scope optimistically instead of serializing the first entries fetch behind the fiscal-periods request. The supplier detail page filters invoices server-side via a new supplier_id query param instead of fetching the whole company ledger, and the invoice editor (with its framer-motion dependency) lazy-loads so it stops shipping with the invoice list bundle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(salary): one-click runs, payslip delivery, payments settings, run cockpit Salary P1 batch, driving the 20-click flow toward 3 clicks: - One-click 'Starta lönekörning': POST /api/salary/runs accepts an empty body and resolves defaults server-side — period follows the latest non-corrected run, payment date from the new salary_pay_day setting, series from the per-source-type map. The separate /salary/runs/new page is gone. - Run detail page rebuilt as a step-railed cockpit (progress rail, KPI cards, employee ledger, journal preview) on a deliberately wider canvas; components extracted to components/salary/run/. - Payslip delivery: tokenized public payslip pages (/payslip/[token], backed by salary_payslip_links) plus per-employee email send with PDF — employees need no account, and the middleware exempts the route from auth redirects. - Payments settings: salary pay day, default bank, and pain.001 vs Bankgirot Lön format with per-bank upload instructions and an LB sunset warning (banks retire LB during 2026). - AGI panel: full submission status flows (stale drafts, signing links, kvittens polling, error reports); tax payment panel with skattekonto shortcut and mark-as-paid. - Salary calendar bulk editing, employee benefits/tax-card polish, municipality tax-table lookup improvements. messages/sv+en also carry the strings for the account-prune, skatteverket-reconsent, and banking surfaces committed just before this. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: adopt Next 16 proxy.ts convention + repo housekeeping - Rename middleware.ts to proxy.ts with the proxy() export (Next 16 renamed the middleware convention; behavior unchanged). - Exclude dev_docs/ from tsconfig so stray snippets in planning docs don't break the build type-check. - Ratchet antipatterns-baseline down (raw-route-auth 165 → 119) to lock in the withRouteContext migration from 5cfd2b76. - template-library uses roundOre() instead of inline rounding. - database.md: drop account_balances from the key-tables list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(bookkeeping): robust service-role detection in correction document relink relink_documents_to_correction() keyed its service-role branch on auth.role(), which reads the singular request.jwt.claim.role GUC that PostgREST v10+ and the pg-real harness no longer populate. Genuine service-role callers (pending-ops executor / MCP approve) landed in the auth gate and could not relink underlag. Read the role from the request.jwt.claims JSON directly, mirroring the canonical link_voucher_rpcs_tenant_guard convention. Validated on staging. Also: harden the salary run page's error paths (res.json().catch) against non-JSON error bodies, and roll back the pg-real service-role case in finally so an aborted transaction cannot poison a pooled connection for the next test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(documents): restore journal_entry_line_id link durability (BFL 7 kap) Migration 20260704103000 rewrote enforce_document_journal_entry_immutability to guard journal_entry_id but left journal_entry_line_id to the metadata trigger, which exempts draft-linked docs -- and the entry-level trigger only fired on UPDATE OF journal_entry_id, so a line-id-only UPDATE never invoked it at all. That let a set journal_entry_line_id be cleared to NULL, breaking the "link durable from first set" invariant (document-immutability.pg regression). Widen the trigger to fire on journal_entry_line_id too and guard it with the same uuid-durability rule as journal_entry_id (setting NULL -> uuid stays allowed; clearing/re-pointing a set value is blocked, status-independent). The correction-relink GUC path, which legitimately clears line_id when moving underlag to the posted correction, stays exempt. Validated on staging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Signed-off-by: Emil <emilmattsson14@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Mattsson
co-authored by
Claude Opus 4.8
Claude Opus 4.8
parent
ec27228a8e
commit
2c2743eb79
@@ -0,0 +1,333 @@
|
||||
import { randomUUID } from 'node:crypto'
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { getPool, withUserContext } from '@/tests/pg/setup'
|
||||
import {
|
||||
insertAuthUser,
|
||||
insertBalancedLines,
|
||||
insertCompanyMember,
|
||||
insertDraftJournalEntry,
|
||||
seedCompany,
|
||||
} from '@/tests/pg/fixtures'
|
||||
|
||||
// relink_documents_to_correction (20260704103000) is the ONLY legal path for
|
||||
// moving underlag from a corrected (reversed) entry to its correction. The
|
||||
// immutability triggers block the direct UPDATE unconditionally; the RPC
|
||||
// validates the correction chain and performs the move under the narrow
|
||||
// gnubok.allow_correction_relink GUC. These tests reproduce the production
|
||||
// failure ([storno] relinkDocumentsToEntry: BFL_DOCUMENT_IMMUTABILITY) and
|
||||
// prove the RPC path works while every abuse path stays blocked.
|
||||
|
||||
const BFL_RETENTION_ERROR = /BFL [57] kap/i
|
||||
|
||||
async function insertDocument(params: {
|
||||
userId: string
|
||||
companyId: string
|
||||
journalEntryId: string | null
|
||||
journalEntryLineId?: string | null
|
||||
}): Promise<string> {
|
||||
const id = randomUUID()
|
||||
await getPool().query(
|
||||
`INSERT INTO public.document_attachments
|
||||
(id, user_id, company_id, storage_path, file_name, file_size_bytes,
|
||||
mime_type, sha256_hash, journal_entry_id, journal_entry_line_id)
|
||||
VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10)`,
|
||||
[
|
||||
id,
|
||||
params.userId,
|
||||
params.companyId,
|
||||
`documents/${params.userId}/${id}.pdf`,
|
||||
'underlag.pdf',
|
||||
1024,
|
||||
'application/pdf',
|
||||
'a'.repeat(64),
|
||||
params.journalEntryId,
|
||||
params.journalEntryLineId ?? null,
|
||||
],
|
||||
)
|
||||
return id
|
||||
}
|
||||
|
||||
async function insertEntryAtStatus(params: {
|
||||
userId: string
|
||||
companyId: string
|
||||
fiscalPeriodId: string
|
||||
voucherNumber: number
|
||||
status?: 'posted' | 'reversed'
|
||||
correctionOfId?: string
|
||||
}): Promise<string> {
|
||||
const entryId = await insertDraftJournalEntry({
|
||||
userId: params.userId,
|
||||
companyId: params.companyId,
|
||||
fiscalPeriodId: params.fiscalPeriodId,
|
||||
voucherNumber: params.voucherNumber,
|
||||
})
|
||||
await insertBalancedLines(entryId)
|
||||
if (params.correctionOfId) {
|
||||
// Drafts are mutable — set the correction link before posting; the
|
||||
// immutability trigger blocks changing it afterwards.
|
||||
await getPool().query(
|
||||
`UPDATE public.journal_entries SET correction_of_id = $2 WHERE id = $1`,
|
||||
[entryId, params.correctionOfId],
|
||||
)
|
||||
}
|
||||
await getPool().query(
|
||||
`UPDATE public.journal_entries SET status = 'posted' WHERE id = $1`,
|
||||
[entryId],
|
||||
)
|
||||
if (params.status === 'reversed') {
|
||||
await getPool().query(
|
||||
`UPDATE public.journal_entries SET status = 'reversed' WHERE id = $1`,
|
||||
[entryId],
|
||||
)
|
||||
}
|
||||
return entryId
|
||||
}
|
||||
|
||||
/** A reversed original + its posted correction, mirroring correctEntry()'s end state. */
|
||||
async function seedCorrectionPair(seed: {
|
||||
userId: string
|
||||
companyId: string
|
||||
fiscalPeriodId: string
|
||||
}): Promise<{ originalId: string; correctionId: string }> {
|
||||
const originalId = await insertEntryAtStatus({
|
||||
...seed,
|
||||
voucherNumber: 1,
|
||||
status: 'reversed',
|
||||
})
|
||||
const correctionId = await insertEntryAtStatus({
|
||||
...seed,
|
||||
voucherNumber: 2,
|
||||
correctionOfId: originalId,
|
||||
})
|
||||
return { originalId, correctionId }
|
||||
}
|
||||
|
||||
describe('correction-document-relink.pg — relink_documents_to_correction RPC', () => {
|
||||
it('reproduces the production failure: direct relink UPDATE is blocked', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId, correctionId } = await seedCorrectionPair(seed)
|
||||
const docId = await insertDocument({
|
||||
userId: seed.userId,
|
||||
companyId: seed.companyId,
|
||||
journalEntryId: originalId,
|
||||
})
|
||||
|
||||
// This is exactly what relinkDocumentsToEntry used to run — and why it
|
||||
// failed 100% of the time in production.
|
||||
await expect(
|
||||
getPool().query(
|
||||
`UPDATE public.document_attachments
|
||||
SET journal_entry_id = $1, journal_entry_line_id = NULL
|
||||
WHERE id = $2`,
|
||||
[correctionId, docId],
|
||||
),
|
||||
).rejects.toThrow(BFL_RETENTION_ERROR)
|
||||
})
|
||||
|
||||
it('moves underlag along a genuine correction chain and clears the line link', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId, correctionId } = await seedCorrectionPair(seed)
|
||||
const lineRow = await getPool().query<{ id: string }>(
|
||||
`SELECT id FROM public.journal_entry_lines WHERE journal_entry_id = $1 LIMIT 1`,
|
||||
[originalId],
|
||||
)
|
||||
const docId = await insertDocument({
|
||||
userId: seed.userId,
|
||||
companyId: seed.companyId,
|
||||
journalEntryId: originalId,
|
||||
journalEntryLineId: lineRow.rows[0]!.id,
|
||||
})
|
||||
|
||||
await withUserContext(seed.userId, async (client) => {
|
||||
const result = await client.query<{ moved: number }>(
|
||||
`SELECT public.relink_documents_to_correction($1::uuid, $2::uuid, $3::uuid) AS moved`,
|
||||
[seed.userId, originalId, correctionId],
|
||||
)
|
||||
expect(result.rows[0]!.moved).toBe(1)
|
||||
|
||||
const after = await client.query<{
|
||||
journal_entry_id: string | null
|
||||
journal_entry_line_id: string | null
|
||||
}>(
|
||||
`SELECT journal_entry_id, journal_entry_line_id
|
||||
FROM public.document_attachments WHERE id = $1`,
|
||||
[docId],
|
||||
)
|
||||
expect(after.rows[0]!.journal_entry_id).toBe(correctionId)
|
||||
expect(after.rows[0]!.journal_entry_line_id).toBeNull()
|
||||
|
||||
// The move is auditable.
|
||||
const audit = await client.query(
|
||||
`SELECT 1 FROM public.audit_log
|
||||
WHERE table_name = 'document_attachments'
|
||||
AND record_id = $1
|
||||
AND description LIKE 'Relinked%'`,
|
||||
[originalId],
|
||||
)
|
||||
expect(audit.rows).toHaveLength(1)
|
||||
})
|
||||
})
|
||||
|
||||
it('accepts a service-role caller with an explicit p_user_id (pending-operations executor)', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId, correctionId } = await seedCorrectionPair(seed)
|
||||
await insertDocument({
|
||||
userId: seed.userId,
|
||||
companyId: seed.companyId,
|
||||
journalEntryId: originalId,
|
||||
})
|
||||
|
||||
const client = await getPool().connect()
|
||||
try {
|
||||
await client.query('BEGIN')
|
||||
// Service-role shape: role claim without a sub — auth.uid() is NULL.
|
||||
await client.query(`SELECT set_config('request.jwt.claims', $1, true)`, [
|
||||
JSON.stringify({ role: 'service_role' }),
|
||||
])
|
||||
const result = await client.query<{ moved: number }>(
|
||||
`SELECT public.relink_documents_to_correction($1::uuid, $2::uuid, $3::uuid) AS moved`,
|
||||
[seed.userId, originalId, correctionId],
|
||||
)
|
||||
expect(result.rows[0]!.moved).toBe(1)
|
||||
} finally {
|
||||
// Always roll back, even if the RPC or an assertion threw: releasing a
|
||||
// connection mid-transaction poisons it for the next test that reuses it.
|
||||
await client.query('ROLLBACK').catch(() => {})
|
||||
client.release()
|
||||
}
|
||||
})
|
||||
|
||||
it('rejects when the target is not the correction of the source', async () => {
|
||||
const seed = await seedCompany()
|
||||
const originalId = await insertEntryAtStatus({
|
||||
...seed,
|
||||
voucherNumber: 1,
|
||||
status: 'reversed',
|
||||
})
|
||||
// Posted, but with no correction_of_id link back to the original.
|
||||
const unrelatedId = await insertEntryAtStatus({ ...seed, voucherNumber: 2 })
|
||||
await insertDocument({
|
||||
userId: seed.userId,
|
||||
companyId: seed.companyId,
|
||||
journalEntryId: originalId,
|
||||
})
|
||||
|
||||
await withUserContext(seed.userId, async (client) => {
|
||||
await expect(
|
||||
client.query(
|
||||
`SELECT public.relink_documents_to_correction($1::uuid, $2::uuid, $3::uuid)`,
|
||||
[seed.userId, originalId, unrelatedId],
|
||||
),
|
||||
).rejects.toThrow(/not the correction of/i)
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects when the source entry is not reversed', async () => {
|
||||
const seed = await seedCompany()
|
||||
const originalId = await insertEntryAtStatus({ ...seed, voucherNumber: 1 }) // still posted
|
||||
const correctionId = await insertEntryAtStatus({
|
||||
...seed,
|
||||
voucherNumber: 2,
|
||||
correctionOfId: originalId,
|
||||
})
|
||||
|
||||
await withUserContext(seed.userId, async (client) => {
|
||||
await expect(
|
||||
client.query(
|
||||
`SELECT public.relink_documents_to_correction($1::uuid, $2::uuid, $3::uuid)`,
|
||||
[seed.userId, originalId, correctionId],
|
||||
),
|
||||
).rejects.toThrow(/not reversed/i)
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects a caller who is not a member of the entries company', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId, correctionId } = await seedCorrectionPair(seed)
|
||||
|
||||
const bobId = await insertAuthUser()
|
||||
|
||||
await withUserContext(bobId, async (client) => {
|
||||
await expect(
|
||||
client.query(
|
||||
`SELECT public.relink_documents_to_correction($1::uuid, $2::uuid, $3::uuid)`,
|
||||
[bobId, originalId, correctionId],
|
||||
),
|
||||
).rejects.toThrow(/not a member/i)
|
||||
})
|
||||
})
|
||||
|
||||
it('rejects a spoofed p_user_id from an authenticated session', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId, correctionId } = await seedCorrectionPair(seed)
|
||||
|
||||
const malloryId = await insertAuthUser()
|
||||
await insertCompanyMember({
|
||||
companyId: seed.companyId,
|
||||
userId: malloryId,
|
||||
role: 'member',
|
||||
})
|
||||
|
||||
await withUserContext(malloryId, async (client) => {
|
||||
await expect(
|
||||
client.query(
|
||||
`SELECT public.relink_documents_to_correction($1::uuid, $2::uuid, $3::uuid)`,
|
||||
// Attributing the relink to seed.userId while auth.uid() is mallory.
|
||||
[seed.userId, originalId, correctionId],
|
||||
),
|
||||
).rejects.toThrow(/does not match authenticated user/i)
|
||||
})
|
||||
})
|
||||
|
||||
it('GUC stays narrow: journal_entry_id → NULL is blocked even with the relink GUC set', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId } = await seedCorrectionPair(seed)
|
||||
const docId = await insertDocument({
|
||||
userId: seed.userId,
|
||||
companyId: seed.companyId,
|
||||
journalEntryId: originalId,
|
||||
})
|
||||
|
||||
const client = await getPool().connect()
|
||||
try {
|
||||
await client.query('BEGIN')
|
||||
await client.query(`SELECT set_config('gnubok.allow_correction_relink', 'true', true)`)
|
||||
// Clearing to NULL would be a soft-delete bypass of BFL 7 kap 2§ —
|
||||
// must raise even under the GUC.
|
||||
await expect(
|
||||
client.query(
|
||||
`UPDATE public.document_attachments SET journal_entry_id = NULL WHERE id = $1`,
|
||||
[docId],
|
||||
),
|
||||
).rejects.toThrow(BFL_RETENTION_ERROR)
|
||||
await client.query('ROLLBACK')
|
||||
} finally {
|
||||
client.release()
|
||||
}
|
||||
})
|
||||
|
||||
it('GUC stays narrow: sha256_hash mutation is blocked even with the relink GUC set', async () => {
|
||||
const seed = await seedCompany()
|
||||
const { originalId } = await seedCorrectionPair(seed)
|
||||
const docId = await insertDocument({
|
||||
userId: seed.userId,
|
||||
companyId: seed.companyId,
|
||||
journalEntryId: originalId,
|
||||
})
|
||||
|
||||
const client = await getPool().connect()
|
||||
try {
|
||||
await client.query('BEGIN')
|
||||
await client.query(`SELECT set_config('gnubok.allow_correction_relink', 'true', true)`)
|
||||
await expect(
|
||||
client.query(
|
||||
`UPDATE public.document_attachments SET sha256_hash = $2 WHERE id = $1`,
|
||||
[docId, 'f'.repeat(64)],
|
||||
),
|
||||
).rejects.toThrow(BFL_RETENTION_ERROR)
|
||||
await client.query('ROLLBACK')
|
||||
} finally {
|
||||
client.release()
|
||||
}
|
||||
})
|
||||
})
|
||||
@@ -131,7 +131,7 @@ export async function correctEntry(
|
||||
*/
|
||||
preloadedOriginal?: OriginalWithLines
|
||||
}
|
||||
): Promise<{ reversal: JournalEntry; corrected: JournalEntry }> {
|
||||
): Promise<{ reversal: JournalEntry; corrected: JournalEntry; documentRelinkError?: string }> {
|
||||
// Validate the corrected lines are balanced
|
||||
const balance = validateBalance(correctedLines)
|
||||
if (!balance.valid) {
|
||||
@@ -424,9 +424,16 @@ export async function correctEntry(
|
||||
// live representation of the affärshändelse, so the transaction row should
|
||||
// keep reading as booked against it (and stay correctable/uncategorizable),
|
||||
// and the underlag should travel with it. Best-effort: the correction_of_id
|
||||
// chain preserves traceability even if either relink fails.
|
||||
// chain preserves traceability even if either relink fails, but a document
|
||||
// relink failure is surfaced on the result so the caller can warn instead
|
||||
// of silently stranding underlag on the reversed entry.
|
||||
await relinkTransactionsToEntry(supabase, companyId, originalEntryId, correctedEntry!.id)
|
||||
await relinkDocumentsToEntry(supabase, companyId, originalEntryId, correctedEntry!.id)
|
||||
const documentRelinkError = await relinkDocumentsToEntry(
|
||||
supabase,
|
||||
userId,
|
||||
originalEntryId,
|
||||
correctedEntry!.id
|
||||
)
|
||||
|
||||
// ===== Step 3: Fetch complete entries =====
|
||||
const { data: finalReversal } = await supabase
|
||||
@@ -444,6 +451,7 @@ export async function correctEntry(
|
||||
const result = {
|
||||
reversal: finalReversal as JournalEntry,
|
||||
corrected: finalCorrected as JournalEntry,
|
||||
...(documentRelinkError ? { documentRelinkError } : {}),
|
||||
}
|
||||
|
||||
await eventBus.emit({
|
||||
@@ -582,27 +590,38 @@ async function relinkTransactionsToEntry(
|
||||
}
|
||||
|
||||
/**
|
||||
* Re-point every document_attachment from one entry to another. Used when a
|
||||
* verifikation is moved to a different period so its underlag travels with the
|
||||
* live (corrected) entry. The line-level link is cleared because the corrected
|
||||
* entry has new line ids. Failures are logged, not thrown: the entry-level
|
||||
* correction chain is the source of truth for traceability.
|
||||
* Re-point every document_attachment from one entry to another so the
|
||||
* underlag travels with the live (corrected) entry. Goes through the
|
||||
* relink_documents_to_correction RPC: a direct UPDATE on
|
||||
* document_attachments.journal_entry_id is categorically blocked by the
|
||||
* BFL immutability triggers (migration 20260506130000/150000); the RPC
|
||||
* validates the correction chain (source reversed, target posted,
|
||||
* target.correction_of_id = source) and performs the move under the narrow
|
||||
* gnubok.allow_correction_relink GUC. The line-level link is cleared because
|
||||
* the corrected entry has new line ids.
|
||||
*
|
||||
* Failures are logged, not thrown (the entry-level correction chain is the
|
||||
* source of truth for traceability), but the error message is returned so
|
||||
* correctEntry can surface a warning instead of pretending the underlag
|
||||
* moved.
|
||||
*/
|
||||
async function relinkDocumentsToEntry(
|
||||
supabase: SupabaseClient,
|
||||
companyId: string,
|
||||
userId: string,
|
||||
fromEntryId: string,
|
||||
toEntryId: string
|
||||
): Promise<void> {
|
||||
const { error } = await supabase
|
||||
.from('document_attachments')
|
||||
.update({ journal_entry_id: toEntryId, journal_entry_line_id: null })
|
||||
.eq('company_id', companyId)
|
||||
.eq('journal_entry_id', fromEntryId)
|
||||
): Promise<string | undefined> {
|
||||
const { error } = await supabase.rpc('relink_documents_to_correction', {
|
||||
p_user_id: userId,
|
||||
p_from_entry_id: fromEntryId,
|
||||
p_to_entry_id: toEntryId,
|
||||
})
|
||||
if (error) {
|
||||
console.error(
|
||||
`[storno] relinkDocumentsToEntry: failed to move documents ${fromEntryId} → ${toEntryId}:`,
|
||||
error.message
|
||||
)
|
||||
return error.message
|
||||
}
|
||||
return undefined
|
||||
}
|
||||
|
||||
@@ -116,6 +116,53 @@ describe('validateDocumentMagicBytes: application/xhtml+xml', () => {
|
||||
})
|
||||
})
|
||||
|
||||
describe('validateDocumentMagicBytes: application/json', () => {
|
||||
const toBuffer = (text: string, bom = false): ArrayBuffer => {
|
||||
const bytes = new TextEncoder().encode(bom ? `${text}` : text)
|
||||
return bytes.buffer.slice(bytes.byteOffset, bytes.byteOffset + bytes.byteLength) as ArrayBuffer
|
||||
}
|
||||
|
||||
it('accepts a JSON object (raw PSD2 response archive shape)', () => {
|
||||
const psd2Page = JSON.stringify({ transactions: [{ amount: '100.00' }], continuation_key: null })
|
||||
expect(validateDocumentMagicBytes(toBuffer(psd2Page), 'application/json')).toBeNull()
|
||||
})
|
||||
|
||||
it('accepts a JSON array, leading whitespace, and a UTF-8 BOM', () => {
|
||||
expect(validateDocumentMagicBytes(toBuffer('[1, 2, 3]'), 'application/json')).toBeNull()
|
||||
expect(validateDocumentMagicBytes(toBuffer('\n {"a": 1}'), 'application/json')).toBeNull()
|
||||
expect(validateDocumentMagicBytes(toBuffer('{"a": 1}', true), 'application/json')).toBeNull()
|
||||
})
|
||||
|
||||
it('rejects prose placeholders and bare JSON scalars', () => {
|
||||
expect(validateDocumentMagicBytes(toBuffer('summary of the response'), 'application/json')).toMatch(
|
||||
/kunde inte verifieras/,
|
||||
)
|
||||
// Scalars parse as JSON but are not a plausible archived API response:
|
||||
// the object/array root requirement keeps the anti-placeholder defense.
|
||||
expect(validateDocumentMagicBytes(toBuffer('"just a string"'), 'application/json')).toMatch(
|
||||
/kunde inte verifieras/,
|
||||
)
|
||||
expect(validateDocumentMagicBytes(toBuffer('42'), 'application/json')).toMatch(
|
||||
/kunde inte verifieras/,
|
||||
)
|
||||
expect(validateDocumentMagicBytes(toBuffer('null'), 'application/json')).toMatch(
|
||||
/kunde inte verifieras/,
|
||||
)
|
||||
})
|
||||
|
||||
it('rejects truncated JSON', () => {
|
||||
expect(validateDocumentMagicBytes(toBuffer('{"transactions": [{"amount":'), 'application/json')).toMatch(
|
||||
/kunde inte verifieras/,
|
||||
)
|
||||
})
|
||||
|
||||
it('does not loosen validation for other declared types', () => {
|
||||
expect(validateDocumentMagicBytes(toBuffer('{"a": 1}'), 'application/pdf')).toMatch(
|
||||
/kunde inte verifieras/,
|
||||
)
|
||||
})
|
||||
})
|
||||
|
||||
describe('validateDocumentMagicBytes: PDF header offset tolerance', () => {
|
||||
const toArrayBuffer = (bytes: Uint8Array): ArrayBuffer =>
|
||||
bytes.buffer.slice(bytes.byteOffset, bytes.byteOffset + bytes.byteLength) as ArrayBuffer
|
||||
|
||||
@@ -111,6 +111,24 @@ function looksLikeXhtml(bytes: Uint8Array): boolean {
|
||||
return head.startsWith('<?xml') || head.startsWith('<!doctype html') || head.startsWith('<html')
|
||||
}
|
||||
|
||||
/**
|
||||
* JSON has no binary magic number either. For the declared type
|
||||
* application/json (raw PSD2 responses archived as räkenskapsinformation per
|
||||
* BFL 7 kap) the content must parse as JSON with an object or array root — a
|
||||
* prose placeholder is not valid JSON, and a bare quoted string still fails
|
||||
* the root check, so the anti-placeholder defense stays intact. Consulted
|
||||
* ONLY for that declared type.
|
||||
*/
|
||||
function looksLikeJson(bytes: Uint8Array): boolean {
|
||||
const offset = bytes[0] === 0xEF && bytes[1] === 0xBB && bytes[2] === 0xBF ? 3 : 0
|
||||
try {
|
||||
const parsed = JSON.parse(Buffer.from(bytes.slice(offset)).toString('utf8'))
|
||||
return typeof parsed === 'object' && parsed !== null
|
||||
} catch {
|
||||
return false
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Verify the buffer actually contains a file of the declared type.
|
||||
* Returns an error string or null if valid. HEIC has many ftyp brands so
|
||||
@@ -123,6 +141,10 @@ export function validateDocumentMagicBytes(buffer: ArrayBuffer, declaredMimeType
|
||||
if (looksLikeXhtml(new Uint8Array(buffer))) return null
|
||||
return `Filinnehållet kunde inte verifieras som ${declaredMimeType}. Filen verkar inte vara ett XHTML/XML-dokument.`
|
||||
}
|
||||
if (declaredMimeType === 'application/json') {
|
||||
if (looksLikeJson(new Uint8Array(buffer))) return null
|
||||
return `Filinnehållet kunde inte verifieras som ${declaredMimeType}. Filen verkar inte vara ett giltigt JSON-dokument.`
|
||||
}
|
||||
const detected = detectFileMagic(new Uint8Array(buffer))
|
||||
if (!detected) {
|
||||
return `Filinnehållet kunde inte verifieras som ${declaredMimeType}. Filen verkar vara skadad eller inte en riktig binärfil: vid uppladdning via API, kontrollera att file_content_base64 är base64-kodade råbytes, inte en textrepresentation.`
|
||||
|
||||
Reference in New Issue
Block a user